)]}'
{"id":"openstack%2Fironic-python-agent~763406","triplet_id":"openstack%2Fironic-python-agent~stable%2Fvictoria~Ia1c2c2e6a32c76ac0249e6a46e4cced18d6093a9","project":"openstack/ironic-python-agent","branch":"stable/victoria","topic":"fix-lshw-2-stable/victoria","hashtags":[],"change_id":"Ia1c2c2e6a32c76ac0249e6a46e4cced18d6093a9","subject":"Fix vendor info retrieval for some versions of lshw","status":"MERGED","created":"2020-11-19 16:31:54.000000000","updated":"2020-11-20 13:17:02.000000000","submitted":"2020-11-20 13:15:03.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"763406-1605878103347-7a5aba1f","meta_rev_id":"83b79213b1255fe6b1ab4bbaccb3f68493600ded","_number":763406,"virtual_id_number":763406,"owner":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-11-20 09:36:18.000000000","_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-11-20 13:15:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-11-19 18:45:41.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"all":[{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":2,"date":"2020-11-20 11:16:16.000000000","_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2020-11-20 11:37:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2020-11-20 11:37:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-19 18:45:41.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-11-20 11:16:16.000000000","updated_by":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"reviewer":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"state":"REVIEWER"},{"updated":"2020-11-20 11:37:13.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-11-20 13:15:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"60f632f36a080cc1ef5304758f0407de4cdf0ccb","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2020-11-19 16:31:54.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"5c139b67b25eb13fbdc44a09bc7a60c8fc46153c","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-11-19 18:45:41.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/2e074378a337406cbba2ed98a2678e98 : SUCCESS in 2h 12m 46s","accounts_in_message":[],"_revision_number":1},{"id":"de339ae03b4168e1502570bd5d724414f0bd4e45","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-19 18:52:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/48b3d6cf9549430c9dd594f4074079d2 : SUCCESS in 7m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4cd6d89043c6483c88dc853067fed42d : SUCCESS in 4m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e743659a10a34018a934575b8869ddce : SUCCESS in 7m 13s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/eda6d72cdba94e4784b84b44a5d2a2db : SUCCESS in 6m 03s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b47d66472f5b443d9bc7fd8ab5c1521d : SUCCESS in 4m 52s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ae45f76e34734e6d916d55d1226efe09 : SUCCESS in 6m 47s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/c2561df191664166bb6ef21bdb22e91a : SUCCESS in 4m 10s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/a949891226ec4d4599c36daf777aac79 : SUCCESS in 4m 54s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/b30cefed77194186a41e33c296b9f163 : SUCCESS in 2h 03m 20s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/787a9df50efd4df69d63b3fce3e5df26 : SUCCESS in 2h 11m 49s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/c94a2d146c3945759eaa7228258d2294 : SUCCESS in 1h 46m 03s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/64438a824eb346588b014cb78a935d4d : SUCCESS in 1h 06m 25s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/7773876c99a54867ad5fef0707e5c6e8 : SUCCESS in 15m 02s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/0b670a0518454745849e0ab315e06d0a : SUCCESS in 13m 33s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/4661530aa9c34477b18a38775d927b4b : SUCCESS in 2h 03m 29s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/f77d9a2e69314577a8aae70ec44fc810 : SUCCESS in 4m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b055f42ac8620479e4e9b1d89aa9b68e2fd25098","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2020-11-20 08:14:04.000000000","message":"Patch Set 1: Code-Review-1\n\nVladyslav: from what I see, this only re-arranges code, so I am not sure this is eligible for backporting.","accounts_in_message":[],"_revision_number":1},{"id":"b0f26b4a08d8c8ebc6aefc1d33d3e2d0ff75f350","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2020-11-20 09:36:18.000000000","message":"Patch Set 1:\n\nHi Arne, thanks for your review. It is not just a rearrangement, it is a fix :) the _get_system_lshw_dict is used by two functions - get_system_vendor_info and get_memory, so moving this bit from get_memory inside _get_system_lshw_dict makes it also fix get_system_vendor_info behaviour.","accounts_in_message":[],"_revision_number":1},{"id":"3453a6442c5dd04c301ef621062382efd086b104","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2020-11-20 11:16:16.000000000","message":"Patch Set 1: Code-Review+2\n\nOops, sorry I missed that! I think it\u0027d be good to have a reno, though. Probably as a follow-up to the original patch in master.","accounts_in_message":[],"_revision_number":1},{"id":"3c049b470a1ff8459e385c81fcab52265ce0e9f6","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-11-20 11:37:13.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"9525a0b860e3d31850e8eccf813a9042e6cea8de","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-20 11:37:28.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"3b481a2c6582c1ccb47f153522ea8eb7f6f1b2ea","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-20 13:15:03.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/520fda9500df414897cd7ce96ef8b98a : SUCCESS in 5m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6928c1cc330340968e6fffa6d78f8268 : SUCCESS in 4m 08s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/daa9e068f157498a905273d8de057d23 : SUCCESS in 4m 01s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/48cc9afc749f4246a66a4e4e3202a73c : SUCCESS in 3m 54s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6384b46bbadb4a98b3a1a528b3045a7f : SUCCESS in 6m 52s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/ea8b36cb9d4e4856b1bd3983181dea49 : SUCCESS in 4m 23s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/e608fc997d03422698b390db17e789d8 : SUCCESS in 1h 18m 47s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/55ede0f68f5747d1b25f260ff3f72c7a : SUCCESS in 1h 29m 43s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/9ea081ce9ef6451db9d4666c2f225859 : SUCCESS in 1h 23m 52s","accounts_in_message":[],"_revision_number":1},{"id":"53abde1642047f7596c44b72b02de9cac880f283","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-20 13:15:03.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"fa834f8f8e524daa2a5482e20b8a249a11c9b424","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-20 13:17:02.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c044314eedf546d7bd65e8931855dada : SUCCESS in 1m 35s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"31e9d0db8c1ea3f8f7dfe1328f7ab0b19325a363","revisions":{"31e9d0db8c1ea3f8f7dfe1328f7ab0b19325a363":{"kind":"REWORK","_number":1,"created":"2020-11-19 16:31:54.000000000","uploader":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"ref":"refs/changes/06/763406/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/06/763406/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/06/763406/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/06/763406/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/06/763406/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/06/763406/1"}}},"commit":{"parents":[{"commit":"8c38177e0ed5f4e05a23f6d1514be2efab8ffb4d","subject":"Fix physical memory calculation with new lshw","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8c38177e0ed5f4e05a23f6d1514be2efab8ffb4d"}]}],"author":{"name":"Vladyslav Drok","email":"vdrok@mirantis.com","date":"2020-11-16 13:51:53.000000000","tz":60},"committer":{"name":"Vladyslav Drok","email":"vdrok@mirantis.com","date":"2020-11-19 16:31:54.000000000","tz":0},"subject":"Fix vendor info retrieval for some versions of lshw","message":"Fix vendor info retrieval for some versions of lshw\n\nThere is one more place that relies on lshw json output being a dict,\nso let\u0027s fix the function that gets the dict rather than places it is\nbeing used in.\n\nChange-Id: Ia1c2c2e6a32c76ac0249e6a46e4cced18d6093a9\nTask: 39527\nStory: 2007588\n(cherry picked from commit 3761a448009467dd342bc0cb3ca3b182969def42)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/31e9d0db8c1ea3f8f7dfe1328f7ab0b19325a363"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/31e9d0db8c1ea3f8f7dfe1328f7ab0b19325a363"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[]}