)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"300a70d6ea30e70584d670aad898fb5ae09453f6","unresolved":true,"context_lines":[{"line_number":658,"context_line":"    def __init__(self, enable, size):"},{"line_number":659,"context_line":"        self.enable \u003d enable"},{"line_number":660,"context_line":"        self.size \u003d size"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"class CPU(encoding.SerializableComparable):"},{"line_number":663,"context_line":"    serializable_fields \u003d (\u0027model_name\u0027, \u0027frequency\u0027, \u0027count\u0027, \u0027architecture\u0027,"},{"line_number":664,"context_line":"                           \u0027flags\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a3418179_593d8f74","line":661,"updated":"2021-01-08 14:51:15.000000000","message":"People really are not going to review this without thigns like pep8 failures fixed. You can check for them locally with \"tox -epep8\"","commit_id":"208970b54f7db42660450c128770ad34b63d97ea"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"300a70d6ea30e70584d670aad898fb5ae09453f6","unresolved":true,"context_lines":[{"line_number":1145,"context_line":"        return network_interfaces_list"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"    def get_aep(self):"},{"line_number":1148,"context_line":"        return AEP(enable\u003d\u0027true\u0027, size\u003d999999)"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"    def get_cpus(self):"},{"line_number":1151,"context_line":"        lines \u003d utils.execute(\u0027lscpu\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"141df128_e81fb96e","line":1148,"updated":"2021-01-08 14:51:15.000000000","message":"Hard coded size?","commit_id":"208970b54f7db42660450c128770ad34b63d97ea"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"bf0acb3fb5c902ad793cddaf223ed2d113257e0e","unresolved":true,"context_lines":[{"line_number":1165,"context_line":"                # flags           : fpu vme de pse"},{"line_number":1166,"context_line":"                flags \u003d out[0].strip().split(\u0027:\u0027, 1)[1].strip().split()"},{"line_number":1167,"context_line":"                flags.append(\u0027bf\u0027)"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":"            except (IndexError, ValueError):"},{"line_number":1170,"context_line":"                LOG.warning(\u0027Malformed CPU flags information: %s\u0027, out)"},{"line_number":1171,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b4c2a769_1011fde8","line":1168,"updated":"2020-12-20 06:18:54.000000000","message":"I guess not all cpus has this flag, why we want to have this flag set without checking?","commit_id":"208970b54f7db42660450c128770ad34b63d97ea"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"300a70d6ea30e70584d670aad898fb5ae09453f6","unresolved":true,"context_lines":[{"line_number":1165,"context_line":"                # flags           : fpu vme de pse"},{"line_number":1166,"context_line":"                flags \u003d out[0].strip().split(\u0027:\u0027, 1)[1].strip().split()"},{"line_number":1167,"context_line":"                flags.append(\u0027bf\u0027)"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":"            except (IndexError, ValueError):"},{"line_number":1170,"context_line":"                LOG.warning(\u0027Malformed CPU flags information: %s\u0027, out)"},{"line_number":1171,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"43b70fc9_44de59a5","line":1168,"in_reply_to":"b4c2a769_1011fde8","updated":"2021-01-08 14:51:15.000000000","message":"++","commit_id":"208970b54f7db42660450c128770ad34b63d97ea"}]}