)]}'
{"id":"openstack%2Fironic-python-agent~772635","triplet_id":"openstack%2Fironic-python-agent~master~I4fca1248a804fae783248484da96b249d234da5f","project":"openstack/ironic-python-agent","branch":"master","topic":"story/2008561","hashtags":[],"change_id":"I4fca1248a804fae783248484da96b249d234da5f","subject":"Fix failed to get CPU flags on aarch64","status":"NEW","created":"2021-01-27 08:08:57.000000000","updated":"2021-01-27 09:58:16.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3a2c2b914ab4c1ddac7c0dff4fe1cd3a3496d9b7","_number":772635,"virtual_id_number":772635,"owner":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-01-27 09:58:16.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":-1,"date":"2021-01-27 09:07:53.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-27 09:07:53.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2021-01-27 09:58:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d3ee5c85813dc125e2368edf81547109fc9388b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"date":"2021-01-27 08:08:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7e78617243a907ebadd7d3b171b35428dddd11ad","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-01-27 09:07:53.000000000","message":"Patch Set 1: Code-Review-1\n\nthanks, this works fine\nI think we should update the unit tests to be explicit that all the cpu data comes from lscpu","accounts_in_message":[],"_revision_number":1},{"id":"453cca3c5467c5045b94475648d022511ef3056a","author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"date":"2021-01-27 09:17:07.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e thanks, this works fine\n\u003e I think we should update the unit tests to be explicit that all the cpu data comes from lscpu\n\nSure, will look into the unit tests. Thanks rpittau.","accounts_in_message":[],"_revision_number":1},{"id":"3a2c2b914ab4c1ddac7c0dff4fe1cd3a3496d9b7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-27 09:58:16.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef2d5b40a9194a5e8dfec061b51fc5df : SUCCESS in 3m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3e13a277b7584f3888cba57de5ea7544 : FAILURE in 4m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/29b14d8d643d4ca1be7ed63daabf445d : FAILURE in 6m 02s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6693d15ab72d4742adee4e1642055fbf : FAILURE in 4m 20s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3f247260ffa24fdebe99d71cc28fcde8 : FAILURE in 3m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dd6be72efb494f67a896f5c5305f900f : SUCCESS in 5m 37s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/73ecdf4cd4fb47f79714fc56218bdb41 : SUCCESS in 3m 41s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/0267c16df17d4cadb2f394549130b081 : SUCCESS in 3m 55s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/655a2a4c82bd41d18e7d0f83dda23061 : SUCCESS in 4m 00s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/1029a3a56e2c4c7ba2dcbfa2078f14de : SUCCESS in 1h 10m 22s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/c989ce7328784d519e5dbfc6d68c0b6f : SUCCESS in 1h 12m 18s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/aa64f90697c649bbbcad489625cd51d9 : SUCCESS in 1h 29m 10s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/a234c4bf56a54dcd9ff0f4318016213e : SUCCESS in 1h 04m 17s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/441a16b61c0d46448272a5bdd678ff82 : SUCCESS in 1h 14m 36s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/6c6c762b69044ff7b0a1709ab3878802 : SUCCESS in 14m 09s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/b612f434268e40a4a84cd782a788531a : SUCCESS in 10m 38s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/cabb40540861486dbf51490e4962e866 : SUCCESS in 1h 46m 27s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/1a1a2aeabbb6457984b34867db5cc79d : SUCCESS in 6m 01s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9a44dea734832768cf9f325566cf9b1d6842eca4","revisions":{"9a44dea734832768cf9f325566cf9b1d6842eca4":{"kind":"REWORK","_number":1,"created":"2021-01-27 08:08:57.000000000","uploader":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"ref":"refs/changes/35/772635/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/35/772635/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/35/772635/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/35/772635/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/35/772635/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/35/772635/1"}}},"commit":{"parents":[{"commit":"c72e58b2fac474a97d39b452a93e0afb4794f56e","subject":"Update minversion of tox","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c72e58b2fac474a97d39b452a93e0afb4794f56e"}]}],"author":{"name":"Xinliang Liu","email":"xinliang.liu@linaro.org","date":"2021-01-27 07:46:31.000000000","tz":0},"committer":{"name":"Xinliang Liu","email":"xinliang.liu@linaro.org","date":"2021-01-27 08:02:49.000000000","tz":0},"subject":"Fix failed to get CPU flags on aarch64","message":"Fix failed to get CPU flags on aarch64\n\nThe output of \u0027/proc/cpuinfo\u0027 on aarch64 is different. It puts flags\nstring after field \u0027Features\u0027 not \u0027flags\u0027:\n$ cat /proc/cpuinfo (aarch64)\n...\nFeatures        : fp asimd evtstrm aes pmull sha1 sha2 crc32 cpuid\n$ cat /proc/cpuinfo (x86_64)\n...\nflags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr ...\n\nWe can use lscpu\u0027s output to get cpu flags. Let lscpu to handle cpuinfo\ndifference on different cpu arch[1].\n\n[1]: https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/sys-utils/lscpu-cputype.c?id\u003d1c675ebee0300553bae2faa04c4796dec61b1ce1#n184\n\nTask: #41699\nStory: #2008561\nChange-Id: I4fca1248a804fae783248484da96b249d234da5f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9a44dea734832768cf9f325566cf9b1d6842eca4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9a44dea734832768cf9f325566cf9b1d6842eca4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}