)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"02e98100ef077d6716fd2792cbaa26014749ecf2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"code in raid_utils, we move some functions and adapt the tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In the process also split samples from the hardware test module to a"},{"line_number":13,"context_line":"common samples module."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I73f6cf118575b627e66727d88d5567377c1999a0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9652a385_76954a41","line":13,"updated":"2021-02-11 11:35:56.000000000","message":"nit: Could this be a separate change? It\u0027s largely unrelated","commit_id":"f3b679ff158b302df8354c08bcdbf4c7a11b679b"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"22a0080871114032cc547390c7fd666a4a0a47a2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"code in raid_utils, we move some functions and adapt the tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In the process also split samples from the hardware test module to a"},{"line_number":13,"context_line":"common samples module."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I73f6cf118575b627e66727d88d5567377c1999a0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"37e423ba_f50b294f","line":13,"in_reply_to":"9652a385_76954a41","updated":"2021-02-11 14:13:49.000000000","message":"yes, I will split the split :)","commit_id":"f3b679ff158b302df8354c08bcdbf4c7a11b679b"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"02e98100ef077d6716fd2792cbaa26014749ecf2","unresolved":false,"context_lines":[{"line_number":2407,"context_line":""},{"line_number":2408,"context_line":""},{"line_number":2409,"context_line":"def _step_sort_key(step):"},{"line_number":2410,"context_line":"    return -step[\u0027hwm\u0027][\u0027support\u0027], -step[\u0027priority\u0027], step[\u0027hwm\u0027][\u0027name\u0027]"},{"line_number":2411,"context_line":""},{"line_number":2412,"context_line":""},{"line_number":2413,"context_line":"def deduplicate_steps(candidate_steps):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a7e2260f_b04fcdc8","line":2410,"updated":"2021-02-11 11:35:56.000000000","message":"Unrelated? And I\u0027m not sure it actually makes the code better","commit_id":"f3b679ff158b302df8354c08bcdbf4c7a11b679b"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"22a0080871114032cc547390c7fd666a4a0a47a2","unresolved":false,"context_lines":[{"line_number":2407,"context_line":""},{"line_number":2408,"context_line":""},{"line_number":2409,"context_line":"def _step_sort_key(step):"},{"line_number":2410,"context_line":"    return -step[\u0027hwm\u0027][\u0027support\u0027], -step[\u0027priority\u0027], step[\u0027hwm\u0027][\u0027name\u0027]"},{"line_number":2411,"context_line":""},{"line_number":2412,"context_line":""},{"line_number":2413,"context_line":"def deduplicate_steps(candidate_steps):"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6ee0722_6f3ed862","line":2410,"in_reply_to":"a7e2260f_b04fcdc8","updated":"2021-02-11 14:13:49.000000000","message":"yeah, I agree, was not convinced myself","commit_id":"f3b679ff158b302df8354c08bcdbf4c7a11b679b"}],"ironic_python_agent/raid_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"02e98100ef077d6716fd2792cbaa26014749ecf2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    return component_devices"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def create_raid_device(incr, index, logical_disk):"},{"line_number":198,"context_line":"    md_device \u003d \u0027/dev/md%d\u0027 % index"},{"line_number":199,"context_line":"    component_devices \u003d []"},{"line_number":200,"context_line":"    for device in logical_disk[\u0027block_devices\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"38a474f0_7f185596","line":197,"updated":"2021-02-11 11:35:56.000000000","message":"Please add a docstring and maybe rename incr to something more meaningful","commit_id":"f3b679ff158b302df8354c08bcdbf4c7a11b679b"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"22a0080871114032cc547390c7fd666a4a0a47a2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    return component_devices"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def create_raid_device(incr, index, logical_disk):"},{"line_number":198,"context_line":"    md_device \u003d \u0027/dev/md%d\u0027 % index"},{"line_number":199,"context_line":"    component_devices \u003d []"},{"line_number":200,"context_line":"    for device in logical_disk[\u0027block_devices\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"accd1f78_2a7888ee","line":197,"in_reply_to":"38a474f0_7f185596","updated":"2021-02-11 14:13:49.000000000","message":"will do","commit_id":"f3b679ff158b302df8354c08bcdbf4c7a11b679b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89369e92e61e9a6402f98b5eaeb19904778f15b9","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    return component_devices"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def create_raid_device(partition, index, logical_disk):"},{"line_number":198,"context_line":"    \"\"\"Create a raid device."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    :param partition: the partition number used to create the raid."}],"source_content_type":"text/x-python","patch_set":5,"id":"089c93ca_438eae5a","line":197,"updated":"2021-02-16 12:37:24.000000000","message":"I got confused by partition vs index, so had to look at the previous code. It seems that partition is a constant 1 right now, so maybe make it a proper constant?","commit_id":"cf5e427784e5009e93efd36912a480953d324881"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d1e8fad5440a384b3c4c234b4a4b1147ca5a39ef","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    return component_devices"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def create_raid_device(partition, index, logical_disk):"},{"line_number":198,"context_line":"    \"\"\"Create a raid device."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    :param partition: the partition number used to create the raid."}],"source_content_type":"text/x-python","patch_set":5,"id":"77f0194c_b0c1a407","line":197,"in_reply_to":"089c93ca_438eae5a","updated":"2021-02-16 13:56:57.000000000","message":"makes sense","commit_id":"cf5e427784e5009e93efd36912a480953d324881"}],"ironic_python_agent/tests/unit/test_raid_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"02e98100ef077d6716fd2792cbaa26014749ecf2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from ironic_python_agent import raid_utils"},{"line_number":16,"context_line":"from ironic_python_agent.tests.unit.samples import hardware_samples as hws"},{"line_number":17,"context_line":"from ironic_python_agent import utils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@mock.patch.object(utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":21,"context_line":"def test__get_actual_component_devices(self, mocked_execute):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ae656d5_afbafa8d","line":18,"updated":"2021-02-11 11:35:56.000000000","message":"Let\u0027s add actual tests for the new public function","commit_id":"f3b679ff158b302df8354c08bcdbf4c7a11b679b"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"22a0080871114032cc547390c7fd666a4a0a47a2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from ironic_python_agent import raid_utils"},{"line_number":16,"context_line":"from ironic_python_agent.tests.unit.samples import hardware_samples as hws"},{"line_number":17,"context_line":"from ironic_python_agent import utils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@mock.patch.object(utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":21,"context_line":"def test__get_actual_component_devices(self, mocked_execute):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f6b6e29d_a41adf8a","line":18,"in_reply_to":"7ae656d5_afbafa8d","updated":"2021-02-11 14:13:49.000000000","message":"ack","commit_id":"f3b679ff158b302df8354c08bcdbf4c7a11b679b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"24521b6510b84588341f111d8a6b75a10af13d9d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    @mock.patch.object(raid_utils, \u0027_get_actual_component_devices\u0027,"},{"line_number":41,"context_line":"                       autospec\u003dTrue)"},{"line_number":42,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":43,"context_line":"    def test_crete_raid_device(self, mock_execute, mocked_components):"},{"line_number":44,"context_line":"        logical_disk \u003d {"},{"line_number":45,"context_line":"            \"block_devices\": [\u0027/dev/sda\u0027, \u0027/dev/sdb\u0027, \u0027/dev/sdc\u0027],"},{"line_number":46,"context_line":"            \"raid_level\": \"1\","}],"source_content_type":"text/x-python","patch_set":6,"id":"3e336b34_841c1178","line":43,"updated":"2021-02-16 16:40:27.000000000","message":"nit: create (same below)","commit_id":"95eab4ed16ec9c2b24fa5990671166916fe469b9"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e86693897f25f8083aece15e82f0349a714062bb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    @mock.patch.object(raid_utils, \u0027_get_actual_component_devices\u0027,"},{"line_number":41,"context_line":"                       autospec\u003dTrue)"},{"line_number":42,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":43,"context_line":"    def test_crete_raid_device(self, mock_execute, mocked_components):"},{"line_number":44,"context_line":"        logical_disk \u003d {"},{"line_number":45,"context_line":"            \"block_devices\": [\u0027/dev/sda\u0027, \u0027/dev/sdb\u0027, \u0027/dev/sdc\u0027],"},{"line_number":46,"context_line":"            \"raid_level\": \"1\","}],"source_content_type":"text/x-python","patch_set":6,"id":"00b03db7_bd9a2302","line":43,"in_reply_to":"3e336b34_841c1178","updated":"2021-02-17 08:49:53.000000000","message":"I\u0027m the king of typos :/","commit_id":"95eab4ed16ec9c2b24fa5990671166916fe469b9"}]}