)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8a355de02d51bdcfc287ebab574a2767902108b3","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"reno was removed from test-requirements.txt in"},{"line_number":10,"context_line":"Id7c5686cdbdc79812e06eb4a5f87eddc75005cc3"},{"line_number":11,"context_line":"but its needed to generate the release note."},{"line_number":12,"context_line":"Install doc/requirements.txt into the venv virtual env to fix this."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9ff69707f366cf192e8bd864a44b259b41795b27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9b277088_4f9968ca","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":43},"updated":"2021-03-02 15:36:15.000000000","message":"create a new release note","commit_id":"59c397ae90e79658936c585ad0830e011f73ec89"}],"tox.ini":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8a355de02d51bdcfc287ebab574a2767902108b3","unresolved":true,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[testenv:venv]"},{"line_number":61,"context_line":"setenv \u003d PYTHONHASHSEED\u003d0"},{"line_number":62,"context_line":"deps \u003d"},{"line_number":63,"context_line":"  {[testenv]deps}"},{"line_number":64,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":65,"context_line":"commands \u003d {posargs:}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"da6c5dc0_133bf35a","line":62,"updated":"2021-03-02 15:36:15.000000000","message":"requirements should not be necessary, so please just add constraints and test-requirements","commit_id":"59c397ae90e79658936c585ad0830e011f73ec89"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c82473a50840b985d6a62f70fb3ea37208f60812","unresolved":true,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[testenv:venv]"},{"line_number":61,"context_line":"setenv \u003d PYTHONHASHSEED\u003d0"},{"line_number":62,"context_line":"deps \u003d"},{"line_number":63,"context_line":"  {[testenv]deps}"},{"line_number":64,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":65,"context_line":"commands \u003d {posargs:}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"c2d523f3_3034ed9b","line":62,"in_reply_to":"6f0a1500_966e4000","updated":"2021-03-02 16:38:24.000000000","message":"correct","commit_id":"59c397ae90e79658936c585ad0830e011f73ec89"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"145b6d92d3d9557ddd32765c5a87ec28dae8189f","unresolved":true,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[testenv:venv]"},{"line_number":61,"context_line":"setenv \u003d PYTHONHASHSEED\u003d0"},{"line_number":62,"context_line":"deps \u003d"},{"line_number":63,"context_line":"  {[testenv]deps}"},{"line_number":64,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":65,"context_line":"commands \u003d {posargs:}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"ea2ee340_7b1616d0","line":62,"in_reply_to":"c2d523f3_3034ed9b","updated":"2021-03-02 16:49:28.000000000","message":"ack, thanks, done.","commit_id":"59c397ae90e79658936c585ad0830e011f73ec89"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"68f23cbb892f44927d4b51298b20ba14c6557a29","unresolved":true,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[testenv:venv]"},{"line_number":61,"context_line":"setenv \u003d PYTHONHASHSEED\u003d0"},{"line_number":62,"context_line":"deps \u003d"},{"line_number":63,"context_line":"  {[testenv]deps}"},{"line_number":64,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":65,"context_line":"commands \u003d {posargs:}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"6f0a1500_966e4000","line":62,"in_reply_to":"da6c5dc0_133bf35a","updated":"2021-03-02 16:35:08.000000000","message":"as is (without this patch) \"testenv:venv\" currently installs\nconstraints, requirements.txt and test-requirements.txt\nare you saying requirements.txt should not be there?","commit_id":"59c397ae90e79658936c585ad0830e011f73ec89"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fc31d920bd5f96f5dedcc0753af3bc827d78472c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"setenv \u003d PYTHONHASHSEED\u003d0"},{"line_number":62,"context_line":"deps \u003d"},{"line_number":63,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":64,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":65,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":66,"context_line":"commands \u003d {posargs:}"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"0e2c712d_3c763f6a","line":64,"updated":"2021-03-10 15:58:21.000000000","message":"for a venv we need requirements, not test-requirements","commit_id":"5489f3eff7a9d0c0ce07bdd45286678b76a70047"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7c866a6f4f3d2fb045b8888b769fdb5a9424bb30","unresolved":false,"context_lines":[{"line_number":61,"context_line":"setenv \u003d PYTHONHASHSEED\u003d0"},{"line_number":62,"context_line":"deps \u003d"},{"line_number":63,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":64,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":65,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":66,"context_line":"commands \u003d {posargs:}"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"86a84df6_73cf4ae6","line":64,"in_reply_to":"0e2c712d_3c763f6a","updated":"2021-03-15 09:35:08.000000000","message":"I thought we were building this only for test, otherwise, in terms of dependencies, it\u0027s just a copy of base testenv plus doc requirements\nif we don\u0027t install test-requirements, then we have a copy of docs at L72\nwe should probably clarify the scope of this because if we install requirements then we need to change it in other projects too","commit_id":"5489f3eff7a9d0c0ce07bdd45286678b76a70047"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17f8a69d0ffbb93570afb52315903611f21e8f86","unresolved":false,"context_lines":[{"line_number":61,"context_line":"setenv \u003d PYTHONHASHSEED\u003d0"},{"line_number":62,"context_line":"deps \u003d"},{"line_number":63,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":64,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":65,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":66,"context_line":"commands \u003d {posargs:}"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"79ae2102_addc7d7b","line":64,"in_reply_to":"86a84df6_73cf4ae6","updated":"2021-03-15 11:57:38.000000000","message":"venv is a weird beast, honestly. some people are using it to play with running the service or its python dependencies. like\n\n tox -evenv -- ironic-conductor\n\n(on ironic, here it may be less used) or\n\n tox -evenv -- python\n # look around","commit_id":"5489f3eff7a9d0c0ce07bdd45286678b76a70047"}]}