)]}'
{"id":"openstack%2Fironic-python-agent~782348","triplet_id":"openstack%2Fironic-python-agent~stable%2Fussuri~I9c10bf05186dcebb37f175d61bf4ac9ff86b6510","project":"openstack/ironic-python-agent","branch":"stable/ussuri","topic":"fstab-ussuri","hashtags":[],"change_id":"I9c10bf05186dcebb37f175d61bf4ac9ff86b6510","subject":"Refactor part of image module","status":"MERGED","created":"2021-03-23 02:20:29.000000000","updated":"2021-03-30 06:50:48.000000000","submitted":"2021-03-30 06:48:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"782348-fstab-ussuri","meta_rev_id":"05d77c7e1f31c7b1c92c03d46dd025f3d0ac6f31","_number":782348,"virtual_id_number":782348,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-30 06:48:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":2,"date":"2021-03-29 20:30:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2021-03-23 08:40:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":1,"date":"2021-03-29 20:30:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-23 02:20:29.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2021-03-23 04:18:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-29 20:30:41.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"}],"messages":[{"id":"862427d167a26e003354e4fb42beeadb700ba40c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-03-23 02:20:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"77bbafc84394259c78053dcaad302a99db1ad878","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-23 04:18:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/918ff9b4fbf74940b121c486fd82ef2b : SUCCESS in 4m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ed33862285664c7582d8cbf95bb870c8 : SUCCESS in 4m 16s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/13391e941e97479cac5df54cd0b470c3 : SUCCESS in 5m 31s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6f0d437109ed4e33a8526497d24e77b1 : SUCCESS in 4m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/66b83499749446ca82b4483ba383587f : SUCCESS in 6m 26s\n- ipa-tempest-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/a60491f228874fe6ab9ca3db0a0e2d9b : SUCCESS in 1h 11m 00s\n- ipa-tempest-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/17f523bad429492c927c7cc89c662152 : SUCCESS in 1h 12m 35s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/25aa3bd16d824a18bef521d18da78a05 : SUCCESS in 1h 28m 43s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/371a56d3de964147b739beab4cfa7fa0 : SUCCESS in 1h 19m 26s\n- ironic-python-agent-check-image-tinyipa-ussuri https://zuul.opendev.org/t/openstack/build/439be3b5cbc84d7694053aa781c35000 : SUCCESS in 16m 49s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/17cf2c848ab74a08b55cc7661334db83 : SUCCESS in 12m 06s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/1fe6460772654eb190bad430d4d3c70b : SUCCESS in 1h 55m 53s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/e9e4d2b0f33744258566bf156b14a10b : FAILURE in 32m 18s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/ce3fdc3737f94e6fb775dd178932e77a : FAILURE in 30m 34s (non-voting)\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/391b920e2d5c4d9ab3a2e2e75d510b9b : SUCCESS in 4m 21s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/fbdcadf3f42b4d4b84ca058ba63bb3e1 : SUCCESS in 4m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ac6d11d2597a3798d1aade3dda0c355263021806","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-03-23 08:40:18.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"61da57d8d12b4963090807f4e77b3b57083ce8d1","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-03-29 20:30:41.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"5d9719ce2921f3832307f75fb87cec7d02a72d0f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-29 20:31:09.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"3d2c225d5f28f82fcf40b4ac726bbcfaf5babd79","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-29 22:12:31.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c25650192f9c4cd3a1b9f6c90d257153 : SUCCESS in 5m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d47190c0628a4665a82c8fae759313bf : SUCCESS in 5m 31s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/59ccc679e1fc4c06b05a6b4c4e79dbc4 : SUCCESS in 6m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c238f88569e44bd2877aea99caf6da8c : SUCCESS in 8m 05s\n- ipa-tempest-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/e6b2d986cbf34fa296b8de86bc9d4dff : SUCCESS in 1h 08m 32s\n- ipa-tempest-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/4d4f4ea3949e4d67adcd93791841ebd7 : SUCCESS in 1h 22m 50s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/0ccfdde3d64f49379b14f4ca0b817ba0 : FAILURE in 1h 38m 41s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/9d935d506f6b4a8fa39fab9ac8d5ee7c : SUCCESS in 1h 25m 28s","accounts_in_message":[],"_revision_number":1},{"id":"0d82a022615dbdfd7eb191e39dd7c79b252abb65","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-03-30 03:26:00.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"fff81d2a5a6863b60eaeb4053588fe2cb4df45dc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-30 05:12:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3155790ebded4e84b520d9e5a451cf6a : SUCCESS in 4m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bc0dc3e8ab5245eb879044522aa65e63 : SUCCESS in 5m 05s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/d8718339180c40ac9f27a7979c881d5c : SUCCESS in 5m 15s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/24018871672544029433b078c93a8b9f : SUCCESS in 5m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c28d8964ad9f4502afea74aafc2fa2e6 : SUCCESS in 6m 33s\n- ipa-tempest-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/28010d4af5d54443b6a7788e651413f6 : SUCCESS in 1h 08m 10s\n- ipa-tempest-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/25fbd28afb7141aebec3df7e95b96a67 : SUCCESS in 1h 06m 05s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/b718bb94a2b44d94be24cfbbe91dee1a : SUCCESS in 1h 22m 44s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/be4e92ef98d4410ea1aa2998cf84d735 : SUCCESS in 1h 10m 29s\n- ironic-python-agent-check-image-tinyipa-ussuri https://zuul.opendev.org/t/openstack/build/e7d1822c50974952853789d8550d038f : SUCCESS in 14m 43s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/67f9fa612dfb42d78795f5d6b804af21 : SUCCESS in 11m 06s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/08a7c8a40cf94f628e607eea1dea7625 : SUCCESS in 1h 44m 50s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/587e49d2e117498d99e03c2c3275b6f0 : FAILURE in 34m 15s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/c68ea021b702409b8120be54c1fcf085 : FAILURE in 32m 16s (non-voting)\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/283ef245ffcc43769a23150a3cacff84 : SUCCESS in 4m 40s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/b21752539e6345d795467da33b111322 : SUCCESS in 4m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b6e98090a48899b5c36be5958b77b51afefb91a9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-30 05:12:50.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0fc829017c8c6e1cd2b31c1c12387635b796e2ad","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-30 06:48:26.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d34b5164bdcd4108880372ad81323cdf : SUCCESS in 5m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c9bc1491dfe2418abf49aa3bebdaccfa : SUCCESS in 4m 24s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/26b7071e3788412681937f26c2382c8b : SUCCESS in 6m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0d88f5267e174476ac81e851d37186f4 : SUCCESS in 6m 06s\n- ipa-tempest-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/0ff6ae848f884cae8c263fe84ea6c269 : SUCCESS in 1h 01m 14s\n- ipa-tempest-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/22faa801c79b4a45b782f8ab514c199b : SUCCESS in 1h 26m 27s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/e2501431168b43c7867871d25b00c114 : SUCCESS in 1h 08m 39s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/4b1631213fc94b158af7db300032a9ce : SUCCESS in 1h 30m 58s","accounts_in_message":[],"_revision_number":1},{"id":"93ce5a212be70d465629495dc49572f44263fc33","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-30 06:48:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"05d77c7e1f31c7b1c92c03d46dd025f3d0ac6f31","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-30 06:50:48.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/465169d13448406e878eb3921f44416f : SUCCESS in 1m 27s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d0f69e9948bf81d338bbc7c84711263fbd937598","revisions":{"d0f69e9948bf81d338bbc7c84711263fbd937598":{"kind":"REWORK","_number":1,"created":"2021-03-23 02:20:29.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/48/782348/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/48/782348/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/48/782348/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/48/782348/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/48/782348/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/48/782348/1"}}},"commit":{"parents":[{"commit":"d8eefc9c9b84bd1e1b5adec24159b19121237705","subject":"Re-enable the ussuri tinyipa jobs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d8eefc9c9b84bd1e1b5adec24159b19121237705"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2020-07-03 15:04:27.000000000","tz":120},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-03-23 02:13:40.000000000","tz":780},"subject":"Refactor part of image module","message":"Refactor part of image module\n\nShuffle some functions around and reduce size of _is_bootloader_loaded\nmoving logic out to a new function.\n\nChange-Id: I9c10bf05186dcebb37f175d61bf4ac9ff86b6510\n(cherry picked from commit 9d9a6bce5c246d18d50dc405265e865fb77142eb)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d0f69e9948bf81d338bbc7c84711263fbd937598"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d0f69e9948bf81d338bbc7c84711263fbd937598"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}