)]}'
{"id":"openstack%2Fironic-python-agent~782881","triplet_id":"openstack%2Fironic-python-agent~stable%2Ftrain~I5b54c1f6cfac5fff672245c523b9fb647478edbd","project":"openstack/ironic-python-agent","branch":"stable/train","topic":"fstab-train","hashtags":[],"change_id":"I5b54c1f6cfac5fff672245c523b9fb647478edbd","subject":"Do not try to read raw disk data as unicode","status":"MERGED","created":"2021-03-25 00:41:49.000000000","updated":"2021-03-29 15:19:41.000000000","submitted":"2021-03-29 15:14:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"782881-fstab-train","meta_rev_id":"aee4bbe051ceb613676dfe613c1a41dccd1a38c5","_number":782881,"virtual_id_number":782881,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-29 15:14:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"all":[{"value":2,"date":"2021-03-29 13:35:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-03-25 08:49:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"all":[{"value":1,"date":"2021-03-29 13:35:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-25 00:41:49.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2021-03-25 02:44:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-25 08:49:45.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2021-03-29 13:35:04.000000000","updated_by":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"reviewer":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"state":"REVIEWER"}],"messages":[{"id":"f90d1a86e6b860a6b104ee8733d2bc5ce93541b9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-03-25 00:41:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7cef2ec89a0e4bec43e62066a24c41aad40aebb9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-25 02:44:38.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4f5e4bc6e21c43d4863614be4674a087 : SUCCESS in 4m 26s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/d22acad34bbf4e2d91cabc4ed67bcc8e : SUCCESS in 4m 33s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/81521d41bc9b4f92a8249a11221a3729 : SUCCESS in 4m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a54ee0d4a4d14191bc0abe8f0fd353ff : SUCCESS in 6m 59s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/fe4d808e54ed4571a3d467ebca169436 : SUCCESS in 53m 53s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/bbf283b4881a454091c397d1c268700a : SUCCESS in 1h 06m 03s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/8e0c534b5b31439fbbcf08d62d662aaf : SUCCESS in 1h 07m 45s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/e3c3601d284848f4a24024d26c2c1c05 : SUCCESS in 1h 09m 09s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/4f98e61b59db44758137878808bea340 : FAILURE in 1h 25m 00s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/48bdccff2ac14855a27a45353740106b : FAILURE in 3m 16s (non-voting)\n- ironic-python-agent-check-image-dib-centos7 https://zuul.opendev.org/t/openstack/build/28e8f1fe1f044dd2a52fed6904000bde : SUCCESS in 9m 59s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/169632969038413d8c6405ee232354bc : SUCCESS in 1h 56m 00s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/1a9ff320cbcc48abafb29a6e2c987ce9 : RETRY_LIMIT in 33m 18s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/fd0f2a6cf4ac414d885c68207c2c3e31 : FAILURE in 41m 04s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/f643a1439dd24b1aa6e85702596f9d6e : SUCCESS in 4m 37s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/f08ee3fd52aa4b9e9593d30c8ea953de : SUCCESS in 4m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"38c7d63c66b3cbe9590253d1bf707fa3487a00fc","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-03-25 08:49:45.000000000","message":"Patch Set 1: Code-Review+2\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"5ef13c9a159be5e48fea8d1627fdbd17d99a68fb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-25 10:53:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/49490e3fc5df43ecadd2a3ec4c599510 : SUCCESS in 5m 36s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/fa9dc194b1fe4f278c945d37ce7d5fa3 : SUCCESS in 6m 35s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fae84f9a90c64c16a0db7cf73d49c523 : SUCCESS in 5m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/12ff34d9048c403995b3f6dfe60470ce : SUCCESS in 9m 30s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/b8494fe5d419485c91b825660b2220e3 : SUCCESS in 1h 11m 09s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/4d432d7c6e2d4ebca9ee50e4b9db26a3 : SUCCESS in 48m 02s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/dbc85f18d82346bbb4dc30d51442f5ad : SUCCESS in 53m 27s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/b21f662e26864f59925f0a127bd0024e : SUCCESS in 1h 03m 48s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/0c9a1ffbae9f4200a965c146fd7bb213 : SUCCESS in 1h 12m 59s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/1ace003ea493422a9587c4114b2a15d6 : FAILURE in 2m 48s (non-voting)\n- ironic-python-agent-check-image-dib-centos7 https://zuul.opendev.org/t/openstack/build/11bd5a71da4f415d934b5d82b450caf5 : SUCCESS in 10m 39s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/7b29ae43db124bbeb7f558f4c0bb7ea1 : FAILURE in 1h 53m 50s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/983d1fe7869948e591dfdb286d2f8308 : RETRY_LIMIT in 36m 09s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/bb45bf2e646841438aad669d8eae466c : FAILURE in 40m 39s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/9fc43f1361ea4963bfc3d4d07919afcd : SUCCESS in 6m 16s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/59fb1dd779ca4c5a912228268c7e54fc : SUCCESS in 6m 24s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"92deb17363927d709c4e1411d1a3b9242f34d4be","author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"date":"2021-03-29 13:35:04.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a9dc6b90f88aa356bf6d9fcc0566845d4fa0c1f5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-29 13:35:30.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6c2e3d296f3b8b9dae38b5f82400ebc61e3a33f2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-29 15:14:15.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/31d3eea4f6504d85a26f2a27d5ec35a9 : SUCCESS in 5m 26s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b72e52bd5e8f4789a9c8b32ce355bf2a : SUCCESS in 5m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d46e917b388f41c388e1dab50a5a7691 : SUCCESS in 7m 33s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/6f09e0e3b6f645499640ef395e8e2a31 : SUCCESS in 59m 58s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/4bdd53ee2a76493dba4de490456fb295 : SUCCESS in 1h 09m 06s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/bbfac960a4ef409e95f3cb756687b21d : SUCCESS in 1h 10m 03s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/a61828ad512f4b1cbe75452a70996eda : SUCCESS in 58m 58s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/3f39191ffce34859895ee73d9b7d8477 : SUCCESS in 1h 18m 06s","accounts_in_message":[],"_revision_number":1},{"id":"29822467b2e21552b6c0c3b53d5d134694beb85c","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-29 15:14:33.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"aee4bbe051ceb613676dfe613c1a41dccd1a38c5","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-29 15:19:41.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3eb26f2f9d0a4c58ad20dfa3aa62cb2b : SUCCESS in 1m 53s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"045bcfef32e4ab679678500d2a58c92398ad838c","revisions":{"045bcfef32e4ab679678500d2a58c92398ad838c":{"kind":"REWORK","_number":1,"created":"2021-03-25 00:41:49.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/81/782881/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/81/782881/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/81/782881/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/81/782881/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/81/782881/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/81/782881/1"}}},"commit":{"parents":[{"commit":"10059c535fe7b77d8d73918ca1316cfcc856b351","subject":"CI: Remove l-c job, set ipa-b to 2.2.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/10059c535fe7b77d8d73918ca1316cfcc856b351"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2019-11-11 15:03:59.000000000","tz":60},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-03-23 22:11:07.000000000","tz":780},"subject":"Do not try to read raw disk data as unicode","message":"Do not try to read raw disk data as unicode\n\nFixes regression in commit 9f8fa2853af00045118ccd44180e7053e6d027af:\nutils.execute returns unicode by default, but this data is binary.\n\nChange-Id: I5b54c1f6cfac5fff672245c523b9fb647478edbd\n(cherry picked from commit 1d12505fa069bef886ee908a83920aa2afa44298)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/045bcfef32e4ab679678500d2a58c92398ad838c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/045bcfef32e4ab679678500d2a58c92398ad838c"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}