)]}'
{"id":"openstack%2Fironic-python-agent~787925","triplet_id":"openstack%2Fironic-python-agent~master~I5f434e6bfde6f645804941f3a36d5458a28270e7","project":"openstack/ironic-python-agent","branch":"master","topic":"no-pbr","hashtags":[],"change_id":"I5f434e6bfde6f645804941f3a36d5458a28270e7","subject":"Remove runtime dependency on pbr","status":"MERGED","created":"2021-04-26 07:17:08.000000000","updated":"2021-05-04 19:13:24.000000000","submitted":"2021-05-04 19:11:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"787925-no-pbr","meta_rev_id":"721d1072aeefca23703a32e5d0ec1bbcbbda662e","_number":787925,"virtual_id_number":787925,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-05-04 19:11:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":2,"date":"2021-04-30 21:14:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":2,"date":"2021-04-26 07:36:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":1,"date":"2021-05-04 17:58:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-26 07:29:53.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2021-04-26 08:59:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-30 21:14:37.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"}],"messages":[{"id":"57680ce9c3ba2485e9f5add0787acd1be998b59a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-04-26 07:17:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3886f70a1817697a00668d17ef8dcb14278b33d2","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-04-26 07:29:53.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3e2982afc1ac06a77763189bec3667c32645568b","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-04-26 07:34:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9f71b20483ca13415ba04452c34cd08feb06fe0a","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-04-26 07:36:07.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"68347ed5524014cd0c2615930ee021913a0fe63c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-26 08:59:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5abb19c2a2ac4ec6bbe4665dfb7b9d82 : SUCCESS in 4m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/40cf24c4b39046128065fc3d27afe113 : SUCCESS in 5m 15s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fe983662ae074d91b9b1475566422fad : SUCCESS in 5m 30s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ab17b6c3cac44359a13dcb66f5428e1c : SUCCESS in 5m 45s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6d01ed2d55404c2da5ecb18356be1e8c : SUCCESS in 5m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eab49da5dd7f4a72bc2eae40bec1e48f : SUCCESS in 7m 28s\n- requirements-check https://zuul.opendev.org/t/openstack/build/29f7658f6da14f43ae3b77136c9ab58f : SUCCESS in 3m 09s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/73593e428d064232b7b741d3a726bf49 : SUCCESS in 5m 38s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/2b322a7e22b94e4cb7da725de431e855 : SUCCESS in 4m 17s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/e07e42d26717417c8d3ea5f70d9c5e42 : SUCCESS in 1h 16m 05s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/d9b1c122218e450a92fde34d7503a403 : SUCCESS in 58m 33s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/5b9f8f5b7eff440c9e0ce7f1beb4e769 : SUCCESS in 1h 17m 25s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/f5cda0f85133460ca2e6e635ca933ea4 : SUCCESS in 1h 16m 21s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/ea0ff1be9ab24d2f984cf82e2d0ec0e3 : SUCCESS in 1h 13m 32s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/0cf4748b9e7a4bd6b8489fbca1beff48 : SUCCESS in 1h 20m 33s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/5cbd974d5f9d459ba62d290ec2c1b674 : SUCCESS in 15m 00s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/049516b7d56642f1b1abc020932da679 : SUCCESS in 12m 05s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/caf4af8db54d409f86a6f6644e44ce61 : SUCCESS in 1h 37m 59s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/79316103243c46308682ca4bbb2176a8 : SUCCESS in 4m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"900be15b8d5ec0f15da37d78554740cba480fba3","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2021-04-30 21:14:37.000000000","message":"Patch Set 1: Code-Review+2\n\nI mean, this code is fine... I\u0027m just confused about the use case? Are we going to manually remove PBR from ramdisks?","accounts_in_message":[],"_revision_number":1},{"id":"3a7ad5c388329eb129d4fc8b3a5e739834d5c6dc","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-05-03 12:20:29.000000000","message":"Patch Set 1:\n\nOnce we don\u0027t actually use pbr, we can remove its dependency from packaging (RDO in my case) and stop pulling git-core in.","accounts_in_message":[],"_revision_number":1},{"id":"39792029ea7f0b721cca6a367d7b46bf133683d6","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2021-05-04 17:58:59.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7f644d49793cdd5976fe69c532f9aad202071c94","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-04 18:00:11.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"45c6e6e9142a5ea7aae2117d323ee66664713bf2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-04 19:11:38.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/31966c55daea47a196834ab0a29e328c : SUCCESS in 4m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ea2033926ae24725b80cdd9c23a89fe8 : SUCCESS in 4m 26s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7ef7a672ff2e43be80f9273993319c6f : SUCCESS in 4m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/63993ddea0a04b8f82e50f086f5ff84c : SUCCESS in 7m 09s\n- requirements-check https://zuul.opendev.org/t/openstack/build/a669ec514e4d4443b0836f9d56c3920c : SUCCESS in 3m 30s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/9d7136c721db41ab9f42f9150e2d1d04 : SUCCESS in 4m 54s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/2f627c67edd445b18c76c5186be8c565 : SUCCESS in 1h 10m 39s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/b372ebcb643d4293a74b4fe9a88ff553 : SUCCESS in 54m 30s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/c26075b463ba4bb2bb703840cff15202 : SUCCESS in 1h 07m 08s","accounts_in_message":[],"_revision_number":1},{"id":"5c21dcda79a0d8480ec75a5800ba2bbb49d38f4a","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-04 19:11:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"721d1072aeefca23703a32e5d0ec1bbcbbda662e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-04 19:13:24.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9f196547188b40c2a9ae24364d4bb416 : SUCCESS in 1m 20s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3251d7b6417ff67c7f0d1e51bb9b3bea078de967","revisions":{"3251d7b6417ff67c7f0d1e51bb9b3bea078de967":{"kind":"REWORK","_number":1,"created":"2021-04-26 07:17:08.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/25/787925/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/25/787925/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/25/787925/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/25/787925/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/25/787925/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/25/787925/1"}}},"commit":{"parents":[{"commit":"9edb13d891de658124d11099e2287163a76f1050","subject":"Merge \"Do not fail network interface collection on unsupported interface\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9edb13d891de658124d11099e2287163a76f1050"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-04-26 07:14:08.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-04-26 07:16:34.000000000","tz":120},"subject":"Remove runtime dependency on pbr","message":"Remove runtime dependency on pbr\n\nPbr is a very heavy package to depend on. It requires git-core, which is\n16 MiB on my Fedora. We only use it to detect the version, which can be\ndone without pbr using a much lighter importlib_metadata.\n\nCopied from https://review.opendev.org/c/openstack/osprofiler/+/739379\n\nChange-Id: I5f434e6bfde6f645804941f3a36d5458a28270e7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3251d7b6417ff67c7f0d1e51bb9b3bea078de967"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3251d7b6417ff67c7f0d1e51bb9b3bea078de967"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}