)]}'
{"id":"openstack%2Fironic-python-agent~793083","triplet_id":"openstack%2Fironic-python-agent~master~Ieaa60ccccabec8aa300184e2f2666c11990d74d3","project":"openstack/ironic-python-agent","branch":"master","topic":"story/2008923","hashtags":[],"change_id":"Ieaa60ccccabec8aa300184e2f2666c11990d74d3","subject":"[WIP] Don\u0027t grub2-install overwrite EFI bootloaders","status":"ABANDONED","created":"2021-05-26 01:14:37.000000000","updated":"2021-05-27 06:45:14.000000000","total_comment_count":6,"unresolved_comment_count":4,"has_review_started":true,"meta_rev_id":"17a57972953cbee3b8c1ac52e415159e7c4d8e15","_number":793083,"virtual_id_number":793083,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2021-05-26 03:32:20.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2021-05-26 02:34:53.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-26 03:32:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-26 13:53:17.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"CC"},{"updated":"2021-05-27 06:45:14.000000000","updated_by":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"reviewer":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"state":"CC"}],"messages":[{"id":"b4b1bfc525eb18bc5c0b211a1825435fe25dd2ce","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-05-26 01:14:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a2bb5165929fb2bf7d1fb4c01711551a07aba85d","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-05-26 02:34:53.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"25f07d307749ff0e448a3847f5a57314bf2dd554","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 03:32:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bff75ad5dcd349ada65d382cc976f599 : SUCCESS in 4m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/654c7cc2fda349a589b86cac2bf53070 : SUCCESS in 5m 14s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1a345a1224544af8ba449c672ca87640 : SUCCESS in 5m 18s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/47d414199a8f439395177a4e7cb1ec5c : SUCCESS in 5m 39s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3c240878dca0439d9405aa9abd198c1c : SUCCESS in 4m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ee67487cc67d4bf8a4f3457bd5b2b238 : SUCCESS in 6m 24s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/8f67b5767daf4163869a43897a750800 : SUCCESS in 4m 35s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/105a9af6c66a4240a6f29b24e45038dc : SUCCESS in 4m 23s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/fa848339384e45598601233b06637454 : SUCCESS in 1h 26m 01s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/1c181340fd4e4945ab862c15527643e1 : SUCCESS in 1h 20m 04s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/f4da380ddd354dbcbda29aaf17dc1c27 : SUCCESS in 1h 09m 22s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/17b0d0f21b69472ca5326b67d3d2719a : SUCCESS in 1h 25m 59s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/264abb6df1714c6aa72b374808941b96 : SUCCESS in 1h 37m 29s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/7e47f05938f84f2e87e7144970072908 : SUCCESS in 17m 10s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/fd0a5bc65dbf43148998847be8a9c05e : SUCCESS in 11m 10s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/b5d90605364745179b0cf3d83e750787 : SUCCESS in 2h 12m 09s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/65f14ee6533e423b9a9b22015decf8de : SUCCESS in 3m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c3b0c888513944017f22d47cb5e4832ab185a0aa","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-05-26 05:43:11.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f64b161d8195e968e8510cc860c162bc52928289","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-05-26 13:53:17.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"0959766fd0ba16257af45c5f4f61cf1347977cac","tag":"autogenerated:gerrit:abandon","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-05-27 02:36:13.000000000","message":"Abandoned\n\nI just deployed a partition image overcloud-full using master IPA, and it looks like the _preserve_efi_assets path leads to a successful deployment because grub2-install is not run.\n\nGiven the changed grub2-install behaviour will only occur on new images I think it is acceptable to require that they come with a populated /boot/efi as well. This leaves the whole-disk+softraid scenario which is the only one that always calls grub2-install. Its not clear to me why softraid doesn\u0027t use _preserve_efi_assets. I\u0027m hoping its because of an abundance of caution, and it may just work if we switch over. See https://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/extensions/image.py#L579","accounts_in_message":[],"_revision_number":1},{"id":"17a57972953cbee3b8c1ac52e415159e7c4d8e15","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2021-05-27 06:45:14.000000000","message":"Patch Set 1:\n\nThere is some history to it. At the time, we squeezed the UEFI RAID in just before Train (?), all was tested with grub. At around the same time the move to efibootmgr was made, but we considered to switch wdi+raid to be too risky. Ofc, we said we would fix this later :-D\n\nAlso, preserve_efi_assets did not exist at the time.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ac938aba2a2d0d781291e46ae807320007c72262","revisions":{"ac938aba2a2d0d781291e46ae807320007c72262":{"kind":"REWORK","_number":1,"created":"2021-05-26 01:14:37.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/83/793083/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/83/793083/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/83/793083/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/83/793083/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/83/793083/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/83/793083/1"}}},"commit":{"parents":[{"commit":"10d18c41136cc645ee99d41acfb6031b9158e1fb","subject":"Make _get_efi_bootloaders return relative paths","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/10d18c41136cc645ee99d41acfb6031b9158e1fb"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-05-26 01:03:13.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-05-26 01:03:13.000000000","tz":720},"subject":"[WIP] Don\u0027t grub2-install overwrite EFI bootloaders","message":"[WIP] Don\u0027t grub2-install overwrite EFI bootloaders\n\nGrub 2.04 no longer supports direct invocation of grub2-install when\nthe machine is in UEFI mode as it does not support secure-boot.\n\nThis change avoids calling grub2-install when there is already an EFI\nbootloader in the expected location (such as\n/boot/efi/EFI/BOOT/BOOTX64.EFI).\n\nThis change also changes _configure_grub to walk /boot/efi directories\nlooking for other grub.cfg files to overwrite with the generated\ngrub.cfg. For example on centos, the generated /boot/grub2/grub.cfg will be\ncopied to /boot/efi/EFI/centos/grub.cfg.\n\nThis is consistent with recent changes in diskimage-builder to support\ninstalling the shim bootloader and signed grub.\n\nWIP, some of the ~19 _install_grub2 unit tests needs to exercise\nskipping the grub2-install and copying grub.cfg to signed grub\ndirectories.\n\nStory: 2008923\nTask: 42521\nChange-Id: Ieaa60ccccabec8aa300184e2f2666c11990d74d3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ac938aba2a2d0d781291e46ae807320007c72262"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ac938aba2a2d0d781291e46ae807320007c72262"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}