)]}'
{"id":"openstack%2Fironic-python-agent~793187","triplet_id":"openstack%2Fironic-python-agent~stable%2Fvictoria~Ie3bd49add9a57fabbcdcbae4b73309066b620d02","project":"openstack/ironic-python-agent","branch":"stable/victoria","hashtags":[],"change_id":"Ie3bd49add9a57fabbcdcbae4b73309066b620d02","subject":"Fix NVMe Partition image on UEFI","status":"MERGED","created":"2021-05-26 18:04:11.000000000","updated":"2021-05-26 22:37:15.000000000","submitted":"2021-05-26 22:35:50.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"793187","cherry_pick_of_change":793186,"cherry_pick_of_patch_set":1,"meta_rev_id":"1c1a42adb8da36e2c5c3370c48a57801edaffcad","_number":793187,"virtual_id_number":793187,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-05-26 22:35:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-05-26 21:09:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-05-26 21:09:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-26 20:24:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-26 21:09:51.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"}],"messages":[{"id":"5d30e13b5a0bc27814b15e805a575eb66b727f40","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-05-26 18:04:11.000000000","message":"Patch Set 1: Cherry Picked from branch stable/wallaby.","accounts_in_message":[],"_revision_number":1},{"id":"253fc3ba02514c00fc94fcf4ef8d202af14c7233","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 20:24:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/84a26bcf885a408bbaaf7065fc03f908 : SUCCESS in 5m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/223daaec2fb8474c96cf77335350bd16 : SUCCESS in 4m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fda17619f6b04e10b022f93dffb7364a : SUCCESS in 6m 45s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9a55b5f4efa741bd81eab49d326bea4e : SUCCESS in 6m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0cf055c6719c4e1e93ade7ccfb187be3 : SUCCESS in 6m 14s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2c97f05d3e9f4a1c89782baf33a7f5a4 : SUCCESS in 5m 01s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/3b71f294db7641789aa2dfa3c10ca799 : SUCCESS in 4m 36s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/5beaabb20ffe4acfb910bbd87bd7684e : SUCCESS in 4m 16s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/87169ef6d45e40499d7f87dad4cb90b8 : SUCCESS in 1h 26m 50s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/2a43918d892942ed85b440418c5a1aa2 : SUCCESS in 59m 00s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/8bfc4feb22e24a5894eb912227f7fa13 : SUCCESS in 1h 31m 19s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/46970c0f2dc2400bafb130ad0b221ca8 : SUCCESS in 1h 04m 59s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/f33479c4ee7640f3876c891e89ae318a : SUCCESS in 17m 59s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/31396dc029064aa6a6b15e1f554b3cf3 : SUCCESS in 21m 12s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/7f332163846044e88d586ce74ef6ebdf : SUCCESS in 2h 15m 07s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/6d3d2ad69193492c93a7d66e40a7187d : SUCCESS in 4m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c4b42a4dc7042cb029621b5c384929b8e87b4376","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2021-05-26 21:09:51.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"2061478e9613a2fd650cce08da7ad8ecf1a159a4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 21:10:13.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"1637a89015627acd54ca0a2a7fd1aa34169c8f75","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 22:35:49.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c205357d4a1a4731923f35ed4f3c2411 : SUCCESS in 5m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a32a30b1f6a14728b6dec88741a49129 : SUCCESS in 4m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0119cbefb50348999fb967d20e602485 : SUCCESS in 6m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/09259de02d4c42f6b1f6791fb60c958d : SUCCESS in 7m 20s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b9fd6e5fa7e745bb9c0dd2ece2d0d850 : SUCCESS in 9m 15s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/40a2b509f78d4d9ea0016e6555ff19d0 : SUCCESS in 5m 43s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/7697a589b3f94f5b92ee39735f44f4cd : SUCCESS in 1h 21m 45s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/7a885be6bceb4c24b808db55133290ed : SUCCESS in 1h 16m 53s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/b14f41cde3b543bdb5a55072b2d0b69a : SUCCESS in 1h 23m 45s","accounts_in_message":[],"_revision_number":1},{"id":"9dd7f466cae519b861498b068c5550acd6cb6fa8","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 22:35:50.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"1c1a42adb8da36e2c5c3370c48a57801edaffcad","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 22:37:15.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f91253a80c3143bea034111914e54e4d : SUCCESS in 48s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/67a84269bf904bd3b2ddd710f62c5a5d : SUCCESS in 1m 06s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"601b83308697e395df5a129f6403ab9535a909b3","revisions":{"601b83308697e395df5a129f6403ab9535a909b3":{"kind":"REWORK","_number":1,"created":"2021-05-26 18:04:11.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/87/793187/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/87/793187/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/87/793187/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/87/793187/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/87/793187/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/87/793187/1"}}},"commit":{"parents":[{"commit":"b307c34c27f0df7a90cdb6e824d23bd68d7d1844","subject":"Point ipa-builder to stable/wallaby","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b307c34c27f0df7a90cdb6e824d23bd68d7d1844"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2021-04-27 18:09:52.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2021-05-26 18:04:11.000000000","tz":0},"subject":"Fix NVMe Partition image on UEFI","message":"Fix NVMe Partition image on UEFI\n\nThe _manage_uefi code has a check where it attempts to just\nidentify the precise partition number of the device, in order\nfor configuration to be parsed and passed. However, the same code\ndid not handle the existence of a `p1` partition instead of just a\npartition #1. This is because the device naming format is different\nwith NVMe and Software RAID.\n\nLikely, this wasn\u0027t an issue with software raid due to how complex the\ncode interaction is, but the docs also indicate to use only whole disk\nimages in that case.\n\nThis patch was pulled down my one RH\u0027s professional services folks\nwho has confirmed it does indeed fix the issue at hand. This is noted\nas a public comment on the Red Hat bugzilla.\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1954096\n\nStory: 2008881\nTask: 42426\nRelated: rhbz#1954096\nChange-Id: Ie3bd49add9a57fabbcdcbae4b73309066b620d02\n(cherry picked from commit fe825fa97ed1f3c9fa8b1461b63ab133fec20b72)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/601b83308697e395df5a129f6403ab9535a909b3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/601b83308697e395df5a129f6403ab9535a909b3"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}