)]}'
{"id":"openstack%2Fironic-python-agent~793188","triplet_id":"openstack%2Fironic-python-agent~stable%2Fussuri~Ie3bd49add9a57fabbcdcbae4b73309066b620d02","project":"openstack/ironic-python-agent","branch":"stable/ussuri","hashtags":[],"change_id":"Ie3bd49add9a57fabbcdcbae4b73309066b620d02","subject":"Fix NVMe Partition image on UEFI","status":"MERGED","created":"2021-05-26 18:04:37.000000000","updated":"2021-05-26 22:08:56.000000000","submitted":"2021-05-26 22:07:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"793188","cherry_pick_of_change":793187,"cherry_pick_of_patch_set":1,"meta_rev_id":"1cf824ca2a75315eb00f93c91e8c3c840dd60f3d","_number":793188,"virtual_id_number":793188,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-05-26 22:07:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-05-26 20:44:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-05-26 20:44:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-26 20:25:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-26 20:44:55.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"}],"messages":[{"id":"f0805025bb2d265e009bcdcdcfcea9e11823134d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-05-26 18:04:37.000000000","message":"Patch Set 1: Cherry Picked from branch stable/victoria.","accounts_in_message":[],"_revision_number":1},{"id":"df42daf658adef28e96dc212dd5f313e1641dc1e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 20:25:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/71ed3febcd134a80be45dc59ccb579cd : SUCCESS in 4m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2511cd9fb0f1461dbb228b51d9ff508d : SUCCESS in 5m 16s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/01d20979d81047549e9698d7da3b3a07 : SUCCESS in 5m 15s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b89206a8a2794841ac54b6acfa76334d : SUCCESS in 4m 31s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f5db821f999c4588beab3f955527bbcb : SUCCESS in 6m 41s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1448cf66f6d3447a822f798bfeb6fb22 : SUCCESS in 3m 55s\n- ipa-tempest-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/7eebb1008a7e42b08d0c39776ffb1b4f : SUCCESS in 1h 11m 02s\n- ipa-tempest-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/cbd2685c3895401782b2788e152e252c : SUCCESS in 55m 20s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/c59567df8638471787a6199664969b38 : SUCCESS in 1h 36m 44s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/1bf8712bce904c97aa35fa951ec4bf4d : SUCCESS in 55m 51s\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/a84e708c620044ebaa5a0c2b02fbe281 : FAILURE in 2h 19m 47s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/79c4f7009ba342e0871d988fa5716281 : FAILURE in 31m 43s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/862ffdcf8e23449db0ad49b5da8747ba : FAILURE in 41m 03s (non-voting)\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/c4c7eef7a6374024b0a648828d705fb5 : SUCCESS in 5m 19s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/dcdf5b9740014f6394c95c765d39429a : SUCCESS in 4m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"20ff05fb57cd65425c6f30ba0af98071571d2907","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2021-05-26 20:44:55.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"55561dcc9a0de59274899237dd9bf9238c00c483","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 20:45:14.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c8589caf1936486f3ba0ce90608759e337c4857d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 22:07:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d75ce18344e84d48b8061be566fd321d : SUCCESS in 4m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9e00266a88bf4f1d84bc7844f027d756 : SUCCESS in 4m 11s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ea672368c9e243d18f55bac8d371c790 : SUCCESS in 5m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/108d009130864f4bb1c77574962a5336 : SUCCESS in 5m 38s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/528fd91f2cf64ea9b2d5d52c34627638 : SUCCESS in 6m 15s\n- ipa-tempest-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/69037c9e001045df92c60f8f6b50198e : SUCCESS in 1h 00m 52s\n- ipa-tempest-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/7634b135a8bf4446a7ed9f42090d3ece : SUCCESS in 1h 12m 23s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/a6fb1d21da744e4abc8d47ac2ad9c467 : SUCCESS in 1h 08m 20s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/cf288d174b8842f9ad6716818b0842f2 : SUCCESS in 1h 19m 46s","accounts_in_message":[],"_revision_number":1},{"id":"27a76811a0bb1af53dc35c71a25a603f764a5ece","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 22:07:33.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"1cf824ca2a75315eb00f93c91e8c3c840dd60f3d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 22:08:56.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e484c03a56c1403090c9fe234036d51d : SUCCESS in 51s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e880327c03214c8ba75a50ab85d8e07c : SUCCESS in 52s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6324b37b43aa1b09c579bcd26c2e036c056b5347","revisions":{"6324b37b43aa1b09c579bcd26c2e036c056b5347":{"kind":"REWORK","_number":1,"created":"2021-05-26 18:04:37.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/88/793188/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/88/793188/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/88/793188/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/88/793188/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/88/793188/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/88/793188/1"}}},"commit":{"parents":[{"commit":"7007ea0906ff30189804b062008393459d6548f2","subject":"Add fstab pointer to EFI partition","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/7007ea0906ff30189804b062008393459d6548f2"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2021-04-27 18:09:52.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2021-05-26 18:04:37.000000000","tz":0},"subject":"Fix NVMe Partition image on UEFI","message":"Fix NVMe Partition image on UEFI\n\nThe _manage_uefi code has a check where it attempts to just\nidentify the precise partition number of the device, in order\nfor configuration to be parsed and passed. However, the same code\ndid not handle the existence of a `p1` partition instead of just a\npartition #1. This is because the device naming format is different\nwith NVMe and Software RAID.\n\nLikely, this wasn\u0027t an issue with software raid due to how complex the\ncode interaction is, but the docs also indicate to use only whole disk\nimages in that case.\n\nThis patch was pulled down my one RH\u0027s professional services folks\nwho has confirmed it does indeed fix the issue at hand. This is noted\nas a public comment on the Red Hat bugzilla.\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1954096\n\nStory: 2008881\nTask: 42426\nRelated: rhbz#1954096\nChange-Id: Ie3bd49add9a57fabbcdcbae4b73309066b620d02\n(cherry picked from commit fe825fa97ed1f3c9fa8b1461b63ab133fec20b72)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6324b37b43aa1b09c579bcd26c2e036c056b5347"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6324b37b43aa1b09c579bcd26c2e036c056b5347"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}
