)]}'
{"id":"openstack%2Fironic-python-agent~793189","triplet_id":"openstack%2Fironic-python-agent~stable%2Ftrain~Ie3bd49add9a57fabbcdcbae4b73309066b620d02","project":"openstack/ironic-python-agent","branch":"stable/train","hashtags":[],"change_id":"Ie3bd49add9a57fabbcdcbae4b73309066b620d02","subject":"Fix NVMe Partition image on UEFI","status":"MERGED","created":"2021-05-26 18:05:00.000000000","updated":"2021-05-27 09:00:04.000000000","submitted":"2021-05-27 08:58:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"793189","cherry_pick_of_change":793188,"cherry_pick_of_patch_set":1,"meta_rev_id":"288077ef302e9e1c6615dbe4a0058e5992cea84f","_number":793189,"virtual_id_number":793189,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-05-27 08:58:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2021-05-27 07:30:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":1,"date":"2021-05-27 07:30:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-26 19:52:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-27 07:30:14.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"}],"messages":[{"id":"41f553741999901afcf0fe7bcd2e3d60d3d809b0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-05-26 18:05:00.000000000","message":"Patch Set 1: Cherry Picked from branch stable/ussuri.","accounts_in_message":[],"_revision_number":1},{"id":"e44c61b88aef709f708170c5519351a1094f6672","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 19:52:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/421f20852629452abf37da3d5454a2c9 : SUCCESS in 5m 52s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/78796285cac54fc0bdeba4d9dea01982 : SUCCESS in 6m 11s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6e258f284c924834bcbb01b3c676bce2 : SUCCESS in 6m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/df953206f18943babc7326c9882d691f : SUCCESS in 7m 53s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/79345f4693da4c1ea082a673651204f2 : SUCCESS in 4m 35s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/24ae29b3c2fd41559965f97fe31b8c29 : SUCCESS in 1h 00m 06s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/4eab810ef3414f1cb5f856fae6b62181 : SUCCESS in 1h 12m 24s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/ed693fa798564ce781eb72aec799efa4 : SUCCESS in 1h 05m 08s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/1e5529cdddd5402f9124784b2a787c05 : SUCCESS in 1h 00m 00s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/e3d4595fa26e4c0aa824e1ef1c18c98e : SUCCESS in 1h 21m 23s\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/494aa3a94f6e4eb38ef06616db365ee3 : SUCCESS in 1h 37m 57s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/6e21eaa4f69e48f18854f1d22c2326c7 : RETRY_LIMIT in 33m 06s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/b596dd0157c74d57a31d3cae3218db51 : FAILURE in 36m 02s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/7b95c9fef1e8458cb1cb9ebac0f2543b : SUCCESS in 5m 08s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/50a8b230a90b44e083e9c35c77e45566 : SUCCESS in 4m 31s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8525f50925bdfb78b625b618386c3784ede7fbf1","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-05-27 07:30:14.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"af09f4744d06988be7c8565762a706039f2f75b4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-27 07:30:33.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5e8fb10c0be4d5fb5c9fd9eb25ec6d72ad541d40","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-27 08:58:38.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1ef4b232db1348cd86927e911636d282 : SUCCESS in 6m 33s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/fcefd4be5cd44751a9009149c4d80768 : SUCCESS in 6m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cd6f26aec1554590a9566e2fed997e3a : SUCCESS in 6m 08s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/04b73da7143f43a0a5ef1d8c4c63c9fc : SUCCESS in 4m 15s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/2b06d04bfac346f889bdb781b19bb498 : SUCCESS in 51m 39s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/40c34f6961cb4800b904e248ab8269f1 : SUCCESS in 52m 58s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/a24a44fbbef242ecab933febbd32cfaf : SUCCESS in 1h 06m 41s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/3c9f47ade0194a6289ad845de6311963 : SUCCESS in 59m 05s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/a2c353bb6ecb46f8ae290ee9c01901a5 : SUCCESS in 1h 23m 57s","accounts_in_message":[],"_revision_number":1},{"id":"32b610e325a177e8a6606d0f9f02cc398c6978fb","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-27 08:58:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"288077ef302e9e1c6615dbe4a0058e5992cea84f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-27 09:00:04.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ac360b1f95f64b01b19b62b389a0ae92 : SUCCESS in 1m 10s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/58b1d02306304d578c7ac12836bd54ab : SUCCESS in 56s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e3da25329df5ade4f30da562f1b196ecae437636","revisions":{"e3da25329df5ade4f30da562f1b196ecae437636":{"kind":"REWORK","_number":1,"created":"2021-05-26 18:05:00.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/89/793189/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/89/793189/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/89/793189/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/89/793189/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/89/793189/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/89/793189/1"}}},"commit":{"parents":[{"commit":"9f2ef8ab02f81ce1a652f76e2c09689dd7d574a8","subject":"Option to enable bootloader config failure bypass","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9f2ef8ab02f81ce1a652f76e2c09689dd7d574a8"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2021-04-27 18:09:52.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2021-05-26 18:05:00.000000000","tz":0},"subject":"Fix NVMe Partition image on UEFI","message":"Fix NVMe Partition image on UEFI\n\nThe _manage_uefi code has a check where it attempts to just\nidentify the precise partition number of the device, in order\nfor configuration to be parsed and passed. However, the same code\ndid not handle the existence of a `p1` partition instead of just a\npartition #1. This is because the device naming format is different\nwith NVMe and Software RAID.\n\nLikely, this wasn\u0027t an issue with software raid due to how complex the\ncode interaction is, but the docs also indicate to use only whole disk\nimages in that case.\n\nThis patch was pulled down my one RH\u0027s professional services folks\nwho has confirmed it does indeed fix the issue at hand. This is noted\nas a public comment on the Red Hat bugzilla.\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1954096\n\nStory: 2008881\nTask: 42426\nRelated: rhbz#1954096\nChange-Id: Ie3bd49add9a57fabbcdcbae4b73309066b620d02\n(cherry picked from commit fe825fa97ed1f3c9fa8b1461b63ab133fec20b72)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e3da25329df5ade4f30da562f1b196ecae437636"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e3da25329df5ade4f30da562f1b196ecae437636"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}