)]}'
{"id":"openstack%2Fironic-python-agent~793953","triplet_id":"openstack%2Fironic-python-agent~master~I6dc357659b1c0f9f491d61043ca38878a60e3327","project":"openstack/ironic-python-agent","branch":"master","topic":"smart","hashtags":[],"change_id":"I6dc357659b1c0f9f491d61043ca38878a60e3327","subject":"Check the target root device with smartctl","status":"ABANDONED","created":"2021-06-01 11:50:08.000000000","updated":"2021-06-10 13:47:11.000000000","total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"796797992dea3e7c0996bab44095f8c4132c1541","_number":793953,"virtual_id_number":793953,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"rejected":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"tag":"autogenerated:zuul:gate","value":-2,"date":"2021-06-03 17:24:15.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":0,"date":"2021-06-04 06:04:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2021-06-04 05:00:05.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":-1,"date":"2021-06-03 17:26:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":-1,"date":"2021-06-03 18:00:02.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2021-06-04 05:00:05.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"date":"2021-06-04 14:58:03.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":-1,"date":"2021-06-03 17:51:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"}],"REVIEWER":[{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-01 13:59:36.000000000","updated_by":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"reviewer":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"state":"REVIEWER"},{"updated":"2021-06-01 17:04:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-03 08:06:55.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"CC"},{"updated":"2021-06-03 08:11:59.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2021-06-03 17:26:31.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2021-06-03 17:51:50.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2021-06-03 21:45:21.000000000","updated_by":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"reviewer":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"state":"CC"}],"messages":[{"id":"f4e73a49b2a32469f19ea676001c17245fbb23b1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-06-01 11:50:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a52471a877ae75a34a6a6dab91d5d1ed1932ac37","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-06-01 13:56:20.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2bbb7ced0b9f59a79eb6afd4e8ce8e0ffcb31b1e","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2021-06-01 14:13:23.000000000","message":"Patch Set 2:\n\nThanks, Dmitry!\n\nHow about logging the smartctl output upon failure? IIRC, utils.execute will only log in debug mode (which I assume to be off under normal circumstances). Otherwise, we would now need to boot the node again to get more details about what is wrong with the disk, rather than just checking the logs.","accounts_in_message":[],"_revision_number":2},{"id":"8d1780101001c2323679e31d176ca8e9f87ebf22","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-06-01 15:14:03.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c6b4ef0afd05d5db58d70bfef93c387cebd9d62d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-01 17:04:12.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9a79b8a40051401092e493a17775aad3 : SUCCESS in 4m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/43f84d6b558242aa8917e4465f251871 : SUCCESS in 5m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9b4320fe349945c4a1310da74efe2eaf : SUCCESS in 5m 16s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b36e468deaa846eb801b5a1a3daafede : SUCCESS in 5m 40s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/347623a6139b475897510ffa41878e8e : SUCCESS in 6m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0485cf4d09ed40a89e62fa685fb29358 : SUCCESS in 6m 37s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/95559393c869455691019e21e065ce6f : SUCCESS in 5m 26s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/9e62be87d3b643fba2b570d3ef061342 : SUCCESS in 5m 04s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/076a0c7e83b3417b98e8b8ac8ee15ce5 : SUCCESS in 5m 21s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/5c476c8ae7d045de90dee76650b2cd07 : FAILURE in 1h 08m 52s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/562ee399d6734ea5a923f7a9fa70a569 : FAILURE in 1h 11m 37s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/b8f2d47521d747709b97d2143ba44c33 : SUCCESS in 59m 16s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/58463667e9f94e07953437008dbc8389 : SUCCESS in 1h 26m 18s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/01efb71d167c4a8ab1e1e52ab0944c19 : SUCCESS in 1h 35m 50s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/ceebdcae8fbf4bb4a1d9fa7150e79768 : SUCCESS in 14m 59s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/f702e70e876744e6bf01ff0b8ae0fd75 : SUCCESS in 12m 33s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/1ffa414220e240e7aedc61ae1c56b9d8 : FAILURE in 1h 44m 01s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/16342804c0b84c2d8fb722c6efcdb000 : SUCCESS in 4m 25s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"71e878d0a4d12fa89e882515364e7ac77512d60b","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2021-06-02 06:36:02.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"b6a73920c47b7a48d5944f665be49af1254d2bcd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-02 08:33:02.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ce10be6a83614893b0a7eef871d41913 : SUCCESS in 6m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8345b6c4c3624bb3aa0daf0453172f35 : SUCCESS in 6m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/cc5abd35d3484411aaa784eb41ce824e : SUCCESS in 6m 31s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d3c03bc943114932aa4e6c9103282edd : SUCCESS in 6m 53s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3784f26d92f4411497f44701fc73c6eb : SUCCESS in 6m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/18729a6c44e947cc82d725c62f6ba9eb : SUCCESS in 8m 09s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/39cdd549a8fa431e838f4a2f98da113c : SUCCESS in 5m 37s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/5c03f0cf94914f8ab40cdff4a70467c8 : SUCCESS in 5m 21s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/a4d3ceb3938c415ca136517e44e0b99a : SUCCESS in 6m 31s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/be59c1e3400c4f04bccf709f7d1ecfe7 : SUCCESS in 1h 26m 47s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/7bb5698b247c4e10805b1a3d73f68445 : SUCCESS in 1h 28m 13s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/0b346f28dd3b49129ab550f1e919a982 : SUCCESS in 57m 50s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/4f3fb5bae78f4803a11a6decd71272af : SUCCESS in 1h 11m 28s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/3745ca21a03f40aa9f36a08ce6047909 : SUCCESS in 1h 49m 56s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/3a9f62976e0b48babeac40db4ee332b9 : SUCCESS in 16m 50s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/d0f623313c2b4b9f95c7ab5e934a0503 : SUCCESS in 12m 34s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/b87bf7698b8d4bf6a1d74cef71d0dd0d : FAILURE in 1h 32m 35s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/f6212164867243f9b93ae044fe85eeaf : SUCCESS in 5m 54s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"bc596946b1ae8d74ac646a25961be0a5e434588f","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2021-06-02 08:43:10.000000000","message":"Patch Set 3: Code-Review+2\n\nThanks, Dmitry!","accounts_in_message":[],"_revision_number":3},{"id":"6e6114e3cddf539b7bf14a7b256c38d87c483317","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-06-02 15:24:53.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"716479afb956aa09545917e8ed0dc41961017026","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2021-06-02 15:30:57.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"08140ac53d8eb69b98a81f97fa81c0a6e8758926","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-02 17:35:35.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f13c1f2d37fd4a569cb62501c9fea4ab : SUCCESS in 5m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b5fe28e780084da4b1ad5d776b699ff3 : SUCCESS in 5m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bb370968ad6f452bb16298385d0b5774 : SUCCESS in 6m 47s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/1b791e43e497469bb074a5b46f632e00 : SUCCESS in 6m 04s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bbfa39a3941d4dd2a1a9e2f7ee484c6f : SUCCESS in 6m 48s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8f56927e928041a9a63195dfa191442a : SUCCESS in 7m 15s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ba2d785ce15b45e2aacc3f3b358dacfa : SUCCESS in 4m 59s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/a05828fe75814f4faabbbdf1f5f39301 : SUCCESS in 6m 53s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/48b2901df6234cdbb92af7c9564b7e1c : SUCCESS in 5m 11s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/129dfc494402441c90cd91ea7f63c9b7 : FAILURE in 1h 11m 30s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/6f2389aa66f848e49776ef17c5f8bf35 : SUCCESS in 1h 19m 51s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/fdf0f749fb264a5eabeebc1ccdbdabc0 : SUCCESS in 58m 02s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/62df1c5c02a84ad487f04a9684f5b73b : SUCCESS in 1h 13m 13s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/d8fe77817d9f4eec8044d4903eb00ec1 : SUCCESS in 1h 38m 01s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/874bb68044324cb7a5645f9abb55fcbc : SUCCESS in 15m 50s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/60e9b2c6083b46f387929a3e7f9fb9ce : SUCCESS in 13m 02s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/41798019dff5464d8b888d60a1213c8e : FAILURE in 1h 47m 01s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/0835dac31d094ff3bace6095e96b2101 : SUCCESS in 5m 04s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"dd20cad0fd2a422ab0ec77ea5ee4225583dda6cc","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-06-03 08:06:55.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"bdf329dd1689335786822a8a5b71fed9bd378177","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-06-03 08:11:59.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"06bbf7c5fc58a8395846f5707425d401c1331597","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-03 10:22:11.000000000","message":"Patch Set 4:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/712c4c620c80472e95805b69d2648e24 : SUCCESS in 5m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2c33a1b9cad44cd3ac5fbfc0dee332c5 : SUCCESS in 5m 31s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/24a22354e783451cad4dc40a6afc0cda : SUCCESS in 5m 28s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ba661997e9c641ab89e9619409e89a5f : SUCCESS in 6m 32s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a3d60e03674341178d52def3b275a007 : SUCCESS in 6m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/894b01fa079b49728b6916cdb8186ede : SUCCESS in 7m 08s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1ad5c7d4e05d4d0a9040f96c6ed2a2a0 : SUCCESS in 4m 56s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/f4f0815228ed42589dc9af8f14d348ed : SUCCESS in 5m 37s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/6f7967edd3314dc0805820f7b7ddfaeb : SUCCESS in 5m 40s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/0c9f58aa236a4b94b87ce50ad3a8b50e : FAILURE in 1h 09m 26s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/b6f6191c3d7245feb3d9cea26da33796 : FAILURE in 1h 05m 48s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/cd3ae33ede2946edb384c047e0573821 : SUCCESS in 55m 17s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/f2e8b8c204dc4d5dae13b1b1e5f0ce9f : SUCCESS in 1h 22m 44s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/d525555c2ab54154a1296735b6907223 : SUCCESS in 1h 31m 24s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/9d253f561bc14724b42acd5bfed0f452 : SUCCESS in 15m 21s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/5d0943fb80314e9398932704055fd342 : SUCCESS in 10m 54s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/6b6f576aa056411b96844e807576d958 : SUCCESS in 2h 11m 23s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/552510640c6546b8939aaf5bb7634df0 : SUCCESS in 4m 32s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"c0d7b50ce15ee75cc0bd16291ed5d808c904de74","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-06-03 14:10:48.000000000","message":"Patch Set 4:\n\nrecheck mmmm","accounts_in_message":[],"_revision_number":4},{"id":"f89ec6d4d28585ea09cdae2da5a4194597db71b0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-03 15:55:05.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6e630a9ea5064c61ab3eeefa915d7f79 : SUCCESS in 4m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4661d0a0c6e34ecfa2f8a2fd77c59e61 : SUCCESS in 5m 12s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8be3448cb492444ea04d1b8dedc0ef51 : SUCCESS in 5m 19s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/749fcecb4a8449eb83a7724012c14fcc : SUCCESS in 5m 55s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d199c8c1397e49559aa04a9714540e9a : SUCCESS in 4m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3eec4ebdf1184c958cadd600f4903077 : SUCCESS in 7m 40s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/eee3d15ef41c4dce9a8f7c89249bb182 : SUCCESS in 4m 10s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/99978fb34b2c4f25b70cc218bb0b9a62 : SUCCESS in 5m 20s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/d317923ce06043eca13e6bf0161b2157 : SUCCESS in 5m 16s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/6d155888a1c04233bf13c5ea9c2afd38 : SUCCESS in 1h 27m 51s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/b3929ad78cd546e1a8cc238abe2db2e5 : SUCCESS in 1h 26m 41s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/7488699c5ecf4df6a144c10793a358aa : SUCCESS in 1h 06m 23s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/c565207e4b3f42309ebfc196dfce5b8d : SUCCESS in 1h 27m 51s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/014dc5d7cb92430d9b42840a52a15d13 : SUCCESS in 1h 39m 27s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/45e18c113b104b42aefa0a6d88fb5d5d : SUCCESS in 18m 08s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/5e29c97653d34501b3c58d62a647d003 : POST_FAILURE in 19m 30s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/eba6f5f86bcd444f9c22659f6ba1a669 : FAILURE in 1h 42m 19s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/4bbf530404f8433f9e217cdcda9417a5 : SUCCESS in 6m 15s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"864ee98de782cdc6ba0fbeaef8e6754cf78a10da","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-03 15:55:28.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"483ac9fd349ac889253645b6dd78a28870260666","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-03 17:24:15.000000000","message":"Patch Set 4: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/69400e70a7cc480da514efca4145e789 : SUCCESS in 4m 52s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/af47e7146abf4ba8b3b60b878143de1f : SUCCESS in 5m 43s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/eff12ea9838e47ffb9b968a4ef5525b1 : SUCCESS in 6m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/17327e824d044c0eb34af2a7bb1daab7 : SUCCESS in 9m 18s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/17216a6572ab403f9f88c602528a79f2 : SUCCESS in 4m 38s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/7077812bc3e44267a63e9ad2d89476d0 : SUCCESS in 5m 22s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/41165624588741a4ba14e8e541e2bc26 : POST_FAILURE in 35m 09s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/01d5fd54289449cab5907eadc510c6cf : SUCCESS in 1h 24m 08s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/13488a90460746ae9998f6dc38bf760f : SUCCESS in 1h 24m 37s","accounts_in_message":[],"_revision_number":4},{"id":"b73dc27f2b612223f8031765c9301e81d72cd548","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2021-06-03 17:26:31.000000000","message":"Patch Set 4: Code-Review-1\n\nI\u0027m glad I got a chance to see this.\n\nI do not think this should be done by default. There are bad HDD\u0027s out there which report invalid smartctl information, and enabling this feature by default will break IPA\u0027s ability to deploy to these HDDs.\n\nCan we please add a configuration for disabling this (maybe on a per-node level? IDK), and preferably leave it disabled by default?","accounts_in_message":[],"_revision_number":4},{"id":"224bcf35ef0bcd4c1778d68aa3820fe58ba6ddc7","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2021-06-03 17:27:30.000000000","message":"Patch Set 4: Workflow-1","accounts_in_message":[],"_revision_number":4},{"id":"d93586881f66685be853dbe0de6c1c1e919ef03b","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2021-06-03 17:27:35.000000000","message":"Patch Set 4: -Workflow","accounts_in_message":[],"_revision_number":4},{"id":"b02ca03b50473a2cca020e3f5e6a3c3ae257d408","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2021-06-03 17:28:40.000000000","message":"Patch Set 4:\n\nSidebar: Is there a way for me to un-workflow a patch someone else has +A\u0027d that I don\u0027t want merging?","accounts_in_message":[],"_revision_number":4},{"id":"e5ce2d9eac5a233703fdd0d86c88824d7fb0a388","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-06-03 17:51:50.000000000","message":"Patch Set 4: Workflow-1","accounts_in_message":[],"_revision_number":4},{"id":"29bd43206ee2f2539aa43dcdd2821952f2fe8ee2","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-06-03 17:52:09.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4:\n\u003e \n\u003e Sidebar: Is there a way for me to un-workflow a patch someone else has +A\u0027d that I don\u0027t want merging?\n\nApply WF-1 ?","accounts_in_message":[],"_revision_number":4},{"id":"7337da0e0006ae6625729539ed19866e20cd2258","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-06-03 17:59:56.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4: Code-Review-1\n\u003e \n\u003e I\u0027m glad I got a chance to see this.\n\u003e \n\u003e I do not think this should be done by default. There are bad HDD\u0027s out there which report invalid smartctl information, and enabling this feature by default will break IPA\u0027s ability to deploy to these HDDs.\n\u003e \n\u003e Can we please add a configuration for disabling this (maybe on a per-node level? IDK), and preferably leave it disabled by default?\n\nThis is also a concern of mine. I *think* most of my concern would be okay if we don\u0027t fail on Bit 1 being set by smartctl because it doesn\u0027t necessarily mean that the drive has failed, as it is device open failed, or no IDENTIFY DEVICE structure response, or in low power mode. Obviously, it supports a number of technologies, for example I just found out it supports NVME, but we still have people out there using fibrechannel arrays, and some controllers may grok the SMART request, or not.  If they don\u0027t, then this change is suddenly operationally breaking when there storage system is perfectly fine. Which in my mind goes back to ensuring bit 1 being returned does not (I guess, exit code 2 in an integer?) create a hard failure.","accounts_in_message":[],"_revision_number":4},{"id":"635428de2acc9f33a12186a364fba7df6ec70a72","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-06-03 18:00:02.000000000","message":"Patch Set 4: Code-Review-1","accounts_in_message":[],"_revision_number":4},{"id":"76de9c52b0ea48e2988f34afea6314e0e4c2ae83","author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"date":"2021-06-03 21:45:21.000000000","message":"Patch Set 4:\n\nThank you for the patch Dmitry and for your comments Julia and Jay. My POV:\n* having an option to control this behaviour certainly sounds like a good idea as it will allow operators to fine-tune behaviour to what their hardware is doing\n* In general I would not be ruling out having this on by default, I think it is a useful feature and if a device is mistakenly reporting failure, to me that is a failure nonetheless\n* however in cases of no hard failure, just poor smartctl support perhaps we should be logging a warning instead of failing deployment. Making this another config option may make sense, but I\u0027m in two minds about this, may be one knob too many.\n@Dmitry @Jay @Julia what are your thoughts on this?","accounts_in_message":[],"_revision_number":4},{"id":"720a2027565a0b8424cb4c7dfe1cf877c31af926","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2021-06-03 21:59:37.000000000","message":"Patch Set 4:\n\nIMO, a better approach to implementing this is:\n\n- Not be done unconditionally on all machines (e.g. off by default)\n- Be implemented as an optional step that could be applied to deploy or cleaning\n\nBut that\u0027s my $.02. My primary requirement for approval is making the behavior optional... but I don\u0027t think it should be enabled by default either (but there is a lot of room to convince me otherwise).","accounts_in_message":[],"_revision_number":4},{"id":"b5ba6ba8bd1140d6b502be7b251e8ff11ca479fd","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-06-04 05:00:05.000000000","message":"Patch Set 4: -Code-Review -Workflow\n\nremoving +W based on recent comments","accounts_in_message":[],"_revision_number":4},{"id":"89a2df445c5583ec8ce8789920bd416b6e2d73ea","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2021-06-04 06:04:45.000000000","message":"Patch Set 4: -Code-Review\n\nRemoving +2 for now.\n\nI guess that most deployments have contracts with their vendors/suppliers about when a disk should be replaced, and I would not be surprised if this is \"smart health check says the disk is\nbroken\" in many places. For us this is one of the cases, for instance. As also mentioned, in our deployment we run a disk burn-in before the node goes into prod, with the idea this reveals broken drives. Unlikely, but not impossible ofc, that drives break while waiting for deployment after. I believe the idea of this change, however, was to catch issues upon re-deployment when you cannot run a full verification.\n\nMaking this check optional (for deploy here and for a clean step later) is a good suggestion as it allows deployments to adjust to their needs.","accounts_in_message":[],"_revision_number":4},{"id":"ef60b088e8cc6c0d57f76f1ee5759ad8618e95ad","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-06-04 09:59:34.000000000","message":"Patch Set 4:\n\n\u003e I do not think this should be done by default. There are bad HDD\u0027s out there which report invalid smartctl information\n\nWe only fail if smartctl explicitly reports \"disk failure\". Is it the case for these devices or do they report a different error code?","accounts_in_message":[],"_revision_number":4},{"id":"0c4210d814144d2ee8424945884b2f789ec9de9e","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2021-06-04 14:58:03.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4:\n\u003e \n\u003e \u003e I do not think this should be done by default. There are bad HDD\u0027s out there which report invalid smartctl information\n\u003e \n\u003e We only fail if smartctl explicitly reports \"disk failure\". Is it the case for these devices or do they report a different error code?\n\nI have had hardware that reported disk failures via SMART out of the box. Usually lower quality SATADOM type modules. That\u0027s obviously the hardwares\u0027 fault, but we shouldn\u0027t paint operators with crappy hardware into a corner.","accounts_in_message":[],"_revision_number":4},{"id":"22f8a5f8745f19b2393bcfbc412be92bbd705259","tag":"autogenerated:gerrit:abandon","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-06-07 09:05:42.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":4},{"id":"796797992dea3e7c0996bab44095f8c4132c1541","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-06-10 13:47:11.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4:\n\u003e \n\u003e \u003e Patch Set 4:\n\u003e \u003e \n\u003e \u003e \u003e I do not think this should be done by default. There are bad HDD\u0027s out there which report invalid smartctl information\n\u003e \u003e \n\u003e \u003e We only fail if smartctl explicitly reports \"disk failure\". Is it the case for these devices or do they report a different error code?\n\u003e \n\u003e I have had hardware that reported disk failures via SMART out of the box. Usually lower quality SATADOM type modules. That\u0027s obviously the hardwares\u0027 fault, but we shouldn\u0027t paint operators with crappy hardware into a corner.\n\nI agree we shouldn\u0027t paint people with problematic hardware in a corner, but think think that would be more reason to have a configuration option so on a per node basis an operator can acknowledge \"hey, i know this may be a problem.\" I do think it is semi-reasonable for us to check the devices but personally I\u0027ve never seen a sata device be in failed state and actually have a working IO interface to really query. I\u0027m sure my experiences were likely somewhat edge cases, but mostly \"pending fail\" was the state I\u0027d find disks and of course if they were re-seated or completely powered off, they would be \"I\u0027m good again!\" in most cases at least for a few weeks or months. (https://twitter.com/ashinclouds/status/1402260136538873858)","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2288ced70d7851142b195b9d975e29a98781bf17","revisions":{"85d278f8d9865c9a1ad10bade33d6dcab8b9a80e":{"kind":"REWORK","_number":1,"created":"2021-06-01 11:50:08.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/53/793953/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/53/793953/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/1"}}},"commit":{"parents":[{"commit":"5c063c8224d3d3e69a1e10f2252e2eebdcceffb1","subject":"Merge \"Make _get_efi_bootloaders return relative paths\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5c063c8224d3d3e69a1e10f2252e2eebdcceffb1"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-06-01 11:49:26.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-06-01 11:49:26.000000000","tz":120},"subject":"[WIP] Check the target root device with smartctl","message":"[WIP] Check the target root device with smartctl\n\nChange-Id: I6dc357659b1c0f9f491d61043ca38878a60e3327\nStory: #2008937\nTask: #42545\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/85d278f8d9865c9a1ad10bade33d6dcab8b9a80e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/85d278f8d9865c9a1ad10bade33d6dcab8b9a80e"}]},"branch":"refs/heads/master"},"97244553f54a60a52cd1752dbc913272f91d333e":{"kind":"REWORK","_number":2,"created":"2021-06-01 13:56:20.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/53/793953/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/53/793953/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/2"}}},"commit":{"parents":[{"commit":"5c063c8224d3d3e69a1e10f2252e2eebdcceffb1","subject":"Merge \"Make _get_efi_bootloaders return relative paths\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5c063c8224d3d3e69a1e10f2252e2eebdcceffb1"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-06-01 11:49:26.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-06-01 13:55:36.000000000","tz":120},"subject":"Check the target root device with smartctl","message":"Check the target root device with smartctl\n\nChange-Id: I6dc357659b1c0f9f491d61043ca38878a60e3327\nStory: #2008937\nTask: #42545\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/97244553f54a60a52cd1752dbc913272f91d333e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/97244553f54a60a52cd1752dbc913272f91d333e"}]},"branch":"refs/heads/master"},"7661d7770ba36be40683d9146d410180ad4d164f":{"kind":"REWORK","_number":3,"created":"2021-06-01 15:14:03.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/53/793953/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/53/793953/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/3"}}},"commit":{"parents":[{"commit":"5c063c8224d3d3e69a1e10f2252e2eebdcceffb1","subject":"Merge \"Make _get_efi_bootloaders return relative paths\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5c063c8224d3d3e69a1e10f2252e2eebdcceffb1"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-06-01 11:49:26.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-06-01 15:13:54.000000000","tz":120},"subject":"Check the target root device with smartctl","message":"Check the target root device with smartctl\n\nChange-Id: I6dc357659b1c0f9f491d61043ca38878a60e3327\nStory: #2008937\nTask: #42545\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/7661d7770ba36be40683d9146d410180ad4d164f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/7661d7770ba36be40683d9146d410180ad4d164f"}]},"branch":"refs/heads/master"},"2288ced70d7851142b195b9d975e29a98781bf17":{"kind":"REWORK","_number":4,"created":"2021-06-02 15:24:53.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/53/793953/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/53/793953/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/53/793953/4"}}},"commit":{"parents":[{"commit":"7fdbcde3de2d7c81f84933ce6f81de1b3c3e05e2","subject":"Merge \"Stop accepting duplicated configdrive\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/7fdbcde3de2d7c81f84933ce6f81de1b3c3e05e2"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-06-01 11:49:26.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-06-02 15:23:54.000000000","tz":120},"subject":"Check the target root device with smartctl","message":"Check the target root device with smartctl\n\nChange-Id: I6dc357659b1c0f9f491d61043ca38878a60e3327\nStory: #2008937\nTask: #42545\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2288ced70d7851142b195b9d975e29a98781bf17"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2288ced70d7851142b195b9d975e29a98781bf17"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}