)]}'
{"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"acbc81b2cd0dd808281c1b09303a837d03986bd5","unresolved":true,"context_lines":[{"line_number":632,"context_line":"            utils.execute(\u0027mount\u0027, efi_partition, efi_partition_mount_point)"},{"line_number":633,"context_line":"            efi_mounted \u003d True"},{"line_number":634,"context_line":"            try:"},{"line_number":635,"context_line":"                # FIXME(rg): does not work in cross boot mode case (target"},{"line_number":636,"context_line":"                # boot mode differs from ramdisk one)"},{"line_number":637,"context_line":"                # Probe for the correct target (depends on the arch, example"},{"line_number":638,"context_line":"                # --target\u003dx86_64-efi)"},{"line_number":639,"context_line":"                utils.execute(\u0027chroot %(path)s /bin/sh -c \u0027"},{"line_number":640,"context_line":"                              \u0027\"%(bin)s-install\"\u0027 %"},{"line_number":641,"context_line":"                              {\u0027path\u0027: path, \u0027bin\u0027: binary_name},"}],"source_content_type":"text/x-python","patch_set":2,"id":"b682de58_aec3bed2","line":638,"range":{"start_line":635,"start_character":2,"end_line":638,"end_character":38},"updated":"2021-06-03 04:22:25.000000000","message":"I\u0027d personally drop this, at this point. We\u0027re never going to fix it magically. the efibootmgr should address this though.","commit_id":"fdfea93b941e4d42f5f2134320b09a3ab339a47a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"95a34adb39ef3f668b3369a227a0ad5561dfe7bc","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            utils.execute(\u0027mount\u0027, efi_partition, efi_partition_mount_point)"},{"line_number":633,"context_line":"            efi_mounted \u003d True"},{"line_number":634,"context_line":"            try:"},{"line_number":635,"context_line":"                # FIXME(rg): does not work in cross boot mode case (target"},{"line_number":636,"context_line":"                # boot mode differs from ramdisk one)"},{"line_number":637,"context_line":"                # Probe for the correct target (depends on the arch, example"},{"line_number":638,"context_line":"                # --target\u003dx86_64-efi)"},{"line_number":639,"context_line":"                utils.execute(\u0027chroot %(path)s /bin/sh -c \u0027"},{"line_number":640,"context_line":"                              \u0027\"%(bin)s-install\"\u0027 %"},{"line_number":641,"context_line":"                              {\u0027path\u0027: path, \u0027bin\u0027: binary_name},"}],"source_content_type":"text/x-python","patch_set":2,"id":"aa37f08c_9db4b27e","line":638,"range":{"start_line":635,"start_character":2,"end_line":638,"end_character":38},"in_reply_to":"b682de58_aec3bed2","updated":"2021-06-03 22:00:18.000000000","message":"Done","commit_id":"fdfea93b941e4d42f5f2134320b09a3ab339a47a"}],"ironic_python_agent/tests/unit/extensions/test_image.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a58e70c59aaab582a636d78866ac7f2b05181b5d","unresolved":true,"context_lines":[{"line_number":1688,"context_line":"            cmd\u003d\u0027grub2-install\u0027"},{"line_number":1689,"context_line":"        )"},{"line_number":1690,"context_line":"        mock_execute.side_effect[9] \u003d grub_failure"},{"line_number":1691,"context_line":"        mock_execute.side_effect[10] \u003d grub_failure"},{"line_number":1692,"context_line":""},{"line_number":1693,"context_line":"        mock_get_part_uuid.side_effect \u003d [self.fake_root_part,"},{"line_number":1694,"context_line":"                                          self.fake_efi_system_part]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff766a10_2b0ee847","line":1691,"updated":"2021-06-03 22:12:24.000000000","message":"This is so much better than just rinsing/repeating :)","commit_id":"a057be7dadc898ec813b2cac14913cd8523fbbcc"}],"releasenotes/notes/ignore-grub-efi-fail-dcf7eb07f61f4388.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a58e70c59aaab582a636d78866ac7f2b05181b5d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Recent releases of redhat grub2 will always fail when installing to EFI"},{"line_number":5,"context_line":"    paths, to encourage a transition to the signed shim bootloader.  Partition"},{"line_number":6,"context_line":"    image deploys avoid calling grub2-install with the preserve-efi-assets"},{"line_number":7,"context_line":"    functions. Deploying whole disk images doesn\u0027t require grub2-install. This"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d9e56ac1_08654f11","line":4,"range":{"start_line":4,"start_character":23,"end_line":4,"end_character":29},"updated":"2021-06-03 22:12:24.000000000","message":"I\u0027m conflicted on this ;)","commit_id":"a057be7dadc898ec813b2cac14913cd8523fbbcc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a58e70c59aaab582a636d78866ac7f2b05181b5d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Recent releases of redhat grub2 will always fail when installing to EFI"},{"line_number":5,"context_line":"    paths, to encourage a transition to the signed shim bootloader.  Partition"},{"line_number":6,"context_line":"    image deploys avoid calling grub2-install with the preserve-efi-assets"},{"line_number":7,"context_line":"    functions. Deploying whole disk images doesn\u0027t require grub2-install. This"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f19e2b1c_e95b461f","line":4,"updated":"2021-06-03 22:12:24.000000000","message":"Overall, it is a bit verbose, but typically this is the kind of information those looking at IPA release notes need.","commit_id":"a057be7dadc898ec813b2cac14913cd8523fbbcc"}]}
