)]}'
{"id":"openstack%2Fironic-python-agent~794363","triplet_id":"openstack%2Fironic-python-agent~master~If432ef795d64d76442d739eb4f7d155ff847041e","project":"openstack/ironic-python-agent","branch":"master","topic":"story/2008923","hashtags":[],"change_id":"If432ef795d64d76442d739eb4f7d155ff847041e","subject":"Ignore efi grub2-install failure","status":"MERGED","created":"2021-06-03 01:52:20.000000000","updated":"2021-06-07 09:48:41.000000000","submitted":"2021-06-07 09:47:12.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":3,"has_review_started":true,"submission_id":"794363-story/2008923","meta_rev_id":"15565f02b0400190757b600bee99f3f79a36a8c0","_number":794363,"virtual_id_number":794363,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-06-07 09:47:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-06-07 07:57:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":2,"date":"2021-06-03 22:12:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-06-07 07:57:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-03 01:59:12.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2021-06-03 01:59:12.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2021-06-03 01:59:12.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2021-06-03 01:59:12.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2021-06-03 04:07:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-07 07:57:35.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"}],"messages":[{"id":"e1bd486d9ff6c99a3ed7f9f9a53fb5b081757a0c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-06-03 01:52:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"25235ed5feddd29a8488ef80e865b1954a25cec1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-06-03 01:58:18.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"3a377f0332888d82b6f21ffe9e9dbb48b10c61e6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-03 04:07:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/66d7c7904a1640cca1850d6b796151b5 : SUCCESS in 4m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6bab01556788420ebddb9988d14ad2d1 : SUCCESS in 4m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/889daf43b64444179708f19f76b661f4 : SUCCESS in 4m 55s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ca094053cceb42e1800b0af4053a1cbd : SUCCESS in 4m 39s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bc155ff80b654caaa8cb402c6ef9c989 : SUCCESS in 5m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dd97d7c7d3e94ada9520e46ca1de3b69 : SUCCESS in 6m 21s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/360f489118c94281bd0fb013e7ac8692 : SUCCESS in 4m 24s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/3602d7e04792423ba67431bd9162092a : SUCCESS in 4m 15s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/3a3f0924601647728ba9a4da08d0da3a : SUCCESS in 1h 18m 42s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/689e5ded53f24df1a4788e6cc93530c4 : SUCCESS in 1h 15m 37s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/5b4a8ef314ff480d9084907af00f83c8 : SUCCESS in 59m 42s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/262cf154657a4f3780f0dd1e20e939b1 : SUCCESS in 1h 17m 37s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/71940d971e244600987a5680c06ea373 : SUCCESS in 1h 30m 27s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/ecfa11c571644fd89e972165c28fb983 : SUCCESS in 14m 25s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/e32140c1dc074a7f87f9e4ddc76b6e0e : SUCCESS in 22m 06s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/07d6bca89d134fc9a98e998576db15c7 : SUCCESS in 2h 05m 37s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/5a4dfef032d242f5b7b15e7c6d8b9e0d : SUCCESS in 3m 44s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"acbc81b2cd0dd808281c1b09303a837d03986bd5","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-06-03 04:22:25.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI think we\u0027re going to need to add a release note, but otherwise I\u0027m +2. We can do it afterwards if we need to.","accounts_in_message":[],"_revision_number":2},{"id":"18a8937ff6e7038aa3eee24e29951e8498f1791a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-06-03 22:00:15.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"95a34adb39ef3f668b3369a227a0ad5561dfe7bc","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-06-03 22:00:18.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9870c410c391986f8080d44e891cc9190b4358d6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-06-03 22:04:14.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"a58e70c59aaab582a636d78866ac7f2b05181b5d","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-06-03 22:12:24.000000000","message":"Patch Set 4: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"ffb604095fd152b2d4873e71405bd2cc0baa387d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-03 23:36:08.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1e93162f608049f5b3266ec9841545e3 : SUCCESS in 4m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d9a036d3fdd442aeb75525e33402cd4b : SUCCESS in 4m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/045990ccde6f4d00b9601542586c6e9f : SUCCESS in 4m 55s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/2f2c85f4749b403f89299913341bdf13 : SUCCESS in 5m 24s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/794de1c569084422837c12bb9cecf05e : SUCCESS in 5m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/019213efa0ba42488342028fe0c4d38c : SUCCESS in 7m 19s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f03801343553430294e9b8f5136086a7 : SUCCESS in 4m 29s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/91dccadd951443aa9ebb212af55b2c48 : SUCCESS in 5m 03s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/ccb97669604e44eb9de156b7f88463ae : SUCCESS in 4m 55s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/b33d8984e1934b3382995837e9ed2d63 : SUCCESS in 1h 05m 02s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/3da46dccf88a4feda537c5fd2c59e1bf : SUCCESS in 1h 05m 42s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/d0f624a9980f48f582c4c365ef47fb45 : SUCCESS in 1h 03m 30s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/64a297c93c174116ab482d15b2a28b1e : SUCCESS in 1h 01m 20s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/3879d905eb064e8b886e01496156edc0 : SUCCESS in 1h 15m 53s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/23551a91d3e44d4daa0398dd5a896ce8 : SUCCESS in 15m 36s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/32d10dd1c9824b47a919f82ab5b86f21 : SUCCESS in 9m 06s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/f2bee080a00742d0afca16b79c54f601 : FAILURE in 1h 30m 47s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/bca96b691ae74b199be873514e3e2dfa : SUCCESS in 4m 15s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"1833266a248f6daadbef5743392e4a922886ea49","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-06-07 07:57:35.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"80dec076c130f8eb4a0b56919a92f9bf87ea336b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-07 07:58:52.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"7f60561b74e2bd007add6b2baba992c14a2becef","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-07 09:47:10.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7f976703344041459a74ec2e47aac1cb : SUCCESS in 4m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ca2b2cbaa18b418b82a5e3f8b47b8d13 : SUCCESS in 4m 25s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/22065511f7384a84bdbf0a9514fd7e10 : SUCCESS in 4m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f9c6f2786d0e468b885fe4e12796867b : SUCCESS in 6m 40s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/588574f230534a2ea2b0a543fd333c2e : SUCCESS in 3m 59s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/d6060f2d51e24aeeb637f9aa470dc673 : SUCCESS in 4m 48s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/5591eb90e3e04e85b319a67f768ffee0 : SUCCESS in 1h 19m 09s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/213087365aa34d8e9bb330c0b052c9f8 : SUCCESS in 1h 42m 38s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/8b879860dd1e4cb4b277da3f369f268a : SUCCESS in 1h 25m 28s","accounts_in_message":[],"_revision_number":4},{"id":"37717e8c8d7e00c53b3a640221ba62891a47b9e9","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-07 09:47:12.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"15565f02b0400190757b600bee99f3f79a36a8c0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-07 09:48:41.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/25d27d10a553436d9fa73050851f5411 : SUCCESS in 1m 06s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b53a353e195f4c6389940154fac7125c : SUCCESS in 52s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"a057be7dadc898ec813b2cac14913cd8523fbbcc","revisions":{"4e43864d6cd9643ef32d10dda52c868a9c404df9":{"kind":"REWORK","_number":1,"created":"2021-06-03 01:52:20.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/63/794363/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/63/794363/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/1"}}},"commit":{"parents":[{"commit":"5c063c8224d3d3e69a1e10f2252e2eebdcceffb1","subject":"Merge \"Make _get_efi_bootloaders return relative paths\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5c063c8224d3d3e69a1e10f2252e2eebdcceffb1"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-06-03 01:16:55.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-06-03 01:52:03.000000000","tz":720},"subject":"Ignore efi grub2-install failure","message":"Ignore efi grub2-install failure\n\nRecent releases of redhat grub2 will always fail when installing to\nEFI paths, to encourage a transition to the signed shim bootloader.\n\nPartition image deploys avoid calling grub2-install with the\npreserve-efi-assets functions. Deploying whole disk images doesn\u0027t\nrequire grub2-install. This leaves whole disk images installed onto\nsoftraid devices, which still attempts to call grub2-install.\n\nThis change will still attempt to run grub2-install in this\none remaining case, but will ignore any failure.\n\nA future enhancement can avoid calling grub2-install entirely so that\nnon-redhat secure-boot capable images can keep their signed\nbootloaders.\n\nStory: 2008070\nTask: 42557\nChange-Id: If432ef795d64d76442d739eb4f7d155ff847041e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4e43864d6cd9643ef32d10dda52c868a9c404df9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4e43864d6cd9643ef32d10dda52c868a9c404df9"}]},"branch":"refs/heads/master"},"fdfea93b941e4d42f5f2134320b09a3ab339a47a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-06-03 01:58:18.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/63/794363/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/63/794363/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/2"}}},"commit":{"parents":[{"commit":"5c063c8224d3d3e69a1e10f2252e2eebdcceffb1","subject":"Merge \"Make _get_efi_bootloaders return relative paths\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5c063c8224d3d3e69a1e10f2252e2eebdcceffb1"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-06-03 01:16:55.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-06-03 01:57:46.000000000","tz":720},"subject":"Ignore efi grub2-install failure","message":"Ignore efi grub2-install failure\n\nRecent releases of redhat grub2 will always fail when installing to\nEFI paths, to encourage a transition to the signed shim bootloader.\n\nPartition image deploys avoid calling grub2-install with the\npreserve-efi-assets functions. Deploying whole disk images doesn\u0027t\nrequire grub2-install. This leaves whole disk images installed onto\nsoftraid devices, which still attempts to call grub2-install.\n\nThis change will still attempt to run grub2-install in this\none remaining case, but will ignore any failure.\n\nA future enhancement can avoid calling grub2-install entirely so that\nnon-redhat secure-boot capable images can keep their signed\nbootloaders.\n\nStory: 2008923\nTask: 42521\nChange-Id: If432ef795d64d76442d739eb4f7d155ff847041e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fdfea93b941e4d42f5f2134320b09a3ab339a47a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fdfea93b941e4d42f5f2134320b09a3ab339a47a"}]},"branch":"refs/heads/master"},"7af46564adc2c748f4daefee3739dbc6ccbba7eb":{"kind":"REWORK","_number":3,"created":"2021-06-03 22:00:15.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/63/794363/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/63/794363/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/3"}}},"commit":{"parents":[{"commit":"5c063c8224d3d3e69a1e10f2252e2eebdcceffb1","subject":"Merge \"Make _get_efi_bootloaders return relative paths\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5c063c8224d3d3e69a1e10f2252e2eebdcceffb1"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-06-03 01:16:55.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-06-03 22:00:02.000000000","tz":720},"subject":"Ignore efi grub2-install failure","message":"Ignore efi grub2-install failure\n\nRecent releases of redhat grub2 will always fail when installing to\nEFI paths, to encourage a transition to the signed shim bootloader.\n\nPartition image deploys avoid calling grub2-install with the\npreserve-efi-assets functions. Deploying whole disk images doesn\u0027t\nrequire grub2-install. This leaves whole disk images installed onto\nsoftraid devices, which still attempts to call grub2-install.\n\nThis change will still attempt to run grub2-install in this\none remaining case, but will ignore any failure.\n\nA future enhancement can avoid calling grub2-install entirely so that\nnon-redhat secure-boot capable images can keep their signed\nbootloaders.\n\nStory: 2008923\nTask: 42521\nChange-Id: If432ef795d64d76442d739eb4f7d155ff847041e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/7af46564adc2c748f4daefee3739dbc6ccbba7eb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/7af46564adc2c748f4daefee3739dbc6ccbba7eb"}]},"branch":"refs/heads/master"},"a057be7dadc898ec813b2cac14913cd8523fbbcc":{"kind":"REWORK","_number":4,"created":"2021-06-03 22:04:14.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/63/794363/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/63/794363/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/794363/4"}}},"commit":{"parents":[{"commit":"5c063c8224d3d3e69a1e10f2252e2eebdcceffb1","subject":"Merge \"Make _get_efi_bootloaders return relative paths\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5c063c8224d3d3e69a1e10f2252e2eebdcceffb1"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-06-03 01:16:55.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-06-03 22:03:55.000000000","tz":720},"subject":"Ignore efi grub2-install failure","message":"Ignore efi grub2-install failure\n\nRecent releases of redhat grub2 will always fail when installing to\nEFI paths, to encourage a transition to the signed shim bootloader.\n\nPartition image deploys avoid calling grub2-install with the\npreserve-efi-assets functions. Deploying whole disk images doesn\u0027t\nrequire grub2-install. This leaves whole disk images installed onto\nsoftraid devices, which still attempts to call grub2-install.\n\nThis change will still attempt to run grub2-install in this\none remaining case, but will ignore any failure.\n\nA future enhancement can avoid calling grub2-install entirely so that\nnon-redhat secure-boot capable images can keep their signed\nbootloaders.\n\nStory: 2008923\nTask: 42521\nChange-Id: If432ef795d64d76442d739eb4f7d155ff847041e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a057be7dadc898ec813b2cac14913cd8523fbbcc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a057be7dadc898ec813b2cac14913cd8523fbbcc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}