)]}'
{"id":"openstack%2Fironic-python-agent~795862","triplet_id":"openstack%2Fironic-python-agent~master~Ibf1ef4fe0764c0a6f1a39cb7eebc23ecc0ee177d","project":"openstack/ironic-python-agent","branch":"master","hashtags":[],"change_id":"Ibf1ef4fe0764c0a6f1a39cb7eebc23ecc0ee177d","subject":"Utilize CSV file for EFI loader selection","status":"MERGED","created":"2021-06-10 18:27:32.000000000","updated":"2021-06-11 09:14:35.000000000","submitted":"2021-06-11 09:12:28.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"795862","meta_rev_id":"2f64b50b71308e73504a963e132a61bc88fb62a0","_number":795862,"virtual_id_number":795862,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-06-11 09:12:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"recommended":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"all":[{"value":1,"date":"2021-06-10 23:41:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},{"value":2,"date":"2021-06-10 22:28:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":2,"date":"2021-06-11 07:34:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":1,"date":"2021-06-11 07:34:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":1,"date":"2021-06-11 07:34:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"REVIEWER":[{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-10 20:04:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-10 22:28:05.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"},{"updated":"2021-06-10 23:41:57.000000000","updated_by":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"reviewer":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"state":"REVIEWER"},{"updated":"2021-06-11 07:34:59.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2021-06-11 08:50:20.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"CC"}],"messages":[{"id":"61e84fd19601cc56f862f2252dd9ce1b6bf3845c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-06-10 18:27:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3c1622dba8cc549e1e33ee98277791ef3ce06f12","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-10 20:04:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d9a1d19bf70f4f77beaf6e366a2822c5 : SUCCESS in 5m 12s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/79e4287cc33b466a869327f93f05031d : SUCCESS in 5m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/87034bd9ba004b088b11684ab9aa0ac6 : SUCCESS in 5m 32s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b7706956475e44aea70ea9c525b97ffa : SUCCESS in 7m 49s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/14cb59f164b34e86b018f22c48afc314 : SUCCESS in 5m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/46e1ddaaea974b50b6ae72974cb94600 : SUCCESS in 7m 24s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d80d06d7ccf1445a9e05bc8143d797b9 : SUCCESS in 4m 15s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/090a9b5065af4e489b2737d23b226190 : SUCCESS in 8m 04s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/7398d6fe83074ae0b9678b3df3b9d727 : SUCCESS in 5m 13s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/fa831e2f19564a7794afa3a1345e6e5d : SUCCESS in 1h 05m 34s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/03f7572a1efa479d9c7bafb279e21590 : SUCCESS in 1h 11m 52s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/58f02ac6724e4051980758bd70422de4 : SUCCESS in 1h 02m 35s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/f9233306520d431cb12d94042693551e : SUCCESS in 1h 27m 19s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/06646b82d4654bfe9a24a974d71f58c8 : SUCCESS in 1h 13m 38s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/465ed5fbfe15483189bddbe1b45d12a0 : SUCCESS in 12m 17s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/897e4935d0fc4d85af47310cd8741361 : SUCCESS in 9m 06s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/5b163e44b2774a188fba6aaef3768524 : FAILURE in 1h 35m 29s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/516fc7b84d3e40e59408520f8ff36b7c : SUCCESS in 4m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"43832415c02e0d6768b08ef32c647ab42ca29bb1","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-06-10 22:01:17.000000000","message":"Patch Set 1:\n\nhttps://f53895d70580881b785a-30f2d4bfe90ac8b488e5b54b3e170d95.ssl.cf5.rackcdn.com/795862/1/check/metalsmith-integration-ipa-src-uefi/06646b8/controller/ironic-bm-logs/node-0_no_ansi_2021-06-10-19%3A35%3A16.log:\n\n2021-06-10 19:34:32.014 770 DEBUG oslo_concurrency.processutils [-] CMD \"efibootmgr -c -d /dev/vda -p 1 -w -L CentOS Linux -l \\EFI\\centos\\shimx64.efi\" returned: 0 in 0.234s execute /usr/local/lib/python3.6/site-packages/oslo_concurrency/processutils.py:423\n2021-06-10 19:34:32.027 770 DEBUG ironic_lib.utils [-] Command stdout is: \"BootCurrent: 0001\nTimeout: 0 seconds\nBootOrder: 0004,0001,0002,0000,0003\nBoot0000* UiApp\nBoot0001* UEFI PXEv4 (MAC:5254004E84BE)\nBoot0002* UEFI HTTPv4 (MAC:5254004E84BE)\nBoot0003* EFI Internal Shell\nBoot0004* CentOS Linux","accounts_in_message":[],"_revision_number":1},{"id":"427b3c61edb02c1b0fee101c2dfdd19368bd1405","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-06-10 22:06:58.000000000","message":"Patch Set 1:\n\nAlso worked on partition image.\n\n2021-06-10 19:20:38.623 611 DEBUG oslo_concurrency.processutils [-] CMD \"efibootmgr -c -d /dev/vda -p 1 -w -L CentOS Linux -l \\EFI\\centos\\shimx64.efi\" returned: 0 in 0.204s execute /usr/local/lib/python3.6/site-packages/oslo_concurrency/processutils.py:423\n2021-06-10 19:20:38.632 611 DEBUG ironic_lib.utils [-] Command stdout is: \"BootCurrent: 0001\nTimeout: 0 seconds\nBootOrder: 0004,0001,0002,0000,0003\nBoot0000* UiApp\nBoot0001* UEFI PXEv4 (MAC:5254004E84BE)\nBoot0002* UEFI HTTPv4 (MAC:5254004E84BE)\nBoot0003* EFI Internal Shell\nBoot0004* CentOS Linux\n\nIn both cases, the machine rebooted to the appropriately labeled entry using the appropriate binary.","accounts_in_message":[],"_revision_number":1},{"id":"bfc45cce40443a0de6dc0b4e58ef46558260482a","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-06-10 22:28:05.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"aa3fae44bc59b8549a13b6d43826812adecf0dd2","author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"date":"2021-06-10 23:41:57.000000000","message":"Patch Set 1: Code-Review+1\n\npatched into a system that was exhibiting the problem and worked as expected.","accounts_in_message":[],"_revision_number":1},{"id":"b93ae4d85931151dee425a1595c9d21b7662ee7b","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-06-11 07:34:59.000000000","message":"Patch Set 1: Backport-Candidate+1 Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"5e3349202cc9d69414a573c1dafc3119044de151","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-11 07:35:19.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"59fea966aabbe9ca7612fc4697db9e5e6bd4ed74","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-06-11 08:50:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"352175a05d1550995d77b995bdfd6b995d796aa5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-11 09:12:09.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2ed7bd9f4ccc416da56473a7fcbe2f02 : SUCCESS in 6m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/da4f2a705ee9460e81146398116689f8 : SUCCESS in 6m 57s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1cd8a5e6c2554d4fb14d7391f33facbb : SUCCESS in 4m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9ec95675896b49eeb2848b19c2529cba : SUCCESS in 6m 41s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/fc41b61e06ce4772a9c1ef75d1c4210f : SUCCESS in 5m 05s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/0401a528f94d402ab905a410217b8b7b : SUCCESS in 4m 52s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/e4c64becbbcf4cb3b4a985bb2205010e : SUCCESS in 1h 25m 27s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/5906e4aaa3ef4c359f192212dc58d86b : SUCCESS in 1h 17m 51s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/9209af1ab3294cfba24db423411a0268 : SUCCESS in 1h 30m 56s","accounts_in_message":[],"_revision_number":1},{"id":"0a582c29c1be6180680d896a90eff88c99a69619","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-11 09:12:28.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"2f64b50b71308e73504a963e132a61bc88fb62a0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-11 09:14:35.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/59166da66e514a63a5d3040aa612183a : SUCCESS in 1m 00s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9babbc7ae47241fba3d837f6baa71435 : SUCCESS in 1m 03s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2fab70c36ba40a345a9dd01aeb5019681e567aa5","revisions":{"2fab70c36ba40a345a9dd01aeb5019681e567aa5":{"kind":"REWORK","_number":1,"created":"2021-06-10 18:27:32.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/62/795862/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/62/795862/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/62/795862/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/62/795862/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/62/795862/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/62/795862/1"}}},"commit":{"parents":[{"commit":"32e3b435bcfdd350b1faa06e3ff6b22fd3a04aba","subject":"Merge \"Burn-in: Add disk step\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/32e3b435bcfdd350b1faa06e3ff6b22fd3a04aba"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2021-06-10 18:23:14.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2021-06-10 18:23:14.000000000","tz":-420},"subject":"Utilize CSV file for EFI loader selection","message":"Utilize CSV file for EFI loader selection\n\nAdds support to identify and utilize a CSV file to signal which\nbootloader to utilize, and set it when the OS is running as opposed\nto when EFI is running. This works around EFI loader potentially\ncrashing some vendors hardware types when entry stored in the\nimage does not match the EFI loader record which was utilzied to\nboot.\n\nGrub2+shim specifically specifically needs the CSV file name\nand entry label to match what the system was booted with in order\nto prevent the machine from potentially crashing.\n\nSee https://storyboard.openstack.org/#!/story/2008962\nand https://bugzilla.redhat.com/show_bug.cgi?id\u003d1966129#c37\nfor more information.\n\nChange-Id: Ibf1ef4fe0764c0a6f1a39cb7eebc23ecc0ee177d\nStory: 2008962\nTask: 42598\nCo-Authored-By: Bob Fournier \u003cbfournie@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2fab70c36ba40a345a9dd01aeb5019681e567aa5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2fab70c36ba40a345a9dd01aeb5019681e567aa5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Backport-Candidate","status":"MAY","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}