)]}'
{"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7fd3fce7e9a4a292c65383b306fd2c8a40e0b013","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        if \u0027csv\u0027 in v_bl.lower():"},{"line_number":287,"context_line":"            # These files are always UTF-16 encoded, sometimes have a header."},{"line_number":288,"context_line":"            # Positive bonus is python silently drops the FEFF header."},{"line_number":289,"context_line":"            with open(mount_point + \u0027/\u0027 + v_bl, \u0027r\u0027,"},{"line_number":290,"context_line":"                      encoding\u003d\u0027utf-16\u0027) as csvfile:"},{"line_number":291,"context_line":"                # NOTE(TheJulia): Python CSV Reader only returns iterators"},{"line_number":292,"context_line":"                # which cannot be positionally accessed, so we need to"}],"source_content_type":"text/x-python","patch_set":1,"id":"f210668a_490f9fda","line":289,"updated":"2021-06-11 13:49:47.000000000","message":"I wonder if we should cover the whole logic in try..except.. to be able to produce a more usable error in case of a failure?","commit_id":"67828b8aaf4ba1958f33260cb43d867adda43ab2"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d3c08ae7f82f59a03eccfdb85b104432c81cbe43","unresolved":true,"context_lines":[{"line_number":291,"context_line":"                # NOTE(TheJulia): Python CSV Reader only returns iterators"},{"line_number":292,"context_line":"                # which cannot be positionally accessed, so we need to"},{"line_number":293,"context_line":"                # explicitly ask for the first, and only line of the csv file"},{"line_number":294,"context_line":"                contents \u003d csv.reader(csvfile, delimiter\u003d\u0027,\u0027).__next__()"},{"line_number":295,"context_line":"            csv_filename \u003d v_bl.split(\u0027/\u0027)[-1]"},{"line_number":296,"context_line":"            v_efi_bl_path \u003d v_bl.replace(csv_filename, contents[0])"},{"line_number":297,"context_line":"            v_efi_bl_path \u003d \u0027\\\\\u0027 + v_efi_bl_path.replace(\u0027/\u0027, \u0027\\\\\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"80ac57d7_b4747d21","line":294,"updated":"2021-06-11 14:40:27.000000000","message":"Please use next(csv.reader()) instead of csv.reader().__next__().","commit_id":"67828b8aaf4ba1958f33260cb43d867adda43ab2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7fd3fce7e9a4a292c65383b306fd2c8a40e0b013","unresolved":true,"context_lines":[{"line_number":292,"context_line":"                # which cannot be positionally accessed, so we need to"},{"line_number":293,"context_line":"                # explicitly ask for the first, and only line of the csv file"},{"line_number":294,"context_line":"                contents \u003d csv.reader(csvfile, delimiter\u003d\u0027,\u0027).__next__()"},{"line_number":295,"context_line":"            csv_filename \u003d v_bl.split(\u0027/\u0027)[-1]"},{"line_number":296,"context_line":"            v_efi_bl_path \u003d v_bl.replace(csv_filename, contents[0])"},{"line_number":297,"context_line":"            v_efi_bl_path \u003d \u0027\\\\\u0027 + v_efi_bl_path.replace(\u0027/\u0027, \u0027\\\\\u0027)"},{"line_number":298,"context_line":"            label \u003d contents[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"d2f819b1_61bb7faa","line":295,"updated":"2021-06-11 13:49:47.000000000","message":"nit: os.path.basename I think","commit_id":"67828b8aaf4ba1958f33260cb43d867adda43ab2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7fd3fce7e9a4a292c65383b306fd2c8a40e0b013","unresolved":true,"context_lines":[{"line_number":293,"context_line":"                # explicitly ask for the first, and only line of the csv file"},{"line_number":294,"context_line":"                contents \u003d csv.reader(csvfile, delimiter\u003d\u0027,\u0027).__next__()"},{"line_number":295,"context_line":"            csv_filename \u003d v_bl.split(\u0027/\u0027)[-1]"},{"line_number":296,"context_line":"            v_efi_bl_path \u003d v_bl.replace(csv_filename, contents[0])"},{"line_number":297,"context_line":"            v_efi_bl_path \u003d \u0027\\\\\u0027 + v_efi_bl_path.replace(\u0027/\u0027, \u0027\\\\\u0027)"},{"line_number":298,"context_line":"            label \u003d contents[1]"},{"line_number":299,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"450315d9_b63a65a6","line":296,"updated":"2021-06-11 13:49:47.000000000","message":"There should be an os.path primitive for this as well","commit_id":"67828b8aaf4ba1958f33260cb43d867adda43ab2"}]}