)]}'
{"id":"openstack%2Fironic-python-agent~796017","triplet_id":"openstack%2Fironic-python-agent~stable%2Fvictoria~Ibf1ef4fe0764c0a6f1a39cb7eebc23ecc0ee177d","project":"openstack/ironic-python-agent","branch":"stable/victoria","hashtags":[],"change_id":"Ibf1ef4fe0764c0a6f1a39cb7eebc23ecc0ee177d","subject":"Utilize CSV file for EFI loader selection","status":"MERGED","created":"2021-06-11 14:06:24.000000000","updated":"2021-06-14 00:06:30.000000000","submitted":"2021-06-14 00:04:26.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"796017","meta_rev_id":"1f6129605a0bf755338bd44039330391ed85ffb0","_number":796017,"virtual_id_number":796017,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-06-14 00:04:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-06-13 22:30:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":2,"date":"2021-06-13 22:29:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-06-13 22:30:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":1,"date":"2021-06-13 22:31:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-11 16:36:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-13 22:29:33.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2021-06-13 22:30:09.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"}],"messages":[{"id":"cfe2e31c17dc856719e8ffb852c738b97e60b195","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-06-11 14:06:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"320f3a1bd3e905eeaa62867078f1669df2360bfe","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-11 16:36:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6d00b04a308846ad91d8fe020ed48c8d : SUCCESS in 5m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/eefad7584fe14442afa0c3ee3afbeff0 : SUCCESS in 5m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a2aa1721fdc54667a3b897f8fd5120c5 : SUCCESS in 5m 45s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4adc7d15c0aa4f43a8911d98bd67b2ec : SUCCESS in 5m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/05baa5f90c034e4aacb4193ab5f376d3 : SUCCESS in 7m 04s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/760f7c240bad47ec931beb91d0b6ea91 : SUCCESS in 4m 51s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/93877be95b4546d09ebdb82d40e4abe1 : SUCCESS in 5m 58s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/139fb6eaa8cf40cc8da0b024ffe1afbc : SUCCESS in 5m 26s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/6ff076b16099402ab855139f80ff514f : SUCCESS in 1h 43m 54s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/34f1f8dab1e64181acd3c2fba029ab69 : SUCCESS in 1h 14m 45s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/27e696d81a5c49a7a5ca836ed1eb41b5 : SUCCESS in 1h 28m 09s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/093859f9226a46c2a26f1e2a223ade18 : SUCCESS in 1h 33m 12s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/8102b553033342b98283a632321c932e : SUCCESS in 19m 31s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/9cce7b4fd6b54f5d9e82b4b1df5ebd80 : SUCCESS in 9m 50s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/8bb1c49edd6740d8bddef67862bc4397 : SUCCESS in 2h 21m 57s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/bda286028f4f4acea3dfcf4ba5b67ae5 : SUCCESS in 5m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ac2ac2acd04e9b6282b8b56244db204183812c5c","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2021-06-13 22:29:33.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"bf76a41241b71723788872cf1ea572193d5eb4f8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-13 22:29:52.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"fbd67e136d897abc75a6dd1f236aaf0ff2fa792a","tag":"autogenerated:gerrit:deleteVote","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2021-06-13 22:30:00.000000000","message":"Removed Workflow+1 by Jay Faulkner \u003cjay@jvf.cc\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"5f2c540860506b61554a0e200a74e05617ab320c","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-06-13 22:30:09.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"03927f5a9b26a88dab98f8a492ecc13828351e1f","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2021-06-13 22:30:20.000000000","message":"Patch Set 1:\n\nWhoops, I thought this already had another +2","accounts_in_message":[],"_revision_number":1},{"id":"7c3d013e1d37e5d545059d22d7a1addec9080d92","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-06-13 22:30:41.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"efe424f565cc2c417dd9f7aa69c9b2275c585d15","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2021-06-13 22:31:03.000000000","message":"Patch Set 1: Workflow+1\n\nWhoa, was that some kind of race?","accounts_in_message":[],"_revision_number":1},{"id":"db9b9899d89bfb3a23f5d5b163216c82e73a7fdc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-14 00:04:26.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/25a86e6ef7984a20b9105387272ad59a : SUCCESS in 3m 52s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/21d7539eb3c643898af87f0d4384187b : SUCCESS in 4m 45s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e0d0092e2a264e918fd5af525bf54cbe : SUCCESS in 4m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/97a53f9d7fa846c2bda802b6a8dd8944 : SUCCESS in 7m 17s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8bd09d81eb7e405d9a829d5b1539c271 : SUCCESS in 3m 31s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/f1da50e3f01b44d89fbfc7f7d5027184 : SUCCESS in 4m 47s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/641c8d943deb46b48f2bb617df44c3c0 : SUCCESS in 1h 09m 31s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/2fa7f47ab9254a27a6d649062dbee652 : SUCCESS in 1h 10m 12s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/ff47c6eadc6b42a9aabb34ebaf9f63c5 : SUCCESS in 1h 23m 15s","accounts_in_message":[],"_revision_number":1},{"id":"1f2db335283988985cfd0cf75f0cf284b087dc53","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-14 00:04:26.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"1f6129605a0bf755338bd44039330391ed85ffb0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-14 00:06:30.000000000","message":"Patch Set 1:\n\nBuild failed (promote pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2678b34a61274c0d8219dc88f7207fa1 : SUCCESS in 50s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/759099a96afa43eebc73dc89aa05ffb0 : FAILURE in 49s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"474d2a91b06942a72c59d0f25ddd65fc255a3d16","revisions":{"474d2a91b06942a72c59d0f25ddd65fc255a3d16":{"kind":"REWORK","_number":1,"created":"2021-06-11 14:06:24.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/17/796017/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/17/796017/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/17/796017/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/17/796017/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/17/796017/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/17/796017/1"}}},"commit":{"parents":[{"commit":"350a67e203f678d66e3ea1b8acc436394fc42f1a","subject":"Make _get_efi_bootloaders return relative paths","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/350a67e203f678d66e3ea1b8acc436394fc42f1a"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2021-06-10 18:23:14.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2021-06-11 14:05:40.000000000","tz":-420},"subject":"Utilize CSV file for EFI loader selection","message":"Utilize CSV file for EFI loader selection\n\nAdds support to identify and utilize a CSV file to signal which\nbootloader to utilize, and set it when the OS is running as opposed\nto when EFI is running. This works around EFI loader potentially\ncrashing some vendors hardware types when entry stored in the\nimage does not match the EFI loader record which was utilzied to\nboot.\n\nGrub2+shim specifically specifically needs the CSV file name\nand entry label to match what the system was booted with in order\nto prevent the machine from potentially crashing.\n\nSee https://storyboard.openstack.org/#!/story/2008962\nand https://bugzilla.redhat.com/show_bug.cgi?id\u003d1966129#c37\nfor more information.\n\nChange-Id: Ibf1ef4fe0764c0a6f1a39cb7eebc23ecc0ee177d\nStory: 2008962\nTask: 42598\nCo-Authored-By: Bob Fournier \u003cbfournie@redhat.com\u003e\n(cherry picked from commit 2fab70c36ba40a345a9dd01aeb5019681e567aa5)\n(cherry picked from commit bfa97cbbc2040d56bd0db14d1e1b83bb14f1a74c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/474d2a91b06942a72c59d0f25ddd65fc255a3d16"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/474d2a91b06942a72c59d0f25ddd65fc255a3d16"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}