)]}'
{"id":"openstack%2Fironic-python-agent~796031","triplet_id":"openstack%2Fironic-python-agent~stable%2Ftrain~Ibf1ef4fe0764c0a6f1a39cb7eebc23ecc0ee177d","project":"openstack/ironic-python-agent","branch":"stable/train","hashtags":[],"change_id":"Ibf1ef4fe0764c0a6f1a39cb7eebc23ecc0ee177d","subject":"Utilize CSV file for EFI loader selection","status":"MERGED","created":"2021-06-11 14:53:42.000000000","updated":"2021-06-14 00:07:26.000000000","submitted":"2021-06-14 00:05:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"796031","meta_rev_id":"28a6926b29ba9670ddf5f8bbc3a2d0e717e1dc68","_number":796031,"virtual_id_number":796031,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-06-14 00:05:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":2,"date":"2021-06-13 22:32:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":2,"date":"2021-06-13 22:27:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":1,"date":"2021-06-13 22:32:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-11 17:17:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-13 22:27:38.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"},{"updated":"2021-06-13 22:32:07.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"}],"messages":[{"id":"8be0b2471d2c5b5c5e2e229f7985012d88563e11","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2021-06-11 14:53:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ba05d983f03738579d72925ff2456d826cd3bb7e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-11 17:17:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/620017691bda45d7be451de360d6cc3c : SUCCESS in 4m 37s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1c0a8d53158149778375220c07bc271f : SUCCESS in 5m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/13c8f3d5f1bd4702b44b2217e7488eea : SUCCESS in 5m 47s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/8f558a40913d4887be10d5c8783516fa : SUCCESS in 5m 44s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4bbef11a1cea4ab491e9e64666e86ef6 : SUCCESS in 5m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/65c0007324554bf2962063fdc713d6fb : SUCCESS in 7m 18s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5a8f89055631482fbbafcf71da44470c : SUCCESS in 3m 49s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/a42942f93c55494fbc27c139977fbb1a : SUCCESS in 1h 08m 59s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/5efb622f828342ec820296637aeb9093 : SUCCESS in 1h 04m 52s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/47951604475e49cd800da17a5047e681 : SUCCESS in 1h 09m 50s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/44858709370e4c5283db5425fbe089ae : SUCCESS in 1h 06m 56s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/e1ff84083e9948fe8ca0a74a12d89302 : SUCCESS in 1h 32m 44s\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/c28f3de7914042609e8a8b7bb7c1fcda : SUCCESS in 1h 52m 30s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/6eeedfe78c534b67941a99dd1b94bb82 : RETRY_LIMIT in 36m 39s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/58be585eed4c4bc4ba040cc02ceffea7 : FAILURE in 43m 40s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/c4a89dd3ba384ed48a9e78020aaf4066 : SUCCESS in 4m 40s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/3ecd241b9a8d4cc7bcdc1cf6ab85128d : SUCCESS in 5m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a959788011356cbda594872968354da1b0d8dcba","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-06-13 22:27:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8e01d3f30cee38d43781088c0d6692d0c8bf1717","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2021-06-13 22:32:07.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"498e8d4acf9a9feb36fdf2bf3a927667f1c64286","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-13 22:32:27.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"59fc6f51c4f0a3414beab08432aeb6dbf614b0fd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-14 00:05:16.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ee1c6369fe264bd59d358e6db9d80912 : SUCCESS in 5m 18s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7aea3c08093d40afb52d10d71e98c95a : SUCCESS in 5m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b15f5cdf1fe941d4aa2ecdc6f51b482c : SUCCESS in 6m 23s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/77c8fb270777438bb1dc1f4d9f36f16f : SUCCESS in 5m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8759d8bb94764909831da76994c52dd2 : SUCCESS in 9m 07s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/04263f5df9514d4cb38ed74d620b37b4 : SUCCESS in 5m 01s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/376db6888a994d8486020443660b0b87 : SUCCESS in 52m 25s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/335d85195ac14449a00b0ee1667f4dd0 : SUCCESS in 48m 38s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/d06e8783fe2a4f8b8f5b97a32a175527 : SUCCESS in 54m 08s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/c7543fe1bab8405eb59df4d261c7748a : SUCCESS in 50m 46s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/094e527057874152a72a452d4e24a531 : SUCCESS in 1h 03m 12s","accounts_in_message":[],"_revision_number":1},{"id":"e3ae6268abde5f6ff015a5434531a4acdc2657cd","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-14 00:05:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"28a6926b29ba9670ddf5f8bbc3a2d0e717e1dc68","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-14 00:07:26.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/699cbd963e3f493691e81a1512769a6f : SUCCESS in 52s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ee2370852c1e40e6b653fde4c41a8d20 : SUCCESS in 46s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b6f02de4b62b087b9555c040f971c4e20f8d0242","revisions":{"b6f02de4b62b087b9555c040f971c4e20f8d0242":{"kind":"REWORK","_number":1,"created":"2021-06-11 14:53:42.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/31/796031/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/31/796031/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/31/796031/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/31/796031/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/31/796031/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/31/796031/1"}}},"commit":{"parents":[{"commit":"413dc5f5009979b4c4fdedf36c258dbf2971eb7e","subject":"Make _get_efi_bootloaders return relative paths","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/413dc5f5009979b4c4fdedf36c258dbf2971eb7e"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2021-06-10 18:23:14.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2021-06-11 14:53:20.000000000","tz":-420},"subject":"Utilize CSV file for EFI loader selection","message":"Utilize CSV file for EFI loader selection\n\nAdds support to identify and utilize a CSV file to signal which\nbootloader to utilize, and set it when the OS is running as opposed\nto when EFI is running. This works around EFI loader potentially\ncrashing some vendors hardware types when entry stored in the\nimage does not match the EFI loader record which was utilzied to\nboot.\n\nGrub2+shim specifically specifically needs the CSV file name\nand entry label to match what the system was booted with in order\nto prevent the machine from potentially crashing.\n\nSee https://storyboard.openstack.org/#!/story/2008962\nand https://bugzilla.redhat.com/show_bug.cgi?id\u003d1966129#c37\nfor more information.\n\nBackport note: This change does include minor changes for python2\ncompatability, mainly the different pattern to mock a file open\noperation.\n\nChange-Id: Ibf1ef4fe0764c0a6f1a39cb7eebc23ecc0ee177d\nStory: 2008962\nTask: 42598\nCo-Authored-By: Bob Fournier \u003cbfournie@redhat.com\u003e\n(cherry picked from commit 2fab70c36ba40a345a9dd01aeb5019681e567aa5)\n(cherry picked from commit bfa97cbbc2040d56bd0db14d1e1b83bb14f1a74c)\n(cherry picked from commit 474d2a91b06942a72c59d0f25ddd65fc255a3d16)\n(cherry picked from commit 8287b96628afc38a8667b7a38e16d2a715011a36)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b6f02de4b62b087b9555c040f971c4e20f8d0242"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b6f02de4b62b087b9555c040f971c4e20f8d0242"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}
