)]}'
{"ironic_python_agent/burnin.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1ca3e5b25a9bcacc142b3bf342cc382bf36e15ff","unresolved":true,"context_lines":[{"line_number":134,"context_line":"    args.extend(xargs)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    while True:"},{"line_number":137,"context_line":"        LOG.info(\u0027Burn-in fio network command: %s\u0027, \u0027 \u0027.join(map(str, args)))"},{"line_number":138,"context_line":"        try:"},{"line_number":139,"context_line":"            out, err \u003d utils.execute(*args)"},{"line_number":140,"context_line":"            # fio reports on stdout"}],"source_content_type":"text/x-python","patch_set":2,"id":"e3844083_8cdce79e","line":137,"range":{"start_line":137,"start_character":12,"end_line":137,"end_character":16},"updated":"2021-07-13 09:29:55.000000000","message":"debug ?","commit_id":"58754404d5521a820215f531882e0989b81214c5"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5ff7137537544966d54a68453b7b2966a5eb1100","unresolved":true,"context_lines":[{"line_number":134,"context_line":"    args.extend(xargs)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    while True:"},{"line_number":137,"context_line":"        LOG.info(\u0027Burn-in fio network command: %s\u0027, \u0027 \u0027.join(map(str, args)))"},{"line_number":138,"context_line":"        try:"},{"line_number":139,"context_line":"            out, err \u003d utils.execute(*args)"},{"line_number":140,"context_line":"            # fio reports on stdout"}],"source_content_type":"text/x-python","patch_set":2,"id":"1c83fc55_1e875235","line":137,"range":{"start_line":137,"start_character":12,"end_line":137,"end_character":16},"in_reply_to":"e3844083_8cdce79e","updated":"2021-07-13 09:44:45.000000000","message":"While I agree this message is probably only used when sth is wrong, i.e. for debugging, the only purpose of this step is to do the network burn-in and this will print what the node will be doing. The exact parameters used may also be important in order to understand the results displayed by fio.\n\nFurthermore, I would like to avoid I need to move the IPA to debug mode in case sth very simple is wrong with the config.","commit_id":"58754404d5521a820215f531882e0989b81214c5"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1ca3e5b25a9bcacc142b3bf342cc382bf36e15ff","unresolved":true,"context_lines":[{"line_number":148,"context_line":"            # \u0027Connection {refused, timeout}\u0027 errors if the partner"},{"line_number":149,"context_line":"            # is not ready, so we need to wait explicitly"},{"line_number":150,"context_line":"            if not writer and \u0027Connection\u0027 in str(e):"},{"line_number":151,"context_line":"                LOG.info(\"fio (network): reader retrying in %s seconds ...\","},{"line_number":152,"context_line":"                         NETWORK_READER_CYCLE)"},{"line_number":153,"context_line":"                time.sleep(NETWORK_READER_CYCLE)"},{"line_number":154,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b4c2611_4156a017","line":151,"range":{"start_line":151,"start_character":20,"end_line":151,"end_character":24},"updated":"2021-07-13 09:29:55.000000000","message":"debug ? or even warning in this case maybe","commit_id":"58754404d5521a820215f531882e0989b81214c5"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5ff7137537544966d54a68453b7b2966a5eb1100","unresolved":true,"context_lines":[{"line_number":148,"context_line":"            # \u0027Connection {refused, timeout}\u0027 errors if the partner"},{"line_number":149,"context_line":"            # is not ready, so we need to wait explicitly"},{"line_number":150,"context_line":"            if not writer and \u0027Connection\u0027 in str(e):"},{"line_number":151,"context_line":"                LOG.info(\"fio (network): reader retrying in %s seconds ...\","},{"line_number":152,"context_line":"                         NETWORK_READER_CYCLE)"},{"line_number":153,"context_line":"                time.sleep(NETWORK_READER_CYCLE)"},{"line_number":154,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"41c5ee9d_9eed87e7","line":151,"range":{"start_line":151,"start_character":20,"end_line":151,"end_character":24},"in_reply_to":"9b4c2611_4156a017","updated":"2021-07-13 09:44:45.000000000","message":"This is a \"normal\" condition: the reader waits for the writer to appear, and from an operations point of view it would be nice if I can see this when I log into the node right away (rather than re-building the image with debug mode on).","commit_id":"58754404d5521a820215f531882e0989b81214c5"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1ca3e5b25a9bcacc142b3bf342cc382bf36e15ff","unresolved":true,"context_lines":[{"line_number":182,"context_line":"        error_msg \u003d (\"fio (network) failed to find \""},{"line_number":183,"context_line":"                     \"\u0027agent_burnin_fio_network_config\u0027 in driver_info\")"},{"line_number":184,"context_line":"        raise errors.CleaningError(error_msg)"},{"line_number":185,"context_line":"    LOG.info(\"agent_burnin_fio_network_config is %s\", str(config))"},{"line_number":186,"context_line":"    role \u003d config.get(\u0027role\u0027)"},{"line_number":187,"context_line":"    partner \u003d config.get(\u0027partner\u0027)"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fe67818_61df2584","line":185,"range":{"start_line":185,"start_character":8,"end_line":185,"end_character":12},"updated":"2021-07-13 09:29:55.000000000","message":"I would put debug here too","commit_id":"58754404d5521a820215f531882e0989b81214c5"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5ff7137537544966d54a68453b7b2966a5eb1100","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        error_msg \u003d (\"fio (network) failed to find \""},{"line_number":183,"context_line":"                     \"\u0027agent_burnin_fio_network_config\u0027 in driver_info\")"},{"line_number":184,"context_line":"        raise errors.CleaningError(error_msg)"},{"line_number":185,"context_line":"    LOG.info(\"agent_burnin_fio_network_config is %s\", str(config))"},{"line_number":186,"context_line":"    role \u003d config.get(\u0027role\u0027)"},{"line_number":187,"context_line":"    partner \u003d config.get(\u0027partner\u0027)"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"16cde160_f22f1e06","line":185,"range":{"start_line":185,"start_character":8,"end_line":185,"end_character":12},"in_reply_to":"9fe67818_61df2584","updated":"2021-07-13 09:44:45.000000000","message":"Ack","commit_id":"58754404d5521a820215f531882e0989b81214c5"}]}