)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"994c751d2e7b3832e0a52be3e8587bf6092de35e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3259b288_03e7fd28","updated":"2021-10-19 09:25:30.000000000","message":"recheck","commit_id":"e68630fe01a0c5fa855728ef0671dcd5b7fd0db5"}],"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abb3399d357009f2fdc874b77aebea19d7761b71","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                    return True"},{"line_number":195,"context_line":"        except IndexError:"},{"line_number":196,"context_line":"            continue"},{"line_number":197,"context_line":"        LOG.warning(\u0027Did not find bootable device for bios mode boot \u0027"},{"line_number":198,"context_line":"                    \u0027operations.\u0027)"},{"line_number":199,"context_line":"    return False"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"567634cc_588f8ba2","line":197,"updated":"2021-10-19 09:58:07.000000000","message":"This will be logged for each line, I assume you wanted it in the end?","commit_id":"e68630fe01a0c5fa855728ef0671dcd5b7fd0db5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abb3399d357009f2fdc874b77aebea19d7761b71","unresolved":false,"context_lines":[{"line_number":592,"context_line":"    efi_preserved \u003d False"},{"line_number":593,"context_line":"    holders \u003d None"},{"line_number":594,"context_line":"    path_variable \u003d _get_path_variable()"},{"line_number":595,"context_line":"    boot \u003d hardware.dispatch_to_managers(\u0027get_boot_info\u0027)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    # NOTE(TheJulia): Seems we need to get this before ever possibly"},{"line_number":598,"context_line":"    # restart the device in the case of multi-device RAID as pyudev"}],"source_content_type":"text/x-python","patch_set":2,"id":"00948b04_9f0ba971","line":595,"updated":"2021-10-19 09:58:07.000000000","message":"nit: we can probably pass it from the caller. or just use target_boot_mode that is already passed?","commit_id":"e68630fe01a0c5fa855728ef0671dcd5b7fd0db5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abb3399d357009f2fdc874b77aebea19d7761b71","unresolved":false,"context_lines":[{"line_number":723,"context_line":"                                  \u0027PATH\u0027: path_variable"},{"line_number":724,"context_line":"                              })"},{"line_number":725,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":726,"context_line":"                if boot.current_boot_mode \u003d\u003d \"uefi\":"},{"line_number":727,"context_line":"                    LOG.warning(\u0027Ignoring GRUB2 boot loader installation \u0027"},{"line_number":728,"context_line":"                                \u0027failure: %s.\u0027, e)"},{"line_number":729,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"47e649bf_a6661362","line":726,"updated":"2021-10-19 09:58:07.000000000","message":"Arguably, using target_boot_mode is more reasonable since we don\u0027t to end up in situation where a node accidentally boots into UEFI if the target boot mode is BIOS.","commit_id":"e68630fe01a0c5fa855728ef0671dcd5b7fd0db5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abb3399d357009f2fdc874b77aebea19d7761b71","unresolved":false,"context_lines":[{"line_number":724,"context_line":"                              })"},{"line_number":725,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":726,"context_line":"                if boot.current_boot_mode \u003d\u003d \"uefi\":"},{"line_number":727,"context_line":"                    LOG.warning(\u0027Ignoring GRUB2 boot loader installation \u0027"},{"line_number":728,"context_line":"                                \u0027failure: %s.\u0027, e)"},{"line_number":729,"context_line":"                else:"},{"line_number":730,"context_line":"                    msg \u003d (\u0027System is not in UEFI mode, and bootloader \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7fdd2c83_e55dcb76","line":727,"updated":"2021-10-19 09:58:07.000000000","message":"I\u0027d even make it debug since grub is not supposed to work on UEFI?","commit_id":"e68630fe01a0c5fa855728ef0671dcd5b7fd0db5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abb3399d357009f2fdc874b77aebea19d7761b71","unresolved":false,"context_lines":[{"line_number":729,"context_line":"                else:"},{"line_number":730,"context_line":"                    msg \u003d (\u0027System is not in UEFI mode, and bootloader \u0027"},{"line_number":731,"context_line":"                           \u0027installation failed. Error: %s\u0027 % e)"},{"line_number":732,"context_line":"                    LOG.error(msg)"},{"line_number":733,"context_line":"                    raise errors.CommandExecutionError(msg)"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"            utils.execute(\u0027umount\u0027, efi_partition_mount_point, attempts\u003d3,"}],"source_content_type":"text/x-python","patch_set":2,"id":"b4a3c9bb_87955af9","line":732,"updated":"2021-10-19 09:58:07.000000000","message":"Not needed, the command itself logs all exceptions","commit_id":"e68630fe01a0c5fa855728ef0671dcd5b7fd0db5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abb3399d357009f2fdc874b77aebea19d7761b71","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"            scenario the bootloader will be installed here."},{"line_number":1086,"context_line":"        :param target_boot_mode: bios, uefi. Only taken into account"},{"line_number":1087,"context_line":"            for softraid, when no efi partition is explicitely provided"},{"line_number":1088,"context_line":"            (happens for whole disk images)"},{"line_number":1089,"context_line":"        :raises: CommandExecutionError if the installation of the"},{"line_number":1090,"context_line":"                 bootloader fails."},{"line_number":1091,"context_line":"        :raises: DeviceNotFound if the root partition is not found."}],"source_content_type":"text/x-python","patch_set":2,"id":"32e8fb0e_ba762396","line":1088,"updated":"2021-10-19 09:58:07.000000000","message":"This should like be changed and use for error detection","commit_id":"e68630fe01a0c5fa855728ef0671dcd5b7fd0db5"}],"releasenotes/notes/capture-bios-mode-failures-with-grub-7310fbaf65d0efc6.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abb3399d357009f2fdc874b77aebea19d7761b71","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    Except with the grub errors being ignored, we wouldn\u0027t give actual"},{"line_number":14,"context_line":"    feedback to the user that there is a problem. The base OS is likely"},{"line_number":15,"context_line":"    unbootable as there was no loaded bootloader header detected for BIOS"},{"line_number":16,"context_line":"    mode to properly work. Now we will check the boot mode the system is"},{"line_number":17,"context_line":"    running in, and raise an exception as appropriate when this case is"},{"line_number":18,"context_line":"    encountered."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b2016707_105c8b6b","line":16,"updated":"2021-10-19 09:58:07.000000000","message":"I think several things are mixed here.. You\u0027re looking at the current boot mode, not target boot mode, so we don\u0027t know if the intended boot is BIOS or not..\n\n.. maybe we should fail if the current boot mode !\u003d target_boot_mode.","commit_id":"e68630fe01a0c5fa855728ef0671dcd5b7fd0db5"}]}