)]}'
{"id":"openstack%2Fironic-python-agent~812108","triplet_id":"openstack%2Fironic-python-agent~master~I1f804cb8aca008a0359027a766954581987dc1b3","project":"openstack/ironic-python-agent","branch":"master","topic":"useless-else","hashtags":[],"change_id":"I1f804cb8aca008a0359027a766954581987dc1b3","subject":"Remove else/elif when not needed","status":"ABANDONED","created":"2021-10-01 08:32:33.000000000","updated":"2022-03-14 15:25:49.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e731df88694b1def699fc40e89446e276bbad6b0","_number":812108,"virtual_id_number":812108,"owner":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-10-06 13:14:23.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-01 10:22:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-10-04 13:57:13.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"}],"messages":[{"id":"5fa54f4d042d447af5d31041df2d70fbd185253d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-10-01 08:32:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d79929bc501b77c20b8b3a3dd2ba49c3d4bc17d0","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-10-01 08:33:51.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"712ddbbc22e6b2dc6a9ceb5101f8dc2523f4e592","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-10-01 08:36:46.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"33875b24a27291c66b1030826d20fb43405cb490","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-01 10:22:17.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/45574f9f38de44119a02baa27f8606cb : SUCCESS in 5m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/eeb3ef1416e84465b8ac6102d69da6f5 : SUCCESS in 6m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/77db43c3ef7d4676bf43d2354482285f : SUCCESS in 4m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b4275d30760f41ca9496a020d64fab8d : SUCCESS in 4m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d858b8898a434c1cb20869cc54ab0d29 : SUCCESS in 5m 00s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7c79eb4d62114f1caff04fc95f80599d : SUCCESS in 5m 00s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/415e4d3bbd224fe290e8ca96da86cc30 : SUCCESS in 6m 19s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/c7c2a83b18e14e20a48c61406315261f : SUCCESS in 4m 19s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/8e79afcb815848fdbdff380172bea624 : SUCCESS in 4m 30s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/614f33662f7343c7a12b16f274c8ba4d : SUCCESS in 1h 23m 00s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/2322aa896b174dbab6a82f30ff19bbc8 : SUCCESS in 1h 16m 41s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/6f9253306f93429985e5459d91b6cd8d : SUCCESS in 1h 09m 39s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/ad8e9dd2e6264784a7706082cd3efaeb : SUCCESS in 1h 22m 42s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/f48ed554d9b3478695e9f19e5efb1464 : SUCCESS in 1h 32m 35s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/68fdc2bd47d248759104adf056eda7e5 : SUCCESS in 14m 55s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/a2cdd7eab416423d9290d0d482c9187f : SUCCESS in 12m 02s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/8827c82bc83740faa57975969407aa84 : FAILURE in 1h 43m 25s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/49f6d1f99f244b8b84457386d47b426f : SUCCESS in 4m 10s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"a030063ba5891d59122f5fc6e410cca1beba3d04","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-10-04 13:57:13.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nA matter of taste, I guess? I think I see one place where it becomes problematic for following the code.","accounts_in_message":[],"_revision_number":2},{"id":"e2f3261c0f61763b1e9053b534029da7667dc945","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-10-06 10:44:53.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"754872d6e282ddda2d04cec7239d0b97d39e3347","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-06 13:14:23.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cefbd93eb8b84201a64d708ba8d2e8ab : SUCCESS in 5m 17s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b5d25678661b4c5fa84e811ca40284e3 : SUCCESS in 8m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/410d2dc919884e3a84d8193025d07893 : SUCCESS in 5m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2df7ca8778714af991c833278b26078b : SUCCESS in 5m 48s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6f69e0a534314e549e3189bcc391e562 : SUCCESS in 5m 11s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ec463cbe54e7451aaef1aed9b92e3022 : SUCCESS in 5m 42s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bac1d400350c495c85e35f2beb50e4d7 : SUCCESS in 6m 54s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/0f165d8eafd54e339e066b1bc40c6fd8 : SUCCESS in 4m 48s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/be03fbdc0df54692afbcc63edda62ac9 : SUCCESS in 4m 52s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/700aa5d15710418e88e5064570f14c3e : SUCCESS in 1h 19m 29s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/0764f90db6b64479b76e439544119366 : SUCCESS in 1h 19m 37s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/dd66bb12bff94315a790aaf5a13e17d5 : SUCCESS in 57m 31s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/c7ad4934567e411daa1cdfed79c292f3 : SUCCESS in 1h 11m 06s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/45199b54c35244bda936a656290138c5 : SUCCESS in 1h 26m 44s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/507c7d95f57d44adb93a2629f2cdd791 : SUCCESS in 16m 21s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/4fc262116b4e4183ba21ab3afcccb8e6 : SUCCESS in 20m 35s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/785a8b22f0ba435da1a69f6400d42c20 : SUCCESS in 2h 22m 32s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/1b7332df351b45f59712f1a48ba75b87 : SUCCESS in 4m 30s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"e731df88694b1def699fc40e89446e276bbad6b0","tag":"autogenerated:gerrit:abandon","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2022-03-14 15:25:49.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"39315c40ee9b81b3fb0079af818125188f07f00e","revisions":{"3938e6e2cb0ef45681479534a1900a44f38cafda":{"kind":"REWORK","_number":1,"created":"2021-10-01 08:32:33.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/08/812108/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/08/812108/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/812108/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/812108/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/812108/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/812108/1"}}},"commit":{"parents":[{"commit":"8d901ff0dca45fb94a3ae079fee66626747285c0","subject":"Add Python3 yoga unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8d901ff0dca45fb94a3ae079fee66626747285c0"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2021-10-01 08:31:52.000000000","tz":120},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2021-10-01 08:31:52.000000000","tz":120},"subject":"Remove else/elif when not needed","message":"Remove else/elif when not needed\n\nThe else/elif statements are not needed if the preceding if ends\nwith return.\n\nChange-Id: I1f804cb8aca008a0359027a766954581987dc1b3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3938e6e2cb0ef45681479534a1900a44f38cafda"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3938e6e2cb0ef45681479534a1900a44f38cafda"}]},"branch":"refs/heads/master"},"eea212042f86d2f274373cdbcf32a0e26a70d950":{"kind":"REWORK","_number":2,"created":"2021-10-01 08:36:46.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/08/812108/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/08/812108/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/812108/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/812108/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/812108/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/812108/2"}}},"commit":{"parents":[{"commit":"8d901ff0dca45fb94a3ae079fee66626747285c0","subject":"Add Python3 yoga unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8d901ff0dca45fb94a3ae079fee66626747285c0"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2021-10-01 08:31:52.000000000","tz":120},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2021-10-01 08:36:29.000000000","tz":120},"subject":"Remove else/elif when not needed","message":"Remove else/elif when not needed\n\nThe else/elif statements are not needed if the preceding if ends\nwith return or raise.\n\nChange-Id: I1f804cb8aca008a0359027a766954581987dc1b3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/eea212042f86d2f274373cdbcf32a0e26a70d950"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/eea212042f86d2f274373cdbcf32a0e26a70d950"}]},"branch":"refs/heads/master"},"39315c40ee9b81b3fb0079af818125188f07f00e":{"kind":"REWORK","_number":3,"created":"2021-10-06 10:44:53.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/08/812108/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/08/812108/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/812108/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/812108/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/812108/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/812108/3"}}},"commit":{"parents":[{"commit":"8d901ff0dca45fb94a3ae079fee66626747285c0","subject":"Add Python3 yoga unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8d901ff0dca45fb94a3ae079fee66626747285c0"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2021-10-01 08:31:52.000000000","tz":120},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2021-10-06 10:42:43.000000000","tz":120},"subject":"Remove else/elif when not needed","message":"Remove else/elif when not needed\n\nThe else/elif statements are not strictly needed if the preceding if ends\nwith return or raise.\n\nAlso create set_md_device helper function for uefi boot mode case in\nsoftraid workflow.\n\nChange-Id: I1f804cb8aca008a0359027a766954581987dc1b3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/39315c40ee9b81b3fb0079af818125188f07f00e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/39315c40ee9b81b3fb0079af818125188f07f00e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}