)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4cf8fc07469b242da6bcfccd8a2150bad438e0b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f0f4e92_08428429","updated":"2021-11-09 09:50:33.000000000","message":"Thank you Riccardo.","commit_id":"a32c0e270de98c77a7de4ef7b2a3ee12bf1aa3fd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8878a98c66d783648caaa274d2ed3cd05ccb4bf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c0069806_99126068","updated":"2021-11-09 09:50:42.000000000","message":"recheck","commit_id":"a32c0e270de98c77a7de4ef7b2a3ee12bf1aa3fd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"033787219b3c9a332203737abf663b7058379482","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d8bd0839_d7f5154b","updated":"2021-11-13 05:55:07.000000000","message":"Thank you Riccardo","commit_id":"a799dcc42288491549be72b43940815dfc684db8"}],"ironic_python_agent/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e6f366878a132ce287f98e0fcc436de235f8a9a","unresolved":false,"context_lines":[{"line_number":928,"context_line":"    :param device: device upon which to rescan and update"},{"line_number":929,"context_line":"                   kernel partition records."},{"line_number":930,"context_line":"    :param check_partx_exit_code: check the exit code of the partx command"},{"line_number":931,"context_line":"                                  and raise an exception if it fails"},{"line_number":932,"context_line":"    \"\"\""},{"line_number":933,"context_line":"    try:"},{"line_number":934,"context_line":"        execute(\u0027partx\u0027, \u0027-a\u0027, device, attempts\u003d3, delay_on_retry\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":5,"id":"d063e2a2_4a155f8f","line":931,"updated":"2021-11-10 08:10:51.000000000","message":"This does not actually happen, we swallow all errors in the try..except block","commit_id":"98cddfce6ef834be40c24a0b594bea6d86454132"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"0a5bd93e714f5984fe4de70a5ff1075119ae33b0","unresolved":false,"context_lines":[{"line_number":928,"context_line":"    :param device: device upon which to rescan and update"},{"line_number":929,"context_line":"                   kernel partition records."},{"line_number":930,"context_line":"    :param check_partx_exit_code: check the exit code of the partx command"},{"line_number":931,"context_line":"                                  and raise an exception if it fails"},{"line_number":932,"context_line":"    \"\"\""},{"line_number":933,"context_line":"    try:"},{"line_number":934,"context_line":"        execute(\u0027partx\u0027, \u0027-a\u0027, device, attempts\u003d3, delay_on_retry\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":5,"id":"6f64a3f9_bf8cf732","line":931,"in_reply_to":"d063e2a2_4a155f8f","updated":"2021-11-10 08:23:52.000000000","message":"whoops, forgot to change it back....","commit_id":"98cddfce6ef834be40c24a0b594bea6d86454132"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"830df60bf3568cd025f306e6a022cf7bd8a7a00b","unresolved":false,"context_lines":[{"line_number":928,"context_line":"    :param device: device upon which to rescan and update"},{"line_number":929,"context_line":"                   kernel partition records."},{"line_number":930,"context_line":"    :param check_partx_exit_code: boolean value to check or not the exit code"},{"line_number":931,"context_line":"                                  of the partx command. Default to True."},{"line_number":932,"context_line":"    \"\"\""},{"line_number":933,"context_line":"    try:"},{"line_number":934,"context_line":"        execute(\u0027partx\u0027, \u0027-a\u0027, device, attempts\u003d3, delay_on_retry\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"2567188b_0232b84c","line":931,"updated":"2021-11-10 08:55:38.000000000","message":"Why is it useful at all? It seems like its only purpose it to prvent udevadm from happening. Maybe just split the two try..except blocks and drop the option?","commit_id":"50e309baddb603fda7978bdcbfdd703333b76f58"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5f355dd468da188c79222beb62bf0fc2b02a20b6","unresolved":false,"context_lines":[{"line_number":928,"context_line":"    :param device: device upon which to rescan and update"},{"line_number":929,"context_line":"                   kernel partition records."},{"line_number":930,"context_line":"    :param check_partx_exit_code: boolean value to check or not the exit code"},{"line_number":931,"context_line":"                                  of the partx command. Default to True."},{"line_number":932,"context_line":"    \"\"\""},{"line_number":933,"context_line":"    try:"},{"line_number":934,"context_line":"        execute(\u0027partx\u0027, \u0027-a\u0027, device, attempts\u003d3, delay_on_retry\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"69fe50df_1b2c4d13","line":931,"in_reply_to":"2567188b_0232b84c","updated":"2021-11-10 10:10:53.000000000","message":"this is to respect the original behavior which is different in image.py (where it\u0027s set to True) and in hardware.py (where it\u0027s set to False)","commit_id":"50e309baddb603fda7978bdcbfdd703333b76f58"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"da85834b2d91f064c079dea5391878bf9efc9d0b","unresolved":false,"context_lines":[{"line_number":928,"context_line":"    :param device: device upon which to rescan and update"},{"line_number":929,"context_line":"                   kernel partition records."},{"line_number":930,"context_line":"    :param check_partx_exit_code: boolean value to check or not the exit code"},{"line_number":931,"context_line":"                                  of the partx command. Default to True."},{"line_number":932,"context_line":"    \"\"\""},{"line_number":933,"context_line":"    try:"},{"line_number":934,"context_line":"        execute(\u0027partx\u0027, \u0027-a\u0027, device, attempts\u003d3, delay_on_retry\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"8b94c7db_d99937b1","line":931,"in_reply_to":"69fe50df_1b2c4d13","updated":"2021-11-10 10:50:21.000000000","message":"Yeah, but why? What\u0027s the point of sometimes skipping udev settle? Won\u0027t it just cause more subtle issues?","commit_id":"50e309baddb603fda7978bdcbfdd703333b76f58"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1608bdb52b920ebfe511745bf2d7acaf13b0ca40","unresolved":false,"context_lines":[{"line_number":928,"context_line":"    :param device: device upon which to rescan and update"},{"line_number":929,"context_line":"                   kernel partition records."},{"line_number":930,"context_line":"    :param check_partx_exit_code: boolean value to check or not the exit code"},{"line_number":931,"context_line":"                                  of the partx command. Default to True."},{"line_number":932,"context_line":"    \"\"\""},{"line_number":933,"context_line":"    try:"},{"line_number":934,"context_line":"        execute(\u0027partx\u0027, \u0027-a\u0027, device, attempts\u003d3, delay_on_retry\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"f34e4752_aa028af7","line":931,"in_reply_to":"8b94c7db_d99937b1","updated":"2021-11-10 13:30:00.000000000","message":"I think I see your point\nI\u0027ll work on your suggestion","commit_id":"50e309baddb603fda7978bdcbfdd703333b76f58"}]}