)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8c971d8206444897b6aae29a94391e2e3c3c4f69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"61ecdd99_d7150a7a","updated":"2021-11-08 16:10:55.000000000","message":"As a FYI, the original code/fix (https://review.opendev.org/c/openstack/ironic-python-agent/+/706667) was backported to stein. I don\u0027t think we want to backport this patch that far?","commit_id":"dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"08b9b4c6acb04e8e4085334f1ccf708c2bc3fb45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b2d9dc82_309a4165","updated":"2021-11-08 16:40:12.000000000","message":"I think backporting up to wallaby should be fine, maybe up to train if really needed","commit_id":"dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e9d600420687796c05a5e74915966d5a22f6d5d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"49cd6c10_6ad784e2","updated":"2021-11-08 16:09:47.000000000","message":"Thanks for fixing!","commit_id":"dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"61fcabe96f9406a0909147ffa0f0ed6378efaf34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b8b82248_99e1359c","updated":"2021-11-08 16:42:50.000000000","message":"Thanks, Ruby!","commit_id":"dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b71758337b5d1e87fb13cb1b4d62b96a5433186a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b2662073_fc91565d","updated":"2021-11-08 14:36:04.000000000","message":"recheck","commit_id":"dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"61fcabe96f9406a0909147ffa0f0ed6378efaf34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38e56b39_df521294","in_reply_to":"61ecdd99_d7150a7a","updated":"2021-11-08 16:42:50.000000000","message":"Once merged, I will propose it for Xena and Wallaby at least.","commit_id":"dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0"}],"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e9d600420687796c05a5e74915966d5a22f6d5d1","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                   kernel partition records."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    try:"},{"line_number":65,"context_line":"        utils.execute(\u0027partx\u0027, \u0027-a\u0027, device, attempts\u003d3,"},{"line_number":66,"context_line":"                      delay_on_retry\u003dTrue)"},{"line_number":67,"context_line":"        utils.execute(\u0027udevadm\u0027, \u0027settle\u0027)"},{"line_number":68,"context_line":"    except processutils.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fe463923_b6c424ae","line":65,"updated":"2021-11-08 16:09:47.000000000","message":"it isn\u0027t clear to me what -u does vs -a (but -a seems to do more?). I wondered what doing both \u0027-u -a\u0027 would do but anyway, this looks. Maybe -u only updates the partitions the kernel already knows about?","commit_id":"dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"0c0882b20bc26782c30db922f6d7545336343883","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                   kernel partition records."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    try:"},{"line_number":65,"context_line":"        utils.execute(\u0027partx\u0027, \u0027-a\u0027, device, attempts\u003d3,"},{"line_number":66,"context_line":"                      delay_on_retry\u003dTrue)"},{"line_number":67,"context_line":"        utils.execute(\u0027udevadm\u0027, \u0027settle\u0027)"},{"line_number":68,"context_line":"    except processutils.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2d4fe90a_338f7a3c","line":65,"in_reply_to":"fe463923_b6c424ae","updated":"2021-11-08 16:43:25.000000000","message":"-u and -a are mutually exclusive\n-u updates the partitions currently present and known to the kernel, -a takes into consideration also the new partitions so it works better in this case","commit_id":"dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"61fcabe96f9406a0909147ffa0f0ed6378efaf34","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                   kernel partition records."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    try:"},{"line_number":65,"context_line":"        utils.execute(\u0027partx\u0027, \u0027-a\u0027, device, attempts\u003d3,"},{"line_number":66,"context_line":"                      delay_on_retry\u003dTrue)"},{"line_number":67,"context_line":"        utils.execute(\u0027udevadm\u0027, \u0027settle\u0027)"},{"line_number":68,"context_line":"    except processutils.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c9353991_de1fbe91","line":65,"in_reply_to":"fe463923_b6c424ae","updated":"2021-11-08 16:42:50.000000000","message":"I think that is it, yes: -a takes a device, -u takes a partition (but does not complain when you give it a device either!). From my testing, though, -a makes new partitions appear, while -u does not (always).","commit_id":"dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0"}]}