)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5b4e6a4e1e334d8170890ff9b36f2e2bb9055be4","unresolved":true,"context_lines":[{"line_number":11,"context_line":"the SMART test on any of the disk fails."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Story: #2007523"},{"line_number":14,"context_line":"Issue: #43383"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I1312d5b71bedd044581a136af0b4c43769d21877"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"75d2f84f_0f3c8054","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":5},"updated":"2021-11-30 08:28:27.000000000","message":"Task","commit_id":"9bf2c7ef6059fab27ad2d40b1b6bdde3192e5b42"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"38082d9b0040d1f055addf39d60fb4ede9030b79","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the SMART test on any of the disk fails."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Story: #2007523"},{"line_number":14,"context_line":"Issue: #43383"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I1312d5b71bedd044581a136af0b4c43769d21877"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"de3814ea_70f900ad","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":5},"in_reply_to":"75d2f84f_0f3c8054","updated":"2021-12-01 09:19:44.000000000","message":"Done","commit_id":"9bf2c7ef6059fab27ad2d40b1b6bdde3192e5b42"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5b4e6a4e1e334d8170890ff9b36f2e2bb9055be4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4bf5c6f8_cc1c410c","updated":"2021-11-30 08:28:27.000000000","message":"thanks Arne, a couple of comments inline","commit_id":"9bf2c7ef6059fab27ad2d40b1b6bdde3192e5b42"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"38082d9b0040d1f055addf39d60fb4ede9030b79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"88f34df7_9332ec8b","updated":"2021-12-01 09:19:44.000000000","message":"Thanks for the review, Riccardo! New patch set uploaded.","commit_id":"24a4435e1088e8d6c20c81e2915e2b0773c1d7a7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4a523d95f091259b7323c01d9cba0f8c056d7804","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1d02ef20_e7ff8fef","updated":"2021-12-03 06:23:54.000000000","message":"Thank you Arne.","commit_id":"74b08c8fb614ef8219376c9b716c5194b0396684"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"97d1e8e81d43f1e1ad2762cf3cd9f2fc0af31960","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b78e64a7_a9c1313d","updated":"2021-12-01 13:14:03.000000000","message":"thanks","commit_id":"74b08c8fb614ef8219376c9b716c5194b0396684"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"59e8929ed38b4fcfafb51b6ceab210a60b529a61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8bada29b_41e06161","updated":"2021-12-09 07:58:33.000000000","message":"Thank you Arne.","commit_id":"c6b1cb1c325d37374eaffb1517e8c6c388e7f807"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"1fd71f11327b539fde6c83f04fb07701875b532c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"af730b60_4f9acb0f","updated":"2021-12-06 08:14:01.000000000","message":"Thanks for the review, Shivanand!","commit_id":"c6b1cb1c325d37374eaffb1517e8c6c388e7f807"}],"ironic_python_agent/burnin.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5b4e6a4e1e334d8170890ff9b36f2e2bb9055be4","unresolved":true,"context_lines":[{"line_number":144,"context_line":"    # step if any of the devices reports an error"},{"line_number":145,"context_line":"    smart_test \u003d info.get(\u0027agent_burnin_fio_disk_smart_test\u0027, False)"},{"line_number":146,"context_line":"    if smart_test:"},{"line_number":147,"context_line":"        try:"},{"line_number":148,"context_line":"            for device in devices:"},{"line_number":149,"context_line":"                args \u003d [\u0027smartctl\u0027, \u0027-t\u0027, \u0027long\u0027, device.name]"},{"line_number":150,"context_line":"                LOG.info(\u0027SMART self test command: %s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0a2ad5e4_749907ed","line":147,"updated":"2021-11-30 08:28:27.000000000","message":"this can probably go in a separate function","commit_id":"9bf2c7ef6059fab27ad2d40b1b6bdde3192e5b42"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"38082d9b0040d1f055addf39d60fb4ede9030b79","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    # step if any of the devices reports an error"},{"line_number":145,"context_line":"    smart_test \u003d info.get(\u0027agent_burnin_fio_disk_smart_test\u0027, False)"},{"line_number":146,"context_line":"    if smart_test:"},{"line_number":147,"context_line":"        try:"},{"line_number":148,"context_line":"            for device in devices:"},{"line_number":149,"context_line":"                args \u003d [\u0027smartctl\u0027, \u0027-t\u0027, \u0027long\u0027, device.name]"},{"line_number":150,"context_line":"                LOG.info(\u0027SMART self test command: %s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7324b8c_99496891","line":147,"in_reply_to":"0a2ad5e4_749907ed","updated":"2021-12-01 09:19:44.000000000","message":"Done","commit_id":"9bf2c7ef6059fab27ad2d40b1b6bdde3192e5b42"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5b4e6a4e1e334d8170890ff9b36f2e2bb9055be4","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            if not devices:"},{"line_number":179,"context_line":"                break"},{"line_number":180,"context_line":"            LOG.debug(\"SMART tests still running ...\")"},{"line_number":181,"context_line":"            time.sleep(30)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        # fail the clean step if the SMART test has failed"},{"line_number":184,"context_line":"        if failed_devices:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dd4b42a6_7609c6ee","line":181,"updated":"2021-11-30 08:28:27.000000000","message":"should we add a time limit?","commit_id":"9bf2c7ef6059fab27ad2d40b1b6bdde3192e5b42"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"38082d9b0040d1f055addf39d60fb4ede9030b79","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            if not devices:"},{"line_number":179,"context_line":"                break"},{"line_number":180,"context_line":"            LOG.debug(\"SMART tests still running ...\")"},{"line_number":181,"context_line":"            time.sleep(30)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        # fail the clean step if the SMART test has failed"},{"line_number":184,"context_line":"        if failed_devices:"}],"source_content_type":"text/x-python","patch_set":1,"id":"59eb8ed9_a2f53ae9","line":181,"in_reply_to":"dd4b42a6_7609c6ee","updated":"2021-12-01 09:19:44.000000000","message":"Checking with my hardware colleagues, I do not think this is necessary: they never observed a smart test running forever.","commit_id":"9bf2c7ef6059fab27ad2d40b1b6bdde3192e5b42"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4a523d95f091259b7323c01d9cba0f8c056d7804","unresolved":true,"context_lines":[{"line_number":101,"context_line":"            return smart_info[\u0027ata_smart_data\u0027]["},{"line_number":102,"context_line":"                \u0027self_test\u0027][\u0027status\u0027][\u0027string\u0027]"},{"line_number":103,"context_line":"    except (processutils.ProcessExecutionError, OSError, KeyError) as e:"},{"line_number":104,"context_line":"        LOG.error(\u0027Checking SMART test on %(device)s failed with \u0027"},{"line_number":105,"context_line":"                  \u0027%(err)s\u0027, {\u0027device\u0027: device.name, \u0027err\u0027: e})"},{"line_number":106,"context_line":"    return None"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f60b04f9_a953e8d8","line":104,"range":{"start_line":104,"start_character":19,"end_line":104,"end_character":27},"updated":"2021-12-03 06:23:54.000000000","message":"s/ Checking //","commit_id":"74b08c8fb614ef8219376c9b716c5194b0396684"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"1fd71f11327b539fde6c83f04fb07701875b532c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            return smart_info[\u0027ata_smart_data\u0027]["},{"line_number":102,"context_line":"                \u0027self_test\u0027][\u0027status\u0027][\u0027string\u0027]"},{"line_number":103,"context_line":"    except (processutils.ProcessExecutionError, OSError, KeyError) as e:"},{"line_number":104,"context_line":"        LOG.error(\u0027Checking SMART test on %(device)s failed with \u0027"},{"line_number":105,"context_line":"                  \u0027%(err)s\u0027, {\u0027device\u0027: device.name, \u0027err\u0027: e})"},{"line_number":106,"context_line":"    return None"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"39707f9f_17df3c66","line":104,"range":{"start_line":104,"start_character":19,"end_line":104,"end_character":27},"in_reply_to":"f60b04f9_a953e8d8","updated":"2021-12-06 08:14:01.000000000","message":"Done","commit_id":"74b08c8fb614ef8219376c9b716c5194b0396684"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4a523d95f091259b7323c01d9cba0f8c056d7804","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            args \u003d [\u0027smartctl\u0027, \u0027-t\u0027, \u0027long\u0027, device.name]"},{"line_number":119,"context_line":"            LOG.info(\u0027SMART self test command: %s\u0027,"},{"line_number":120,"context_line":"                     \u0027 \u0027.join(map(str, args)))"},{"line_number":121,"context_line":"            utils.execute(*args)"},{"line_number":122,"context_line":"    except (processutils.ProcessExecutionError, OSError) as e:"},{"line_number":123,"context_line":"        LOG.error(\"Starting SMART test on %(device)s failed with: \""},{"line_number":124,"context_line":"                  \"%(err)s\", {\u0027device\u0027: device.name, \u0027err\u0027: e})"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    # wait for the test to finish and report the test results"},{"line_number":127,"context_line":"    failed_devices \u003d []"},{"line_number":128,"context_line":"    while True:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fce5ee52_cf74c92c","line":125,"range":{"start_line":121,"start_character":12,"end_line":125,"end_character":0},"updated":"2021-12-03 06:23:54.000000000","message":"Wont it be better to attempt on all devices, instead of breaking from loop when first error is encountered?","commit_id":"74b08c8fb614ef8219376c9b716c5194b0396684"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"1fd71f11327b539fde6c83f04fb07701875b532c","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            args \u003d [\u0027smartctl\u0027, \u0027-t\u0027, \u0027long\u0027, device.name]"},{"line_number":119,"context_line":"            LOG.info(\u0027SMART self test command: %s\u0027,"},{"line_number":120,"context_line":"                     \u0027 \u0027.join(map(str, args)))"},{"line_number":121,"context_line":"            utils.execute(*args)"},{"line_number":122,"context_line":"    except (processutils.ProcessExecutionError, OSError) as e:"},{"line_number":123,"context_line":"        LOG.error(\"Starting SMART test on %(device)s failed with: \""},{"line_number":124,"context_line":"                  \"%(err)s\", {\u0027device\u0027: device.name, \u0027err\u0027: e})"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    # wait for the test to finish and report the test results"},{"line_number":127,"context_line":"    failed_devices \u003d []"},{"line_number":128,"context_line":"    while True:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ae3521f_4dffdf9e","line":125,"range":{"start_line":121,"start_character":12,"end_line":125,"end_character":0},"in_reply_to":"fce5ee52_cf74c92c","updated":"2021-12-06 08:14:01.000000000","message":"Yes, thanks! I uploaded a revised patch.","commit_id":"74b08c8fb614ef8219376c9b716c5194b0396684"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"59e8929ed38b4fcfafb51b6ceab210a60b529a61","unresolved":true,"context_lines":[{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            utils.execute(*args)"},{"line_number":123,"context_line":"        except (processutils.ProcessExecutionError, OSError) as e:"},{"line_number":124,"context_line":"            LOG.error(\"Starting SMART test on %(device)s failed with: \""},{"line_number":125,"context_line":"                      \"%(err)s\", {\u0027device\u0027: device.name, \u0027err\u0027: e})"},{"line_number":126,"context_line":"            failed_devices.append(device.name)"},{"line_number":127,"context_line":"    if failed_devices:"},{"line_number":128,"context_line":"        error_msg \u003d (\"fio (disk) failed to start SMART self test on %s\","}],"source_content_type":"text/x-python","patch_set":5,"id":"36000a6f_8760abc2","line":125,"range":{"start_line":124,"start_character":12,"end_line":125,"end_character":67},"updated":"2021-12-09 07:58:33.000000000","message":"May be this can be removed. Its duplicate of the message at L128","commit_id":"c6b1cb1c325d37374eaffb1517e8c6c388e7f807"}]}