)]}'
{"id":"openstack%2Fironic-python-agent~83604","triplet_id":"openstack%2Fironic-python-agent~master~I39752fb3f42ad3e4f15a49194f1554e1d3463cf8","project":"openstack/ironic-python-agent","branch":"master","topic":"bug/1297019","hashtags":[],"change_id":"I39752fb3f42ad3e4f15a49194f1554e1d3463cf8","subject":"Adding DynamicLoopingCall around lookup","status":"MERGED","created":"2014-03-27 22:19:07.000000000","updated":"2014-03-31 22:18:27.000000000","submitted":"2014-03-31 22:18:27.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":13,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a5fe23cea87369b4cce369eb2e0e81ed78dfdb64","_number":83604,"virtual_id_number":83604,"owner":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":10626,"name":"Russell Haering","email":"russellhaering@gmail.com","username":"russell_h"},{"value":2,"date":"2014-03-31 22:18:27.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10626,"name":"Russell Haering","email":"russellhaering@gmail.com","username":"russell_h"},"all":[{"value":2,"date":"2014-03-31 22:16:50.000000000","_account_id":10626,"name":"Russell Haering","email":"russellhaering@gmail.com","username":"russell_h"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-03-31 21:58:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10626,"name":"Russell Haering","email":"russellhaering@gmail.com","username":"russell_h"},"all":[{"value":1,"date":"2014-03-31 22:16:50.000000000","_account_id":10626,"name":"Russell Haering","email":"russellhaering@gmail.com","username":"russell_h"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-03-31 21:58:00.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10626,"name":"Russell Haering","email":"russellhaering@gmail.com","username":"russell_h"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"_account_id":10626,"name":"Russell Haering","email":"russellhaering@gmail.com","username":"russell_h"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-03-28 13:24:49.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2014-03-31 21:58:00.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2014-03-31 22:16:50.000000000","updated_by":{"_account_id":10626,"name":"Russell Haering","email":"russellhaering@gmail.com","username":"russell_h"},"reviewer":{"_account_id":10626,"name":"Russell Haering","email":"russellhaering@gmail.com","username":"russell_h"},"state":"REVIEWER"},{"updated":"2014-03-31 22:18:27.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e1256526f2f43ea965f14df4eb0f9b01df258069","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-27 22:19:08.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"25666284beae0a4eed853bcc11bda38794c031ea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-27 22:36:54.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/04/83604/1/check/gate-ironic-python-agent-pep8/11b4090 : FAILURE in 1m 19s\n- gate-ironic-python-agent-python26 http://logs.openstack.org/04/83604/1/check/gate-ironic-python-agent-python26/4d9decb : SUCCESS in 1m 25s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/04/83604/1/check/gate-ironic-python-agent-python27/d6a6c5f : SUCCESS in 1m 32s\n\n","accounts_in_message":[],"_revision_number":1},{"id":"9814bc34b5b2d3910f9ee8b508caefca579253cd","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2014-03-27 22:45:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3128605d44ebcd93b9bfa425c3b4a0a527ee541b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-27 22:45:18.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"15b5a1101969d51e22f0a4b2092c46dd03be513c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-27 23:09:34.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/04/83604/2/check/gate-ironic-python-agent-pep8/2906338 : SUCCESS in 1m 20s\n- gate-ironic-python-agent-python26 http://logs.openstack.org/04/83604/2/check/gate-ironic-python-agent-python26/ae7b11f : SUCCESS in 1m 25s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/04/83604/2/check/gate-ironic-python-agent-python27/9633e12 : SUCCESS in 56s\n\n","accounts_in_message":[],"_revision_number":2},{"id":"02af470f0315cde3b52c52c8ef36a8064bd87f7c","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2014-03-28 01:01:05.000000000","message":"Patch Set 2:\n\nWith the openstack/common/loopingcall.py, I believe there\u0027s a proper procedure for syncing (https://wiki.openstack.org/wiki/Oslo#Syncing_Code_from_Incubator ? ). It looks like you might have followed it here, but making sure. I\u0027d love to see how you did it.","accounts_in_message":[],"_revision_number":2},{"id":"481acb0014037094e8d5a58e3cd52c82aaffb055","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2014-03-28 01:05:09.000000000","message":"Patch Set 2:\n\nYup that\u0027s how I did it. Add the relevant bits to openstack-common.conf, clone Oslo in the dev directory, and then run \"python update.py ../ironic-python-agent\", and it syncs them.","accounts_in_message":[],"_revision_number":2},{"id":"73e8dbfbbcde6e4f07dc4eb92ed86e0bdb6a6ee1","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2014-03-28 01:07:48.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\nA nit and a couple of questions about what appear to be hardcoded defaults.","accounts_in_message":[],"_revision_number":2},{"id":"b34ce8ce756d2ca9148290c46cab40c10ce858b6","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2014-03-28 01:34:02.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4566f02813f0d9cff3f1763a0ff2b79c52f571da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-28 01:34:03.000000000","message":"Patch Set 3:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"3a61b45aa511aec064572ff9a5ebb665d2b3011a","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2014-03-28 01:34:40.000000000","message":"Patch Set 3:\n\nAdded config options and fixed a long running test.","accounts_in_message":[],"_revision_number":3},{"id":"35af5b976c1622e8eaef4f6fed4a19e88e61f48e","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2014-03-28 01:37:14.000000000","message":"Patch Set 3: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"c923827a7c99ee736189341438b5c237d3503085","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-28 01:43:59.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/04/83604/3/check/gate-ironic-python-agent-pep8/071f585 : SUCCESS in 57s\n- gate-ironic-python-agent-python26 http://logs.openstack.org/04/83604/3/check/gate-ironic-python-agent-python26/89ef6b0 : SUCCESS in 1m 05s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/04/83604/3/check/gate-ironic-python-agent-python27/96d3f8a : SUCCESS in 1m 07s\n\n","accounts_in_message":[],"_revision_number":3},{"id":"f8b1968f8af6651ff9efc0bf0d45f18176606e35","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2014-03-28 13:24:49.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(7 inline comments)\n\nComments inline.","accounts_in_message":[],"_revision_number":3},{"id":"723c4e6f7d225784fa391ef0349c726adbfea5dd","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2014-03-28 16:42:27.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"b02dcd41da32a60e512e426782822827d1c33ae6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-28 18:03:57.000000000","message":"Patch Set 4:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"ddc2d7a98dce086dae5692f2e5e9e0f7b04c8dca","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2014-03-28 18:03:57.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"566d5e6d3afe6c97943dd8eccc95ed7be6dd2db8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-28 18:08:22.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/04/83604/4/check/gate-ironic-python-agent-pep8/49b6e1b : SUCCESS in 1m 25s\n- gate-ironic-python-agent-python26 http://logs.openstack.org/04/83604/4/check/gate-ironic-python-agent-python26/df17a74 : SUCCESS in 52s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/04/83604/4/check/gate-ironic-python-agent-python27/0aa2c98 : SUCCESS in 55s\n\n","accounts_in_message":[],"_revision_number":4},{"id":"527ec7733eb09a675c5c63519bc2e10966f48985","author":{"_account_id":10626,"name":"Russell Haering","email":"russellhaering@gmail.com","username":"russell_h"},"date":"2014-03-29 07:11:25.000000000","message":"Patch Set 4: Do not merge\n\n(1 inline comment)\n\nOne minor thing on the command line help.\n\nIn the future we should add jitter to the retry, but lets do that in a separate change. It might be worth adding generic backoff+jitter code.","accounts_in_message":[],"_revision_number":4},{"id":"35bb5db3d9519fac2b75f92fb0fd30781c84bad1","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2014-03-31 18:01:03.000000000","message":"Patch Set 4:\n\nI think this would be useful for the current heartbeat as well. For the jitter, why does the heartbeat use a backoff factor of 2.7 + jitter between .4 and .6? It seems simpler to do something like \"double the previous base timeout, multiply by jitter between .6 and .8 (or even .5 and 1.0)\"?\n\nThere\u0027s at least 3 places in Ironic using similar code now (not counting heartbeat), so I think I\u0027ll factor this out and put it a more general form in oslo as \"ExponentialBackoffLoopingCall\" or something, with optional timeouts and configurable backoff.","accounts_in_message":[],"_revision_number":4},{"id":"cff03bc6ac087c34dacfb92449979ec9cd731caa","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2014-03-31 18:04:40.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"29aa13d2530e3ccfe848adf470474b40c424bc41","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-31 18:04:41.000000000","message":"Patch Set 5:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"e887bdb912ac0f64f64e4974f16f1b690ce5c374","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-31 18:09:06.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/04/83604/5/check/gate-ironic-python-agent-pep8/555bca8 : SUCCESS in 1m 05s\n- gate-ironic-python-agent-python26 http://logs.openstack.org/04/83604/5/check/gate-ironic-python-agent-python26/448ef82 : SUCCESS in 50s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/04/83604/5/check/gate-ironic-python-agent-python27/78863cd : SUCCESS in 1m 07s\n- gate-ironic-python-agent-pypy http://logs.openstack.org/04/83604/5/check/gate-ironic-python-agent-pypy/888b75d : SUCCESS in 1m 38s (non-voting)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"91a63ea60f84fd37f225a274eb84c9b66152d046","author":{"_account_id":10626,"name":"Russell Haering","email":"russellhaering@gmail.com","username":"russell_h"},"date":"2014-03-31 20:15:39.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"99b293ddbbe1b7dcc7c5b74d39b2cda7bffb2852","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2014-03-31 21:38:06.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"8695317f2b1857dce305eb99a4ed5f3963536209","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-31 21:38:07.000000000","message":"Patch Set 6:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"00ef6e17d966b6fb69e1448b974b930dddf46acd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-31 21:39:45.000000000","message":"Patch Set 6: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/04/83604/6/check/gate-ironic-python-agent-pep8/0a9747d : FAILURE in 40s\n- gate-ironic-python-agent-python26 http://logs.openstack.org/04/83604/6/check/gate-ironic-python-agent-python26/a373d62 : SUCCESS in 33s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/04/83604/6/check/gate-ironic-python-agent-python27/ed226cf : SUCCESS in 51s\n- gate-ironic-python-agent-pypy http://logs.openstack.org/04/83604/6/check/gate-ironic-python-agent-pypy/bf000ad : SUCCESS in 1m 37s (non-voting)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"3747a83bece755523d1b8def49619de886fcebde","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-31 21:54:22.000000000","message":"Patch Set 7:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"419c92dc9e8c7362f79a1cbd3d4ff5a3e1519a3e","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2014-03-31 21:54:22.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"78a63c0b03f2b9f1b455e0ccf3bae6f37cfa1317","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2014-03-31 21:54:27.000000000","message":"Patch Set 7:\n\nNew patchset patch-id matches previous patchset, but whitespace content has changed.","accounts_in_message":[],"_revision_number":7},{"id":"9d5a0d3d5738881ee67c62846432654f718d7a0e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-31 21:55:50.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/04/83604/7/check/gate-ironic-python-agent-pep8/7adb86a : SUCCESS in 57s\n- gate-ironic-python-agent-python26 http://logs.openstack.org/04/83604/7/check/gate-ironic-python-agent-python26/87eeabe : SUCCESS in 49s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/04/83604/7/check/gate-ironic-python-agent-python27/1acfbf1 : SUCCESS in 52s\n- gate-ironic-python-agent-pypy http://logs.openstack.org/04/83604/7/check/gate-ironic-python-agent-pypy/5b9ab34 : SUCCESS in 1m 27s (non-voting)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"4d56f8ea16fb88e9be7fa13c3adcdfb8ab202d1e","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2014-03-31 21:58:00.000000000","message":"Patch Set 7: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"56c08ee3f5facf3ad3d6430c011a43e5887022fc","author":{"_account_id":10626,"name":"Russell Haering","email":"russellhaering@gmail.com","username":"russell_h"},"date":"2014-03-31 22:16:50.000000000","message":"Patch Set 7: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":7},{"id":"a623345a041a18c2b88b1a613ef4f21d66471b60","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-31 22:16:51.000000000","message":"Patch Set 7: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"aae5126610d5128cb0525ec4fd409183fddc5740","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-31 22:18:27.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":7},{"id":"111346e727910425702d994254bf0e4c30b3a123","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-31 22:18:27.000000000","message":"Patch Set 7: Verified\n\nBuild succeeded.\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/04/83604/7/gate/gate-ironic-python-agent-pep8/f7add75 : SUCCESS in 46s\n- gate-ironic-python-agent-python26 http://logs.openstack.org/04/83604/7/gate/gate-ironic-python-agent-python26/71418d9 : SUCCESS in 50s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/04/83604/7/gate/gate-ironic-python-agent-python27/ee95397 : SUCCESS in 50s\n- gate-ironic-python-agent-pypy http://logs.openstack.org/04/83604/7/gate/gate-ironic-python-agent-pypy/2a42453 : SUCCESS in 1m 35s (non-voting)\n\n","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"3bc4866a21b5fe255a808fb1742e40c3a5bee7b1","revisions":{"d5b5d2ab9e2da8f7610aed32be544b9a8ea78105":{"kind":"REWORK","_number":1,"created":"2014-03-27 22:19:07.000000000","uploader":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"ref":"refs/changes/04/83604/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/04/83604/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/1"}}},"commit":{"parents":[{"commit":"6329ae46dba20cb194462ece583b2ed639c9e0c5","subject":"Fix URL for node lookup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6329ae46dba20cb194462ece583b2ed639c9e0c5"}]}],"author":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-26 17:57:25.000000000","tz":-420},"committer":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-27 22:17:49.000000000","tz":-420},"subject":"Adding DynamicLoopingCall around lookup","message":"Adding DynamicLoopingCall around lookup\n\nCurrently, if a single lookup call to the Ironic API fails, the entire\nagent errors out and restarts. This allows the agent to retry for a set\namount of time before throwing an uncaught exception forcing a restart.\n\nChange-Id: I39752fb3f42ad3e4f15a49194f1554e1d3463cf8\nCloses-Bug: 1297019\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d5b5d2ab9e2da8f7610aed32be544b9a8ea78105"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d5b5d2ab9e2da8f7610aed32be544b9a8ea78105"}]},"branch":"refs/heads/master"},"57b5f4b5625705462c3fe4a368c9d4b8d8fc46ac":{"kind":"REWORK","_number":2,"created":"2014-03-27 22:45:16.000000000","uploader":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"ref":"refs/changes/04/83604/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/04/83604/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/2"}}},"commit":{"parents":[{"commit":"6329ae46dba20cb194462ece583b2ed639c9e0c5","subject":"Fix URL for node lookup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6329ae46dba20cb194462ece583b2ed639c9e0c5"}]}],"author":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-26 17:57:25.000000000","tz":-420},"committer":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-27 22:45:07.000000000","tz":-420},"subject":"Adding DynamicLoopingCall around lookup","message":"Adding DynamicLoopingCall around lookup\n\nCurrently, if a single lookup call to the Ironic API fails, the entire\nagent errors out and restarts. This allows the agent to retry for a set\namount of time before throwing an uncaught exception forcing a restart.\n\nChange-Id: I39752fb3f42ad3e4f15a49194f1554e1d3463cf8\nCloses-Bug: 1297019\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/57b5f4b5625705462c3fe4a368c9d4b8d8fc46ac"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/57b5f4b5625705462c3fe4a368c9d4b8d8fc46ac"}]},"branch":"refs/heads/master"},"c2f9ce4639aa72df4439c9a05371eb9796347abd":{"kind":"REWORK","_number":3,"created":"2014-03-28 01:34:02.000000000","uploader":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"ref":"refs/changes/04/83604/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/04/83604/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/3"}}},"commit":{"parents":[{"commit":"6329ae46dba20cb194462ece583b2ed639c9e0c5","subject":"Fix URL for node lookup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6329ae46dba20cb194462ece583b2ed639c9e0c5"}]}],"author":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-26 17:57:25.000000000","tz":-420},"committer":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-28 01:33:57.000000000","tz":-420},"subject":"Adding DynamicLoopingCall around lookup","message":"Adding DynamicLoopingCall around lookup\n\nCurrently, if a single lookup call to the Ironic API fails, the entire\nagent errors out and restarts. This allows the agent to retry for a set\namount of time before throwing an uncaught exception forcing a restart.\n\nChange-Id: I39752fb3f42ad3e4f15a49194f1554e1d3463cf8\nCloses-Bug: 1297019\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c2f9ce4639aa72df4439c9a05371eb9796347abd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c2f9ce4639aa72df4439c9a05371eb9796347abd"}]},"branch":"refs/heads/master"},"cba59e668201be0cf1d26b1aa9648955fdcc1460":{"kind":"REWORK","_number":4,"created":"2014-03-28 18:03:57.000000000","uploader":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"ref":"refs/changes/04/83604/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/04/83604/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/4"}}},"commit":{"parents":[{"commit":"6329ae46dba20cb194462ece583b2ed639c9e0c5","subject":"Fix URL for node lookup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6329ae46dba20cb194462ece583b2ed639c9e0c5"}]}],"author":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-26 17:57:25.000000000","tz":-420},"committer":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-28 18:03:43.000000000","tz":-420},"subject":"Adding DynamicLoopingCall around lookup","message":"Adding DynamicLoopingCall around lookup\n\nCurrently, if a single lookup call to the Ironic API fails, the entire\nagent errors out and restarts. This allows the agent to retry for a set\namount of time before throwing an uncaught exception forcing a restart.\n\nChange-Id: I39752fb3f42ad3e4f15a49194f1554e1d3463cf8\nCloses-Bug: 1297019\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/cba59e668201be0cf1d26b1aa9648955fdcc1460"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/cba59e668201be0cf1d26b1aa9648955fdcc1460"}]},"branch":"refs/heads/master"},"677fc5209afb59ba08a753d88f867d6984dc4eac":{"kind":"REWORK","_number":5,"created":"2014-03-31 18:04:40.000000000","uploader":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"ref":"refs/changes/04/83604/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/04/83604/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/5"}}},"commit":{"parents":[{"commit":"6329ae46dba20cb194462ece583b2ed639c9e0c5","subject":"Fix URL for node lookup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6329ae46dba20cb194462ece583b2ed639c9e0c5"}]}],"author":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-26 17:57:25.000000000","tz":-420},"committer":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-31 18:04:34.000000000","tz":-420},"subject":"Adding DynamicLoopingCall around lookup","message":"Adding DynamicLoopingCall around lookup\n\nCurrently, if a single lookup call to the Ironic API fails, the entire\nagent errors out and restarts. This allows the agent to retry for a set\namount of time before throwing an uncaught exception forcing a restart.\n\nChange-Id: I39752fb3f42ad3e4f15a49194f1554e1d3463cf8\nCloses-Bug: 1297019\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/677fc5209afb59ba08a753d88f867d6984dc4eac"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/677fc5209afb59ba08a753d88f867d6984dc4eac"}]},"branch":"refs/heads/master"},"aa92043c1f508d9b7e0fc0f2ea4a4ab722f36cf1":{"kind":"REWORK","_number":6,"created":"2014-03-31 21:38:06.000000000","uploader":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"ref":"refs/changes/04/83604/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/04/83604/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/6"}}},"commit":{"parents":[{"commit":"6329ae46dba20cb194462ece583b2ed639c9e0c5","subject":"Fix URL for node lookup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6329ae46dba20cb194462ece583b2ed639c9e0c5"}]}],"author":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-26 17:57:25.000000000","tz":-420},"committer":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-31 21:38:01.000000000","tz":-420},"subject":"Adding DynamicLoopingCall around lookup","message":"Adding DynamicLoopingCall around lookup\n\nCurrently, if a single lookup call to the Ironic API fails, the entire\nagent errors out and restarts. This allows the agent to retry for a set\namount of time before throwing an uncaught exception forcing a restart.\n\nChange-Id: I39752fb3f42ad3e4f15a49194f1554e1d3463cf8\nCloses-Bug: 1297019\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/aa92043c1f508d9b7e0fc0f2ea4a4ab722f36cf1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/aa92043c1f508d9b7e0fc0f2ea4a4ab722f36cf1"}]},"branch":"refs/heads/master"},"3bc4866a21b5fe255a808fb1742e40c3a5bee7b1":{"kind":"REWORK","_number":7,"created":"2014-03-31 21:54:22.000000000","uploader":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"ref":"refs/changes/04/83604/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/04/83604/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/04/83604/7"}}},"commit":{"parents":[{"commit":"6329ae46dba20cb194462ece583b2ed639c9e0c5","subject":"Fix URL for node lookup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6329ae46dba20cb194462ece583b2ed639c9e0c5"}]}],"author":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-26 17:57:25.000000000","tz":-420},"committer":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2014-03-31 21:54:14.000000000","tz":-420},"subject":"Adding DynamicLoopingCall around lookup","message":"Adding DynamicLoopingCall around lookup\n\nCurrently, if a single lookup call to the Ironic API fails, the entire\nagent errors out and restarts. This allows the agent to retry for a set\namount of time before throwing an uncaught exception forcing a restart.\n\nChange-Id: I39752fb3f42ad3e4f15a49194f1554e1d3463cf8\nCloses-Bug: 1297019\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3bc4866a21b5fe255a808fb1742e40c3a5bee7b1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3bc4866a21b5fe255a808fb1742e40c3a5bee7b1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}