)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b0f7d8a16565e04a163b830b2fee60d722f40699","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Guard shared device/cluster filesystems"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Certian filesystems are sometimes used in specialty computing"},{"line_number":10,"context_line":"enviromnets where a shared storage infrastructure or fabric exists."},{"line_number":11,"context_line":"These filesystems allow for multi-host shared concurrent read/write"},{"line_number":12,"context_line":"access to the underlying block device by *not* locking the entire"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"4244729b_b111a9c1","line":9,"updated":"2022-06-30 16:45:40.000000000","message":"nit: spelling\n\nCertian -\u003e Certain\nenviromnets -\u003e environments","commit_id":"e85a3b381085c5e3c979862fdf684e122d22cf47"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"44fafb95576b1645926b420b1aed37b7a9d60475","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Guard shared device/cluster filesystems"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Certian filesystems are sometimes used in specialty computing"},{"line_number":10,"context_line":"enviromnets where a shared storage infrastructure or fabric exists."},{"line_number":11,"context_line":"These filesystems allow for multi-host shared concurrent read/write"},{"line_number":12,"context_line":"access to the underlying block device by *not* locking the entire"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"cd2e4916_615b6bf4","line":9,"in_reply_to":"4244729b_b111a9c1","updated":"2022-07-11 17:37:52.000000000","message":"Done","commit_id":"e85a3b381085c5e3c979862fdf684e122d22cf47"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e6477aee466ddc8b0b845041183d292bf3365f52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4077a5f_23678a0f","updated":"2022-04-25 15:46:13.000000000","message":"When ready, this patch should have a much more detailed \"WHY\" section, as well as be accompanied by a release note and documentation updates.","commit_id":"d074571d360742956ea66694f4003e02fa6d2042"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b0f7d8a16565e04a163b830b2fee60d722f40699","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4e9daa38_6e6f36f3","updated":"2022-06-30 16:45:40.000000000","message":"This represents an API (or convention) change for IPA. Can we ensure the IPA hardware manager docs, explicitly, are updated to reflect this? Might even be worthwhile to add checking for protected FSes to the example disk erase hardware manager.","commit_id":"e85a3b381085c5e3c979862fdf684e122d22cf47"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"52a2534f1cb9a8335d171b76a37b707de7e07cd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"58cdd139_4fd94e4f","updated":"2022-07-13 14:12:32.000000000","message":"I\u0027ve got nothing new, if you want to fix Ricardo\u0027s nits I can re-+2 later today.","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7743ce729f1b4f98fdd58785e7b136dfb0a1e23a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8619912b_b1a7af99","updated":"2022-07-19 20:23:29.000000000","message":"Pushing revision shortly with fixes for these.","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4a226eb601813d523f6b27ce907b20585151e266","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0db3fa1c_ed464276","updated":"2022-07-12 21:54:33.000000000","message":"recheck metalsmith gate fixed","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3420e629a41869847a8afe6db7eb270296b2ba62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a82a1ecc_85fb8320","updated":"2022-07-13 08:00:34.000000000","message":"thanks Julia!","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"19b42d925a0e77cbac07b6385d502006d6dc22b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d37f56e1_4731fa89","updated":"2022-07-19 20:24:48.000000000","message":"I\u0027m clearly personally OK with the code, which hasn\u0027t changed, and the docs, which were modified by my hand. IMO this is safe to merge with only one additional core review.","commit_id":"beb7484858d56ef34699895412881945c5507c81"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bed30cf317e3f0639a0c8429f7bdc48400b5004b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f9420466_b4a62bcb","updated":"2022-07-20 06:53:38.000000000","message":"no code change and was already given 2 +2, so giving this green light","commit_id":"beb7484858d56ef34699895412881945c5507c81"}],"doc/source/admin/hardware_managers.rst":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3420e629a41869847a8afe6db7eb270296b2ba62","unresolved":true,"context_lines":[{"line_number":117,"context_line":"processes on stock hardware manager methods to abort prior to destroying the"},{"line_number":118,"context_line":"contents on the disk."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"These filesystems include IBM General Prallel File System (GPFS),"},{"line_number":121,"context_line":"VmWare Virtual Machine File System (VMFS), and Red Hat Global File System"},{"line_number":122,"context_line":"(GFS2)."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"069dee90_63deb90f","line":120,"range":{"start_line":120,"start_character":38,"end_line":120,"end_character":45},"updated":"2022-07-13 08:00:34.000000000","message":"nit: Parallel","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7743ce729f1b4f98fdd58785e7b136dfb0a1e23a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"processes on stock hardware manager methods to abort prior to destroying the"},{"line_number":118,"context_line":"contents on the disk."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"These filesystems include IBM General Prallel File System (GPFS),"},{"line_number":121,"context_line":"VmWare Virtual Machine File System (VMFS), and Red Hat Global File System"},{"line_number":122,"context_line":"(GFS2)."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"4dbd9393_13fa8bbd","line":120,"range":{"start_line":120,"start_character":38,"end_line":120,"end_character":45},"in_reply_to":"069dee90_63deb90f","updated":"2022-07-19 20:23:29.000000000","message":"Ack","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"}],"doc/source/admin/troubleshooting.rst":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3420e629a41869847a8afe6db7eb270296b2ba62","unresolved":true,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"The IPA service has halted cleaning as one of the block devices within or"},{"line_number":168,"context_line":"attached to the bare metal node contains a class of filesystem which **MAY**"},{"line_number":169,"context_line":"cause ireperable harm to a potentially running cluster if accidently removed."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"These filesystems *may* be used for only local storage and as a result be"},{"line_number":172,"context_line":"safe to erase. However if a shared block device is in use, such as a device"}],"source_content_type":"text/x-rst","patch_set":5,"id":"2f23c524_d1cf9009","line":169,"range":{"start_line":169,"start_character":6,"end_line":169,"end_character":16},"updated":"2022-07-13 08:00:34.000000000","message":"nit: irreparable","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7743ce729f1b4f98fdd58785e7b136dfb0a1e23a","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"The IPA service has halted cleaning as one of the block devices within or"},{"line_number":168,"context_line":"attached to the bare metal node contains a class of filesystem which **MAY**"},{"line_number":169,"context_line":"cause ireperable harm to a potentially running cluster if accidently removed."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"These filesystems *may* be used for only local storage and as a result be"},{"line_number":172,"context_line":"safe to erase. However if a shared block device is in use, such as a device"}],"source_content_type":"text/x-rst","patch_set":5,"id":"c88f1a10_e1378e87","line":169,"range":{"start_line":169,"start_character":6,"end_line":169,"end_character":16},"in_reply_to":"2f23c524_d1cf9009","updated":"2022-07-19 20:23:29.000000000","message":"Ack","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3420e629a41869847a8afe6db7eb270296b2ba62","unresolved":true,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"By default, the agent will prevent these filesystems from being deleted and"},{"line_number":180,"context_line":"will halt the cleaning process when detected. The cleaning process can be"},{"line_number":181,"context_line":"re-triggered via Ironic\u0027s state machine if one of the documented settings"},{"line_number":182,"context_line":"are used to notify the agent no action is required."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"What filesystems are looked for"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dc44066e_9879b104","line":181,"range":{"start_line":181,"start_character":39,"end_line":181,"end_character":40},"updated":"2022-07-13 08:00:34.000000000","message":"nit: add a comma here?","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7743ce729f1b4f98fdd58785e7b136dfb0a1e23a","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"By default, the agent will prevent these filesystems from being deleted and"},{"line_number":180,"context_line":"will halt the cleaning process when detected. The cleaning process can be"},{"line_number":181,"context_line":"re-triggered via Ironic\u0027s state machine if one of the documented settings"},{"line_number":182,"context_line":"are used to notify the agent no action is required."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"What filesystems are looked for"}],"source_content_type":"text/x-rst","patch_set":5,"id":"04cfc5e8_1b2b7ab5","line":181,"range":{"start_line":181,"start_character":39,"end_line":181,"end_character":40},"in_reply_to":"dc44066e_9879b104","updated":"2022-07-19 20:23:29.000000000","message":"I reworded this sentence (with help from my home-for-the-summer English teacher wife). I think your concern is resolved.","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3420e629a41869847a8afe6db7eb270296b2ba62","unresolved":true,"context_lines":[{"line_number":185,"context_line":"-------------------------------"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"+------------------------------------------+"},{"line_number":188,"context_line":"| IBM General Prallel Filesystem           |"},{"line_number":189,"context_line":"+------------------------------------------+"},{"line_number":190,"context_line":"| Red Hat Global Filesystem 2              |"},{"line_number":191,"context_line":"+------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fcc31210_15bfa22d","line":188,"range":{"start_line":188,"start_character":14,"end_line":188,"end_character":21},"updated":"2022-07-13 08:00:34.000000000","message":"nit: Parallel","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7743ce729f1b4f98fdd58785e7b136dfb0a1e23a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"-------------------------------"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"+------------------------------------------+"},{"line_number":188,"context_line":"| IBM General Prallel Filesystem           |"},{"line_number":189,"context_line":"+------------------------------------------+"},{"line_number":190,"context_line":"| Red Hat Global Filesystem 2              |"},{"line_number":191,"context_line":"+------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"2916bb9f_56920924","line":188,"range":{"start_line":188,"start_character":14,"end_line":188,"end_character":21},"in_reply_to":"fcc31210_15bfa22d","updated":"2022-07-19 20:23:29.000000000","message":"Ack","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3420e629a41869847a8afe6db7eb270296b2ba62","unresolved":true,"context_lines":[{"line_number":196,"context_line":"---------------------------------------------------------------"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Four potential ways exist to signal to IPA. Please note, all of these options"},{"line_number":199,"context_line":"except where explicitly noted, requires administrative access to Ironic."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Via Ironic"},{"line_number":202,"context_line":"~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":5,"id":"0e12d8dd_fc2ba85c","line":199,"range":{"start_line":199,"start_character":31,"end_line":199,"end_character":39},"updated":"2022-07-13 08:00:34.000000000","message":"nit: require ?","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7743ce729f1b4f98fdd58785e7b136dfb0a1e23a","unresolved":false,"context_lines":[{"line_number":196,"context_line":"---------------------------------------------------------------"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Four potential ways exist to signal to IPA. Please note, all of these options"},{"line_number":199,"context_line":"except where explicitly noted, requires administrative access to Ironic."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Via Ironic"},{"line_number":202,"context_line":"~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":5,"id":"f8228073_aa74ca30","line":199,"range":{"start_line":199,"start_character":31,"end_line":199,"end_character":39},"in_reply_to":"0e12d8dd_fc2ba85c","updated":"2022-07-19 20:23:29.000000000","message":"Reworded this one too.","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"}],"ironic_python_agent/config.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7f04acf10289f1250445c1534c8873693e2184ce","unresolved":true,"context_lines":[{"line_number":316,"context_line":"               help\u003d\u0027Priority of the inject_files deploy step (disabled \u0027"},{"line_number":317,"context_line":"                    \u0027by default), an integer between 1 and .\u0027),"},{"line_number":318,"context_line":"    cfg.BoolOpt(\u0027guard-special-filesystems\u0027,"},{"line_number":319,"context_line":"                default\u003dAPARAMS.get(\u0027ipa-guard-special-filesystems\u0027, True),"},{"line_number":320,"context_line":"                help\u003d\u0027Guard \"special\" shared device filesystems from \u0027"},{"line_number":321,"context_line":"                     \u0027cleaning. If one of these filesystems is detected \u0027"},{"line_number":322,"context_line":"                     \u0027during cleaning, the cleaning process will be aborted \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"21ff7f90_e36048b4","line":319,"updated":"2022-06-30 16:46:31.000000000","message":"There is value, perhaps, in indicating that this will only be respected by IPA-shipped hardware managers and custom ones which choose to implement it.","commit_id":"e85a3b381085c5e3c979862fdf684e122d22cf47"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"44fafb95576b1645926b420b1aed37b7a9d60475","unresolved":true,"context_lines":[{"line_number":316,"context_line":"               help\u003d\u0027Priority of the inject_files deploy step (disabled \u0027"},{"line_number":317,"context_line":"                    \u0027by default), an integer between 1 and .\u0027),"},{"line_number":318,"context_line":"    cfg.BoolOpt(\u0027guard-special-filesystems\u0027,"},{"line_number":319,"context_line":"                default\u003dAPARAMS.get(\u0027ipa-guard-special-filesystems\u0027, True),"},{"line_number":320,"context_line":"                help\u003d\u0027Guard \"special\" shared device filesystems from \u0027"},{"line_number":321,"context_line":"                     \u0027cleaning. If one of these filesystems is detected \u0027"},{"line_number":322,"context_line":"                     \u0027during cleaning, the cleaning process will be aborted \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"4a232a2b_686b6e42","line":319,"in_reply_to":"21ff7f90_e36048b4","updated":"2022-07-11 17:37:52.000000000","message":"This is a very good point! Revising.","commit_id":"e85a3b381085c5e3c979862fdf684e122d22cf47"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7743ce729f1b4f98fdd58785e7b136dfb0a1e23a","unresolved":false,"context_lines":[{"line_number":316,"context_line":"               help\u003d\u0027Priority of the inject_files deploy step (disabled \u0027"},{"line_number":317,"context_line":"                    \u0027by default), an integer between 1 and .\u0027),"},{"line_number":318,"context_line":"    cfg.BoolOpt(\u0027guard-special-filesystems\u0027,"},{"line_number":319,"context_line":"                default\u003dAPARAMS.get(\u0027ipa-guard-special-filesystems\u0027, True),"},{"line_number":320,"context_line":"                help\u003d\u0027Guard \"special\" shared device filesystems from \u0027"},{"line_number":321,"context_line":"                     \u0027cleaning. If one of these filesystems is detected \u0027"},{"line_number":322,"context_line":"                     \u0027during cleaning, the cleaning process will be aborted \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1cbab1f5_c1dcf529","line":319,"in_reply_to":"4a232a2b_686b6e42","updated":"2022-07-19 20:23:29.000000000","message":"This was already resolved, marking as such.","commit_id":"e85a3b381085c5e3c979862fdf684e122d22cf47"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3420e629a41869847a8afe6db7eb270296b2ba62","unresolved":true,"context_lines":[{"line_number":3016,"context_line":"    di_info \u003d node.get(\u0027driver_internal_info\u0027, {})"},{"line_number":3017,"context_line":"    if not di_info.get(\u0027wipe_special_filesystems\u0027, True):"},{"line_number":3018,"context_line":"        return"},{"line_number":3019,"context_line":"    report, _e \u003d il_utils.execute(\u0027lsblk\u0027, \u0027-Pbia\u0027,"},{"line_number":3020,"context_line":"                                  \u0027-oFSTYPE,UUID,PTUUID,PARTTYPE,PARTUUID\u0027,"},{"line_number":3021,"context_line":"                                  device)"},{"line_number":3022,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f8577bb_32944800","line":3019,"updated":"2022-07-13 08:00:34.000000000","message":"we should really use lsblk json output now that we can","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"}],"releasenotes/notes/prevent-deletion-of-shared-disk-filesystems-4c17c7666d2fe3bc.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3420e629a41869847a8afe6db7eb270296b2ba62","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Previously when the ``ironic-python-agent`` would undergo erasure of block"},{"line_number":5,"context_line":"    devices during cleaning, it would automatically attempt to erase the"},{"line_number":6,"context_line":"    contents of any \"Shared Device\" clustered filesystems which may be in use"},{"line_number":7,"context_line":"    by distinct multiple machines over a storage fabric. In particular "},{"line_number":8,"context_line":"    IBM GPFS, Red Hat Global File System 2, and VmWare Virtual Machine File"},{"line_number":9,"context_line":"    System (VMFS), are now identified and cleaning is halted. This is important"},{"line_number":10,"context_line":"    because should an active cluster be using the this disk, cleaning could"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"96f2d0ee_01a0da9c","line":7,"range":{"start_line":7,"start_character":70,"end_line":7,"end_character":71},"updated":"2022-07-13 08:00:34.000000000","message":"nit: blank space","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7743ce729f1b4f98fdd58785e7b136dfb0a1e23a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Previously when the ``ironic-python-agent`` would undergo erasure of block"},{"line_number":5,"context_line":"    devices during cleaning, it would automatically attempt to erase the"},{"line_number":6,"context_line":"    contents of any \"Shared Device\" clustered filesystems which may be in use"},{"line_number":7,"context_line":"    by distinct multiple machines over a storage fabric. In particular "},{"line_number":8,"context_line":"    IBM GPFS, Red Hat Global File System 2, and VmWare Virtual Machine File"},{"line_number":9,"context_line":"    System (VMFS), are now identified and cleaning is halted. This is important"},{"line_number":10,"context_line":"    because should an active cluster be using the this disk, cleaning could"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c813358b_04e00854","line":7,"range":{"start_line":7,"start_character":70,"end_line":7,"end_character":71},"in_reply_to":"96f2d0ee_01a0da9c","updated":"2022-07-19 20:23:29.000000000","message":"Ack","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3420e629a41869847a8afe6db7eb270296b2ba62","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    System (VMFS), are now identified and cleaning is halted. This is important"},{"line_number":10,"context_line":"    because should an active cluster be using the this disk, cleaning could"},{"line_number":11,"context_line":"    potentially cause the cluster to go down forcing restoration from backups."},{"line_number":12,"context_line":"    Ideally, infrastruture operators should check their environment\u0027s storage"},{"line_number":13,"context_line":"    configuration and un-map any clustered filesystems from being visible to"},{"line_number":14,"context_line":"    Ironic nodes, unless explicitly needed and expected. Please see the"},{"line_number":15,"context_line":"    Ironic-Python-Agent troubleshooting documentation for more information."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e751f8ef_bb90b1c5","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":26},"updated":"2022-07-13 08:00:34.000000000","message":"nit: infrastructure","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7743ce729f1b4f98fdd58785e7b136dfb0a1e23a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    System (VMFS), are now identified and cleaning is halted. This is important"},{"line_number":10,"context_line":"    because should an active cluster be using the this disk, cleaning could"},{"line_number":11,"context_line":"    potentially cause the cluster to go down forcing restoration from backups."},{"line_number":12,"context_line":"    Ideally, infrastruture operators should check their environment\u0027s storage"},{"line_number":13,"context_line":"    configuration and un-map any clustered filesystems from being visible to"},{"line_number":14,"context_line":"    Ironic nodes, unless explicitly needed and expected. Please see the"},{"line_number":15,"context_line":"    Ironic-Python-Agent troubleshooting documentation for more information."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3c48caff_240aaa1b","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":26},"in_reply_to":"e751f8ef_bb90b1c5","updated":"2022-07-19 20:23:29.000000000","message":"Ack","commit_id":"07481814ef5ab65f0db662f873cd968e28fa8d78"}]}