)]}'
{"ironic_python_agent/cmd/agent.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"cfac5ae36aa236d8c5f6099a6410352937ca9ab9","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def _get_kernel_params():"},{"line_number":23,"context_line":"    with open(\u0027/proc/cmdline\u0027) as f:"},{"line_number":24,"context_line":"        cmdline \u003d f.read().strip()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    options \u003d cmdline.split()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F99l0%3D","line":23,"updated":"2014-03-31 22:06:11.000000000","message":"Is this going to throw an exception if /proc/cmdline is not readable by the user running the agent?","commit_id":"e20ddc430ae198e6d0138e7ddce1eca11b1d992d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"cfac5ae36aa236d8c5f6099a6410352937ca9ab9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                            help\u003d\u0027URL of the Ironic API\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    parser.add_argument(\u0027--listen-host\u0027,"},{"line_number":51,"context_line":"                        default\u003dkparams.get(\u0027ipa-listen-host\u0027, \u00270.0.0.0\u0027),"},{"line_number":52,"context_line":"                        type\u003dstr,"},{"line_number":53,"context_line":"                        help\u003d\u0027The IP address to listen on.\u0027)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F99lo%3D","line":51,"updated":"2014-03-31 22:06:11.000000000","message":"Is this an OK way to inject the kernel param variables? Should we not merge them in some other way?","commit_id":"e20ddc430ae198e6d0138e7ddce1eca11b1d992d"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"d869c97d3702a4754f64d7b37d7f4b3207700b13","unresolved":false,"context_lines":[{"line_number":22,"context_line":"def _get_kernel_params():"},{"line_number":23,"context_line":"    try:"},{"line_number":24,"context_line":"        with open(\u0027/proc/cmdline\u0027) as f:"},{"line_number":25,"context_line":"            cmdline \u003d f.read().strip()"},{"line_number":26,"context_line":"    except Exception:"},{"line_number":27,"context_line":"        return {}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F95Bk%3D","line":25,"updated":"2014-04-01 12:09:55.000000000","message":"Stripping isn\u0027t necessary. Split() without separator arg will do the white characters stripping implicitly below on L29","commit_id":"3b646ba575d403b47bd97dd6e91cfdb2b4bd5d7c"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"d869c97d3702a4754f64d7b37d7f4b3207700b13","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        with open(\u0027/proc/cmdline\u0027) as f:"},{"line_number":25,"context_line":"            cmdline \u003d f.read().strip()"},{"line_number":26,"context_line":"    except Exception:"},{"line_number":27,"context_line":"        return {}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    options \u003d cmdline.split()"},{"line_number":30,"context_line":"    params \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F941Q%3D","line":27,"updated":"2014-04-01 12:09:55.000000000","message":"It might be better to log/print the error message, not to keeping the silence at all","commit_id":"3b646ba575d403b47bd97dd6e91cfdb2b4bd5d7c"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"0643f8abfe32d66ec6d00dcc1140c35988a541be","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        with open(\u0027/proc/cmdline\u0027) as f:"},{"line_number":25,"context_line":"            cmdline \u003d f.read().strip()"},{"line_number":26,"context_line":"    except Exception:"},{"line_number":27,"context_line":"        return {}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    options \u003d cmdline.split()"},{"line_number":30,"context_line":"    params \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F94Vo%3D","line":27,"in_reply_to":"AAAAWH%2F941Q%3D","updated":"2014-04-01 13:27:31.000000000","message":"I was thinking about that, and I think the only way this will fail is if it was an odd system or explicitly disabled via kernel options. That said, guess it can\u0027t hurt - will update.","commit_id":"3b646ba575d403b47bd97dd6e91cfdb2b4bd5d7c"}],"ironic_python_agent/tests/agent.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"cfac5ae36aa236d8c5f6099a6410352937ca9ab9","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        pass"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    @mock.patch(\u0027__builtin__.open\u0027)"},{"line_number":250,"context_line":"    def test__get_kernel_params(self, open_mock):"},{"line_number":251,"context_line":"        kernel_line \u003d \u0027api-url\u003dhttp://localhost:9999 baz foo\u003dbar\\n\u0027"},{"line_number":252,"context_line":"        open_mock.return_value.__enter__ \u003d lambda s: s"},{"line_number":253,"context_line":"        open_mock.return_value.__exit__ \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F99lk%3D","line":250,"updated":"2014-03-31 22:06:11.000000000","message":"Can we get a negative test? For if the file doesn\u0027t exist/is unreadable or empty?","commit_id":"e20ddc430ae198e6d0138e7ddce1eca11b1d992d"}]}