)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"22c77859c8d4c830eb20491817c9c25224c6e2d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"03e9ed31_78944fb3","updated":"2022-06-24 18:44:28.000000000","message":"First of all, I love this change. Thank you for bringing it up.\n\nWe have extensive documentation on how to run clean steps and write your own hardware managers, including examples. It seems like a bad idea to merge in this kind of API change without documenting it.\n\nI suggest two additions:\n - Add a segment to hardware manager documentation (probably here? https://github.com/openstack/ironic-python-agent/blob/master/doc/source/contributor/hardware_managers.rst#custom-hardwaremanagers-and-cleaning ) noting that you can pass kwargs to custom clean steps.\n - Add a release note indicating this API enhancement\n \nIf we want to do the documentation change in a follow-up, I\u0027m OK with that, but we cannot make this kind of change without any release note IMO.","commit_id":"615ec7e91d0ef2dadba44257a77070082a4bae76"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"70340852f1b8e5e276ba44378d5a28536df88d69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09bab4f5_0b561605","updated":"2022-06-14 07:03:05.000000000","message":"recheck","commit_id":"615ec7e91d0ef2dadba44257a77070082a4bae76"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"e689da0afbb1222034db7cf5ce9081f62d863805","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b32d289a_c2c60d52","updated":"2022-06-14 13:07:32.000000000","message":"recheck","commit_id":"615ec7e91d0ef2dadba44257a77070082a4bae76"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"a795b2ad98c23bc1580403559e5b3f10733dee8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2473e892_ff95dc75","in_reply_to":"03e9ed31_78944fb3","updated":"2022-06-30 09:14:02.000000000","message":"Done","commit_id":"615ec7e91d0ef2dadba44257a77070082a4bae76"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c8c90157d1a867744230e10255688d1f58fa9272","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a0cfdc23_09650de2","updated":"2022-06-30 14:04:42.000000000","message":"recheck","commit_id":"bc8f767899d85719bd440933dfdc353d53e5bb32"}]}