)]}'
{"id":"openstack%2Fironic-python-agent~847591","triplet_id":"openstack%2Fironic-python-agent~master~I03a381e99de79f201ec7e9a388777c3d48457e93","project":"openstack/ironic-python-agent","branch":"master","attention_set":{},"removed_from_attention_set":{"14826":{"account":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"last_update":"2022-06-27 08:13:47.000000000","reason":"\u003cGERRIT_ACCOUNT_14826\u003e replied on the change","reason_account":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"}}},"hashtags":[],"change_id":"I03a381e99de79f201ec7e9a388777c3d48457e93","subject":"Warn when smartctl not found","status":"MERGED","created":"2022-06-24 15:49:05.000000000","updated":"2022-06-27 12:11:42.000000000","submitted":"2022-06-27 12:10:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"847591","meta_rev_id":"4ce8082c2e9368f722a97b73beece7c220c25ddf","_number":847591,"virtual_id_number":847591,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-06-27 12:10:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":2,"date":"2022-06-24 18:28:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-06-24 18:23:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":1,"date":"2022-06-24 18:28:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-24 15:50:19.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2022-06-24 18:06:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-06-24 18:28:07.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"}],"messages":[{"id":"9fde13257c287f1d1e055764339b0f670659360c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2022-06-24 15:49:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2a22c11e309fc0130a6854f80db7f71e7c4c50b5","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2022-06-24 15:50:19.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2996ef9d8e49f984f794fef3e99f0ab62e47c580","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2022-06-24 16:01:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a94040464cc69d068368a69e7776add282068ece","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 18:06:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a868d66e63244111945c74085cc52a3e : SUCCESS in 4m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/da8a6336dd3949bea34f3fefc50507f4 : SUCCESS in 3m 26s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6cb1ccd5da4744c5902b769cf8133197 : SUCCESS in 4m 06s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/439686f5dd224e5794ac3ec6856f6037 : SUCCESS in 4m 32s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/31acd8e9ad1b4c949c899d5bd9208dba : RETRY_LIMIT in 2m 15s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7c6a07f63faf46719cc85ed9de6542ad : SUCCESS in 7m 51s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/0ad17b8351f54887a8214b3409543297 : SUCCESS in 4m 07s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/4f49c6ed437d46b697403e1f8bbd18d3 : SUCCESS in 4m 03s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/eb696d21c0964cc8a72cec58c585e5e4 : SUCCESS in 1h 27m 29s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/f9a4eaa9035b41be98bebabb1c1f8ff7 : SUCCESS in 1h 25m 35s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/cdeb9c24d15d4c9180f692b8692b793b : SUCCESS in 1h 45m 00s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/dbebc53827204ae69002595cbeb642d5 : SUCCESS in 1h 48m 34s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/51bf1d4b67ff42498c2ecb3c748c2d8a : SUCCESS in 55m 42s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/8193e42d189e4c729afb77cb33f7f9d1 : SUCCESS in 14m 17s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/364bacfddf9e4c71a5e5bd2407f1e7e0 : SUCCESS in 7m 46s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/2ebfc5c5e7164a0b9852687c0d71d0e6 : SUCCESS in 2h 02m 05s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/3db70e980f484898960499cf51abba11 : SUCCESS in 3m 18s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"7708aa74f0f6d819d3575592013c4e184a1c9907","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2022-06-24 18:23:22.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d6b89e8416618970b6d53f5d0bf3a4c0c495d60f","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2022-06-24 18:28:07.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"06ea48e4eb68627c2561cfe053fbff675bcdbc8a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 18:28:52.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"6550299fa68ea5765fb2ccd6715e82db5e7ecc65","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 22:47:56.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f307065aec664808b5c22b219351c418 : SUCCESS in 4m 25s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9780d019b6e64ea4be48eb55497d393c : SUCCESS in 5m 26s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/93de6d19941a4bf596343774150c475a : SUCCESS in 4m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/18dc8c5832f244778cba6f2c72ed1f28 : SUCCESS in 5m 36s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/654576e4413442a9a518aaaf3bf6036a : SUCCESS in 4m 14s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/440484ff67f9449fb6954c203b08bbd2 : SUCCESS in 1h 26m 45s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/f4234f7edf4648c288cb17199f87ca60 : FAILURE in 1h 55m 21s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/d51a5281144d4872bb5f21b0fa794920 : SUCCESS in 1h 46m 02s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/d8c05f5753444849b1582669ec921045 : SUCCESS in 1h 39m 28s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/1092652e9e924399a2831424d9f9f18f : SUCCESS in 1h 14m 22s","accounts_in_message":[],"_revision_number":2},{"id":"47afe5e3c84a391898bec44b7729a80ca3d6d544","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2022-06-27 08:13:47.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c7925e36d222d537b68355af1c7366a76825f1e2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-27 10:26:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a655c0ef5a85434fba0c48a62c59e14a : SUCCESS in 5m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/56ec23d592464d99bd9395f347c057c2 : SUCCESS in 3m 59s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6ec31ada792f4e2390f02533aeb76a2b : SUCCESS in 4m 40s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e839c2ee155a496baedc2059ef396d2b : SUCCESS in 5m 05s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/ecf510997b874a199800397948486d36 : RETRY_LIMIT in 2m 11s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/31550ca08a6e4e31b4af83a49dc61743 : SUCCESS in 7m 05s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/a8e64fc723304e0fbb3b38d7db428ceb : SUCCESS in 4m 45s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/44a9b9eb393242189eed91dbba24dc66 : SUCCESS in 5m 14s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/af4492d055444565b380f1930755912b : SUCCESS in 1h 34m 20s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/7c63f7864ce64f518c1981d6cf882904 : SUCCESS in 1h 12m 44s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/0363e3cac32048a885b23157f64c6e61 : SUCCESS in 1h 29m 22s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/2dc83b1644a54519958eacf66f8d0ce8 : SUCCESS in 1h 37m 52s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/bd57c87b66ac4efe83c0e25a41e4d276 : SUCCESS in 1h 07m 48s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/2b08adb3acd54603a66bc3a64c66a956 : SUCCESS in 16m 49s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/22a2b73319904e8bb542c49826e5997f : SUCCESS in 7m 27s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/1ca1b92471294da4b03ad2e9766f771e : SUCCESS in 2h 10m 50s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/8410621fdbd140b4a766bb48900252cc : SUCCESS in 4m 20s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"8a6186113b92c6c1b1e6f118b5d1b21343db0436","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-27 10:27:24.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"5e35012b83f5c16bd683a8dd484f5f3fec644485","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-27 12:10:31.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5ea98a074cf546398da3fbd58df1c0ca : SUCCESS in 3m 41s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/913766ad766d45969730a06b6303173b : SUCCESS in 4m 37s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/00fcbb2a6d8b434c9e7b48ce5b704a35 : SUCCESS in 4m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d5d8ad2926c44bcf98f2eae87915118c : SUCCESS in 8m 06s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/822e177cccca442a9aef939ceb7042fb : SUCCESS in 4m 21s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/06c6f66b945d4a5383923722c9234796 : SUCCESS in 4m 24s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/976dec4276264749b909ce0ef6267863 : SUCCESS in 1h 17m 41s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/69c6a9d6482c477ab3bad1f1cefb372d : SUCCESS in 1h 15m 20s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/9e5ec06a7ca3450a9b8cc651425be3e1 : SUCCESS in 1h 21m 00s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/ece5ee0f6b1c49399499e5bceb2e826e : SUCCESS in 1h 42m 06s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/214aa193984a4fc198d39a836047b55a : SUCCESS in 59m 14s","accounts_in_message":[],"_revision_number":2},{"id":"0e81933a7d53215ab86bd9d3ac80531126f8c239","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-27 12:10:31.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"4ce8082c2e9368f722a97b73beece7c220c25ddf","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-27 12:11:42.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b2f5e36230e2493ea5b491e53aa29246 : SUCCESS in 47s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b68fa6b2e13774dbde5d0b81f6bf0b0095536aa4","revisions":{"70f206a9c738e66c49facc7009b1978214afba65":{"kind":"REWORK","_number":1,"created":"2022-06-24 15:49:05.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/91/847591/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/91/847591/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/91/847591/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/91/847591/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/91/847591/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/91/847591/1"}}},"commit":{"parents":[{"commit":"f08f70134d24a23355511e9c8feac9987f2e62e4","subject":"Merge \"Improve efficiency of storage cleaning in mixed media envs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f08f70134d24a23355511e9c8feac9987f2e62e4"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2022-06-24 15:47:18.000000000","tz":60},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2022-06-24 15:48:54.000000000","tz":60},"subject":"Warn when smartctl not found","message":"Warn when smartctl not found\n\nCurrently, if smartctl is not found by IPA, it will silently skip ATA\nsecure erase and proceed to shred (if enabled). This is supposedly for\nbackwards compatibility, but is quite hard to diagnose.\n\nThis change adds a warning message to make it more obvious what is\nhappening.\n\nTrivialFix\n\nChange-Id: I03a381e99de79f201ec7e9a388777c3d48457e93\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/70f206a9c738e66c49facc7009b1978214afba65"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/70f206a9c738e66c49facc7009b1978214afba65"}]},"branch":"refs/heads/master"},"b68fa6b2e13774dbde5d0b81f6bf0b0095536aa4":{"kind":"REWORK","_number":2,"created":"2022-06-24 16:01:02.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/91/847591/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/91/847591/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/91/847591/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/91/847591/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/91/847591/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/91/847591/2"}}},"commit":{"parents":[{"commit":"f08f70134d24a23355511e9c8feac9987f2e62e4","subject":"Merge \"Improve efficiency of storage cleaning in mixed media envs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f08f70134d24a23355511e9c8feac9987f2e62e4"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2022-06-24 15:47:18.000000000","tz":60},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2022-06-24 15:58:37.000000000","tz":60},"subject":"Warn when smartctl not found","message":"Warn when smartctl not found\n\nCurrently, if smartctl is not found by IPA, it will silently skip ATA\nsecure erase and proceed to shred (if enabled). This is supposedly for\nbackwards compatibility, but is quite hard to diagnose.\n\nThis change adds a warning message to make it more obvious what is\nhappening.\n\nTrivialFix\n\nChange-Id: I03a381e99de79f201ec7e9a388777c3d48457e93\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b68fa6b2e13774dbde5d0b81f6bf0b0095536aa4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b68fa6b2e13774dbde5d0b81f6bf0b0095536aa4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[]}
