)]}'
{"id":"openstack%2Fironic-python-agent~850498","triplet_id":"openstack%2Fironic-python-agent~master~I89f56c69d90fb0eb61907d6667266fbd57d333af","project":"openstack/ironic-python-agent","branch":"master","topic":"remove_unused_code_from_erase_devices_metadata","attention_set":{},"removed_from_attention_set":{"35099":{"account":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"last_update":"2022-07-22 13:06:06.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I89f56c69d90fb0eb61907d6667266fbd57d333af","subject":"Remove unused lines of code","status":"MERGED","created":"2022-07-20 10:07:13.000000000","updated":"2022-07-22 13:07:10.000000000","submitted":"2022-07-22 13:06:06.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"850498-remove_unused_code_from_erase_devices_metadata","meta_rev_id":"79fe61862a139bec21829374b6c2a03d47e26c59","_number":850498,"virtual_id_number":850498,"owner":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-07-22 13:06:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2022-07-20 13:40:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-07-22 11:29:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2022-07-22 11:29:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-20 12:08:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-07-20 13:40:39.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2022-07-22 11:29:09.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"}],"messages":[{"id":"6ffebf60d24ca9dc5139972af292f2756c16547a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"date":"2022-07-20 10:07:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"438c50fc19aa55fee8225c187a87dcd7bda6db67","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-20 12:08:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f62a2b985ed24b5b92d6758bcb3a9241\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b9d01e681a19438093fa424e8f15ac61 : SUCCESS in 4m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/79882ecb31764f3293b9577acce7f679 : SUCCESS in 4m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c71f79272b4344199c7abe7db02ebdf9 : SUCCESS in 5m 21s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/357634f8a47343078994525a3a5a3c3f : SUCCESS in 5m 10s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/9dd9637c08af42ef9ddfd5a1402ce86c : SUCCESS in 4m 55s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/40bda428f073401aad1c30054f17798d : SUCCESS in 6m 50s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/c48d000b2eeb42a6b2bac4c6bf2107a9 : SUCCESS in 4m 59s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/1a553311099541c4aa6c7f2dc1935e57 : SUCCESS in 4m 35s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/ddf97e1e8ea6449e89acc5f73dcbcca6 : SUCCESS in 55m 31s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/e1ba8eb19e62494e95f7c2bc2d906284 : SUCCESS in 1h 10m 24s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/dc8ecbabf6ba44d78f9978b034c65f33 : SUCCESS in 1h 17m 46s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/78075a047fe04f8299d16185c2a9fdfe : SUCCESS in 1h 20m 49s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/147c3806676546bf8dd9e48bf87864a8 : SUCCESS in 1h 01m 39s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/532e46c737214ac3bc95639af391cd0b : SUCCESS in 18m 05s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/f3d76ab590c9476bb292e495529943d1 : SUCCESS in 8m 39s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/fd1c82b20a1d4635bc6441db431cc108 : SUCCESS in 1h 57m 29s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/c905a4b461bd436784c1a31b6d38712e : SUCCESS in 5m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b881f750cc8d6af994868f41f1c7c99cf2c7e7a0","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2022-07-20 13:40:39.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"23788d11d678f998c9af32f1fb783fd74d737135","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2022-07-22 11:29:09.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b877b6a1c61edae3c8095807c12838ab4d533ef8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-22 11:29:49.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"16f128faab572241ff76e4603e1b23723cac6c19","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-22 13:06:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/df68cf7ddae24dd1bb84247b6cd8e105\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/23f7308b0a484720a87aecdf06b8f7b5 : SUCCESS in 6m 00s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/876a276177a6421da473f8b5103c80ac : SUCCESS in 7m 08s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f34088b7e4c64027a8f7684b5bb7afff : SUCCESS in 4m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ac29237801a4495692cc8e42e4bf3470 : SUCCESS in 6m 41s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/e60cc41019484cf0ad52810bb7d86805 : SUCCESS in 4m 24s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/545b6062a71b462da5f6283ec36ace8d : SUCCESS in 4m 27s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/45107899b3604011918ddc018f826622 : SUCCESS in 1h 13m 25s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/b5b3065563884c2da1381962af77ed4d : SUCCESS in 1h 23m 56s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/94fd04eb851d4547be7fb035d9b6a2ac : SUCCESS in 1h 29m 39s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/6bf199d257c14d8c97242972ea6a507a : SUCCESS in 1h 34m 10s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/3a06ea773011431eaa953592a0327234 : SUCCESS in 1h 10m 26s","accounts_in_message":[],"_revision_number":1},{"id":"51c2c411f5a34152a2ecb6bf1c8f48578272e8d3","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-22 13:06:06.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"79fe61862a139bec21829374b6c2a03d47e26c59","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-22 13:07:10.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7a94ddb059774884baceab07988fd018\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ed822c862d884fcc8432c667661d4b7e : SUCCESS in 45s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e196fdfb62a5c5a8d56727f703e8a35abe3956ea","revisions":{"e196fdfb62a5c5a8d56727f703e8a35abe3956ea":{"kind":"REWORK","_number":1,"created":"2022-07-20 10:07:13.000000000","uploader":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"ref":"refs/changes/98/850498/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/98/850498/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/98/850498/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/98/850498/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/98/850498/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/98/850498/1"}}},"commit":{"parents":[{"commit":"21b21a5f15bce4871f6af0dc06ebf50d0e9b0967","subject":"Merge \"Guard shared device/cluster filesystems\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/21b21a5f15bce4871f6af0dc06ebf50d0e9b0967"}]}],"author":{"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","date":"2022-07-20 10:00:53.000000000","tz":0},"committer":{"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","date":"2022-07-20 10:00:53.000000000","tz":0},"subject":"Remove unused lines of code","message":"Remove unused lines of code\n\nThe 5 lines of code were extracted from erase_devices_metadata to _list_erasable_devices, but now are duplicated in both functions.\nThe variable block_devices is not used in erase_devices_metadata.\n\nChange-Id: I89f56c69d90fb0eb61907d6667266fbd57d333af\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e196fdfb62a5c5a8d56727f703e8a35abe3956ea"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e196fdfb62a5c5a8d56727f703e8a35abe3956ea"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[]}