)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f6a4638d698310c853ec81b703faa74ae626ff6a","unresolved":true,"context_lines":[{"line_number":15,"context_line":"passes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story: 2010233"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib9290a97519bc48e585e1bafb0b60cc14e621e0f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"b6aaf092_042aad9a","line":18,"updated":"2022-09-02 17:35:37.000000000","message":"nit: missing task, since the open/closed status is tracked by tasks, not stories.","commit_id":"ced2f57111f6f18db413261a19058998122a8954"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3d46cf5a949f29d902c6d60f43b2cf63830e15c3","unresolved":true,"context_lines":[{"line_number":15,"context_line":"passes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story: 2010233"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib9290a97519bc48e585e1bafb0b60cc14e621e0f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ebf295e3_ba6cb9e7","line":18,"in_reply_to":"b6aaf092_042aad9a","updated":"2022-09-02 17:43:58.000000000","message":"46032 is the task #","commit_id":"ced2f57111f6f18db413261a19058998122a8954"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b2006c14622a573bc9e29d66cfff47b194743777","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3cb6a517_2b8c6e5a","updated":"2022-08-12 15:42:31.000000000","message":"Can we be more explicit about what the goal is? To skip cleaning on devices *that contain a raid* or to skip cleaning on *the raid partitions themselves*? ","commit_id":"54f354baacc90db68e678fc717b2d87f6b14591a"},{"author":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"change_message_id":"b7094c78c21e7874b2585fb3f220f88ba99966df","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9fce38ff_cff74cc3","in_reply_to":"3cb6a517_2b8c6e5a","updated":"2022-08-15 06:20:49.000000000","message":"I am aiming for skipping the raid partitions themselves.","commit_id":"54f354baacc90db68e678fc717b2d87f6b14591a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bf891ab526a658d1338111ed09737c8d6b420671","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4a2cb6a7_ef6d8b07","in_reply_to":"9fce38ff_cff74cc3","updated":"2022-08-16 15:54:32.000000000","message":"Can we get that in a comment or the commit message?","commit_id":"54f354baacc90db68e678fc717b2d87f6b14591a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bf891ab526a658d1338111ed09737c8d6b420671","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b5886b3f_80ad3e57","updated":"2022-08-16 15:54:32.000000000","message":"This is on my list to give a full review to. I\u0027ll revisit probably today","commit_id":"5920e17941348785c5f619fa018a4cc262abdf45"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"567555f7f4f6d6bac79d0dfafe9c96ee7d4dfe58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1092a4ae_377ce254","updated":"2022-09-02 17:45:58.000000000","message":"Approving as I only updated the commit message to include the associated task.","commit_id":"c03161af2fc452c1b4cefa0f20c30c220d262755"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"50190f61351bee2394f1b443cfccf896553299b5","unresolved":true,"context_lines":[{"line_number":2374,"context_line":"        self.validate_configuration(raid_config, node)"},{"line_number":2375,"context_line":""},{"line_number":2376,"context_line":"        # Remove any logical disk from the list if its volume name"},{"line_number":2377,"context_line":"        # if on the skip list"},{"line_number":2378,"context_line":"        skip_list \u003d self.get_skip_list_from_node("},{"line_number":2379,"context_line":"            node, just_raids\u003dTrue)"},{"line_number":2380,"context_line":"        rm_from_list \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"17dd7aae_27d973db","line":2377,"updated":"2022-08-25 22:08:15.000000000","message":"This comment is unintentionally confusing, I think.\n\n# Remove any logical disk from being eligible for inclusion in the RAID if it\u0027s on the skip list\n\n\nOr something else, if my interpretation does not match up with what\u0027s happening. It\u0027s a really confusing double-use of \"list\" in the comment.","commit_id":"bd8c2aca6f60c305d7e76bc5375c592c1bcc3174"},{"author":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"change_message_id":"cbe3128803b8e01ec5979e801b14118c8e31700c","unresolved":false,"context_lines":[{"line_number":2374,"context_line":"        self.validate_configuration(raid_config, node)"},{"line_number":2375,"context_line":""},{"line_number":2376,"context_line":"        # Remove any logical disk from the list if its volume name"},{"line_number":2377,"context_line":"        # if on the skip list"},{"line_number":2378,"context_line":"        skip_list \u003d self.get_skip_list_from_node("},{"line_number":2379,"context_line":"            node, just_raids\u003dTrue)"},{"line_number":2380,"context_line":"        rm_from_list \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"378e4aba_3cf09bf6","line":2377,"in_reply_to":"17dd7aae_27d973db","updated":"2022-08-29 08:03:23.000000000","message":"Done","commit_id":"bd8c2aca6f60c305d7e76bc5375c592c1bcc3174"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"50190f61351bee2394f1b443cfccf896553299b5","unresolved":true,"context_lines":[{"line_number":2553,"context_line":"            holder_disks \u003d get_holder_disks(raid_device.name)"},{"line_number":2554,"context_line":""},{"line_number":2555,"context_line":"            if not do_not_delete:"},{"line_number":2556,"context_line":"                LOG.info(\"Deleting Software RAID device %s\", raid_device.name)"},{"line_number":2557,"context_line":"            LOG.debug(\u0027Found component devices %s\u0027, component_devices)"},{"line_number":2558,"context_line":"            LOG.debug(\u0027Found holder disks %s\u0027, holder_disks)"},{"line_number":2559,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"2024aa48_a2c22324","line":2556,"updated":"2022-08-25 22:08:15.000000000","message":"We should log loudly that we skipped deleting this raid -- same below.","commit_id":"bd8c2aca6f60c305d7e76bc5375c592c1bcc3174"},{"author":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"change_message_id":"cbe3128803b8e01ec5979e801b14118c8e31700c","unresolved":false,"context_lines":[{"line_number":2553,"context_line":"            holder_disks \u003d get_holder_disks(raid_device.name)"},{"line_number":2554,"context_line":""},{"line_number":2555,"context_line":"            if not do_not_delete:"},{"line_number":2556,"context_line":"                LOG.info(\"Deleting Software RAID device %s\", raid_device.name)"},{"line_number":2557,"context_line":"            LOG.debug(\u0027Found component devices %s\u0027, component_devices)"},{"line_number":2558,"context_line":"            LOG.debug(\u0027Found holder disks %s\u0027, holder_disks)"},{"line_number":2559,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"286ec5b1_fcf9984d","line":2556,"in_reply_to":"2024aa48_a2c22324","updated":"2022-08-29 08:03:23.000000000","message":"Done","commit_id":"bd8c2aca6f60c305d7e76bc5375c592c1bcc3174"}],"ironic_python_agent/raid_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3d46cf5a949f29d902c6d60f43b2cf63830e15c3","unresolved":true,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"def get_volume_name_of_raid_device(raid_device):"},{"line_number":268,"context_line":"    \"\"\"Get the volume name of a RAID device"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    :param raid_device: A Software RAID block device name."},{"line_number":271,"context_line":"    :returns: volume name of the device, or None"}],"source_content_type":"text/x-python","patch_set":7,"id":"ac8dba74_ed60c492","line":268,"updated":"2022-09-02 17:43:58.000000000","message":"fwiw, I wish there was a unit test wrapped around this, since it does have a regex.\n\nThat being said, the code path looks like it will be fine if this fails.","commit_id":"ced2f57111f6f18db413261a19058998122a8954"}],"ironic_python_agent/utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3d46cf5a949f29d902c6d60f43b2cf63830e15c3","unresolved":true,"context_lines":[{"line_number":662,"context_line":"    if not device:"},{"line_number":663,"context_line":"        return None"},{"line_number":664,"context_line":"    partition_number \u003d part.replace(device, \u0027\u0027)"},{"line_number":665,"context_line":"    if \u0027nvme\u0027 in device and partition_number[0] \u003d\u003d \u0027p\u0027:"},{"line_number":666,"context_line":"        partition_number \u003d partition_number[1:]"},{"line_number":667,"context_line":"    return (device, partition_number)"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a1f56b3_276acda0","line":666,"range":{"start_line":665,"start_character":2,"end_line":666,"end_character":47},"updated":"2022-09-02 17:43:58.000000000","message":"I\u0027m not sure if drivers like cciss are still a think, but some other block device drivers took this pattern. Likely fine in the grand scheme of the universe.","commit_id":"ced2f57111f6f18db413261a19058998122a8954"}]}