)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c201b7121e17aacaffe7bcb1436f13fabe0086a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"867ee9d9_da0356a9","updated":"2023-04-19 18:38:09.000000000","message":"LGTM outside of the one question. Should we get Ade Lee to review this, too?","commit_id":"a55f3b8e18f8ab7ae1d3f5e30aa33f7932f75d04"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7206cd5dbeb79fc6c2a4acac6a20a92c3e5d2951","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"813ff698_edf39cef","updated":"2023-04-19 19:21:45.000000000","message":"Thanks for the explanation!","commit_id":"a55f3b8e18f8ab7ae1d3f5e30aa33f7932f75d04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"851d33ca451d83e98d4aa5a4ec4ee3d20e616f35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"82c7fe87_db8befad","in_reply_to":"813ff698_edf39cef","updated":"2023-04-19 19:33:41.000000000","message":"oh, forgot one quesiton! W/R/T Ade lee, I don\u0027t think it is really needed, but I\u0027ll be happy to ping him if you want another set of eyes on it.","commit_id":"a55f3b8e18f8ab7ae1d3f5e30aa33f7932f75d04"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c0de32213627abb4ccf405d933b75cfbdaa859f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d72277a3_5fa7bba4","updated":"2023-04-26 19:46:28.000000000","message":"I\u0027m happy if CI is :D","commit_id":"32df26a22ad79fd9b69f6ae994a0d694ad03c5c0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"64df050f1439ddc84f9e0369aef40a1f1b8d9da4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"155bd1fa_1203d646","updated":"2023-04-26 19:16:36.000000000","message":"recheck ci should be working now","commit_id":"32df26a22ad79fd9b69f6ae994a0d694ad03c5c0"}],"ironic_python_agent/extensions/standby.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c201b7121e17aacaffe7bcb1436f13fabe0086a3","unresolved":true,"context_lines":[{"line_number":293,"context_line":"    elif checksum_len \u003d\u003d 32:"},{"line_number":294,"context_line":"        check_md5_enabled()"},{"line_number":295,"context_line":"        # This is not super great, but opt-in only."},{"line_number":296,"context_line":"        return hashlib.new(\u0027md5\u0027)  # nosec"},{"line_number":297,"context_line":"    else:"},{"line_number":298,"context_line":"        # Previously, we would have just assumed the value was"},{"line_number":299,"context_line":"        # md5 by default. This way we are a little smarter and"}],"source_content_type":"text/x-python","patch_set":2,"id":"47691ab2_68c64287","line":296,"updated":"2023-04-19 18:38:09.000000000","message":"Is it intentional that this isn\u0027t adding usedforsecurity\u003dFalse? https://docs.python.org/3/library/hashlib.html#hashlib.new","commit_id":"a55f3b8e18f8ab7ae1d3f5e30aa33f7932f75d04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4e77a85e2d452ed3bc8e87b002252dcf1a22f4e2","unresolved":true,"context_lines":[{"line_number":293,"context_line":"    elif checksum_len \u003d\u003d 32:"},{"line_number":294,"context_line":"        check_md5_enabled()"},{"line_number":295,"context_line":"        # This is not super great, but opt-in only."},{"line_number":296,"context_line":"        return hashlib.new(\u0027md5\u0027)  # nosec"},{"line_number":297,"context_line":"    else:"},{"line_number":298,"context_line":"        # Previously, we would have just assumed the value was"},{"line_number":299,"context_line":"        # md5 by default. This way we are a little smarter and"}],"source_content_type":"text/x-python","patch_set":2,"id":"bc200afd_e5c72a3d","line":296,"in_reply_to":"47691ab2_68c64287","updated":"2023-04-19 18:51:38.000000000","message":"Yes, checksum is a security action in this context. The acceptable non-security use of the flag per docs is compression/de-duplication. In this case, we\u0027re validating the file is what we were told matches the checksum we were told. I consulted glance, and the only place where they use it is for test value generation for unit testing.","commit_id":"a55f3b8e18f8ab7ae1d3f5e30aa33f7932f75d04"}],"ironic_python_agent/tests/unit/extensions/test_standby.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"dbfbbe25ae6f8089766adca33156dc004c90d59f","unresolved":true,"context_lines":[{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"    def test_download_image_and_checksum_md5(self, requests_mock, hash_mock):"},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"        content \u003d [\u0027SpongeBob\u0027, \u0027SquarePants\u0027]"},{"line_number":1617,"context_line":"        fake_cs \u003d \"019fe036425da1c562f2e9f5299820bf\""},{"line_number":1618,"context_line":"        cs_response \u003d mock.Mock()"},{"line_number":1619,"context_line":"        cs_response.status_code \u003d 200"}],"source_content_type":"text/x-python","patch_set":3,"id":"6c3bcbe5_090aad28","line":1616,"updated":"2023-05-02 05:02:14.000000000","message":"🧽","commit_id":"32df26a22ad79fd9b69f6ae994a0d694ad03c5c0"}]}