)]}'
{"id":"openstack%2Fironic-python-agent~867161","triplet_id":"openstack%2Fironic-python-agent~stable%2Fwallaby~I03a381e99de79f201ec7e9a388777c3d48457e93","project":"openstack/ironic-python-agent","branch":"stable/wallaby","attention_set":{},"removed_from_attention_set":{"14826":{"account":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"last_update":"2022-12-13 14:23:25.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I03a381e99de79f201ec7e9a388777c3d48457e93","subject":"Warn when smartctl not found","status":"MERGED","created":"2022-12-12 15:07:27.000000000","updated":"2022-12-13 14:24:32.000000000","submitted":"2022-12-13 14:23:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"867161","cherry_pick_of_change":847591,"cherry_pick_of_patch_set":2,"meta_rev_id":"104094d0a1da2dfbd83551c35553c983b34a4331","_number":867161,"virtual_id_number":867161,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-12-13 14:23:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2022-12-13 12:48:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":1,"date":"2022-12-13 12:48:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-12 16:52:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-12-13 12:48:19.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"}],"messages":[{"id":"bc4014fae110dcc434dca26bd1bf6b6109566752","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2022-12-12 15:07:27.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"bf95441c0f57405cf664fa572c9df213a93b82f0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-12 16:52:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/aeb51e80a5454eb08f02e284a9fdd1dd\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/61eb03817ac146cdba540aba2eea04b1 : SUCCESS in 3m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f4d2ab2a76854e26803a323028372f30 : SUCCESS in 4m 08s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a7a326df866e4400b19fd5c45b242c74 : SUCCESS in 4m 22s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/eed175f92c00447783d0c2b2c7210d26 : SUCCESS in 5m 18s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/60a8510406a64a4985d47532b2148ec5 : SUCCESS in 5m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a9818ad8e2b84684bb9bc5014334170d : SUCCESS in 5m 30s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/a17e4d6385f44d978e50b6f5f0bd55f9 : SUCCESS in 3m 24s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/52ce88327d0347ec8b6892e75d603564 : SUCCESS in 3m 19s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/700e231638f6429a8c1083942dbe31f3 : SUCCESS in 1h 29m 40s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/914308e1c1674473bd90cdca271c98c4 : SUCCESS in 1h 27m 27s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/0e88b01bcb384672bc34d55903198e45 : SUCCESS in 1h 12m 33s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/e3d4b63f610148fe8d2b7070b34e4f2b : SUCCESS in 1h 02m 31s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/23f3d5278494487c80711f7d946ef8bf : SUCCESS in 59m 22s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/a41d7b7a2c6248939a029d20764051e9 : SUCCESS in 1h 12m 16s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/4ffed23a357d41beaa9b503cfb36b337 : SUCCESS in 12m 34s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/a6420904e2334830bb93842cfe1e3e56 : SUCCESS in 10m 45s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/27da47f010a34ff2befd6d4112110c3f : SUCCESS in 1h 43m 24s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/0e51c47d7b634609b92de7c53a4f8490 : SUCCESS in 3m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4a15fae0a100208a70e0b3380aee8925f03405d1","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2022-12-13 12:48:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4562f9835ab924d5a88df6e64084e46650533ed3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-13 12:48:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a7f43e38fc398581883d1bd22afc49d4a02eac5c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-13 14:23:25.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cbae73ed23134c4384f0af99f95cf616\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/07798656b415418a8fba4a7ebe4b2050 : SUCCESS in 3m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3bf6207eb8524932b6b5bfc94b8f191a : SUCCESS in 3m 57s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/103f739d57f14479bb89876cc58efc8f : SUCCESS in 4m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/442983b0fe8848e3abaeab555ae454bc : SUCCESS in 6m 35s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/555a3b402a6449028e69a664cc3ddc61 : SUCCESS in 3m 47s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/1ccecdf3e0e940f181f3774af6ef6b95 : SUCCESS in 1h 17m 54s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/259d7cbedf9f4275885f61bff90a9489 : SUCCESS in 1h 11m 31s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/492fda36ed494d4d9f91d17ed096cae4 : SUCCESS in 1h 06m 09s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/7484517863fb4093b6b773c2e165c4f8 : SUCCESS in 1h 08m 33s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/4a3dc070ba2d4d0db22ad09d0ed3958f : SUCCESS in 1h 18m 25s","accounts_in_message":[],"_revision_number":1},{"id":"97a7abbbbf01e63a391f65d40f61613ff4847dde","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-13 14:23:25.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"104094d0a1da2dfbd83551c35553c983b34a4331","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-13 14:24:32.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7b5a63dacbc64e57b93a2fee2904df42\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/faa1d6b2273742e0ab69c21ac9e69a4f : SUCCESS in 46s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c9d00d92788a1c70767e6bedadfae6cddec34ca8","revisions":{"c9d00d92788a1c70767e6bedadfae6cddec34ca8":{"kind":"REWORK","_number":1,"created":"2022-12-12 15:07:27.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/61/867161/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/61/867161/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/867161/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/867161/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/867161/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/867161/1"}}},"commit":{"parents":[{"commit":"f11ae6a072c8c9bbf0a08c9e32a2bfb81d35bfeb","subject":"Drop python2 from bindep.txt","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f11ae6a072c8c9bbf0a08c9e32a2bfb81d35bfeb"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2022-06-24 15:47:18.000000000","tz":60},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2022-12-12 15:07:27.000000000","tz":0},"subject":"Warn when smartctl not found","message":"Warn when smartctl not found\n\nCurrently, if smartctl is not found by IPA, it will silently skip ATA\nsecure erase and proceed to shred (if enabled). This is supposedly for\nbackwards compatibility, but is quite hard to diagnose.\n\nThis change adds a warning message to make it more obvious what is\nhappening.\n\nTrivialFix\n\nChange-Id: I03a381e99de79f201ec7e9a388777c3d48457e93\n(cherry picked from commit b68fa6b2e13774dbde5d0b81f6bf0b0095536aa4)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c9d00d92788a1c70767e6bedadfae6cddec34ca8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c9d00d92788a1c70767e6bedadfae6cddec34ca8"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[]}
