)]}'
{"ironic_python_agent/extensions/base.py":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"c94d67fc1e8b71e96e06215cedd03bdd1e2bcd92","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    be whatever args/kwargs you pass into the decorated command."},{"line_number":135,"context_line":"    \"\"\""},{"line_number":136,"context_line":"    def async_decorator(func):"},{"line_number":137,"context_line":"        @functools.wraps(func)"},{"line_number":138,"context_line":"        def wrapper(self, command_name, **command_params):"},{"line_number":139,"context_line":"            # Run a validator before passing everything off to async."},{"line_number":140,"context_line":"            # validators should raise exceptions or return silently."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FTow%3D","line":137,"updated":"2014-04-15 13:32:19.000000000","message":"It is really really really bad practice to change method signature!","commit_id":"07715e9d99df88dd413b40f034e93b6b3bfb1d88"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b9c9611ed0942c24d4aa7a4b2fe5674bd4dae202","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    be whatever args/kwargs you pass into the decorated command."},{"line_number":135,"context_line":"    \"\"\""},{"line_number":136,"context_line":"    def async_decorator(func):"},{"line_number":137,"context_line":"        @functools.wraps(func)"},{"line_number":138,"context_line":"        def wrapper(self, command_name, **command_params):"},{"line_number":139,"context_line":"            # Run a validator before passing everything off to async."},{"line_number":140,"context_line":"            # validators should raise exceptions or return silently."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FRWM%3D","line":137,"in_reply_to":"AAAAW3%2F%2FTow%3D","updated":"2014-04-15 16:40:49.000000000","message":"This is preexisitng stuff. I\u0027d suggest filing another bug or another merge req to fix it if there\u0027s a problem, but I don\u0027t wanna hold up Russell\u0027s changes for an unrelated, preexisting thing.","commit_id":"07715e9d99df88dd413b40f034e93b6b3bfb1d88"}],"ironic_python_agent/extensions/standby.py":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"3a0510f93a45b9cc62984a71bb02a69169986857","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    def prepare_image(self,"},{"line_number":173,"context_line":"                      image_info\u003dNone,"},{"line_number":174,"context_line":"                      metadata\u003dNone,"},{"line_number":175,"context_line":"                      files\u003dNone):"},{"line_number":176,"context_line":"        location \u003d _configdrive_location()"},{"line_number":177,"context_line":"        device \u003d hardware.get_manager().get_os_install_device()"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FTZE%3D","line":175,"updated":"2014-04-15 13:34:18.000000000","message":"Do you really need several lines here?","commit_id":"07715e9d99df88dd413b40f034e93b6b3bfb1d88"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b9c9611ed0942c24d4aa7a4b2fe5674bd4dae202","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    def prepare_image(self,"},{"line_number":173,"context_line":"                      image_info\u003dNone,"},{"line_number":174,"context_line":"                      metadata\u003dNone,"},{"line_number":175,"context_line":"                      files\u003dNone):"},{"line_number":176,"context_line":"        location \u003d _configdrive_location()"},{"line_number":177,"context_line":"        device \u003d hardware.get_manager().get_os_install_device()"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FRWc%3D","line":175,"in_reply_to":"AAAAW3%2F%2FTZE%3D","updated":"2014-04-15 16:40:49.000000000","message":"I actually really prefer things formatted like this; but honestly if pep8/hacking doesn\u0027t catch it we probably shouldn\u0027t enforce it.","commit_id":"07715e9d99df88dd413b40f034e93b6b3bfb1d88"}]}