)]}'
{"id":"openstack%2Fironic-python-agent~881659","triplet_id":"openstack%2Fironic-python-agent~stable%2Fyoga~I006535bf124379ed65443c7b283bc99ecc95568b","project":"openstack/ironic-python-agent","branch":"stable/yoga","attention_set":{},"removed_from_attention_set":{"11655":{"account":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"last_update":"2023-05-02 07:07:34.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I006535bf124379ed65443c7b283bc99ecc95568b","subject":"Fix UTF-16 result handling for efibootmgr","status":"MERGED","created":"2023-04-27 15:57:35.000000000","updated":"2023-05-02 07:08:34.000000000","submitted":"2023-05-02 07:07:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"881659","cherry_pick_of_change":881658,"cherry_pick_of_patch_set":1,"meta_rev_id":"f234be1eb88f1af24664b4a4f4900e4df453433f","_number":881659,"virtual_id_number":881659,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-05-02 07:07:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":2,"date":"2023-04-27 16:04:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":2,"date":"2023-05-02 05:08:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":1,"date":"2023-05-02 05:08:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-27 16:04:33.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2023-04-27 18:22:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-02 05:08:04.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"}],"messages":[{"id":"ae72b502f78c625663426e06ab0a107d61e45d51","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2023-04-27 15:57:35.000000000","message":"Patch Set 1: Cherry Picked from branch stable/zed.","accounts_in_message":[],"_revision_number":1},{"id":"65cceb9bbc488cbfeb5b173c4afe4a08d15dd551","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2023-04-27 16:04:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"dd59499cee3a6690f4fb9b0e0665f6ce579aa1c5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-27 18:22:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/32ba391f475e4a39afd4fe37b0856906\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/be69c86cb8e54354bb0ffc0716e21544 : SUCCESS in 4m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e0cc7f72a1244630b69001fd1dd39ccd : SUCCESS in 3m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a10c1b76ffe048c0a312640f8ab1abb1 : SUCCESS in 4m 08s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/78ecdfd8fadf470393fbf327a1b21c2a : SUCCESS in 5m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bf3f7d0c8c794b6387b72443b9ca0a50 : SUCCESS in 6m 26s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/aaa7fb7fea8d4be0b0f568998957f069 : SUCCESS in 3m 20s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/376c6d06a25f491f81637013eab21ed0 : SUCCESS in 3m 53s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/9d16a04bc50246b5a5094eb52cc27e10 : SUCCESS in 3m 55s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/8a5fa20cef0d479082d80cdf3077f927 : SUCCESS in 1h 33m 51s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/58ef7c43d9cc40cc80aea383393a09c9 : SUCCESS in 1h 53m 04s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/997523444aef48428e6837b9f76682af : SUCCESS in 1h 24m 32s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/6e53f1f16b814a17b02f9883165e10ff : SUCCESS in 1h 12m 35s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/64979a45aa744cd5a9705077acd26091 : SUCCESS in 21m 47s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/522fee1cc5f246438e63a79e51ab1afd : SUCCESS in 8m 53s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/9beaa076018f459aad3e626363cfadea : SUCCESS in 8m 36s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/b61891db3aad4885bc6abff1fee332af : SUCCESS in 2h 16m 15s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/dbec165da33f4afd811f69baeb32a0a5 : FAILURE in 4m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2586751ac20da7fad9593755827f1d02712538d8","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2023-05-02 05:08:04.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"833935809d2160a61ca3bd09c119df7234cfd840","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-02 05:08:44.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9d3ac87fdeee02eca1b4161ba4896e92132e3749","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-02 07:07:34.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/559ba64ae1224a2786232a9da794d965\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/985a7578446b4286bb66114667509160 : SUCCESS in 3m 58s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/735d2ef627674dc9aab71e6f67443b63 : SUCCESS in 3m 11s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/45666b7330b946b48b685da9dd16b90f : SUCCESS in 4m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8ca0f69293d7400c9c0de9674c7f3b71 : SUCCESS in 6m 35s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4f9eea018d4d4b3090b2872ba92315bc : SUCCESS in 3m 01s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/d110f56964cb47738096c680cf052a01 : SUCCESS in 4m 49s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/d1e6ccc15a70459489db21959dbb860b : SUCCESS in 55m 44s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/6fac289a8a66476ebb6cd4e984df92ac : SUCCESS in 1h 07m 46s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/e3b8b814eead4dd7ad5e72eb330d4534 : SUCCESS in 1h 01m 56s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/6eb46b239cba4741b686986b24836c65 : SUCCESS in 1h 32m 56s","accounts_in_message":[],"_revision_number":1},{"id":"6f886d47d3883c205df0af40024db0995549d410","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-02 07:07:34.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"f234be1eb88f1af24664b4a4f4900e4df453433f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-02 07:08:34.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1717517201cc4fe584f9e49b99c8b7de\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/968215e90f7743bfb80df6b6259bc596 : SUCCESS in 35s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6bb514b8b34244bbba1e6c9139570b2b : SUCCESS in 41s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9f84c8b3d1fa0e08bf1f799f37a11698f8da07a4","revisions":{"9f84c8b3d1fa0e08bf1f799f37a11698f8da07a4":{"kind":"REWORK","_number":1,"created":"2023-04-27 15:57:35.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/59/881659/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/59/881659/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/59/881659/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/59/881659/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/59/881659/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/59/881659/1"}}},"commit":{"parents":[{"commit":"8e77848c901e8a70295a41a355cb2b44a4793d06","subject":"Make reno ignore bugfix eol tags","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8e77848c901e8a70295a41a355cb2b44a4793d06"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2023-04-07 14:32:44.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2023-04-27 15:57:35.000000000","tz":0},"subject":"Fix UTF-16 result handling for efibootmgr","message":"Fix UTF-16 result handling for efibootmgr\n\nThe tl;dr is that UEFI NVRAM is in encoded\nin UTF-16, and when we run the efibootmgr command,\nwe can get unicode characters back.\n\nExcept we previously were forcing everything to be\ntreated as UTF-8 due to the way oslo.concurrency\u0027s\nprocessutils module works.\n\nThis could be observed with UTF character 0x00FF\nwhich raises up a nice exception when we try to\ndecode it.\n\nAnyhow! while fixing handling of this, we discovered\nwe could get basically the cruft out of the NVRAM,\nby getting what was most likey a truncated string\nout of our own test VMs. As such, we need to also\npermit decoding to be tollerant of failures.\nThis could be binary data or as simple as flipped\nbits which get interpretted invalid characters.\nAs such, we have introduced such data into one of our\ntests involving UEFI record de-duplication.\n\nCloses-Bug: 2015602\nChange-Id: I006535bf124379ed65443c7b283bc99ecc95568b\n(cherry picked from commit 76accfb880474445a5dcb07825889123b3dd0237)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9f84c8b3d1fa0e08bf1f799f37a11698f8da07a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9f84c8b3d1fa0e08bf1f799f37a11698f8da07a4"}]},"branch":"refs/heads/stable/yoga"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}