)]}'
{"id":"openstack%2Fironic-python-agent~881762","triplet_id":"openstack%2Fironic-python-agent~stable%2Fxena~I006535bf124379ed65443c7b283bc99ecc95568b","project":"openstack/ironic-python-agent","branch":"stable/xena","attention_set":{},"removed_from_attention_set":{"11655":{"account":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"last_update":"2023-05-02 07:07:36.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I006535bf124379ed65443c7b283bc99ecc95568b","subject":"Fix UTF-16 result handling for efibootmgr","status":"MERGED","created":"2023-04-27 21:28:21.000000000","updated":"2023-05-02 07:08:37.000000000","submitted":"2023-05-02 07:07:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"881762","meta_rev_id":"af3ef597df7b1c375f80110be94c2863b9f7c997","_number":881762,"virtual_id_number":881762,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-05-02 07:07:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":2,"date":"2023-04-27 21:31:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":2,"date":"2023-05-02 05:08:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":1,"date":"2023-05-02 05:08:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-27 21:31:22.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2023-04-27 23:09:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-02 05:08:52.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"}],"messages":[{"id":"0a2edaad718541d4f1f5bbd79f75af2486168c97","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2023-04-27 21:28:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e6634848e5aa8844661f8cd18a61b8b5e95ddd82","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2023-04-27 21:31:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"15eeeafe95a750b12795e7f7df46cb960c950905","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-27 23:09:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/72eb8e309a054ff194dbc4e3ba795ad1\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/240786886cbb45e586a6969631f73c84 : SUCCESS in 3m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2b94fa76e2cf43aebccb52b0e9f2474c : SUCCESS in 3m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e225bbed2fdf4a0c9cc6e96c27152170 : SUCCESS in 5m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1900fe41258b453d8dd82b688a1fec47 : SUCCESS in 3m 39s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/568e4fbec1e84b7faa69dbeee638146a : SUCCESS in 3m 36s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5682a096962c40b9ba3236cef0897463 : SUCCESS in 5m 44s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ec1f873002474a9096cc6952d73560fb : SUCCESS in 3m 09s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/aca1f969d5544eab945f7e59ec96b9b1 : SUCCESS in 3m 26s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/ea63b089f7864354a285d6c2a7f4e3e7 : SUCCESS in 3m 44s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/9074164a88724f2faaa91af707a19502 : SUCCESS in 1h 12m 29s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/05804b41ee1743388a3cf81ca7db53ae : SUCCESS in 1h 33m 02s (non-voting)\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/fc34a398c8894049bacfb0e4c9438b91 : SUCCESS in 1h 01m 08s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/bd037d6368be4483bb56ec4c53d5a450 : SUCCESS in 58m 08s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/3f8cb13a5a2942c19c26f3fdc5113026 : SUCCESS in 1h 05m 29s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/c6d1d8f4c76e4661ab2f234601dfbb3d : SUCCESS in 18m 09s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/fb12fa9f66e94a92a78256baa327a3d1 : SUCCESS in 8m 16s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/547d0836571f4de4a0c625508e932d8e : SUCCESS in 1h 40m 06s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/985cc6be0cd74f3498b80ef5907dc022 : FAILURE in 3m 36s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3abc6680a1d1577646cf460aef8ea04c84235a76","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2023-05-02 05:08:52.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4df637165f4c26c787f7e6bb6a87a5dee8986ab5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-02 05:09:29.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"242f80b0c0ecff8916c2bdd25b463636ab361f8d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-02 07:07:35.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6a8139795d334edda7e208bddb97f74d\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c00dc4fd246b4fefa17100dc323b066d : SUCCESS in 3m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8986fe6b68354f669ec8f86605212e0d : SUCCESS in 4m 17s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/894572a24444415ba8a2a8f1970e7d6b : SUCCESS in 4m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c23ce0a40dd149bc998228efe17c5184 : SUCCESS in 5m 45s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/254c1a4db3c84b17a62f94ed865ee642 : SUCCESS in 3m 07s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/d91c5a6a798c4b059d743264116cf568 : SUCCESS in 3m 42s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/20b618d62b81455a935f3b01a900717d : SUCCESS in 1h 03m 54s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/0bfa1814ac60416e9727519e2067b287 : SUCCESS in 57m 07s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/18ea3c2a80a246c8bcaf6cfe83677159 : SUCCESS in 59m 27s","accounts_in_message":[],"_revision_number":1},{"id":"8be3c027262354ff3b251eb2ef4b02e04aea0724","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-02 07:07:36.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"af3ef597df7b1c375f80110be94c2863b9f7c997","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-02 07:08:37.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c14c54479f3b4fc7b86a9a8c80b00690\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/af5ea86c0af64af682990d8ac309155d : SUCCESS in 43s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/7495e322123345d98e4da202244af707 : SUCCESS in 35s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d77424d7315e24390d6b159eab8dd9b3d4c56942","revisions":{"d77424d7315e24390d6b159eab8dd9b3d4c56942":{"kind":"REWORK","_number":1,"created":"2023-04-27 21:28:21.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/62/881762/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/62/881762/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/62/881762/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/62/881762/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/62/881762/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/62/881762/1"}}},"commit":{"parents":[{"commit":"6aa917d4b45c83bf8b6600b1138492d7e23dbaf5","subject":"Make reno ignore bugfix eol tags","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6aa917d4b45c83bf8b6600b1138492d7e23dbaf5"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2023-04-07 14:32:44.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2023-04-27 21:28:05.000000000","tz":-420},"subject":"Fix UTF-16 result handling for efibootmgr","message":"Fix UTF-16 result handling for efibootmgr\n\nThe tl;dr is that UEFI NVRAM is in encoded\nin UTF-16, and when we run the efibootmgr command,\nwe can get unicode characters back.\n\nExcept we previously were forcing everything to be\ntreated as UTF-8 due to the way oslo.concurrency\u0027s\nprocessutils module works.\n\nThis could be observed with UTF character 0x00FF\nwhich raises up a nice exception when we try to\ndecode it.\n\nAnyhow! while fixing handling of this, we discovered\nwe could get basically the cruft out of the NVRAM,\nby getting what was most likey a truncated string\nout of our own test VMs. As such, we need to also\npermit decoding to be tollerant of failures.\nThis could be binary data or as simple as flipped\nbits which get interpretted invalid characters.\nAs such, we have introduced such data into one of our\ntests involving UEFI record de-duplication.\n\nCloses-Bug: 2015602\nChange-Id: I006535bf124379ed65443c7b283bc99ecc95568b\n(cherry picked from commit 76accfb880474445a5dcb07825889123b3dd0237)\n(cherry picked from commit 9f84c8b3d1fa0e08bf1f799f37a11698f8da07a4)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d77424d7315e24390d6b159eab8dd9b3d4c56942"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d77424d7315e24390d6b159eab8dd9b3d4c56942"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}