)]}'
{"id":"openstack%2Fironic-python-agent~881763","triplet_id":"openstack%2Fironic-python-agent~stable%2Fwallaby~I006535bf124379ed65443c7b283bc99ecc95568b","project":"openstack/ironic-python-agent","branch":"stable/wallaby","attention_set":{},"removed_from_attention_set":{"11655":{"account":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"last_update":"2023-05-02 07:07:37.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I006535bf124379ed65443c7b283bc99ecc95568b","subject":"Fix UTF-16 result handling for efibootmgr","status":"MERGED","created":"2023-04-27 21:48:56.000000000","updated":"2023-05-02 07:08:39.000000000","submitted":"2023-05-02 07:07:37.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"881763","meta_rev_id":"d297fd1d05e8f3b56c1b02b760112f9a9fb8529c","_number":881763,"virtual_id_number":881763,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-05-02 07:07:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2023-05-02 05:11:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":2,"date":"2023-04-27 22:16:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-05-02 05:11:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-27 22:16:02.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2023-04-27 23:46:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-02 05:11:29.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"}],"messages":[{"id":"b527717551cfdb3e9aafa4cd9cacde87d06682d3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2023-04-27 21:48:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"048e284cf631cb7bb6ab04721bb034a4e21f712b","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2023-04-27 22:16:02.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"323763013c047ed402ee40bc2d6dd7db87a94eb9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-27 23:46:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c677107167aa48f88c9fe07b7c381af7\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e184f5c1019847c8b05af319a7f4d8f1 : SUCCESS in 6m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a47e4deb97bd422293c8a4edf22c86ce : SUCCESS in 3m 54s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4111af0220404e6f8002c49bb6d78f35 : SUCCESS in 3m 41s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6c03bf3a64064434a81d1469029faaf2 : SUCCESS in 4m 07s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b4c9b968246248e6a358cc4991f164f1 : SUCCESS in 3m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/839aa9d7e43847d38d36146103cf0de5 : SUCCESS in 7m 53s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ea0797c4e9b341539c3afee62be209a6 : SUCCESS in 2m 50s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/ba44d7089a664fa989ea0226ba72572c : SUCCESS in 3m 36s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/127f234d071042f0bc50c0550ebcc0f7 : SUCCESS in 3m 34s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/2f960379cfd248f5ba98515dbc7119e9 : SUCCESS in 1h 35m 43s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/40c24f0aa2df429f8f198a2acf52cbc5 : SUCCESS in 1h 08m 50s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/e6f30ad742854fa982ba514e753a2c6b : SUCCESS in 1h 39m 42s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/6823a8b8263d45c49180447bfe33cfdb : SUCCESS in 1h 49m 43s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/6c0aaacf6c5341769f447ce328e47113 : SUCCESS in 1h 26m 52s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/7820d5b0dcaf4312bdf48d84c42e350a : SUCCESS in 1h 15m 04s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/6d1fabbcddc944159125128e37c916a8 : SUCCESS in 14m 52s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/d416ec8684784d968d18d8dcbefc470a : SUCCESS in 9m 03s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/20c3eae870d741d7a01d8a34d8cb7ec5 : SUCCESS in 1h 50m 44s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/cf70290828654cac97ae65cb78e53a30 : FAILURE in 3m 48s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e4c25caa388bbd8f43363d82e2e69aa681407217","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2023-05-02 05:11:29.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e9c93190d1739400be5477cea31d6022f1597111","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-02 05:12:10.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"4d57d09a796a9dac9e021c5843327a64e278a79a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-02 07:07:37.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cfae409221494fc7a25914093355e7f9\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ffaa36cfbb4a41cbba84f58764c0fef3 : SUCCESS in 3m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/dc47fc32dcda4217aa71034ec9103b8f : SUCCESS in 4m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e4dfef78f08e48979add9760e2c4aa84 : SUCCESS in 3m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5f4277a572af45dd91f12bca75fb2117 : SUCCESS in 6m 49s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f46d98a495da43c18dae5c84b35bd165 : SUCCESS in 3m 48s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/8dc39218702e42d6a150faf924ad6661 : SUCCESS in 3m 17s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/3cf673a9191145d1a577c55a4290f69d : SUCCESS in 1h 05m 06s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/66a5e2c43ac64208b772379735c58299 : SUCCESS in 55m 56s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/b7db91fe94614f2699a4f8e257e3f74b : SUCCESS in 1h 26m 35s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/339b5b67ee9d4deaaa57b5dc09341357 : SUCCESS in 1h 26m 48s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/7e5913803bf5444aa11d738feab72bbf : SUCCESS in 1h 04m 53s","accounts_in_message":[],"_revision_number":1},{"id":"086ffe5d46c16166438c63259317692a1af2cf98","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-02 07:07:37.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"d297fd1d05e8f3b56c1b02b760112f9a9fb8529c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-02 07:08:39.000000000","message":"Patch Set 1:\n\nBuild failed (promote pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/69a57826ac99425ba69a66865558550d\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4dee6d9aae8d488cbe20921fdd6910a8 : SUCCESS in 41s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9a869e025adf48e8b8eb957f4249af06 : FAILURE in 36s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e1813e14b7d7783b628dbd0169faa328c59ed2ce","revisions":{"e1813e14b7d7783b628dbd0169faa328c59ed2ce":{"kind":"REWORK","_number":1,"created":"2023-04-27 21:48:56.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/63/881763/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/63/881763/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/881763/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/881763/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/881763/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/63/881763/1"}}},"commit":{"parents":[{"commit":"9619ceb46f31892ffdbb5273189089fdf3cb9341","subject":"Make reno ignore bugfix eol tags","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9619ceb46f31892ffdbb5273189089fdf3cb9341"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2023-04-07 14:32:44.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2023-04-27 21:48:10.000000000","tz":-420},"subject":"Fix UTF-16 result handling for efibootmgr","message":"Fix UTF-16 result handling for efibootmgr\n\nThe tl;dr is that UEFI NVRAM is in encoded\nin UTF-16, and when we run the efibootmgr command,\nwe can get unicode characters back.\n\nExcept we previously were forcing everything to be\ntreated as UTF-8 due to the way oslo.concurrency\u0027s\nprocessutils module works.\n\nThis could be observed with UTF character 0x00FF\nwhich raises up a nice exception when we try to\ndecode it.\n\nAnyhow! while fixing handling of this, we discovered\nwe could get basically the cruft out of the NVRAM,\nby getting what was most likey a truncated string\nout of our own test VMs. As such, we need to also\npermit decoding to be tollerant of failures.\nThis could be binary data or as simple as flipped\nbits which get interpretted invalid characters.\nAs such, we have introduced such data into one of our\ntests involving UEFI record de-duplication.\n\nNOTE: One of the unit tests from the stable/xena backport\nwere removed, as software raid was still in-flight at the\nend of Wallaby.\n\nCloses-Bug: 2015602\nChange-Id: I006535bf124379ed65443c7b283bc99ecc95568b\n(cherry picked from commit 76accfb880474445a5dcb07825889123b3dd0237)\n(cherry picked from commit 9f84c8b3d1fa0e08bf1f799f37a11698f8da07a4)\n(cherry picked from commit d77424d7315e24390d6b159eab8dd9b3d4c56942)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e1813e14b7d7783b628dbd0169faa328c59ed2ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e1813e14b7d7783b628dbd0169faa328c59ed2ce"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}