)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6dc1cb65d5e675f1da4ac0d79b93a85002e3e744","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3dbd1ba5_e26b9b87","updated":"2023-06-07 18:00:29.000000000","message":"recheck current logs required","commit_id":"e6fd7e753e3895ba420801099a380717b2100862"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e4b5568de7c59e11ac5b6e037695e6642cc0539b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"90891384_44262206","updated":"2023-07-11 23:23:12.000000000","message":"recheck ipa-tempest-uefi-redfish-vmedia-src passed last time","commit_id":"e6fd7e753e3895ba420801099a380717b2100862"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"94e47fed85fa50830d86020b0aec45b141307864","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"738ed468_7f81d8c1","updated":"2023-07-11 10:54:30.000000000","message":"recheck ironic-standalone job should be fixed","commit_id":"e6fd7e753e3895ba420801099a380717b2100862"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3d7e3d7e221722c934855253bc1aab7887ca60f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"90b5585b_85a32d01","updated":"2023-07-11 14:36:15.000000000","message":"recheck that job passed last time; see if it\u0027s a fluke","commit_id":"e6fd7e753e3895ba420801099a380717b2100862"}],"ironic_python_agent/agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"15f7f5db7e789920a449658d2e8de69bdee7c8c3","unresolved":true,"context_lines":[{"line_number":411,"context_line":"        md5_allowed \u003d config.get(\u0027agent_md5_checksum_enable\u0027)"},{"line_number":412,"context_line":"        if md5_allowed is not None:"},{"line_number":413,"context_line":"            if md5_allowed:"},{"line_number":414,"context_line":"                setattr(cfg.CONF, \u0027md5_enabled\u0027, True)"},{"line_number":415,"context_line":"            else:"},{"line_number":416,"context_line":"                setattr(cfg.CONF, \u0027md5_enabled\u0027, False)"},{"line_number":417,"context_line":"        if config.get(\u0027agent_token_required\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b8b59969_1d00a33c","line":414,"updated":"2023-05-05 07:06:38.000000000","message":"Probably:\n\n cfg.CONF.set_override(\u0027md5_enabled\u0027, md5_allowed)\n \n(now that you actually have the config object)","commit_id":"0a76077f9c1714654a9e5f0568cdff68edda1767"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ca0776526914871a97d0a6798a11b52803274156","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        md5_allowed \u003d config.get(\u0027agent_md5_checksum_enable\u0027)"},{"line_number":412,"context_line":"        if md5_allowed is not None:"},{"line_number":413,"context_line":"            if md5_allowed:"},{"line_number":414,"context_line":"                setattr(cfg.CONF, \u0027md5_enabled\u0027, True)"},{"line_number":415,"context_line":"            else:"},{"line_number":416,"context_line":"                setattr(cfg.CONF, \u0027md5_enabled\u0027, False)"},{"line_number":417,"context_line":"        if config.get(\u0027agent_token_required\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"784ddc3e_b3277b7d","line":414,"in_reply_to":"ade318e5_c2594f86","updated":"2023-05-25 14:59:43.000000000","message":"well, dunno, it seems to be good now. who knows.","commit_id":"0a76077f9c1714654a9e5f0568cdff68edda1767"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c10e6d0f796deed4129fb29e03e881860c23b705","unresolved":true,"context_lines":[{"line_number":411,"context_line":"        md5_allowed \u003d config.get(\u0027agent_md5_checksum_enable\u0027)"},{"line_number":412,"context_line":"        if md5_allowed is not None:"},{"line_number":413,"context_line":"            if md5_allowed:"},{"line_number":414,"context_line":"                setattr(cfg.CONF, \u0027md5_enabled\u0027, True)"},{"line_number":415,"context_line":"            else:"},{"line_number":416,"context_line":"                setattr(cfg.CONF, \u0027md5_enabled\u0027, False)"},{"line_number":417,"context_line":"        if config.get(\u0027agent_token_required\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f8335f79_71c64656","line":414,"in_reply_to":"b8b59969_1d00a33c","updated":"2023-05-08 15:37:38.000000000","message":"I\u0027m fairly sure it doesn\u0027t work, because we couldn\u0027t get it to work even with unit tests without changing over to setattr. Turns out this has happened before, and I remember hitting this before.","commit_id":"0a76077f9c1714654a9e5f0568cdff68edda1767"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1255cc3406b6bf49da8454570d6aa7692b4c0a40","unresolved":true,"context_lines":[{"line_number":411,"context_line":"        md5_allowed \u003d config.get(\u0027agent_md5_checksum_enable\u0027)"},{"line_number":412,"context_line":"        if md5_allowed is not None:"},{"line_number":413,"context_line":"            if md5_allowed:"},{"line_number":414,"context_line":"                setattr(cfg.CONF, \u0027md5_enabled\u0027, True)"},{"line_number":415,"context_line":"            else:"},{"line_number":416,"context_line":"                setattr(cfg.CONF, \u0027md5_enabled\u0027, False)"},{"line_number":417,"context_line":"        if config.get(\u0027agent_token_required\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ade318e5_c2594f86","line":414,"in_reply_to":"f8335f79_71c64656","updated":"2023-05-10 13:13:26.000000000","message":"It could be because we wipe overrides in unit tests (while setattr interferes with the normal way config options are handled).","commit_id":"0a76077f9c1714654a9e5f0568cdff68edda1767"}]}
