)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"26ee220098e5f1fe093385738c014a5e27d8bfd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"72afa1a7_1ac49e2f","updated":"2023-07-06 15:31:27.000000000","message":"lgtm, but the ironic-standalone-ipa-src is failing same as ironic-standalone \u003d(","commit_id":"9ccac8b47639b0abaeca71fa887fb15770908b11"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ab449a283cc0cc8cc2c45aea030cb1890dd0300b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c223b11c_a25f4ef2","updated":"2023-07-12 19:46:55.000000000","message":"recheck ironic\u0027s standalone jobs are green again","commit_id":"9ccac8b47639b0abaeca71fa887fb15770908b11"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f2165c0c7eeb2d6c797002df0c321f1c568a8999","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cca1f12f_31c5e367","updated":"2023-07-17 17:07:31.000000000","message":"recheck unrelated failure","commit_id":"9ccac8b47639b0abaeca71fa887fb15770908b11"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"61446a450049bce2382f87df5bedb1c97c418224","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e160dafa_60a9e7fc","updated":"2023-07-18 02:01:02.000000000","message":"Some nits, and a suggestion which might be out of scope for this change","commit_id":"4589aaebc32acf20f6a09f0ea071109cb68d887d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"192789456a68a28f971f9a2475d6639ad7dba526","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"54da8242_a201fea4","updated":"2023-07-19 16:20:56.000000000","message":"I pushed a trivial spelling fix; still +2\u0027ing","commit_id":"c65ad42ff1571a4658bc64c12093b0dc4320c805"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"28167ed113154380a7c6824e8b3d0cb962dac2d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"07571549_cc4545ce","updated":"2023-07-26 13:57:49.000000000","message":"recheck prior jobs failed due to connectivity issues it seems.","commit_id":"c65ad42ff1571a4658bc64c12093b0dc4320c805"}],"ironic_python_agent/extensions/standby.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"61446a450049bce2382f87df5bedb1c97c418224","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            if resp.status_code !\u003d 200:"},{"line_number":85,"context_line":"                msg \u003d (\u0027Received status code {} from {}, expected 200. \u0027"},{"line_number":86,"context_line":"                       \u0027Response body: {}\u0027).format(resp.status_code, url,"},{"line_number":87,"context_line":"                                                   resp.text)"},{"line_number":88,"context_line":"                raise errors.ImageDownloadError(image_id, msg)"},{"line_number":89,"context_line":"        except (errors.ImageDownloadError, requests.RequestException) as e:"},{"line_number":90,"context_line":"            if (attempt \u003d\u003d CONF.image_download_connection_retries"}],"source_content_type":"text/x-python","patch_set":4,"id":"45c731df_4693b3b4","line":87,"updated":"2023-07-18 02:01:02.000000000","message":"How about also LOG.debug every response header here? Like if Transfer-Encoding: chunked is set that would explain why Content-Length is missing in some cases.","commit_id":"4589aaebc32acf20f6a09f0ea071109cb68d887d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bdcb6bb52566aeea09d4d8c1b13ee1a41f8814a8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            if resp.status_code !\u003d 200:"},{"line_number":85,"context_line":"                msg \u003d (\u0027Received status code {} from {}, expected 200. \u0027"},{"line_number":86,"context_line":"                       \u0027Response body: {}\u0027).format(resp.status_code, url,"},{"line_number":87,"context_line":"                                                   resp.text)"},{"line_number":88,"context_line":"                raise errors.ImageDownloadError(image_id, msg)"},{"line_number":89,"context_line":"        except (errors.ImageDownloadError, requests.RequestException) as e:"},{"line_number":90,"context_line":"            if (attempt \u003d\u003d CONF.image_download_connection_retries"}],"source_content_type":"text/x-python","patch_set":4,"id":"36182eb0_9daa2c7f","line":87,"in_reply_to":"221fa3ca_33a61790","updated":"2023-07-18 13:34:06.000000000","message":"Done","commit_id":"4589aaebc32acf20f6a09f0ea071109cb68d887d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"244f268c9188f94c5877afa9e5353a56646ae9f5","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            if resp.status_code !\u003d 200:"},{"line_number":85,"context_line":"                msg \u003d (\u0027Received status code {} from {}, expected 200. \u0027"},{"line_number":86,"context_line":"                       \u0027Response body: {}\u0027).format(resp.status_code, url,"},{"line_number":87,"context_line":"                                                   resp.text)"},{"line_number":88,"context_line":"                raise errors.ImageDownloadError(image_id, msg)"},{"line_number":89,"context_line":"        except (errors.ImageDownloadError, requests.RequestException) as e:"},{"line_number":90,"context_line":"            if (attempt \u003d\u003d CONF.image_download_connection_retries"}],"source_content_type":"text/x-python","patch_set":4,"id":"221fa3ca_33a61790","line":87,"in_reply_to":"45c731df_4693b3b4","updated":"2023-07-18 03:12:01.000000000","message":"Reasonable. I don\u0027t see why it would be an issue.","commit_id":"4589aaebc32acf20f6a09f0ea071109cb68d887d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"61446a450049bce2382f87df5bedb1c97c418224","unresolved":true,"context_lines":[{"line_number":478,"context_line":"                self._last_chunk_time \u003d time.time()"},{"line_number":479,"context_line":"                if isinstance(chunk, str):"},{"line_number":480,"context_line":"                    self._hash_algo.update(chunk.encode())"},{"line_number":481,"context_line":"                    self._bytes_transferred +\u003d len(chunk.encode())"},{"line_number":482,"context_line":"                else:"},{"line_number":483,"context_line":"                    self._hash_algo.update(chunk)"},{"line_number":484,"context_line":"                    self._bytes_transferred +\u003d len(chunk)"}],"source_content_type":"text/x-python","patch_set":4,"id":"77d4aff8_0df2e53e","line":481,"updated":"2023-07-18 02:01:02.000000000","message":"How about encode into a variable so it is only required once?","commit_id":"4589aaebc32acf20f6a09f0ea071109cb68d887d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"244f268c9188f94c5877afa9e5353a56646ae9f5","unresolved":true,"context_lines":[{"line_number":478,"context_line":"                self._last_chunk_time \u003d time.time()"},{"line_number":479,"context_line":"                if isinstance(chunk, str):"},{"line_number":480,"context_line":"                    self._hash_algo.update(chunk.encode())"},{"line_number":481,"context_line":"                    self._bytes_transferred +\u003d len(chunk.encode())"},{"line_number":482,"context_line":"                else:"},{"line_number":483,"context_line":"                    self._hash_algo.update(chunk)"},{"line_number":484,"context_line":"                    self._bytes_transferred +\u003d len(chunk)"}],"source_content_type":"text/x-python","patch_set":4,"id":"aacf4ecf_4f510c1e","line":481,"in_reply_to":"77d4aff8_0df2e53e","updated":"2023-07-18 03:12:01.000000000","message":"I\u0027m not sure I grok what your thinking. The issue is we get a chunk and yield it to the caller as part of an iterator.","commit_id":"4589aaebc32acf20f6a09f0ea071109cb68d887d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bdcb6bb52566aeea09d4d8c1b13ee1a41f8814a8","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                self._last_chunk_time \u003d time.time()"},{"line_number":479,"context_line":"                if isinstance(chunk, str):"},{"line_number":480,"context_line":"                    self._hash_algo.update(chunk.encode())"},{"line_number":481,"context_line":"                    self._bytes_transferred +\u003d len(chunk.encode())"},{"line_number":482,"context_line":"                else:"},{"line_number":483,"context_line":"                    self._hash_algo.update(chunk)"},{"line_number":484,"context_line":"                    self._bytes_transferred +\u003d len(chunk)"}],"source_content_type":"text/x-python","patch_set":4,"id":"b9c981e9_3077cc53","line":481,"in_reply_to":"aacf4ecf_4f510c1e","updated":"2023-07-18 13:34:06.000000000","message":"Oh, I think I get what your saying, call encode once. Yeah, that makes sense.","commit_id":"4589aaebc32acf20f6a09f0ea071109cb68d887d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"61446a450049bce2382f87df5bedb1c97c418224","unresolved":true,"context_lines":[{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    @property"},{"line_number":522,"context_line":"    def bytes_transferred(self):"},{"line_number":523,"context_line":"        \"\"\"Propety value to return the number of bytes transferred.\"\"\""},{"line_number":524,"context_line":"        return self._bytes_transferred"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac0dca3_f3437d67","line":523,"range":{"start_line":523,"start_character":11,"end_line":523,"end_character":18},"updated":"2023-07-18 02:01:02.000000000","message":"Property","commit_id":"4589aaebc32acf20f6a09f0ea071109cb68d887d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bdcb6bb52566aeea09d4d8c1b13ee1a41f8814a8","unresolved":false,"context_lines":[{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    @property"},{"line_number":522,"context_line":"    def bytes_transferred(self):"},{"line_number":523,"context_line":"        \"\"\"Propety value to return the number of bytes transferred.\"\"\""},{"line_number":524,"context_line":"        return self._bytes_transferred"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":4,"id":"550149f4_9bdc5a6a","line":523,"range":{"start_line":523,"start_character":11,"end_line":523,"end_character":18},"in_reply_to":"dac0dca3_f3437d67","updated":"2023-07-18 13:34:06.000000000","message":"Done","commit_id":"4589aaebc32acf20f6a09f0ea071109cb68d887d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"61446a450049bce2382f87df5bedb1c97c418224","unresolved":true,"context_lines":[{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    @property"},{"line_number":527,"context_line":"    def content_length(self):"},{"line_number":528,"context_line":"        \"\"\"Propety value to return the server indicated length.\"\"\""},{"line_number":529,"context_line":"        # If none, there is nothing we can do, the server didn\u0027t have"},{"line_number":530,"context_line":"        # a response."},{"line_number":531,"context_line":"        return self._expected_size"}],"source_content_type":"text/x-python","patch_set":4,"id":"586af4cc_1c95ea03","line":528,"range":{"start_line":528,"start_character":11,"end_line":528,"end_character":18},"updated":"2023-07-18 02:01:02.000000000","message":"Property","commit_id":"4589aaebc32acf20f6a09f0ea071109cb68d887d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bdcb6bb52566aeea09d4d8c1b13ee1a41f8814a8","unresolved":false,"context_lines":[{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    @property"},{"line_number":527,"context_line":"    def content_length(self):"},{"line_number":528,"context_line":"        \"\"\"Propety value to return the server indicated length.\"\"\""},{"line_number":529,"context_line":"        # If none, there is nothing we can do, the server didn\u0027t have"},{"line_number":530,"context_line":"        # a response."},{"line_number":531,"context_line":"        return self._expected_size"}],"source_content_type":"text/x-python","patch_set":4,"id":"958bd2a7_4b8ec9f3","line":528,"range":{"start_line":528,"start_character":11,"end_line":528,"end_character":18},"in_reply_to":"586af4cc_1c95ea03","updated":"2023-07-18 13:34:06.000000000","message":"Done","commit_id":"4589aaebc32acf20f6a09f0ea071109cb68d887d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"92603f18bf29cd2968553c566553b483775900a7","unresolved":true,"context_lines":[{"line_number":83,"context_line":"                                timeout\u003dCONF.image_download_connection_timeout)"},{"line_number":84,"context_line":"            if resp.status_code !\u003d 200:"},{"line_number":85,"context_line":"                msg \u003d (\u0027Received status code {} from {}, expected 200. \u0027"},{"line_number":86,"context_line":"                       \u0027Response body: {} Respones headers: {}\u0027).format("},{"line_number":87,"context_line":"                    resp.status_code, url, resp.text, resp.headers)"},{"line_number":88,"context_line":"                raise errors.ImageDownloadError(image_id, msg)"},{"line_number":89,"context_line":"        except (errors.ImageDownloadError, requests.RequestException) as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"e0d94e22_0d8c61d7","line":86,"updated":"2023-07-19 16:20:44.000000000","message":"sp: Response","commit_id":"98b0845e32245124727278cbaf19fb2565c03146"}]}
