)]}'
{"ironic_python_agent/config.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"521f9e40c0171d1ef4edb2a10a26cd0314d1d413","unresolved":true,"context_lines":[{"line_number":338,"context_line":"               help\u003d\u0027Time in seconds to wait for an HTTP request TCP socket \u0027"},{"line_number":339,"context_line":"                    \u0027used by an API request to a remote service to enter \u0027"},{"line_number":340,"context_line":"                    \u0027a state where a request can be transmitted.\u0027),"},{"line_number":341,"context_line":"    cfg.BoolOpt(\u0027force_config_drive_rebuild\u0027,"},{"line_number":342,"context_line":"                # NOTE(TheJulia): To test, change to false."},{"line_number":343,"context_line":"                default\u003dTrue,"},{"line_number":344,"context_line":"                help\u003d\u0027If the agent should rebuild the configuration drive \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"ea8a2dad_0f3d9347","line":341,"updated":"2023-07-25 22:11:44.000000000","message":"Its possible once things settle down we\u0027ll want to switch to rebuild by default, as it will be more robust. How about a slightly less scary config name like rebuild_config_drive","commit_id":"4889303fb6ce6f41b2f1d39e39b857dd6f48b300"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7187b5d384358fe72dfcd4b4d0f328db0399c3fd","unresolved":false,"context_lines":[{"line_number":338,"context_line":"               help\u003d\u0027Time in seconds to wait for an HTTP request TCP socket \u0027"},{"line_number":339,"context_line":"                    \u0027used by an API request to a remote service to enter \u0027"},{"line_number":340,"context_line":"                    \u0027a state where a request can be transmitted.\u0027),"},{"line_number":341,"context_line":"    cfg.BoolOpt(\u0027force_config_drive_rebuild\u0027,"},{"line_number":342,"context_line":"                # NOTE(TheJulia): To test, change to false."},{"line_number":343,"context_line":"                default\u003dTrue,"},{"line_number":344,"context_line":"                help\u003d\u0027If the agent should rebuild the configuration drive \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"8cdafdde_6585e14f","line":341,"in_reply_to":"ea8a2dad_0f3d9347","updated":"2023-08-24 15:11:48.000000000","message":"Done","commit_id":"4889303fb6ce6f41b2f1d39e39b857dd6f48b300"}],"ironic_python_agent/partition_utils.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5afd258dc12a2a2e915e6bcc2378577333873852","unresolved":true,"context_lines":[{"line_number":480,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":481,"context_line":"        # If the configdrive was requested make sure we delete the file"},{"line_number":482,"context_line":"        # after copying the content to the partition"},{"line_number":483,"context_line":"        if confdrive_file:"},{"line_number":484,"context_line":"            utils.unlink_without_raise(confdrive_file)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    if (confdrive_file and not _does_config_drive_works("},{"line_number":487,"context_line":"            config_drive_part)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"8c64e41b_f3590881","line":484,"range":{"start_line":483,"start_character":0,"end_line":484,"end_character":54},"updated":"2023-07-18 20:35:12.000000000","message":"delete this and move the comment down to #493?","commit_id":"43d6f8ffabe870baaea6145c80a1323808e28b89"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b18078943e7c643662cc4f98cfb3796ad687bc1d","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":481,"context_line":"        # If the configdrive was requested make sure we delete the file"},{"line_number":482,"context_line":"        # after copying the content to the partition"},{"line_number":483,"context_line":"        if confdrive_file:"},{"line_number":484,"context_line":"            utils.unlink_without_raise(confdrive_file)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    if (confdrive_file and not _does_config_drive_works("},{"line_number":487,"context_line":"            config_drive_part)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"349e249a_7d81ede3","line":484,"range":{"start_line":483,"start_character":0,"end_line":484,"end_character":54},"in_reply_to":"866b0901_756ebb29","updated":"2023-07-27 18:56:20.000000000","message":"Done","commit_id":"43d6f8ffabe870baaea6145c80a1323808e28b89"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"311a1ee19c6a6f245ea5439ff7bf996f0d949188","unresolved":true,"context_lines":[{"line_number":480,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":481,"context_line":"        # If the configdrive was requested make sure we delete the file"},{"line_number":482,"context_line":"        # after copying the content to the partition"},{"line_number":483,"context_line":"        if confdrive_file:"},{"line_number":484,"context_line":"            utils.unlink_without_raise(confdrive_file)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    if (confdrive_file and not _does_config_drive_works("},{"line_number":487,"context_line":"            config_drive_part)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"866b0901_756ebb29","line":484,"range":{"start_line":483,"start_character":0,"end_line":484,"end_character":54},"in_reply_to":"8c64e41b_f3590881","updated":"2023-07-19 14:10:14.000000000","message":"Oh yes, good catch. I forgot to do this.","commit_id":"43d6f8ffabe870baaea6145c80a1323808e28b89"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5afd258dc12a2a2e915e6bcc2378577333873852","unresolved":true,"context_lines":[{"line_number":506,"context_line":"        # Why: If the filesystem is ISO9660 or vfat, and the logical sector"},{"line_number":507,"context_line":"        # size which is supported is *not* something which supports 512 bytes,"},{"line_number":508,"context_line":"        # i.e. a 4k Block size, then ISO9660 just will not work. Vfat also"},{"line_number":509,"context_line":"        # will not work because the logical size needs to match the logical"},{"line_number":510,"context_line":"        # size."},{"line_number":511,"context_line":"        utils.execute(\u0027mount\u0027, \u0027-o\u0027, \u0027ro\u0027, \u0027-t\u0027, \u0027auto\u0027, config_drive_part,"},{"line_number":512,"context_line":"                      temp_folder)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5486c38f_7ed0da07","line":509,"range":{"start_line":509,"start_character":68,"end_line":509,"end_character":75},"updated":"2023-07-18 20:35:12.000000000","message":"physical?","commit_id":"43d6f8ffabe870baaea6145c80a1323808e28b89"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"311a1ee19c6a6f245ea5439ff7bf996f0d949188","unresolved":true,"context_lines":[{"line_number":506,"context_line":"        # Why: If the filesystem is ISO9660 or vfat, and the logical sector"},{"line_number":507,"context_line":"        # size which is supported is *not* something which supports 512 bytes,"},{"line_number":508,"context_line":"        # i.e. a 4k Block size, then ISO9660 just will not work. Vfat also"},{"line_number":509,"context_line":"        # will not work because the logical size needs to match the logical"},{"line_number":510,"context_line":"        # size."},{"line_number":511,"context_line":"        utils.execute(\u0027mount\u0027, \u0027-o\u0027, \u0027ro\u0027, \u0027-t\u0027, \u0027auto\u0027, config_drive_part,"},{"line_number":512,"context_line":"                      temp_folder)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c9f850c6_300ca2d0","line":509,"range":{"start_line":509,"start_character":68,"end_line":509,"end_character":75},"in_reply_to":"5486c38f_7ed0da07","updated":"2023-07-19 14:10:14.000000000","message":"Well, there are two layers. There is the physical block size. Then there is logical. Both can be 4k. Even my laptop reports them as 4k, but if you go ask the smallest block logical block size transaction on my laptop, you get 512 bytes. Given this is a newer storage driver, I think it doesn\u0027t quite support that last pattern, and I think that is where this whole base issue is rooted.","commit_id":"43d6f8ffabe870baaea6145c80a1323808e28b89"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"453ff9e6db5174ea5972b2516167b580f3162c5c","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        # Why: If the filesystem is ISO9660 or vfat, and the logical sector"},{"line_number":507,"context_line":"        # size which is supported is *not* something which supports 512 bytes,"},{"line_number":508,"context_line":"        # i.e. a 4k Block size, then ISO9660 just will not work. Vfat also"},{"line_number":509,"context_line":"        # will not work because the logical size needs to match the logical"},{"line_number":510,"context_line":"        # size."},{"line_number":511,"context_line":"        utils.execute(\u0027mount\u0027, \u0027-o\u0027, \u0027ro\u0027, \u0027-t\u0027, \u0027auto\u0027, config_drive_part,"},{"line_number":512,"context_line":"                      temp_folder)"}],"source_content_type":"text/x-python","patch_set":2,"id":"19aa9d3e_5af03ef8","line":509,"range":{"start_line":509,"start_character":68,"end_line":509,"end_character":75},"in_reply_to":"c9f850c6_300ca2d0","updated":"2023-07-25 18:43:29.000000000","message":"Done","commit_id":"43d6f8ffabe870baaea6145c80a1323808e28b89"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5afd258dc12a2a2e915e6bcc2378577333873852","unresolved":true,"context_lines":[{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    try:"},{"line_number":566,"context_line":"        utils.execute(\u0027umount\u0027, conf_drive_temp)"},{"line_number":567,"context_line":"        utils.execute(\u0027umount\u0027, new_drive_temp)"},{"line_number":568,"context_line":"    finally:"},{"line_number":569,"context_line":"        utils.unlink_without_raise(new_drive_temp)"},{"line_number":570,"context_line":"        utils.unlink_without_raise(conf_drive_temp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8a02668d_abf935e2","line":567,"updated":"2023-07-18 20:35:12.000000000","message":"Maybe break these out into separate try/finally, and also put these in the finally for the try on line #537","commit_id":"43d6f8ffabe870baaea6145c80a1323808e28b89"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"453ff9e6db5174ea5972b2516167b580f3162c5c","unresolved":true,"context_lines":[{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    try:"},{"line_number":566,"context_line":"        utils.execute(\u0027umount\u0027, conf_drive_temp)"},{"line_number":567,"context_line":"        utils.execute(\u0027umount\u0027, new_drive_temp)"},{"line_number":568,"context_line":"    finally:"},{"line_number":569,"context_line":"        utils.unlink_without_raise(new_drive_temp)"},{"line_number":570,"context_line":"        utils.unlink_without_raise(conf_drive_temp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0b2a5adc_2bedccdf","line":567,"in_reply_to":"3d0d8d05_9d9ca1d7","updated":"2023-07-25 18:43:29.000000000","message":"Also if the un-mount fails, it is not horrible.","commit_id":"43d6f8ffabe870baaea6145c80a1323808e28b89"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"311a1ee19c6a6f245ea5439ff7bf996f0d949188","unresolved":true,"context_lines":[{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    try:"},{"line_number":566,"context_line":"        utils.execute(\u0027umount\u0027, conf_drive_temp)"},{"line_number":567,"context_line":"        utils.execute(\u0027umount\u0027, new_drive_temp)"},{"line_number":568,"context_line":"    finally:"},{"line_number":569,"context_line":"        utils.unlink_without_raise(new_drive_temp)"},{"line_number":570,"context_line":"        utils.unlink_without_raise(conf_drive_temp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3d0d8d05_9d9ca1d7","line":567,"in_reply_to":"8a02668d_abf935e2","updated":"2023-07-19 14:10:14.000000000","message":"The same as 537 with just finally makes the most sense, if they fail, the world can realistically go on.","commit_id":"43d6f8ffabe870baaea6145c80a1323808e28b89"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e9fb0d005a518e1b9ba27d60b5d3ed9e308b6a37","unresolved":true,"context_lines":[{"line_number":523,"context_line":"    return True"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"def _try_build_fat32_config_drive(partition, confdrive_file):"},{"line_number":527,"context_line":"    conf_drive_temp \u003d tempfile.mkdtemp()"},{"line_number":528,"context_line":"    try:"},{"line_number":529,"context_line":"        utils.execute(\u0027mount\u0027, \u0027-o\u0027, \u0027loop,ro\u0027, \u0027-t\u0027, \u0027auto\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"953596aa_e1a96bbd","line":526,"updated":"2023-07-24 19:37:51.000000000","message":"An idea I disucssed with steve to enable testing this, is actually have an internal configuration option to \"force\" this behavior, and just default it to off, FOREVER!.","commit_id":"94a1b7ce900b4fb759baaf9c3b402c0d1f846756"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"453ff9e6db5174ea5972b2516167b580f3162c5c","unresolved":false,"context_lines":[{"line_number":523,"context_line":"    return True"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"def _try_build_fat32_config_drive(partition, confdrive_file):"},{"line_number":527,"context_line":"    conf_drive_temp \u003d tempfile.mkdtemp()"},{"line_number":528,"context_line":"    try:"},{"line_number":529,"context_line":"        utils.execute(\u0027mount\u0027, \u0027-o\u0027, \u0027loop,ro\u0027, \u0027-t\u0027, \u0027auto\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"0c2a684c_f0f30aea","line":526,"in_reply_to":"953596aa_e1a96bbd","updated":"2023-07-25 18:43:29.000000000","message":"Done","commit_id":"94a1b7ce900b4fb759baaf9c3b402c0d1f846756"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"521f9e40c0171d1ef4edb2a10a26cd0314d1d413","unresolved":true,"context_lines":[{"line_number":466,"context_line":"            utils.execute(\u0027test\u0027, \u0027-e\u0027, config_drive_part, attempts\u003d15,"},{"line_number":467,"context_line":"                          delay_on_retry\u003dTrue)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        disk_utils.dd(confdrive_file, config_drive_part)"},{"line_number":470,"context_line":"        LOG.info(\"Configdrive for node %(node)s successfully \""},{"line_number":471,"context_line":"                 \"copied onto partition %(part)s\","},{"line_number":472,"context_line":"                 {\u0027node\u0027: node_uuid, \u0027part\u0027: config_drive_part})"}],"source_content_type":"text/x-python","patch_set":5,"id":"032af96f_4fbd56a8","line":469,"updated":"2023-07-25 22:11:44.000000000","message":"force_config_drive_rebuild would be ignored unless an exception was raised, how about here:\n\n    if CONF.force_config_drive_rebuild:\n        _try_build_fat32_config_drive(config_drive_part, confdrive_file)\n    else:\n        disk_utils.dd(confdrive_file, config_drive_part)","commit_id":"4889303fb6ce6f41b2f1d39e39b857dd6f48b300"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b18078943e7c643662cc4f98cfb3796ad687bc1d","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            utils.execute(\u0027test\u0027, \u0027-e\u0027, config_drive_part, attempts\u003d15,"},{"line_number":467,"context_line":"                          delay_on_retry\u003dTrue)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        disk_utils.dd(confdrive_file, config_drive_part)"},{"line_number":470,"context_line":"        LOG.info(\"Configdrive for node %(node)s successfully \""},{"line_number":471,"context_line":"                 \"copied onto partition %(part)s\","},{"line_number":472,"context_line":"                 {\u0027node\u0027: node_uuid, \u0027part\u0027: config_drive_part})"}],"source_content_type":"text/x-python","patch_set":5,"id":"24773a1b_e89383d0","line":469,"in_reply_to":"032af96f_4fbd56a8","updated":"2023-07-27 18:56:20.000000000","message":"Done","commit_id":"4889303fb6ce6f41b2f1d39e39b857dd6f48b300"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"25e12c947ae208ddf4fc464954bf7cccefd86380","unresolved":true,"context_lines":[{"line_number":492,"context_line":"        # If the configdrive was requested make sure we delete the file"},{"line_number":493,"context_line":"        # after copying the content to the partition"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    if (confdrive_file"},{"line_number":496,"context_line":"        and not _does_config_drive_work(config_drive_part)):"},{"line_number":497,"context_line":"        # If we have reached this point, we might have an"},{"line_number":498,"context_line":"        # invalid configuration drive, OR the block device"},{"line_number":499,"context_line":"        # layer doesn\u0027t support 2K block Logical IO (iso9660)"},{"line_number":500,"context_line":"        _try_build_fat32_config_drive(config_drive_part, confdrive_file)"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    # If the configdrive was requested make sure we delete the file"},{"line_number":503,"context_line":"    # after copying the content to the partition"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7d4f51_17f5db35","line":500,"range":{"start_line":495,"start_character":0,"end_line":500,"end_character":72},"updated":"2023-07-30 22:07:23.000000000","message":"I thought this should be in the above except block.\n\nAlso to ensure it doesn\u0027t get attempted twice, add this to the if expression \"not CONF.config_drive_rebuild and ...\"","commit_id":"3cf0da32e1dec54d63007209e376e8d7fefb40ba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7187b5d384358fe72dfcd4b4d0f328db0399c3fd","unresolved":true,"context_lines":[{"line_number":492,"context_line":"        # If the configdrive was requested make sure we delete the file"},{"line_number":493,"context_line":"        # after copying the content to the partition"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    if (confdrive_file"},{"line_number":496,"context_line":"        and not _does_config_drive_work(config_drive_part)):"},{"line_number":497,"context_line":"        # If we have reached this point, we might have an"},{"line_number":498,"context_line":"        # invalid configuration drive, OR the block device"},{"line_number":499,"context_line":"        # layer doesn\u0027t support 2K block Logical IO (iso9660)"},{"line_number":500,"context_line":"        _try_build_fat32_config_drive(config_drive_part, confdrive_file)"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    # If the configdrive was requested make sure we delete the file"},{"line_number":503,"context_line":"    # after copying the content to the partition"}],"source_content_type":"text/x-python","patch_set":6,"id":"68873d21_ea85eee5","line":500,"range":{"start_line":495,"start_character":0,"end_line":500,"end_character":72},"in_reply_to":"5f7d4f51_17f5db35","updated":"2023-08-24 15:11:48.000000000","message":"I think I\u0027ve got this changed as such, migraine permitting.","commit_id":"3cf0da32e1dec54d63007209e376e8d7fefb40ba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"21158110353b3bc3f1b4a30323326ed76e7a8b5b","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        # If the configdrive was requested make sure we delete the file"},{"line_number":493,"context_line":"        # after copying the content to the partition"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    if (confdrive_file"},{"line_number":496,"context_line":"        and not _does_config_drive_work(config_drive_part)):"},{"line_number":497,"context_line":"        # If we have reached this point, we might have an"},{"line_number":498,"context_line":"        # invalid configuration drive, OR the block device"},{"line_number":499,"context_line":"        # layer doesn\u0027t support 2K block Logical IO (iso9660)"},{"line_number":500,"context_line":"        _try_build_fat32_config_drive(config_drive_part, confdrive_file)"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    # If the configdrive was requested make sure we delete the file"},{"line_number":503,"context_line":"    # after copying the content to the partition"}],"source_content_type":"text/x-python","patch_set":6,"id":"2a913667_fc02835c","line":500,"range":{"start_line":495,"start_character":0,"end_line":500,"end_character":72},"in_reply_to":"68873d21_ea85eee5","updated":"2023-09-05 14:01:36.000000000","message":"Done","commit_id":"3cf0da32e1dec54d63007209e376e8d7fefb40ba"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"25e12c947ae208ddf4fc464954bf7cccefd86380","unresolved":true,"context_lines":[{"line_number":499,"context_line":"        # layer doesn\u0027t support 2K block Logical IO (iso9660)"},{"line_number":500,"context_line":"        _try_build_fat32_config_drive(config_drive_part, confdrive_file)"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    # If the configdrive was requested make sure we delete the file"},{"line_number":503,"context_line":"    # after copying the content to the partition"},{"line_number":504,"context_line":"    if confdrive_file:"},{"line_number":505,"context_line":"        utils.unlink_without_raise(confdrive_file)"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"def _does_config_drive_work(config_drive_part):"}],"source_content_type":"text/x-python","patch_set":6,"id":"cd171d28_7f52b20a","line":505,"range":{"start_line":502,"start_character":0,"end_line":505,"end_character":50},"updated":"2023-07-30 22:07:23.000000000","message":"If this was in a finally block, the other 2 above wouldn\u0027t be needed?","commit_id":"3cf0da32e1dec54d63007209e376e8d7fefb40ba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7187b5d384358fe72dfcd4b4d0f328db0399c3fd","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        # layer doesn\u0027t support 2K block Logical IO (iso9660)"},{"line_number":500,"context_line":"        _try_build_fat32_config_drive(config_drive_part, confdrive_file)"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    # If the configdrive was requested make sure we delete the file"},{"line_number":503,"context_line":"    # after copying the content to the partition"},{"line_number":504,"context_line":"    if confdrive_file:"},{"line_number":505,"context_line":"        utils.unlink_without_raise(confdrive_file)"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"def _does_config_drive_work(config_drive_part):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3da6fe05_18698a75","line":505,"range":{"start_line":502,"start_character":0,"end_line":505,"end_character":50},"in_reply_to":"cd171d28_7f52b20a","updated":"2023-08-24 15:11:48.000000000","message":"Ahh, I see, done.","commit_id":"3cf0da32e1dec54d63007209e376e8d7fefb40ba"}]}