)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"55a4a19c64274453942594aa7f7a0eacdd7ef691","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f59b2d2_19af9a71","updated":"2023-08-22 23:52:08.000000000","message":"Dmitry, adding you since this is ultimately this is a major part going sideways with metal3. Their jobs might actually succeed if it wasn\u0027t for this.","commit_id":"5ed520df895997e571732c305b3f1ac2f954209a"}],"ironic_python_agent/ironic_api_client.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6a134842c68bfd7703bc10c91a94801c24e560a7","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                \u0027node is locked. We will wait 30 seconds before trying \u0027"},{"line_number":253,"context_line":"                \u0027again. %s\u0027,"},{"line_number":254,"context_line":"                self._error_from_response(response))"},{"line_number":255,"context_line":"            time.sleep(30)"},{"line_number":256,"context_line":"            return False"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        if response.status_code !\u003d requests.codes.OK:"}],"source_content_type":"text/x-python","patch_set":1,"id":"42158ae1_3aaae26d","line":255,"updated":"2023-08-14 21:39:35.000000000","message":"nit: eventlet.sleep(30)? But I\u0027m pretty sure monkey patching is doing this in effect.\n\nMore substantive: Is there a reason we aren\u0027t doing an actual backoff here? Something like 1s-\u003e5s-\u003e15s-\u003e30s (stays at 30s?). This is probably better but trades off more speed than would be needed in all cases.","commit_id":"11a7eaebcee1f60fb049cf0118349e25d8bcb640"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"730b7308c46331fbb0502eb6297d790f8fb93a1c","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                \u0027node is locked. We will wait 30 seconds before trying \u0027"},{"line_number":253,"context_line":"                \u0027again. %s\u0027,"},{"line_number":254,"context_line":"                self._error_from_response(response))"},{"line_number":255,"context_line":"            time.sleep(30)"},{"line_number":256,"context_line":"            return False"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        if response.status_code !\u003d requests.codes.OK:"}],"source_content_type":"text/x-python","patch_set":1,"id":"61931a94_67251f98","line":255,"in_reply_to":"42158ae1_3aaae26d","updated":"2023-08-22 18:56:10.000000000","message":"What we\u0027re seeing in metal3 is we get a ton of queries held up which have timed out, and we\u0027re trying to service them, effectively breaking the deploy. A progressive backoff will just be the same problem, really.\n\nA 30 second is hold is not perfect, but this is a critical junction.","commit_id":"11a7eaebcee1f60fb049cf0118349e25d8bcb640"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ed534907df94fca6ed2dd8831e681a82f13abc4c","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                \u0027node is locked. We will wait 30 seconds before trying \u0027"},{"line_number":253,"context_line":"                \u0027again. %s\u0027,"},{"line_number":254,"context_line":"                self._error_from_response(response))"},{"line_number":255,"context_line":"            time.sleep(30)"},{"line_number":256,"context_line":"            return False"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        if response.status_code !\u003d requests.codes.OK:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c1240416_414855a4","line":255,"in_reply_to":"61931a94_67251f98","updated":"2023-08-22 23:51:27.000000000","message":"Ack","commit_id":"11a7eaebcee1f60fb049cf0118349e25d8bcb640"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ed534907df94fca6ed2dd8831e681a82f13abc4c","unresolved":true,"context_lines":[{"line_number":253,"context_line":"            elif self.lookup_lock_pause \u003d\u003d 5:"},{"line_number":254,"context_line":"                self.lookup_lock_pause \u003d 10"},{"line_number":255,"context_line":"            elif self.lookup_lock_pause \u003d\u003d 10:"},{"line_number":256,"context_line":"                # If we\u0027re reaching this point, we\u0027ve got a long held"},{"line_number":257,"context_line":"                # persistent lock, which means things can go very sideways"},{"line_number":258,"context_line":"                # or the ironic deployment is downright grumpy. Either way,"},{"line_number":259,"context_line":"                # we need to slow things down."}],"source_content_type":"text/x-python","patch_set":2,"id":"514c2f92_72538047","line":256,"updated":"2023-08-22 23:51:27.000000000","message":"nit: tag with NOTE(TheJulia)?","commit_id":"5ed520df895997e571732c305b3f1ac2f954209a"}]}