)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e6fa166d8b232237e91f2504c23837543e87ebc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"005d1103_09c3591a","updated":"2023-10-10 07:28:25.000000000","message":"recheck","commit_id":"286d66709a1b2f2068360db641079c67197b21b6"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"101a6b44516e8f57d63f40340ca6287d8c30f801","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d32ab86a_ba5a7768","updated":"2023-10-04 07:08:47.000000000","message":"recheck","commit_id":"286d66709a1b2f2068360db641079c67197b21b6"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"8fc0f684dc9b4602e2637d59bcfd75bc25248aca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"49ae32d7_1862137c","updated":"2023-08-21 08:47:11.000000000","message":"recheck (after another check with upstream)","commit_id":"286d66709a1b2f2068360db641079c67197b21b6"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"6289429f2693a4146b6aa2c512224ad78fda5724","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc012749_689de9d5","updated":"2023-08-22 09:02:39.000000000","message":"recheck (now that the metalsmith jammy patch has been merged)","commit_id":"286d66709a1b2f2068360db641079c67197b21b6"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"8303904c5cbd0ea4268f15fe3836c2a3c72806cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8d5c3a96_e790b63c","updated":"2023-08-17 11:16:00.000000000","message":"recheck (potential setup issue)","commit_id":"286d66709a1b2f2068360db641079c67197b21b6"}],"ironic_python_agent/raid_utils.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1a2c361debca62ffa99810fc93213f919ea105de","unresolved":true,"context_lines":[{"line_number":351,"context_line":"            LOG.info(\"Creating EFI partitions on software RAID holder disks\")"},{"line_number":352,"context_line":"            # We know that we kept this space when configuring raid,see"},{"line_number":353,"context_line":"            # hardware.GenericHardwareManager.create_configuration."},{"line_number":354,"context_line":"            # We could also directly get the EFI partition size."},{"line_number":355,"context_line":"            partsize_mib \u003d ESP_SIZE_MIB"},{"line_number":356,"context_line":"            partlabel_prefix \u003d \u0027uefi-holder-\u0027"},{"line_number":357,"context_line":"            efi_partitions \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"5790eb7e_0538b51b","line":354,"updated":"2023-09-27 12:04:47.000000000","message":"as a follow up it\u0027s probably worth moving this code out in a separate function","commit_id":"286d66709a1b2f2068360db641079c67197b21b6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c63f274d87019c74585d095f644fd4cf138aeb51","unresolved":true,"context_lines":[{"line_number":439,"context_line":"    report \u003d lsblk[0]"},{"line_number":440,"context_line":"    for line in report.split(\u0027\\n\u0027):"},{"line_number":441,"context_line":"        dev \u003d {}"},{"line_number":442,"context_line":"        vals \u003d shlex.split(line)"},{"line_number":443,"context_line":"        for key, val in (v.split(\u0027\u003d\u0027, 1) for v in vals):"},{"line_number":444,"context_line":"            dev[key] \u003d val.strip()"},{"line_number":445,"context_line":"        if dev.get(\u0027TYPE\u0027) \u003d\u003d \u0027raid1\u0027 and dev.get(\u0027FSTYPE\u0027) \u003d\u003d \u0027vfat\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"697f669e_ceedcf53","line":442,"updated":"2023-09-27 16:01:32.000000000","message":"Please use https://opendev.org/openstack/ironic-lib/src/branch/master/ironic_lib/utils.py#L652 instead, as other code that calls/parses lsblk does, unless there\u0027s a good reason otherwise.\n\nI normally wouldn\u0027t worry too much about it, but output from these tools breaking has been a pain point in the past and having it parsed in one place helps prevent this from getting missed if it happens again.","commit_id":"286d66709a1b2f2068360db641079c67197b21b6"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"9c6e449fd00ff21406ed9d7ee9731ab7f97d53ae","unresolved":true,"context_lines":[{"line_number":439,"context_line":"    report \u003d lsblk[0]"},{"line_number":440,"context_line":"    for line in report.split(\u0027\\n\u0027):"},{"line_number":441,"context_line":"        dev \u003d {}"},{"line_number":442,"context_line":"        vals \u003d shlex.split(line)"},{"line_number":443,"context_line":"        for key, val in (v.split(\u0027\u003d\u0027, 1) for v in vals):"},{"line_number":444,"context_line":"            dev[key] \u003d val.strip()"},{"line_number":445,"context_line":"        if dev.get(\u0027TYPE\u0027) \u003d\u003d \u0027raid1\u0027 and dev.get(\u0027FSTYPE\u0027) \u003d\u003d \u0027vfat\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d670b2c3_9c278d7e","line":442,"in_reply_to":"697f669e_ceedcf53","updated":"2023-09-27 16:13:35.000000000","message":"The \"reason\" is\n\nhttps://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/partition_utils.py#L620\n\nor\n\nhttps://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/hardware.py#L442\n\n... don\u0027t remember from which one I took inspiration :)\n\nAgree with your point, though.","commit_id":"286d66709a1b2f2068360db641079c67197b21b6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ef370c9e569dc8f273694b86040f8e3e9e9e7d58","unresolved":true,"context_lines":[{"line_number":439,"context_line":"    report \u003d lsblk[0]"},{"line_number":440,"context_line":"    for line in report.split(\u0027\\n\u0027):"},{"line_number":441,"context_line":"        dev \u003d {}"},{"line_number":442,"context_line":"        vals \u003d shlex.split(line)"},{"line_number":443,"context_line":"        for key, val in (v.split(\u0027\u003d\u0027, 1) for v in vals):"},{"line_number":444,"context_line":"            dev[key] \u003d val.strip()"},{"line_number":445,"context_line":"        if dev.get(\u0027TYPE\u0027) \u003d\u003d \u0027raid1\u0027 and dev.get(\u0027FSTYPE\u0027) \u003d\u003d \u0027vfat\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a1b5c7b_325e8af3","line":442,"in_reply_to":"d670b2c3_9c278d7e","updated":"2023-09-27 16:20:11.000000000","message":"You got unlucky twice: \n- Your grep found the shlex variant\n- My grep found the ironic-lib variant\n\nI\u0027ll file a followup bug as a low-hanging-fruit for a new contributor and flip my vote here.","commit_id":"286d66709a1b2f2068360db641079c67197b21b6"}]}