)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-10-06 13:33:42 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add additional mock tests to unit tests."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie9b884e58e4677a47e57c3ad39cadd65db8eec75"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"340e2270_eb21e036","line":8,"updated":"2023-10-06 21:03:32.000000000","message":"don\u0027t forget to add the Partial-bug: #xxxxxx or Closes-Bug: #xxxxxx when you update this patch for merge","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-10-06 13:33:42 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add additional mock tests to unit tests."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie9b884e58e4677a47e57c3ad39cadd65db8eec75"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"acf460e2_43785972","line":8,"in_reply_to":"340e2270_eb21e036","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f4f837556d2696401cf705e904ec3c55e66a5def","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-10-06 15:02:09 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add additional mock tests to unit tests for read only devices."},{"line_number":8,"context_line":"Change ordering to ensure mock tests work correctly."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Closes Bug: #2037690"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f9f5e7c1_c557033c","line":8,"updated":"2023-10-06 22:06:21.000000000","message":"General style for git commit messages is 50 character first line; 70 characters below with a newline between. There\u0027s no need to mention changes made mid-process (e.g. changing the ordering of the mocks) -- because whoever ends up reading this in the repo will only care about the difference from the original branch.\n\n(please don\u0027t copy+paste this, it\u0027s just an example) For something like this, I\u0027d probably do a commit message like this:\n```\nFixes mocking in test_hardware\n\nThese tests were missing mocks, causing them to fail when run on WSL.\n\nCloses-Bug: #2037690\n```","commit_id":"dc538b332bae9e1cc6f335a9f20a9928479c80a7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f4f837556d2696401cf705e904ec3c55e66a5def","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add additional mock tests to unit tests for read only devices."},{"line_number":8,"context_line":"Change ordering to ensure mock tests work correctly."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Closes Bug: #2037690"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie9b884e58e4677a47e57c3ad39cadd65db8eec75"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5b3dece5_7460c517","line":10,"updated":"2023-10-06 22:06:21.000000000","message":"Closes-bug","commit_id":"dc538b332bae9e1cc6f335a9f20a9928479c80a7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"674ff4c1_d3289d54","updated":"2023-10-06 21:03:32.000000000","message":"There are basically three problems here all combining to cause your CI failures:\n\n- In many of these test methods, the mock decorators and the function declaration do not have matching orders; this means that what you think might be, e.g. mocked_execute in a test might actually be the mock object something else.\n\n- This is made harder to find by the naming being inconsistent -- for this change specifically, lets try to ensure we use the same variable names for the same mocks -- e.g. _is_linux_raid_member always is passed in as mocked_raid_member, _is_read_only_device is always passed in as mocked_ro_device or similar. Part of this is also ensuring the names are distinct (e.g. mocked_read_only_member doesn\u0027t really make sense; (raid) member is a specific term in this context meaning \"part of a raid array\"\n\n- Whitespace issues throughout will cause lint failures; zuul will comment them all specifically but you can find them locally with `tox -epep8`. I typically ensure this passes even before running unit tests as it quickly finds syntax or whitespace errors.","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"34788470_7e3cd950","in_reply_to":"674ff4c1_d3289d54","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f7ec3284df6df2286d52e270e529cc65ce39d2a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"24d91583_3cfc9dd4","updated":"2023-10-08 19:23:21.000000000","message":"Thanks for this contribution, it looks good and functionally correct.\n\nThere is a few accumulated nits so having one more revision would clean it up, otherwise +2. Thanks!","commit_id":"a892d6f04ca451ffe1c32a47a8c31e595b5b5fdf"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"68a46d18258e94e4bbf57abc31bd14cb11b85a5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e055c29d_bd7c0750","updated":"2023-10-08 20:05:04.000000000","message":"The only changes are non-functional, so I\u0027m going to land this. Thanks again","commit_id":"25704d25557973e5b76bdc67217c0f6ed2596fc7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"155cc18d69ad37c9eadbc7ae5f8486f5cac5dd2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f358f351_de8f1f3e","updated":"2023-10-09 02:25:46.000000000","message":"recheck unrelated metalsmith-integration-ipa-src-uefi","commit_id":"25704d25557973e5b76bdc67217c0f6ed2596fc7"}],"ironic_python_agent/tests/unit/test_hardware.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":1682,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1683,"context_line":"    def test_erase_block_device_ata_success(self, mocked_execute,"},{"line_number":1684,"context_line":"                                            mocked_raid_member,"},{"line_number":1685,"context_line":"                                            mocked_read_only_member):"},{"line_number":1686,"context_line":"        mocked_execute.side_effect \u003d ["},{"line_number":1687,"context_line":"            (create_hdparm_info("},{"line_number":1688,"context_line":"                supported\u003dTrue, enabled\u003dFalse, frozen\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"54126ba6_7c057d8e","line":1685,"updated":"2023-10-06 21:03:32.000000000","message":"I\u0027m fairly sure that you have the arguments here mixed... if you look at previous tests, like on line 1641, you can see it is reversed. In this specific test, the two that are mixed are both mocked out to return false so you can\u0027t tell, but this class of error, I believe, is causing other failures.\n\ne.g. (this is psuedocodeish)\n\n```\n@mock(thing1)\n@mock(thing2)\ndef test_method(self, thing2, thing1)\n    pass\n```\n\nAdditionally, mocked_read_only_member seems like a mashup of the two names, is it intentional? Something more clear might be `mocked_ro_device`? I would absolutely drop the word \"member\" no matter how you improve it. (throughout; not just this test)","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":1682,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1683,"context_line":"    def test_erase_block_device_ata_success(self, mocked_execute,"},{"line_number":1684,"context_line":"                                            mocked_raid_member,"},{"line_number":1685,"context_line":"                                            mocked_read_only_member):"},{"line_number":1686,"context_line":"        mocked_execute.side_effect \u003d ["},{"line_number":1687,"context_line":"            (create_hdparm_info("},{"line_number":1688,"context_line":"                supported\u003dTrue, enabled\u003dFalse, frozen\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f049126e_efea0dff","line":1685,"in_reply_to":"54126ba6_7c057d8e","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":1753,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1754,"context_line":"    def test_erase_block_device_nosecurity_shred(self, mocked_execute,"},{"line_number":1755,"context_line":"                                                 mocked_raid_member,"},{"line_number":1756,"context_line":"                                                 mocked_read_only_member):"},{"line_number":1757,"context_line":"        hdparm_output \u003d hws.HDPARM_INFO_TEMPLATE.split(\u0027\\nSecurity:\u0027)[0]"},{"line_number":1758,"context_line":""},{"line_number":1759,"context_line":"        mocked_execute.side_effect \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"0f3572cf_af46ff86","line":1756,"updated":"2023-10-06 21:03:32.000000000","message":"same here: I believe you have these arguments swapped around in order","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":1753,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1754,"context_line":"    def test_erase_block_device_nosecurity_shred(self, mocked_execute,"},{"line_number":1755,"context_line":"                                                 mocked_raid_member,"},{"line_number":1756,"context_line":"                                                 mocked_read_only_member):"},{"line_number":1757,"context_line":"        hdparm_output \u003d hws.HDPARM_INFO_TEMPLATE.split(\u0027\\nSecurity:\u0027)[0]"},{"line_number":1758,"context_line":""},{"line_number":1759,"context_line":"        mocked_execute.side_effect \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"393b686f_ee9b8259","line":1756,"in_reply_to":"0f3572cf_af46ff86","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":1814,"context_line":"                                                           mocked_execute,"},{"line_number":1815,"context_line":"                                                           mocked_raid_member,"},{"line_number":1816,"context_line":"                                                           mocked_read_only_member,"},{"line_number":1817,"context_line":"                                                           mocked_vm_member,"},{"line_number":1818,"context_line":"                                                           ):"},{"line_number":1819,"context_line":"        hdparm_output \u003d create_hdparm_info("},{"line_number":1820,"context_line":"            supported\u003dTrue, enabled\u003dFalse, frozen\u003dFalse, enhanced_erase\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d0a9a567_1b8ec627","line":1817,"updated":"2023-10-06 21:03:32.000000000","message":"ordering here is wrong as well, I think","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":1814,"context_line":"                                                           mocked_execute,"},{"line_number":1815,"context_line":"                                                           mocked_raid_member,"},{"line_number":1816,"context_line":"                                                           mocked_read_only_member,"},{"line_number":1817,"context_line":"                                                           mocked_vm_member,"},{"line_number":1818,"context_line":"                                                           ):"},{"line_number":1819,"context_line":"        hdparm_output \u003d create_hdparm_info("},{"line_number":1820,"context_line":"            supported\u003dTrue, enabled\u003dFalse, frozen\u003dFalse, enhanced_erase\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"382eab54_866da316","line":1817,"in_reply_to":"d0a9a567_1b8ec627","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":1845,"context_line":"                       \u0027_is_read_only_device\u0027, autospec\u003dTrue)"},{"line_number":1846,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1847,"context_line":"    def test_erase_block_device_smartctl_fails_security_fallback_to_shred("},{"line_number":1848,"context_line":"            self, mocked_execute, mocked_raid_member, mocked_vm_member):"},{"line_number":1849,"context_line":"        hdparm_output \u003d create_hdparm_info("},{"line_number":1850,"context_line":"            supported\u003dTrue, enabled\u003dFalse, frozen\u003dFalse, enhanced_erase\u003dFalse)"},{"line_number":1851,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f6feb20_c48ccaf2","line":1848,"updated":"2023-10-06 21:03:32.000000000","message":"ordering here, this is named vm_member too, and I think you missed adding the mock for _is_virtual_media_device","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":1845,"context_line":"                       \u0027_is_read_only_device\u0027, autospec\u003dTrue)"},{"line_number":1846,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1847,"context_line":"    def test_erase_block_device_smartctl_fails_security_fallback_to_shred("},{"line_number":1848,"context_line":"            self, mocked_execute, mocked_raid_member, mocked_vm_member):"},{"line_number":1849,"context_line":"        hdparm_output \u003d create_hdparm_info("},{"line_number":1850,"context_line":"            supported\u003dTrue, enabled\u003dFalse, frozen\u003dFalse, enhanced_erase\u003dFalse)"},{"line_number":1851,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2c2f9012_d5e6ed85","line":1848,"in_reply_to":"3f6feb20_c48ccaf2","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":1874,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1875,"context_line":"    def test_erase_block_device_shred_uses_internal_info(self, mocked_execute,"},{"line_number":1876,"context_line":"                                                         mocked_raid_member,"},{"line_number":1877,"context_line":"                                                         mocked_read_only_member):"},{"line_number":1878,"context_line":"        hdparm_output \u003d create_hdparm_info("},{"line_number":1879,"context_line":"            supported\u003dFalse, enabled\u003dFalse, frozen\u003dFalse, enhanced_erase\u003dFalse)"},{"line_number":1880,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b117b7ac_7c6b9672","line":1877,"updated":"2023-10-06 21:03:32.000000000","message":"ordering here, too","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":1874,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1875,"context_line":"    def test_erase_block_device_shred_uses_internal_info(self, mocked_execute,"},{"line_number":1876,"context_line":"                                                         mocked_raid_member,"},{"line_number":1877,"context_line":"                                                         mocked_read_only_member):"},{"line_number":1878,"context_line":"        hdparm_output \u003d create_hdparm_info("},{"line_number":1879,"context_line":"            supported\u003dFalse, enabled\u003dFalse, frozen\u003dFalse, enhanced_erase\u003dFalse)"},{"line_number":1880,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"60dacd3b_73f855bb","line":1877,"in_reply_to":"b117b7ac_7c6b9672","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":2010,"context_line":"    @mock.patch.object(hardware.GenericHardwareManager,"},{"line_number":2011,"context_line":"                       \u0027_is_virtual_media_device\u0027, autospec\u003dTrue)"},{"line_number":2012,"context_line":"    def test_erase_block_device_ata_security_unlock_fallback_pass("},{"line_number":2013,"context_line":"            self, mocked_execute, mocked_raid_member, mocked_read_only_member,"},{"line_number":2014,"context_line":"            mocked_vm_member):"},{"line_number":2015,"context_line":"        hdparm_output \u003d create_hdparm_info("},{"line_number":2016,"context_line":"            supported\u003dTrue, enabled\u003dTrue, locked\u003dTrue"}],"source_content_type":"text/x-python","patch_set":1,"id":"59c289c6_6f9371fe","line":2013,"updated":"2023-10-06 21:03:32.000000000","message":"Ordering is wrong here; and this is 100% causing the failure in this case -- il_utils.execute is actually being mocked into mocked_read_only_member, so when we check the mocked_execute for calls; it doesn\u0027t have the expected ones (because the mock is mapped to the wrong argument in the function definition)","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":2010,"context_line":"    @mock.patch.object(hardware.GenericHardwareManager,"},{"line_number":2011,"context_line":"                       \u0027_is_virtual_media_device\u0027, autospec\u003dTrue)"},{"line_number":2012,"context_line":"    def test_erase_block_device_ata_security_unlock_fallback_pass("},{"line_number":2013,"context_line":"            self, mocked_execute, mocked_raid_member, mocked_read_only_member,"},{"line_number":2014,"context_line":"            mocked_vm_member):"},{"line_number":2015,"context_line":"        hdparm_output \u003d create_hdparm_info("},{"line_number":2016,"context_line":"            supported\u003dTrue, enabled\u003dTrue, locked\u003dTrue"}],"source_content_type":"text/x-python","patch_set":1,"id":"dd318482_7f61ba21","line":2013,"in_reply_to":"59c289c6_6f9371fe","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":2017,"context_line":"        )"},{"line_number":2018,"context_line":"        hdparm_output_unlocked \u003d create_hdparm_info("},{"line_number":2019,"context_line":"            supported\u003dTrue, enabled\u003dTrue, frozen\u003dFalse, enhanced_erase\u003dFalse)"},{"line_number":2020,"context_line":"        "},{"line_number":2021,"context_line":"        hdparm_output_not_enabled \u003d create_hdparm_info("},{"line_number":2022,"context_line":"            supported\u003dTrue, enabled\u003dFalse, frozen\u003dFalse, enhanced_erase\u003dFalse)"},{"line_number":2023,"context_line":"        "}],"source_content_type":"text/x-python","patch_set":1,"id":"59d10147_3fd34ca0","line":2020,"updated":"2023-10-06 21:03:32.000000000","message":"linter is not going to be happy about the whitespace here, throughout. I suggest running `tox -epep8` locally and working through the errs","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":2017,"context_line":"        )"},{"line_number":2018,"context_line":"        hdparm_output_unlocked \u003d create_hdparm_info("},{"line_number":2019,"context_line":"            supported\u003dTrue, enabled\u003dTrue, frozen\u003dFalse, enhanced_erase\u003dFalse)"},{"line_number":2020,"context_line":"        "},{"line_number":2021,"context_line":"        hdparm_output_not_enabled \u003d create_hdparm_info("},{"line_number":2022,"context_line":"            supported\u003dTrue, enabled\u003dFalse, frozen\u003dFalse, enhanced_erase\u003dFalse)"},{"line_number":2023,"context_line":"        "}],"source_content_type":"text/x-python","patch_set":1,"id":"2c0566ef_3e9b20d8","line":2020,"in_reply_to":"59d10147_3fd34ca0","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":2053,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":2054,"context_line":"    def test_erase_block_device_ata_security_enabled("},{"line_number":2055,"context_line":"            self, mocked_execute, mock_shred, mocked_raid_member,"},{"line_number":2056,"context_line":"            mocked_read_only_member, mocked_vm_member):"},{"line_number":2057,"context_line":"        # Tests that an exception is thrown if all of the recovery passwords"},{"line_number":2058,"context_line":"        # fail to unlock the device without throwing exception"},{"line_number":2059,"context_line":"        hdparm_output \u003d create_hdparm_info("}],"source_content_type":"text/x-python","patch_set":1,"id":"2bb1c23e_08bf1d82","line":2056,"updated":"2023-10-06 21:03:32.000000000","message":"ordering","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":2054,"context_line":"    def test_erase_block_device_ata_security_enabled("},{"line_number":2055,"context_line":"            self, mocked_execute, mock_shred, mocked_raid_member,"},{"line_number":2056,"context_line":"            mocked_read_only_member, mocked_vm_member):"},{"line_number":2057,"context_line":"        # Tests that an exception is thrown if all of the recovery passwords"},{"line_number":2058,"context_line":"        # fail to unlock the device without throwing exception"},{"line_number":2059,"context_line":"        hdparm_output \u003d create_hdparm_info("}],"source_content_type":"text/x-python","patch_set":1,"id":"b86d3631_9a56c00f","line":2056,"in_reply_to":"2bb1c23e_08bf1d82","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":2096,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":2097,"context_line":"    def test_erase_block_device_ata_security_enabled_unlock_attempt("},{"line_number":2098,"context_line":"            self, mocked_execute, mock_shred, mocked_raid_member,"},{"line_number":2099,"context_line":"            mocked_read_only_member, mocked_vm_member):"},{"line_number":2100,"context_line":"        hdparm_output \u003d create_hdparm_info("},{"line_number":2101,"context_line":"            supported\u003dTrue, enabled\u003dTrue, locked\u003dTrue)"},{"line_number":2102,"context_line":"        hdparm_output_not_enabled \u003d create_hdparm_info("}],"source_content_type":"text/x-python","patch_set":1,"id":"d357def7_87c91313","line":2099,"updated":"2023-10-06 21:03:32.000000000","message":"ordering","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":2096,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":2097,"context_line":"    def test_erase_block_device_ata_security_enabled_unlock_attempt("},{"line_number":2098,"context_line":"            self, mocked_execute, mock_shred, mocked_raid_member,"},{"line_number":2099,"context_line":"            mocked_read_only_member, mocked_vm_member):"},{"line_number":2100,"context_line":"        hdparm_output \u003d create_hdparm_info("},{"line_number":2101,"context_line":"            supported\u003dTrue, enabled\u003dTrue, locked\u003dTrue)"},{"line_number":2102,"context_line":"        hdparm_output_not_enabled \u003d create_hdparm_info("}],"source_content_type":"text/x-python","patch_set":1,"id":"f27613d4_7c4d1c00","line":2099,"in_reply_to":"d357def7_87c91313","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":2232,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":2233,"context_line":"    @mock.patch.object(hardware.GenericHardwareManager,"},{"line_number":2234,"context_line":"                       \u0027_is_virtual_media_device\u0027, autospec\u003dTrue)"},{"line_number":2235,"context_line":""},{"line_number":2236,"context_line":"    def test_erase_block_device_ata_failed(self, mocked_execute, mock_shred,"},{"line_number":2237,"context_line":"                                           mocked_raid_member,"},{"line_number":2238,"context_line":"                                           mocked_read_only_member,"}],"source_content_type":"text/x-python","patch_set":1,"id":"8b7ebc75_3794a561","line":2235,"updated":"2023-10-06 21:03:32.000000000","message":"erroneous whitespace?","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":2232,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":2233,"context_line":"    @mock.patch.object(hardware.GenericHardwareManager,"},{"line_number":2234,"context_line":"                       \u0027_is_virtual_media_device\u0027, autospec\u003dTrue)"},{"line_number":2235,"context_line":""},{"line_number":2236,"context_line":"    def test_erase_block_device_ata_failed(self, mocked_execute, mock_shred,"},{"line_number":2237,"context_line":"                                           mocked_raid_member,"},{"line_number":2238,"context_line":"                                           mocked_read_only_member,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6f47503b_8f2277da","line":2235,"in_reply_to":"8b7ebc75_3794a561","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":2276,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":2277,"context_line":"    def test_erase_block_device_ata_failed_continued("},{"line_number":2278,"context_line":"            self, mocked_execute, mock_shred, mocked_raid_member,"},{"line_number":2279,"context_line":"            mocked_read_only_member, mocked_vm_member):"},{"line_number":2280,"context_line":""},{"line_number":2281,"context_line":"        info \u003d self.node[\u0027driver_internal_info\u0027]"},{"line_number":2282,"context_line":"        info[\u0027agent_continue_if_ata_erase_failed\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"899aff69_94d3b43e","line":2279,"updated":"2023-10-06 21:03:32.000000000","message":"ordering here, too","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":2276,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":2277,"context_line":"    def test_erase_block_device_ata_failed_continued("},{"line_number":2278,"context_line":"            self, mocked_execute, mock_shred, mocked_raid_member,"},{"line_number":2279,"context_line":"            mocked_read_only_member, mocked_vm_member):"},{"line_number":2280,"context_line":""},{"line_number":2281,"context_line":"        info \u003d self.node[\u0027driver_internal_info\u0027]"},{"line_number":2282,"context_line":"        info[\u0027agent_continue_if_ata_erase_failed\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"96e4f533_44ac7cee","line":2279,"in_reply_to":"899aff69_94d3b43e","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":2317,"context_line":"    def test_erase_block_device_ata_erase_disabled("},{"line_number":2318,"context_line":"            self, mocked_execute, mock_shred, "},{"line_number":2319,"context_line":"            mocked_read_only_member, mocked_vm_member,"},{"line_number":2320,"context_line":"            mocked_raid_member):"},{"line_number":2321,"context_line":""},{"line_number":2322,"context_line":"        info \u003d self.node[\u0027driver_internal_info\u0027]"},{"line_number":2323,"context_line":"        info[\u0027agent_enable_ata_secure_erase\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7c06dc70_814b3421","line":2320,"updated":"2023-10-06 21:03:32.000000000","message":"ordering here, also whitespace on 2318 will make pep8 unhappy 😊","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":2317,"context_line":"    def test_erase_block_device_ata_erase_disabled("},{"line_number":2318,"context_line":"            self, mocked_execute, mock_shred, "},{"line_number":2319,"context_line":"            mocked_read_only_member, mocked_vm_member,"},{"line_number":2320,"context_line":"            mocked_raid_member):"},{"line_number":2321,"context_line":""},{"line_number":2322,"context_line":"        info \u003d self.node[\u0027driver_internal_info\u0027]"},{"line_number":2323,"context_line":"        info[\u0027agent_enable_ata_secure_erase\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"e5a06439_1de34740","line":2320,"in_reply_to":"7c06dc70_814b3421","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":2343,"context_line":"                                       expected_option,"},{"line_number":2344,"context_line":"                                       mocked_execute,"},{"line_number":2345,"context_line":"                                       mocked_raid_member,"},{"line_number":2346,"context_line":"                                       mocked_read_only_member):"},{"line_number":2347,"context_line":"            mocked_execute.side_effect \u003d ["},{"line_number":2348,"context_line":"                (create_hdparm_info("},{"line_number":2349,"context_line":"                    supported\u003dTrue, enabled\u003dFalse, frozen\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"048133de_664d4387","line":2346,"updated":"2023-10-06 21:03:32.000000000","message":"ordering","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":2343,"context_line":"                                       expected_option,"},{"line_number":2344,"context_line":"                                       mocked_execute,"},{"line_number":2345,"context_line":"                                       mocked_raid_member,"},{"line_number":2346,"context_line":"                                       mocked_read_only_member):"},{"line_number":2347,"context_line":"            mocked_execute.side_effect \u003d ["},{"line_number":2348,"context_line":"                (create_hdparm_info("},{"line_number":2349,"context_line":"                    supported\u003dTrue, enabled\u003dFalse, frozen\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f47e3e55_bb25de22","line":2346,"in_reply_to":"048133de_664d4387","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":2484,"context_line":"                       \u0027_is_read_only_device\u0027, autospec\u003dTrue)"},{"line_number":2485,"context_line":"    def test_erase_devices_metadata("},{"line_number":2486,"context_line":"            self, mock_metadata, mock_list_devs, mock__is_vmedia,"},{"line_number":2487,"context_line":"            mock_execute, mock_safety_check, mocked_vm_member):"},{"line_number":2488,"context_line":"        "},{"line_number":2489,"context_line":"        mocked_vm_member.return_value \u003d False"},{"line_number":2490,"context_line":"        mock__is_vmedia.return_value \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"49d444fd_706aa848","line":2487,"updated":"2023-10-06 21:03:32.000000000","message":"ordering","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":2484,"context_line":"                       \u0027_is_read_only_device\u0027, autospec\u003dTrue)"},{"line_number":2485,"context_line":"    def test_erase_devices_metadata("},{"line_number":2486,"context_line":"            self, mock_metadata, mock_list_devs, mock__is_vmedia,"},{"line_number":2487,"context_line":"            mock_execute, mock_safety_check, mocked_vm_member):"},{"line_number":2488,"context_line":"        "},{"line_number":2489,"context_line":"        mocked_vm_member.return_value \u003d False"},{"line_number":2490,"context_line":"        mock__is_vmedia.return_value \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"e225d5a7_fdc7993e","line":2487,"in_reply_to":"49d444fd_706aa848","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c6a0927198683acc9be31557709c5ed75fc469d","unresolved":true,"context_lines":[{"line_number":2592,"context_line":"                       \u0027_is_read_only_device\u0027, autospec\u003dTrue)"},{"line_number":2593,"context_line":"    def test_erase_devices_metadata_error("},{"line_number":2594,"context_line":"            self, mock_metadata, mock_list_devs, mock__is_vmedia,"},{"line_number":2595,"context_line":"            mock__is_raid_member, mock_safety_check, mocked_vm_memebr):"},{"line_number":2596,"context_line":"        block_devices \u003d ["},{"line_number":2597,"context_line":"            hardware.BlockDevice(\u0027/dev/sda\u0027, \u0027small\u0027, 65535, False),"},{"line_number":2598,"context_line":"            hardware.BlockDevice(\u0027/dev/sdb\u0027, \u0027big\u0027, 10737418240, True),"}],"source_content_type":"text/x-python","patch_set":1,"id":"53b0a339_973558f5","line":2595,"updated":"2023-10-06 21:03:32.000000000","message":"ordering, name","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"784e61c784b8050a3c9c15419edaaa171f830189","unresolved":false,"context_lines":[{"line_number":2592,"context_line":"                       \u0027_is_read_only_device\u0027, autospec\u003dTrue)"},{"line_number":2593,"context_line":"    def test_erase_devices_metadata_error("},{"line_number":2594,"context_line":"            self, mock_metadata, mock_list_devs, mock__is_vmedia,"},{"line_number":2595,"context_line":"            mock__is_raid_member, mock_safety_check, mocked_vm_memebr):"},{"line_number":2596,"context_line":"        block_devices \u003d ["},{"line_number":2597,"context_line":"            hardware.BlockDevice(\u0027/dev/sda\u0027, \u0027small\u0027, 65535, False),"},{"line_number":2598,"context_line":"            hardware.BlockDevice(\u0027/dev/sdb\u0027, \u0027big\u0027, 10737418240, True),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a6d3528_691b3dba","line":2595,"in_reply_to":"53b0a339_973558f5","updated":"2023-10-06 22:15:30.000000000","message":"Done","commit_id":"f9267b4dcedacddd83786bbbe1428305f858e855"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f7ec3284df6df2286d52e270e529cc65ce39d2a9","unresolved":true,"context_lines":[{"line_number":1682,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1683,"context_line":"    def test_erase_block_device_ata_success(self, mocked_execute,"},{"line_number":1684,"context_line":"                                            mocked_ro_device,"},{"line_number":1685,"context_line":"                                            mocked_raid_member,"},{"line_number":1686,"context_line":"                                            ):"},{"line_number":1687,"context_line":"        mocked_execute.side_effect \u003d ["},{"line_number":1688,"context_line":"            (create_hdparm_info("}],"source_content_type":"text/x-python","patch_set":8,"id":"051badc1_3a8e6a17","line":1685,"range":{"start_line":1685,"start_character":62,"end_line":1685,"end_character":63},"updated":"2023-10-08 19:23:21.000000000","message":"nit: no need for this trailing comma. There are a quite a few other methods with this also, may as well clean them all up","commit_id":"a892d6f04ca451ffe1c32a47a8c31e595b5b5fdf"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"d5d1f6580de8fb4687074c56713875a345dc3e86","unresolved":false,"context_lines":[{"line_number":1682,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1683,"context_line":"    def test_erase_block_device_ata_success(self, mocked_execute,"},{"line_number":1684,"context_line":"                                            mocked_ro_device,"},{"line_number":1685,"context_line":"                                            mocked_raid_member,"},{"line_number":1686,"context_line":"                                            ):"},{"line_number":1687,"context_line":"        mocked_execute.side_effect \u003d ["},{"line_number":1688,"context_line":"            (create_hdparm_info("}],"source_content_type":"text/x-python","patch_set":8,"id":"b5f397c0_83ae4a15","line":1685,"range":{"start_line":1685,"start_character":62,"end_line":1685,"end_character":63},"in_reply_to":"051badc1_3a8e6a17","updated":"2023-10-08 19:56:13.000000000","message":"Done","commit_id":"a892d6f04ca451ffe1c32a47a8c31e595b5b5fdf"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"46a48251436d78f353b46d22333f131429709a45","unresolved":true,"context_lines":[{"line_number":1913,"context_line":"                       \u0027_is_read_only_device\u0027, autospec\u003dTrue)"},{"line_number":1914,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1915,"context_line":"    def test_erase_block_device_shred_0_pass_no_zeroize(self, mocked_execute,"},{"line_number":1916,"context_line":"                                                        mock_read_only_member,"},{"line_number":1917,"context_line":"                                                        mocked_raid_member):"},{"line_number":1918,"context_line":"        hdparm_output \u003d create_hdparm_info("},{"line_number":1919,"context_line":"            supported\u003dFalse, enabled\u003dFalse, frozen\u003dFalse, enhanced_erase\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"968d3d7b_b52721da","line":1916,"updated":"2023-10-07 04:21:32.000000000","message":"nit: inconsistent name with the rest of the tests","commit_id":"a892d6f04ca451ffe1c32a47a8c31e595b5b5fdf"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"a8ff0261a1ab8b1dc3d7583b51733d4b13e250c7","unresolved":false,"context_lines":[{"line_number":1913,"context_line":"                       \u0027_is_read_only_device\u0027, autospec\u003dTrue)"},{"line_number":1914,"context_line":"    @mock.patch.object(il_utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1915,"context_line":"    def test_erase_block_device_shred_0_pass_no_zeroize(self, mocked_execute,"},{"line_number":1916,"context_line":"                                                        mock_read_only_member,"},{"line_number":1917,"context_line":"                                                        mocked_raid_member):"},{"line_number":1918,"context_line":"        hdparm_output \u003d create_hdparm_info("},{"line_number":1919,"context_line":"            supported\u003dFalse, enabled\u003dFalse, frozen\u003dFalse, enhanced_erase\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"daaa3236_32c517f5","line":1916,"in_reply_to":"968d3d7b_b52721da","updated":"2023-10-08 20:10:06.000000000","message":"Done","commit_id":"a892d6f04ca451ffe1c32a47a8c31e595b5b5fdf"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"46a48251436d78f353b46d22333f131429709a45","unresolved":true,"context_lines":[{"line_number":2501,"context_line":"            hardware.BlockDevice(\u0027/dev/sda2\u0027, \u0027raid-member\u0027, 32767, False),"},{"line_number":2502,"context_line":"            hardware.BlockDevice(\u0027/dev/md0\u0027, \u0027raid-device\u0027, 32767, False)"},{"line_number":2503,"context_line":"        ]"},{"line_number":2504,"context_line":""},{"line_number":2505,"context_line":"        # NOTE(coreywright): Don\u0027t return the list, but a copy of it, because"},{"line_number":2506,"context_line":"        # we depend on its elements\u0027 order when referencing it later during"},{"line_number":2507,"context_line":"        # verification, but the method under test sorts the list changing it."}],"source_content_type":"text/x-python","patch_set":8,"id":"3349f8ce_6af2ab37","line":2504,"updated":"2023-10-07 04:21:32.000000000","message":"nit: inadvertent whitespace added?","commit_id":"a892d6f04ca451ffe1c32a47a8c31e595b5b5fdf"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"a8ff0261a1ab8b1dc3d7583b51733d4b13e250c7","unresolved":false,"context_lines":[{"line_number":2501,"context_line":"            hardware.BlockDevice(\u0027/dev/sda2\u0027, \u0027raid-member\u0027, 32767, False),"},{"line_number":2502,"context_line":"            hardware.BlockDevice(\u0027/dev/md0\u0027, \u0027raid-device\u0027, 32767, False)"},{"line_number":2503,"context_line":"        ]"},{"line_number":2504,"context_line":""},{"line_number":2505,"context_line":"        # NOTE(coreywright): Don\u0027t return the list, but a copy of it, because"},{"line_number":2506,"context_line":"        # we depend on its elements\u0027 order when referencing it later during"},{"line_number":2507,"context_line":"        # verification, but the method under test sorts the list changing it."}],"source_content_type":"text/x-python","patch_set":8,"id":"f33410b4_b3f19bca","line":2504,"in_reply_to":"3349f8ce_6af2ab37","updated":"2023-10-08 20:10:06.000000000","message":"Done","commit_id":"a892d6f04ca451ffe1c32a47a8c31e595b5b5fdf"}]}