)]}'
{"id":"openstack%2Fironic-python-agent~897950","triplet_id":"openstack%2Fironic-python-agent~stable%2F2023.1~I543a60555a2621b49dd7b6564bd0654a46db2e9a","project":"openstack/ironic-python-agent","branch":"stable/2023.1","attention_set":{},"removed_from_attention_set":{"11655":{"account":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"last_update":"2023-10-12 09:29:58.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I543a60555a2621b49dd7b6564bd0654a46db2e9a","subject":"Retry on checksum failures","status":"MERGED","created":"2023-10-11 13:43:20.000000000","updated":"2023-10-12 09:30:59.000000000","submitted":"2023-10-12 09:29:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"897950","meta_rev_id":"66cc622190c04d0ec6bb407507d7cce99db39d2c","_number":897950,"virtual_id_number":897950,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-10-12 09:29:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":2,"date":"2023-10-11 21:52:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":2,"date":"2023-10-12 07:45:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":1,"date":"2023-10-12 07:45:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-10-11 13:58:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-10-11 16:14:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-10-11 21:52:42.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"},{"updated":"2023-10-12 07:45:06.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"}],"messages":[{"id":"b0159d8f68569e91a7e1227211a11969e6f431a1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2023-10-11 13:43:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"847baf27d35b1a7c440e21d0af97a745a172d92c","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-11 13:58:22.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d0120ff6ba6b494b8f7da33e6daff611\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/8cb6f027a55b4910a31a55b67f2df587 : SUCCESS in 8m 12s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/68047d4d845f44008e518b5328ba96c3 : SUCCESS in 7m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"850920b5e9169a32a5a47a3c5b3e939f77f1ee49","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-11 16:14:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/246aee5132ae41b584554f7bce61dd51\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b65c82fddca04a07b381c42a0f6b4323 : SUCCESS in 5m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ae3db301681e4ada8a0a724e3d366080 : SUCCESS in 3m 48s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/087293ae8d23496ebcb885b35217f4d1 : SUCCESS in 4m 14s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/c459036b966046afb6f379c708e1180c : SUCCESS in 4m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3f686bde02a44c6bba999ebb4cca648b : SUCCESS in 6m 57s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/24b947a7a70144638bedbe926efddbf9 : SUCCESS in 3m 29s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/56e327d8c9c64512ba3ae31d3007b23c : SUCCESS in 3m 48s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/226cdb7ce50045b2afcebc7f6589233c : SUCCESS in 4m 00s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/096e161a366745218697200e3288629c : SUCCESS in 59m 28s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/759d352603894bbb950bdec6b0178ac8 : SUCCESS in 1h 13m 52s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/52a9eff7091b4f23bf5388e94e69eca0 : SUCCESS in 1h 27m 28s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/9031692e6507457cb2deabe678159618 : SUCCESS in 1h 43m 29s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/b59b3a7c59de44c78ae8e43cf874d60d : SUCCESS in 59m 33s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/c0d50eadf3044bed9ec6f37c5b5b0569 : SUCCESS in 19m 28s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/432809fbade24c5faa5ff14b88fea500 : SUCCESS in 8m 39s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/45ee6eb508b24ae480ee34a242a123da : SUCCESS in 2h 26m 24s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/bf1e9d89d47c4b52aea99c69a87082b1 : FAILURE in 3m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"48954be8ee855e301b82a88783e2a9adabb0f687","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2023-10-11 21:52:42.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9ae373c13de1fb6af7e8787a6cd54ee663e5ef65","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2023-10-12 07:45:06.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"3f8c544b6c85a497fa87887b42c06f9c35b028b4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-12 07:45:42.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"3b8c432a10b22b7b62c83328ad4ef65ddc7215ac","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-12 09:29:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/85599c475eec4feb92924c3f3768f323\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/13abbf683f044181bf401f6671840201 : SUCCESS in 3m 26s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/786e89e73a1b4dc79d5dc542ffc2785d : SUCCESS in 3m 56s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/2bd691779de540fd87703d28b530443a : SUCCESS in 4m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6fe9749194024ec387335a6bcf61c95b : SUCCESS in 6m 04s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/20f9946ee9ae4df78fa136de9cc09af1 : SUCCESS in 3m 19s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/9cb9f685412941209d3238ff545693bf : SUCCESS in 3m 27s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/3ed0c95574894cfb8fb832fb4386fc3e : SUCCESS in 3m 48s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/2d2789b050204507b9ff300fb84190ca : SUCCESS in 1h 00m 22s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/34a5fcbebf0e4c01b06f9aae9c081af6 : SUCCESS in 1h 17m 25s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/b4621f8ec9ef4c49b546706d225eb349 : SUCCESS in 1h 30m 26s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/065869f87abf4e548a0700ae2b228e04 : SUCCESS in 1h 31m 42s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/ae90f01384e0404593b4ec8b4fc84d85 : SUCCESS in 1h 20m 48s","accounts_in_message":[],"_revision_number":1},{"id":"23af8badcc8c7e770ab0e3964f1685a1b1d8dfa2","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-12 09:29:58.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"66cc622190c04d0ec6bb407507d7cce99db39d2c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-12 09:30:59.000000000","message":"Patch Set 1:\n\nBuild failed (promote pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/d0bb04434d414465ae7ad2867b80346d\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/566927b449e6460a9b6ad70a68082747 : SUCCESS in 40s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9e2c31df997244cb93545e0f6c918070 : FAILURE in 35s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"424e4b3a731d4d22c7b9556488922a0671c68fc6","revisions":{"424e4b3a731d4d22c7b9556488922a0671c68fc6":{"kind":"REWORK","_number":1,"created":"2023-10-11 13:43:20.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/50/897950/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/50/897950/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/897950/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/897950/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/897950/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/897950/1"}}},"commit":{"parents":[{"commit":"804567831cf1d21aa362f80f8eb397cccb6b383e","subject":"Handle the node being locked","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/804567831cf1d21aa362f80f8eb397cccb6b383e"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2023-10-10 15:56:05.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2023-10-11 13:43:13.000000000","tz":-420},"subject":"Retry on checksum failures","message":"Retry on checksum failures\n\nHTTP is a fun protocol.\n\nSize is basically optional. And clients implicitly trust the server\nand socket has transferred all the bytes. Which *really* means you\nshould always checksum.\n\nBut... previously we didn\u0027t checksum as part of retrying.\n\nSo if anything happened with python-requests, or lower level\nlibrary code or the system itself causing bytes to be lost off the\nbuffer, creating an incomplete transfer situation, then we wouldn\u0027t\nknow until the checksum.\n\nSo now, we checksum and re-trigger the download if there is a\nfailure of the checksum.\n\nThis involved a minor shift in the download logic, and resulted in\na needful minor fix to an image checksum test as it would loop for\n90 seconds as well.\n\nCloses-Bug: 2038934\nChange-Id: I543a60555a2621b49dd7b6564bd0654a46db2e9a\n(cherry picked from commit cb61a8d6c052f4401d482ca45b43bc53935a6b28)\n(cherry picked from commit 0b31c4cb753fd5ea8f9f17f9e0612d6a3a668971)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/424e4b3a731d4d22c7b9556488922a0671c68fc6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/424e4b3a731d4d22c7b9556488922a0671c68fc6"}]},"branch":"refs/heads/stable/2023.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
