)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"42626aa03fe8cf864ec2bf15403b94fe6c375a0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ce0fdf4_4721c08a","updated":"2023-10-12 08:02:56.000000000","message":"thanks, a couple of comments inline","commit_id":"a5bcfa0bf4e11819d4dafe9545958dc71c33174a"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"10557fe0020d07670eea28f43de8b4e3c5103a1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"329913e7_b0635e6a","updated":"2023-10-12 19:54:03.000000000","message":"mdadm output does not include an equal sign in the first output, therefore using `parse_device_tags` is not suitable.","commit_id":"ba34e32bfde6d939a13d3ec9d4538ca5a7208f60"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9a7682b1b0561883bc75ea401f92388b577582d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6b60f81a_46183dcf","updated":"2023-10-12 23:07:06.000000000","message":"I helped some with this. Take this as a core review or not, your choice.","commit_id":"dbf3e5408d3b100505685638a4cbf6c93f9283fe"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d0a638e40c181d5eb7688d5a1ffd4e612e6f0e41","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from ironic_lib import disk_utils"},{"line_number":32,"context_line":"from ironic_lib import utils as il_utils"},{"line_number":33,"context_line":"from ironic_lib import utils as ut"},{"line_number":34,"context_line":"from oslo_concurrency import processutils"},{"line_number":35,"context_line":"from oslo_config import cfg"},{"line_number":36,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":1,"id":"91e171c7_2634acd8","line":33,"updated":"2023-10-12 08:01:01.000000000","message":"Duplicate import","commit_id":"a5bcfa0bf4e11819d4dafe9545958dc71c33174a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"42626aa03fe8cf864ec2bf15403b94fe6c375a0e","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from ironic_lib import disk_utils"},{"line_number":32,"context_line":"from ironic_lib import utils as il_utils"},{"line_number":33,"context_line":"from ironic_lib import utils as ut"},{"line_number":34,"context_line":"from oslo_concurrency import processutils"},{"line_number":35,"context_line":"from oslo_config import cfg"},{"line_number":36,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f4f971a_5632fd69","line":33,"updated":"2023-10-12 08:02:56.000000000","message":"already imported as il_utils in the precedent line","commit_id":"a5bcfa0bf4e11819d4dafe9545958dc71c33174a"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"10557fe0020d07670eea28f43de8b4e3c5103a1c","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from ironic_lib import disk_utils"},{"line_number":32,"context_line":"from ironic_lib import utils as il_utils"},{"line_number":33,"context_line":"from ironic_lib import utils as ut"},{"line_number":34,"context_line":"from oslo_concurrency import processutils"},{"line_number":35,"context_line":"from oslo_config import cfg"},{"line_number":36,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":1,"id":"60a86bc3_ad116004","line":33,"in_reply_to":"4f4f971a_5632fd69","updated":"2023-10-12 19:54:03.000000000","message":"Done","commit_id":"a5bcfa0bf4e11819d4dafe9545958dc71c33174a"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"10557fe0020d07670eea28f43de8b4e3c5103a1c","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from ironic_lib import disk_utils"},{"line_number":32,"context_line":"from ironic_lib import utils as il_utils"},{"line_number":33,"context_line":"from ironic_lib import utils as ut"},{"line_number":34,"context_line":"from oslo_concurrency import processutils"},{"line_number":35,"context_line":"from oslo_config import cfg"},{"line_number":36,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffdcf7e5_d4190fb4","line":33,"in_reply_to":"91e171c7_2634acd8","updated":"2023-10-12 19:54:03.000000000","message":"Done","commit_id":"a5bcfa0bf4e11819d4dafe9545958dc71c33174a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d0a638e40c181d5eb7688d5a1ffd4e612e6f0e41","unresolved":true,"context_lines":[{"line_number":439,"context_line":"    lines \u003d report.splitlines()"},{"line_number":440,"context_line":"    result \u003d {}"},{"line_number":441,"context_line":"    for line in lines:"},{"line_number":442,"context_line":"        for vals in ut.parse_device_tags(line):"},{"line_number":443,"context_line":"            for key, value in vals.items():"},{"line_number":444,"context_line":"                result[vals[1]][key] \u003d value.strip()"},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"70921b37_e9c09906","line":442,"updated":"2023-10-12 08:01:01.000000000","message":"parse_device_tags  can handle several lines, no need for the outer loop","commit_id":"a5bcfa0bf4e11819d4dafe9545958dc71c33174a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"42626aa03fe8cf864ec2bf15403b94fe6c375a0e","unresolved":true,"context_lines":[{"line_number":439,"context_line":"    lines \u003d report.splitlines()"},{"line_number":440,"context_line":"    result \u003d {}"},{"line_number":441,"context_line":"    for line in lines:"},{"line_number":442,"context_line":"        for vals in ut.parse_device_tags(line):"},{"line_number":443,"context_line":"            for key, value in vals.items():"},{"line_number":444,"context_line":"                result[vals[1]][key] \u003d value.strip()"},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"197da779_e7718eb4","line":442,"updated":"2023-10-12 08:02:56.000000000","message":"parse_device_tags has been thought for blkid/lsblk output, so before converting everything we should make sure that it can actually be applied to all the cases and maybe update the function itself as it explicitely mention blkid/lsblk","commit_id":"a5bcfa0bf4e11819d4dafe9545958dc71c33174a"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"10557fe0020d07670eea28f43de8b4e3c5103a1c","unresolved":false,"context_lines":[{"line_number":439,"context_line":"    lines \u003d report.splitlines()"},{"line_number":440,"context_line":"    result \u003d {}"},{"line_number":441,"context_line":"    for line in lines:"},{"line_number":442,"context_line":"        for vals in ut.parse_device_tags(line):"},{"line_number":443,"context_line":"            for key, value in vals.items():"},{"line_number":444,"context_line":"                result[vals[1]][key] \u003d value.strip()"},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3dbe04d8_fad328fd","line":442,"in_reply_to":"197da779_e7718eb4","updated":"2023-10-12 19:54:03.000000000","message":"Done","commit_id":"a5bcfa0bf4e11819d4dafe9545958dc71c33174a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bbfab361b0c115b301b494b2e583353bbd5be90b","unresolved":true,"context_lines":[{"line_number":439,"context_line":"    lines \u003d report.splitlines()"},{"line_number":440,"context_line":"    result \u003d {}"},{"line_number":441,"context_line":"    for line in lines:"},{"line_number":442,"context_line":"        for vals in ut.parse_device_tags(line):"},{"line_number":443,"context_line":"            for key, value in vals.items():"},{"line_number":444,"context_line":"                result[vals[1]][key] \u003d value.strip()"},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"aa66c47f_d6eee4ba","line":442,"in_reply_to":"197da779_e7718eb4","updated":"2023-10-12 20:36:12.000000000","message":"FYI this was a good call. I got some mdadm output:\n\nARRAY /dev/md/my-raid  metadata\u003d1.2 UUID\u003df9eb9feb:99999c99:9999aed9:a99a999b name\u003dserver:my-raid","commit_id":"a5bcfa0bf4e11819d4dafe9545958dc71c33174a"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"10557fe0020d07670eea28f43de8b4e3c5103a1c","unresolved":false,"context_lines":[{"line_number":439,"context_line":"    lines \u003d report.splitlines()"},{"line_number":440,"context_line":"    result \u003d {}"},{"line_number":441,"context_line":"    for line in lines:"},{"line_number":442,"context_line":"        for vals in ut.parse_device_tags(line):"},{"line_number":443,"context_line":"            for key, value in vals.items():"},{"line_number":444,"context_line":"                result[vals[1]][key] \u003d value.strip()"},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"10561332_4e8f0949","line":442,"in_reply_to":"70921b37_e9c09906","updated":"2023-10-12 19:54:03.000000000","message":"Done","commit_id":"a5bcfa0bf4e11819d4dafe9545958dc71c33174a"},{"author":{"_account_id":36402,"name":"Boushra Sondos Bettir","display_name":"Boushra Sondos Bettir","email":"boushrab04@gmail.com","username":"boushrabettir"},"change_message_id":"ff858c5c202010f45c885be948c5675e6953a9aa","unresolved":false,"context_lines":[{"line_number":439,"context_line":"    lines \u003d report.splitlines()"},{"line_number":440,"context_line":"    result \u003d {}"},{"line_number":441,"context_line":"    for line in lines:"},{"line_number":442,"context_line":"        for vals in ut.parse_device_tags(line):"},{"line_number":443,"context_line":"            for key, value in vals.items():"},{"line_number":444,"context_line":"                result[vals[1]][key] \u003d value.strip()"},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"76330236_d820121e","line":442,"in_reply_to":"aa66c47f_d6eee4ba","updated":"2023-10-12 20:39:17.000000000","message":"Done","commit_id":"a5bcfa0bf4e11819d4dafe9545958dc71c33174a"}]}