)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5ea31af710e14d6b9dd71e0b9bb384c493a9b002","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"746bfa50_da418e4e","updated":"2023-10-18 03:06:58.000000000","message":"Can you please add unit tests to it? Thanks!","commit_id":"b39c6ef956fe44972badf0212f7cdbb1d097bc4d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e0746c0ef14f754ad54a5b814d01f231b20193f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"575eea85_8dc31ffd","updated":"2023-11-09 15:47:52.000000000","message":"Adam promised me a follow up for release notes issues in DM.","commit_id":"13537db293543db9449f54d7b2a85e06b8c1e1bb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0d220cee432f5b13918194d40db41534b724cf26","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"deda3595_b5512663","updated":"2023-11-09 15:26:22.000000000","message":"That release note needs to be fixed; happy to land this now with a commitment to follow-up, or can fix here and then we can land 😊","commit_id":"13537db293543db9449f54d7b2a85e06b8c1e1bb"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9541a0873fa4a0be69839de98b119a8492324901","unresolved":true,"context_lines":[{"line_number":216,"context_line":"        # NOTE(rozzix): This could cause an OS error:"},{"line_number":217,"context_line":"        # \"process is already running failed to create pid file\" depending on"},{"line_number":218,"context_line":"        # the multipathd version in case multipathd is already running."},{"line_number":219,"context_line":"        # I suggest muting the OS error in addition to the execution error."},{"line_number":220,"context_line":"        il_utils.try_execute(\u0027multipathd\u0027)"},{"line_number":221,"context_line":"        # This is mainly to get the system to actually do the needful and"},{"line_number":222,"context_line":"        # identify/enumerate paths by combining what it can detect and what"}],"source_content_type":"text/x-python","patch_set":3,"id":"c8dc3c6d_7fe60925","line":219,"range":{"start_line":219,"start_character":7,"end_line":219,"end_character":75},"updated":"2023-11-06 13:58:51.000000000","message":"FWIW, normally we would want to phrase this for the future reader as if they\u0027ve never looked at the code. \"The best path is to wait until the end\" or something along those lines.","commit_id":"13537db293543db9449f54d7b2a85e06b8c1e1bb"}],"releasenotes/notes/multipath_error_handling_improvement-1669d0de4bfdbe95.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0ccab9fa6d970f29897f77d19468eb812760f959","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The error handling of the multipathd service startup/discovery process."},{"line_number":5,"context_line":"    IPA handles both scenario when the multipathd service is already started"},{"line_number":6,"context_line":"    and the scenario when the service has not been started and in the second"},{"line_number":7,"context_line":"    scenario IPA will try to start the service. IPA is not pre checking whether"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"17a5a34b_c1745b1d","line":4,"updated":"2023-11-06 16:33:31.000000000","message":"This will be out of context in the rendered page. Please lead with something like \"Fixes error handling ...\"","commit_id":"13537db293543db9449f54d7b2a85e06b8c1e1bb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0ccab9fa6d970f29897f77d19468eb812760f959","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The error handling of the multipathd service startup/discovery process."},{"line_number":5,"context_line":"    IPA handles both scenario when the multipathd service is already started"},{"line_number":6,"context_line":"    and the scenario when the service has not been started and in the second"},{"line_number":7,"context_line":"    scenario IPA will try to start the service. IPA is not pre checking whether"},{"line_number":8,"context_line":"    multipathd is running already or not, it will start the multipathd service"},{"line_number":9,"context_line":"    even if it is already running and expects 0 error code . It has been"},{"line_number":10,"context_line":"    noticed that with certain combinations of Linux distros and multipathd"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ad39602f_2fb423f8","line":7,"updated":"2023-11-06 16:33:31.000000000","message":"nit: s/pre checking/checking/","commit_id":"13537db293543db9449f54d7b2a85e06b8c1e1bb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0ccab9fa6d970f29897f77d19468eb812760f959","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    and the scenario when the service has not been started and in the second"},{"line_number":7,"context_line":"    scenario IPA will try to start the service. IPA is not pre checking whether"},{"line_number":8,"context_line":"    multipathd is running already or not, it will start the multipathd service"},{"line_number":9,"context_line":"    even if it is already running and expects 0 error code . It has been"},{"line_number":10,"context_line":"    noticed that with certain combinations of Linux distros and multipathd"},{"line_number":11,"context_line":"    versions the error code is not 0 when IPA tries to start multipathd in"},{"line_number":12,"context_line":"    case an instance of multipathd is already running."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4504fdae_cd2f20fc","line":9,"updated":"2023-11-06 16:33:31.000000000","message":"nit: redundant space before dot","commit_id":"13537db293543db9449f54d7b2a85e06b8c1e1bb"}]}
