)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e4eaf77badfc02b5327f53d4859be8caa6d45b71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a6209039_cdd6b10a","updated":"2023-11-06 14:10:23.000000000","message":"Overall change looks good, but I have a question to pose regarding the change. Also adding Dmitry as a reviewer.","commit_id":"c8841ec324a72d0e617708484430cfbedfcc6977"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"74b67d568a49f077743b34a3b1812a6da5480e7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"86a2a2db_1ceed301","updated":"2023-11-09 15:28:04.000000000","message":"If the intention of this is to make it useful for a step, that implies to me the change here might be useful to billboard in a release note for external hardware manager integrations.","commit_id":"429e48c5210884e6e1b22e1876cc3a4d3c8204d5"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"aebd162dbec19b506b61643356763deba855afd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6c6868e8_fdda1caf","updated":"2023-11-26 20:51:07.000000000","message":"recheck ipa-tempest-uefi-redfish-vmedia-src","commit_id":"352df0bc54c56f6a1ea2e3efc7c3db4b882d9f03"}],"ironic_python_agent/tests/unit/test_efi_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e4eaf77badfc02b5327f53d4859be8caa6d45b71","unresolved":true,"context_lines":[{"line_number":224,"context_line":"Boot123A* Integrated NIC 1 Port 1 Partition 1   VenHw(33391845-5f86-4e78-8fce-c4cff59f9bbb)"},{"line_number":225,"context_line":"Boot000B* UEFI: PXE IPv4 Realtek PCIe 2.5GBE Family Controller\tPciRoot(0x0)/Pci(0x1c,0x0)/Pci(0x0,0x0)/MAC([REDACTED],0)/IPv4(0.0.0.00.0.0.0,0,0)..BO"},{"line_number":226,"context_line":"Boot0008* Generic USB Boot UsbClass(ffff,ffff,255,255)"},{"line_number":227,"context_line":"Boot0009* Internal CD/DVD ROM Drive (UEFI)      PciRoot(0x0)/Pci(0x11,0x0)/Sata(1,65535,0)/CDROM(1,0x265,0x2000)"},{"line_number":228,"context_line":"\"\"\".encode(\u0027utf-16\u0027) # noqa This is a giant literal string for testing."},{"line_number":229,"context_line":"        mock_execute.return_value \u003d (efibootmgr_resp, \u0027\u0027)"},{"line_number":230,"context_line":"        result \u003d list(efi_utils.get_boot_records())"}],"source_content_type":"text/x-python","patch_set":3,"id":"c956f744_46415f77","line":227,"range":{"start_line":227,"start_character":91,"end_line":227,"end_character":96},"updated":"2023-11-06 14:10:23.000000000","message":"Thinking out loud here.\n\nWhat if we wanted to remove anythign that looks/smells like a CDROM as well.\n\nIt is a nested device in this case. From the PCI Root -\u003e PCI Bus -\u003e SATA Bus -\u003e CDROM.\n\nFor virtual media it would be similar, USB -\u003e CDROM (or other),\n\nShould we be identifying other tokens from the path?","commit_id":"c8841ec324a72d0e617708484430cfbedfcc6977"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6c1aeb7329f83f76aa59a93d203411fd313bd914","unresolved":false,"context_lines":[{"line_number":224,"context_line":"Boot123A* Integrated NIC 1 Port 1 Partition 1   VenHw(33391845-5f86-4e78-8fce-c4cff59f9bbb)"},{"line_number":225,"context_line":"Boot000B* UEFI: PXE IPv4 Realtek PCIe 2.5GBE Family Controller\tPciRoot(0x0)/Pci(0x1c,0x0)/Pci(0x0,0x0)/MAC([REDACTED],0)/IPv4(0.0.0.00.0.0.0,0,0)..BO"},{"line_number":226,"context_line":"Boot0008* Generic USB Boot UsbClass(ffff,ffff,255,255)"},{"line_number":227,"context_line":"Boot0009* Internal CD/DVD ROM Drive (UEFI)      PciRoot(0x0)/Pci(0x11,0x0)/Sata(1,65535,0)/CDROM(1,0x265,0x2000)"},{"line_number":228,"context_line":"\"\"\".encode(\u0027utf-16\u0027) # noqa This is a giant literal string for testing."},{"line_number":229,"context_line":"        mock_execute.return_value \u003d (efibootmgr_resp, \u0027\u0027)"},{"line_number":230,"context_line":"        result \u003d list(efi_utils.get_boot_records())"}],"source_content_type":"text/x-python","patch_set":3,"id":"61cc86d0_47bd2393","line":227,"range":{"start_line":227,"start_character":91,"end_line":227,"end_character":96},"in_reply_to":"833a7eee_ef835121","updated":"2023-11-22 19:59:13.000000000","message":"Done","commit_id":"c8841ec324a72d0e617708484430cfbedfcc6977"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"bc0194698714a2e56cda8695a844b2b21f87b27b","unresolved":true,"context_lines":[{"line_number":224,"context_line":"Boot123A* Integrated NIC 1 Port 1 Partition 1   VenHw(33391845-5f86-4e78-8fce-c4cff59f9bbb)"},{"line_number":225,"context_line":"Boot000B* UEFI: PXE IPv4 Realtek PCIe 2.5GBE Family Controller\tPciRoot(0x0)/Pci(0x1c,0x0)/Pci(0x0,0x0)/MAC([REDACTED],0)/IPv4(0.0.0.00.0.0.0,0,0)..BO"},{"line_number":226,"context_line":"Boot0008* Generic USB Boot UsbClass(ffff,ffff,255,255)"},{"line_number":227,"context_line":"Boot0009* Internal CD/DVD ROM Drive (UEFI)      PciRoot(0x0)/Pci(0x11,0x0)/Sata(1,65535,0)/CDROM(1,0x265,0x2000)"},{"line_number":228,"context_line":"\"\"\".encode(\u0027utf-16\u0027) # noqa This is a giant literal string for testing."},{"line_number":229,"context_line":"        mock_execute.return_value \u003d (efibootmgr_resp, \u0027\u0027)"},{"line_number":230,"context_line":"        result \u003d list(efi_utils.get_boot_records())"}],"source_content_type":"text/x-python","patch_set":3,"id":"833a7eee_ef835121","line":227,"range":{"start_line":227,"start_character":91,"end_line":227,"end_character":96},"in_reply_to":"c956f744_46415f77","updated":"2023-11-06 20:08:39.000000000","message":"Agreed, but I think something else should do the parsing, this regex is doing enough. I\u0027ll change it so that group 3 and 4 are merged so the entire path is returned for something else to process.","commit_id":"c8841ec324a72d0e617708484430cfbedfcc6977"}]}
