)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6f9d466a4a96608d9f5773c43909d92b649d27f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de5572fa_1bda7a46","updated":"2023-12-11 10:55:57.000000000","message":"Great addition. Could it be called socket_count or something more obvious? Also please add a release note and update the inventory documentation.","commit_id":"671ccf637a1ad4ccddf8510e0747a81cadcb49d4"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6bb1b28ade15a8a1411b9b31da0284f0118871d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36da0e33_0e3351e7","in_reply_to":"8f888094_f2158367","updated":"2024-01-01 13:24:09.000000000","message":"socket_count make sense, but I haven\u0027t seen the socket number reported by lscpu is in other form other than physical installation, would love to see example like this :)","commit_id":"671ccf637a1ad4ccddf8510e0747a81cadcb49d4"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9396d2ca25ed6239928d19a343c5cdc026e69130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8f888094_f2158367","in_reply_to":"de5572fa_1bda7a46","updated":"2023-12-13 18:41:32.000000000","message":"++ Confirmed the socket value returned from lscpu is a socket count, not the absolute socket of the CPU installed.","commit_id":"671ccf637a1ad4ccddf8510e0747a81cadcb49d4"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"cf0660d93d3cc32f43f9505be8406189683cf5b2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"677870d9_6f02221c","updated":"2024-01-19 21:25:24.000000000","message":"Trivial edit, re-adding my +2.","commit_id":"9cafe762257ffbfadcd1b7cc6633086d8000aa86"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"458ddf6b4d361140a776ebc4a59fe01c572d32cb","unresolved":false,"context_lines":[{"line_number":1493,"context_line":"                   count\u003dint(cpu_info.get(\u0027cpu(s)\u0027)),"},{"line_number":1494,"context_line":"                   architecture\u003dcpu_info.get(\u0027architecture\u0027),"},{"line_number":1495,"context_line":"                   flags\u003dflags,"},{"line_number":1496,"context_line":"                   socket_count\u003dint(cpu_info.get(\u0027socket(s)\u0027)))"},{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"    def get_memory(self):"},{"line_number":1499,"context_line":"        # psutil returns a long, so we force it to an int"}],"source_content_type":"text/x-python","patch_set":2,"id":"8968db96_35803a0e","line":1496,"updated":"2024-01-10 08:40:17.000000000","message":"get() may return None, which will upset int(). is it expected in reality?","commit_id":"a6b73568f29bdbdc01e7ae9c4257cf421c7f8feb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"4e306eeeb372f8ced9ded5c4d9227903c6c6148b","unresolved":false,"context_lines":[{"line_number":1493,"context_line":"                   count\u003dint(cpu_info.get(\u0027cpu(s)\u0027)),"},{"line_number":1494,"context_line":"                   architecture\u003dcpu_info.get(\u0027architecture\u0027),"},{"line_number":1495,"context_line":"                   flags\u003dflags,"},{"line_number":1496,"context_line":"                   socket_count\u003dint(cpu_info.get(\u0027socket(s)\u0027)))"},{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"    def get_memory(self):"},{"line_number":1499,"context_line":"        # psutil returns a long, so we force it to an int"}],"source_content_type":"text/x-python","patch_set":2,"id":"5be68605_b59c4cf3","line":1496,"in_reply_to":"8968db96_35803a0e","updated":"2024-01-10 16:42:21.000000000","message":"Probably safest to get(blah, 0)?","commit_id":"a6b73568f29bdbdc01e7ae9c4257cf421c7f8feb"}]}