)]}'
{"id":"openstack%2Fironic-python-agent~902214","triplet_id":"openstack%2Fironic-python-agent~master~I313d14e6783e9bc98ebf448da947da030a4402fc","project":"openstack/ironic-python-agent","branch":"master","topic":"efi-utf-8","attention_set":{"4571":{"account":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"last_update":"2023-11-30 04:08:35.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I313d14e6783e9bc98ebf448da947da030a4402fc","subject":"Switch to utf-8 for parsing efibootmgr -v","status":"NEW","created":"2023-11-30 01:59:39.000000000","updated":"2023-11-30 22:17:07.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"437202bb588ee3bad0965b89603ae54b8d3d860a","_number":902214,"virtual_id_number":902214,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-11-30 22:17:07.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-30 02:06:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-11-30 04:08:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5f495db18296d9813a4d3c2e5fcff8358f17c777","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2023-11-30 01:59:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"41d649e56226bd5659a7ba0c369c9049361974a3","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-30 02:06:19.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3b7c5568295843179623f184df8fb235\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/463ae3b97d80490d90e148a94b5efa3e : SUCCESS in 4m 56s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/5f92db8f460f4a03bc0d4078c9388011 : SUCCESS in 5m 27s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/cb1062230d614fac963a8ba681cbdd20 : SUCCESS in 5m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6dd8ab27b55354ae58f8e3d09d3178cefad0063a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-30 04:08:35.000000000","message":"Patch Set 1: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/57795971f55c46169eff71c9aee24cee\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/af113706c97f4b9a86f5d577c98f99ad : SUCCESS in 3m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/32b4bf80c3d04de98c8828514ecee0ae : FAILURE in 3m 20s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6e1cf7a344b94c03a3d26084a5d4c06a : SUCCESS in 3m 49s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/fdc1cca7bf2945ba988c56e60a33777f : SUCCESS in 3m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ff4308860fca48e29b2a0f72836e5ac6 : SUCCESS in 6m 04s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/75a3c2a8862746269a22df3b572e7b5b : SUCCESS in 4m 56s\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/6579946a715d4f918c4d14f6fee6ca0c : SUCCESS in 3m 23s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/fba1adc1889a4190ab85b4a64bc04b6a : SUCCESS in 3m 22s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/cfb0b9f823c04623aa2b64bb81cfb054 : SUCCESS in 1h 00m 14s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/13c7076edd75421e9f47129a560b59ed : SUCCESS in 1h 09m 10s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/e58705a7aabb4c3d9d1a1028c9d2b428 : SUCCESS in 1h 37m 13s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/b2822d85ca7a46698c9ed93fa99aa6a7 : SUCCESS in 1h 06m 39s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/b25acf9bb0a24e168fa618196f9f29df : SUCCESS in 54m 33s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/bacfcd712b1048edbea4837d4b8d1ede : SUCCESS in 20m 59s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/e1b52ff4a2064269ace49697583a2c3c : SUCCESS in 7m 02s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/8721297d6ba346f2abb6b224e581ac29 : SUCCESS in 2h 06m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"bbfc88f3585bbf2609b703e89b58980dea5cc259","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2023-11-30 20:15:05.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"54eeb014aa84418f91c9987cefd688d5f96a4ed3","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-30 20:32:14.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/24ae359ae4ef4c1a99aeb50ff4561608\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/d24b90d9d8894101b4cc759165ca205a : SUCCESS in 7m 33s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/68b91906be3d488f86929b311249b9dc : SUCCESS in 11m 25s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/c6b164ab8acd4116bcb61f8299b6cbc3 : SUCCESS in 7m 05s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"437202bb588ee3bad0965b89603ae54b8d3d860a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-30 22:17:07.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/50bcb75f873f43f1b147e6f6fe1392ca\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f0dc5f6678e64d51ac2f1c5b1c0a8daa : SUCCESS in 4m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9b1106d30b194239842388f12cd5835a : SUCCESS in 3m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/48e1e1d371df4d5e940b3298f8c7564c : SUCCESS in 3m 57s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/2fdb5c29200e4338b6cc43df3116d1fc : SUCCESS in 4m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/176c82c7c2cc475599c435a3c0e359d1 : SUCCESS in 5m 55s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/af1b6030476343cf822daeb8a1d5d7b8 : SUCCESS in 3m 46s\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/11c8c0acf8584931aa192d69588f0a15 : SUCCESS in 4m 29s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/22f15f822fbb4f00ae49773a31ab00a6 : SUCCESS in 3m 21s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/ff82307fa56647e7aa534826c0f98db3 : SUCCESS in 1h 21m 47s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/51551ca7d6624abea3622dbbb58e6a18 : SUCCESS in 1h 40m 46s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/28413405445e4cb1a57947d4df933ab7 : FAILURE in 23m 07s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/fe8f6f48014f42a39bc056e157afa564 : SUCCESS in 1h 10m 27s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/6fff47c794154144bed9673d91832919 : SUCCESS in 1h 24m 18s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/212b503e13c74747a435f20a2bd83e96 : SUCCESS in 16m 38s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/4eb888146ad34e6c81934bca339a04be : SUCCESS in 7m 15s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/1147189924674810aafbcc717c6a697d : SUCCESS in 1h 59m 58s (non-voting)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bdf93019514b23f31efeb6a4ee8133e10dae283a","revisions":{"a9be8b8d79b4a34021cea804f1f6b247bbac01c7":{"kind":"REWORK","_number":1,"created":"2023-11-30 01:59:39.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/14/902214/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/14/902214/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/902214/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/902214/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/902214/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/902214/1"}}},"commit":{"parents":[{"commit":"61d17e2225938be84c9e15f6317e17235d2b04b9","subject":"Merge \"Parse efibootmgr type and details\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/61d17e2225938be84c9e15f6317e17235d2b04b9"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2023-11-30 01:25:55.000000000","tz":780},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2023-11-30 01:42:19.000000000","tz":780},"subject":"Switch to utf-8 for parsing efibootmgr -v","message":"Switch to utf-8 for parsing efibootmgr -v\n\nCommit 76accfb880474445a5dcb07825889123b3dd0237 handles UTF16 in\nefibootmgr output by treating all output as UTF16. However all UTF16\nstored values are converted to UTF8[1]. This conversion must have issues\nas UTF16 character 0x00FF has been seen in the wild.\n\nThis change switches back to UTF8, but ignoring errors. The tests are\nupdated to corrupt the byte output with 0x00FF to confirm at least\nsomething is parsed from invalid UTF8.\n\n[1] https://github.com/rhboot/efibootmgr/blob/main/src/efibootmgr.c#L1133\n    https://github.com/rhboot/efivar/blob/main/src/loadopt.c#L362\nChange-Id: I20d9d3b3d28bf3357da59615eaf6af9a5dcaaddd\n\nChange-Id: I313d14e6783e9bc98ebf448da947da030a4402fc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a9be8b8d79b4a34021cea804f1f6b247bbac01c7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a9be8b8d79b4a34021cea804f1f6b247bbac01c7"}]},"branch":"refs/heads/master"},"bdf93019514b23f31efeb6a4ee8133e10dae283a":{"kind":"REWORK","_number":2,"created":"2023-11-30 20:15:05.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/14/902214/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/14/902214/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/902214/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/902214/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/902214/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/902214/2"}}},"commit":{"parents":[{"commit":"61d17e2225938be84c9e15f6317e17235d2b04b9","subject":"Merge \"Parse efibootmgr type and details\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/61d17e2225938be84c9e15f6317e17235d2b04b9"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2023-11-30 01:25:55.000000000","tz":780},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2023-11-30 20:14:55.000000000","tz":780},"subject":"Switch to utf-8 for parsing efibootmgr -v","message":"Switch to utf-8 for parsing efibootmgr -v\n\nCommit 76accfb880474445a5dcb07825889123b3dd0237 handles UTF16 in\nefibootmgr output by treating all output as UTF16. However all UTF16\nstored values are converted to UTF8[1]. This conversion must have issues\nas UTF16 character 0x00FF has been seen in the wild.\n\nThis change switches back to UTF8, but ignoring errors. The tests are\nupdated to corrupt the byte output with 0x00FF to confirm at least\nsomething is parsed from invalid UTF8.\n\n[1] https://github.com/rhboot/efibootmgr/blob/main/src/efibootmgr.c#L1133\n    https://github.com/rhboot/efivar/blob/main/src/loadopt.c#L362\nChange-Id: I20d9d3b3d28bf3357da59615eaf6af9a5dcaaddd\n\nChange-Id: I313d14e6783e9bc98ebf448da947da030a4402fc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/bdf93019514b23f31efeb6a4ee8133e10dae283a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/bdf93019514b23f31efeb6a4ee8133e10dae283a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}